opentelemetry-exporter-jaeger 0.17.0 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 26e202a0355f910f2a246337567c6ca9909f0c3b189accf5836f035d84b8170a
-  data.tar.gz: b11ac5dbde83535ae7fb2d71760ac18da00be55a82b1bccda0d3e029d3fbb151
+  metadata.gz: aea1f8e091f974dbb5bfae4d6e9506062db6b15a7d692cb4a62e75c7f17cd293
+  data.tar.gz: 64e21515595bc61b93956359efe7e849a6326ba10fe14edadb9f2ee625970af1
 SHA512:
-  metadata.gz: df8ed6bf2f857b11cc5e0518f2023369abd834ea0f4470812e8c07a0015d21955205a9ef2340390fad962d9718ec92bc3fb0b5b6cfcc9b41fd2bc8505632b2b4
-  data.tar.gz: 2984207bd9210bdaf8b707ca979b03f9a1bb8ac379207cc2014e758c19bebd55b6348ea1fb0836ca1ca68585c06cf5c90cbc2403d2625ceb8d441d747290ddda
+  metadata.gz: 2b0454fd14bd43b70cf0047b84d3c39edeffc3c5d8125d7737a2ee38de94f31c1e71997cd0395b036768cd5626bf96645f12c0549e2416384e5016bf1fbe1ade
+  data.tar.gz: afb4a85910189015834c6d260a2b1050b914d9092c19b12da2bdc76b25da3b6b38e5467874dc0da1b02f895093c41ce2b8ed3ea291550f9427b29e0b3f347da1

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Release History: opentelemetry-exporter-jaeger
 
+### v0.18.0 / 2021-05-21
+
+* BREAKING CHANGE: Replace Time.now with Process.clock_gettime 
+
+* ADDED: Export to jaeger collectors w/ self-signed certs 
+* FIXED: Replace Time.now with Process.clock_gettime 
+* FIXED: Rename constant to hide warning message 
+* FIXED: Index a link trace_id in middle rather than end 
+
 ### v0.17.0 / 2021-04-22
 
 * ADDED: Add zipkin exporter 

data/README.md

@@ -75,11 +75,15 @@ The agent exporter can be configured explicitly in code, as shown above, or via
 
 The collector exporter can be configured explicitly in code, as shown above, or via environment variables. The configuration parameters, environment variables, and defaults are shown below.
 
-| Parameter   | Environment variable            | Default                    |
-| ----------- | ------------------------------- | -------------------------- |
-| `endpoint:` | `OTEL_EXPORTER_JAEGER_ENDPOINT` | `"http://localhost:14268"` |
-| `username:` | `OTEL_EXPORTER_JAEGER_USER`     | `nil`                      |
-| `password:` | `OTEL_EXPORTER_JAEGER_PASSWORD` | `nil`                      |
+| Parameter          | Environment variable                           | Default                    |
+| ------------------ | ---------------------------------------------- | -------------------------- |
+| `endpoint:`        | `OTEL_EXPORTER_JAEGER_ENDPOINT`                | `"http://localhost:14268"` |
+| `username:`        | `OTEL_EXPORTER_JAEGER_USER`                    | `nil`                      |
+| `password:`        | `OTEL_EXPORTER_JAEGER_PASSWORD`                | `nil`                      |
+| `ssl_verify_mode:` | `OTEL_RUBY_EXPORTER_JAEGER_SSL_VERIFY_PEER` or | `OpenSSL::SSL:VERIFY_PEER` |
+|                    | `OTEL_RUBY_EXPORTER_JAEGER_SSL_VERIFY_NONE`    |                            |
+
+`ssl_verify_mode:` parameter values should be flags for server certificate verification: `OpenSSL::SSL:VERIFY_PEER` and `OpenSSL::SSL:VERIFY_NONE` are acceptable. These values can also be set using the appropriately named environment variables as shown where `VERIFY_PEER` will take precedence over `VERIFY_NONE`.  Please see [the Net::HTTP docs](https://ruby-doc.org/stdlib-2.5.1/libdoc/net/http/rdoc/Net/HTTP.html#verify_mode) for more information about these flags.
 
 ## How can I get involved?
 

data/lib/opentelemetry/exporter/jaeger/agent_exporter.rb

@@ -35,7 +35,7 @@ module OpenTelemetry
         def export(span_data, timeout: nil)
           return FAILURE if @shutdown
 
-          start_time = Time.now
+          start_time = OpenTelemetry::Common::Utilities.timeout_timestamp
           encoded_batches(span_data) do |batch|
             return FAILURE if @shutdown || OpenTelemetry::Common::Utilities.maybe_timeout(timeout, start_time)&.zero?
 

data/lib/opentelemetry/exporter/jaeger/collector_exporter.rb

@@ -15,13 +15,25 @@ module OpenTelemetry
         FAILURE = OpenTelemetry::SDK::Trace::Export::FAILURE
         private_constant(:SUCCESS, :FAILURE)
 
+        def self.ssl_verify_mode
+          if ENV.key?('OTEL_RUBY_EXPORTER_JAEGER_SSL_VERIFY_PEER')
+            OpenSSL::SSL::VERIFY_PEER
+          elsif ENV.key?('OTEL_RUBY_EXPORTER_JAEGER_SSL_VERIFY_NONE')
+            OpenSSL::SSL::VERIFY_NONE
+          else
+            OpenSSL::SSL::VERIFY_PEER
+          end
+        end
+
         def initialize(endpoint: ENV.fetch('OTEL_EXPORTER_JAEGER_ENDPOINT', 'http://localhost:14268/api/traces'),
                        username: ENV['OTEL_EXPORTER_JAEGER_USER'],
-                       password: ENV['OTEL_EXPORTER_JAEGER_PASSWORD'])
+                       password: ENV['OTEL_EXPORTER_JAEGER_PASSWORD'],
+                       ssl_verify_mode: CollectorExporter.ssl_verify_mode)
           raise ArgumentError, "invalid url for Jaeger::CollectorExporter #{endpoint}" if invalid_url?(endpoint)
           raise ArgumentError, 'username and password should either both be nil or both be set' if username.nil? != password.nil?
 
-          @transport = ::Thrift::HTTPClientTransport.new(endpoint)
+          transport_opts = { ssl_verify_mode: Integer(ssl_verify_mode) }
+          @transport = ::Thrift::HTTPClientTransport.new(endpoint, transport_opts)
           unless username.nil? || password.nil?
             authorization = Base64.strict_encode64("#{username}:#{password}")
             auth_header = { 'Authorization': "Basic #{authorization}" }

data/lib/opentelemetry/exporter/jaeger/encoder.rb

@@ -65,8 +65,8 @@ module OpenTelemetry
         end
 
         def encoded_span(span_data) # rubocop:disable Metrics/AbcSize
-          start_time = (span_data.start_timestamp.to_f * 1_000_000).to_i
-          duration = (span_data.end_timestamp.to_f * 1_000_000).to_i - start_time
+          start_time = span_data.start_timestamp / 1_000
+          duration = span_data.end_timestamp / 1_000 - start_time
 
           Thrift::Span.new(
             'traceIdLow' => int64(span_data.trace_id[8, 8]),
@@ -102,7 +102,7 @@ module OpenTelemetry
         def encoded_logs(events)
           events&.map do |event|
             Thrift::Log.new(
-              'timestamp' => (event.timestamp.to_f * 1_000_000).to_i,
+              'timestamp' => event.timestamp / 1_000,
               'fields' => encoded_tags(event.attributes) + encoded_tags('name' => event.name)
             )
           end
@@ -112,8 +112,8 @@ module OpenTelemetry
           links&.map do |link|
             Thrift::SpanRef.new(
               'refType' => Thrift::SpanRefType::FOLLOWS_FROM,
-              'traceIdLow' => int64(link.span_context.trace_id[16, 16]),
-              'traceIdHigh' => int64(link.span_context.trace_id[0, 16]),
+              'traceIdLow' => int64(link.span_context.trace_id[8, 8]),
+              'traceIdHigh' => int64(link.span_context.trace_id[0, 8]),
               'spanId' => int64(link.span_context.span_id)
             )
           end

data/lib/opentelemetry/exporter/jaeger/version.rb

@@ -8,7 +8,7 @@ module OpenTelemetry
   module Exporter
     module Jaeger
       ## Current OpenTelemetry Jaeger exporter version
-      VERSION = '0.17.0'
+      VERSION = '0.18.0'
     end
   end
 end

data/thrift/gen-rb/jaeger_types.rb

@@ -77,11 +77,11 @@ module OpenTelemetry
         class Log
           include ::Thrift::Struct, ::Thrift::Struct_Union
           TIMESTAMP = 1
-          FIELDS = 2
+          FIELDS_LIST = 2
 
           FIELDS = {
             TIMESTAMP => {:type => ::Thrift::Types::I64, :name => 'timestamp'},
-            FIELDS => {:type => ::Thrift::Types::LIST, :name => 'fields', :element => {:type => ::Thrift::Types::STRUCT, :class => ::OpenTelemetry::Exporter::Jaeger::Thrift::Tag}}
+            FIELDS_LIST => {:type => ::Thrift::Types::LIST, :name => 'fields', :element => {:type => ::Thrift::Types::STRUCT, :class => ::OpenTelemetry::Exporter::Jaeger::Thrift::Tag}}
           }
 
           def struct_fields; FIELDS; end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opentelemetry-exporter-jaeger
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.0
 platform: ruby
 authors:
 - OpenTelemetry Authors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-23 00:00:00.000000000 Z
+date: 2021-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opentelemetry-api
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: 1.0.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: 1.0.0.rc1
 - !ruby/object:Gem::Dependency
   name: opentelemetry-common
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: 0.18.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: 0.18.0
 - !ruby/object:Gem::Dependency
   name: opentelemetry-sdk
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: 1.0.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.0
+        version: 1.0.0.rc1
 - !ruby/object:Gem::Dependency
   name: thrift
   requirement: !ruby/object:Gem::Requirement
@@ -223,10 +223,10 @@ homepage: https://github.com/open-telemetry/opentelemetry-ruby
 licenses:
 - Apache-2.0
 metadata:
-  changelog_uri: https://open-telemetry.github.io/opentelemetry-ruby/opentelemetry-exporter-jaeger/v0.17.0/file.CHANGELOG.html
+  changelog_uri: https://open-telemetry.github.io/opentelemetry-ruby/opentelemetry-exporter-jaeger/v0.18.0/file.CHANGELOG.html
   source_code_uri: https://github.com/open-telemetry/opentelemetry-ruby/tree/main/exporter/jaeger
   bug_tracker_uri: https://github.com/open-telemetry/opentelemetry-ruby/issues
-  documentation_uri: https://open-telemetry.github.io/opentelemetry-ruby/opentelemetry-exporter-jaeger/v0.17.0
+  documentation_uri: https://open-telemetry.github.io/opentelemetry-ruby/opentelemetry-exporter-jaeger/v0.18.0
 post_install_message: 
 rdoc_options: []
 require_paths: