openstudio-workflow 1.2.1 → 1.2.2

data/lib/openstudio/workflow/util/model.rb

@@ -1,100 +1,100 @@
-module OpenStudio
-  module Workflow
-    module Util
-      # Manages routine tasks involving OpenStudio::Model or OpenStudio::Workflow objects, such as loading, saving, and
-      # translating them.
-      #
-      module Model
-        # Method to create / load an OSM file
-        #
-        # @param [String] osm_path The full path to an OSM file to load
-        # @param [Object] logger An optional logger to use for finding the OSM model
-        # @return [Object] The return from this method is a loaded OSM or a failure.
-        #
-        def load_osm(osm_path, logger)
-          logger.info 'Loading OSM model'
-
-          # Load the model and return it
-          logger.info "Reading in OSM model #{osm_path}"
-
-          loaded_model = nil
-          begin
-            translator = OpenStudio::OSVersion::VersionTranslator.new
-            loaded_model = translator.loadModel(osm_path)
-          rescue
-            # TODO: get translator working in embedded.
-            # Need to embed idd files
-            logger.warn 'OpenStudio VersionTranslator could not be loaded'
-            loaded_model = OpenStudio::Model::Model.load(osm_path)
-          end
-          raise "Failed to load OSM file #{osm_path}" if loaded_model.empty?
-          loaded_model.get
-        end
-
-        # Method to create / load an IDF file
-        #
-        # @param [String] idf_path Full path to the IDF
-        # @param [Object] logger An optional logger to use for finding the idf model
-        # @return [Object] The return from this method is a loaded IDF or a failure.
-        #
-        def load_idf(idf_path, logger)
-          logger.info 'Loading IDF model'
-
-          # Load the IDF into a workspace object and return it
-          logger.info "Reading in IDF model #{idf_path}"
-
-          idf = OpenStudio::Workspace.load(idf_path)
-          raise "Failed to load IDF file #{idf_path}" if idf.empty?
-          idf.get
-        end
-
-        # Translates a OpenStudio model object into an OpenStudio IDF object
-        #
-        # @param [Object] model the OpenStudio::Model instance to translate into an OpenStudio::Workspace object -- see
-        #   the OpenStudio SDK for details on the process
-        # @return [Object] Returns and OpenStudio::Workspace object
-        # @todo (rhorsey) rescue errors here
-        #
-        def translate_to_energyplus(model, logger = nil)
-          logger = ::Logger.new(STDOUT) unless logger
-          logger.info 'Translate object to EnergyPlus IDF in preparation for EnergyPlus'
-          a = ::Time.now
-          # ensure objects exist for reporting purposes
-          model.getFacility
-          model.getBuilding
-          forward_translator = OpenStudio::EnergyPlus::ForwardTranslator.new
-          model_idf = forward_translator.translateModel(model)
-          b = ::Time.now
-          logger.info "Translate object to EnergyPlus IDF took #{b.to_f - a.to_f}"
-          model_idf
-        end
-
-        # Saves an OpenStudio model object to file
-        #
-        # @param [Object] model The OpenStudio::Model instance to save to file
-        # @param [String] save_directory Folder to save the model in
-        # @param [String] name ('in.osm') Option to define a non-standard name
-        # @return [String] OSM file name
-        #
-        def save_osm(model, save_directory, name = 'in.osm')
-          osm_filename = File.join(save_directory.to_s, name.to_s)
-          File.open(osm_filename, 'w') { |f| f << model.to_s }
-          osm_filename
-        end
-
-        # Saves an OpenStudio IDF model object to file
-        #
-        # @param [Object] model The OpenStudio::Workspace instance to save to file
-        # @param [String] save_directory Folder to save the model in
-        # @param [String] name ('in.osm') Option to define a non-standard name
-        # @return [String] IDF file name
-        #
-        def save_idf(model_idf, save_directory, name = 'in.idf')
-          idf_filename = File.join(save_directory.to_s, name.to_s)
-          File.open(idf_filename, 'w') { |f| f << model_idf.to_s }
-          idf_filename
-        end
-      end
-    end
-  end
-end
+module OpenStudio
+  module Workflow
+    module Util
+      # Manages routine tasks involving OpenStudio::Model or OpenStudio::Workflow objects, such as loading, saving, and
+      # translating them.
+      #
+      module Model
+        # Method to create / load an OSM file
+        #
+        # @param [String] osm_path The full path to an OSM file to load
+        # @param [Object] logger An optional logger to use for finding the OSM model
+        # @return [Object] The return from this method is a loaded OSM or a failure.
+        #
+        def load_osm(osm_path, logger)
+          logger.info 'Loading OSM model'
+
+          # Load the model and return it
+          logger.info "Reading in OSM model #{osm_path}"
+
+          loaded_model = nil
+          begin
+            translator = OpenStudio::OSVersion::VersionTranslator.new
+            loaded_model = translator.loadModel(osm_path)
+          rescue
+            # TODO: get translator working in embedded.
+            # Need to embed idd files
+            logger.warn 'OpenStudio VersionTranslator could not be loaded'
+            loaded_model = OpenStudio::Model::Model.load(osm_path)
+          end
+          raise "Failed to load OSM file #{osm_path}" if loaded_model.empty?
+          loaded_model.get
+        end
+
+        # Method to create / load an IDF file
+        #
+        # @param [String] idf_path Full path to the IDF
+        # @param [Object] logger An optional logger to use for finding the idf model
+        # @return [Object] The return from this method is a loaded IDF or a failure.
+        #
+        def load_idf(idf_path, logger)
+          logger.info 'Loading IDF model'
+
+          # Load the IDF into a workspace object and return it
+          logger.info "Reading in IDF model #{idf_path}"
+
+          idf = OpenStudio::Workspace.load(idf_path)
+          raise "Failed to load IDF file #{idf_path}" if idf.empty?
+          idf.get
+        end
+
+        # Translates a OpenStudio model object into an OpenStudio IDF object
+        #
+        # @param [Object] model the OpenStudio::Model instance to translate into an OpenStudio::Workspace object -- see
+        #   the OpenStudio SDK for details on the process
+        # @return [Object] Returns and OpenStudio::Workspace object
+        # @todo (rhorsey) rescue errors here
+        #
+        def translate_to_energyplus(model, logger = nil)
+          logger = ::Logger.new(STDOUT) unless logger
+          logger.info 'Translate object to EnergyPlus IDF in preparation for EnergyPlus'
+          a = ::Time.now
+          # ensure objects exist for reporting purposes
+          model.getFacility
+          model.getBuilding
+          forward_translator = OpenStudio::EnergyPlus::ForwardTranslator.new
+          model_idf = forward_translator.translateModel(model)
+          b = ::Time.now
+          logger.info "Translate object to EnergyPlus IDF took #{b.to_f - a.to_f}"
+          model_idf
+        end
+
+        # Saves an OpenStudio model object to file
+        #
+        # @param [Object] model The OpenStudio::Model instance to save to file
+        # @param [String] save_directory Folder to save the model in
+        # @param [String] name ('in.osm') Option to define a non-standard name
+        # @return [String] OSM file name
+        #
+        def save_osm(model, save_directory, name = 'in.osm')
+          osm_filename = File.join(save_directory.to_s, name.to_s)
+          File.open(osm_filename, 'w') { |f| f << model.to_s }
+          osm_filename
+        end
+
+        # Saves an OpenStudio IDF model object to file
+        #
+        # @param [Object] model The OpenStudio::Workspace instance to save to file
+        # @param [String] save_directory Folder to save the model in
+        # @param [String] name ('in.osm') Option to define a non-standard name
+        # @return [String] IDF file name
+        #
+        def save_idf(model_idf, save_directory, name = 'in.idf')
+          idf_filename = File.join(save_directory.to_s, name.to_s)
+          File.open(idf_filename, 'w') { |f| f << model_idf.to_s }
+          idf_filename
+        end
+      end
+    end
+  end
+end

data/lib/openstudio/workflow/util/post_process.rb

@@ -1,187 +1,187 @@
-module OpenStudio
-  module Workflow
-    module Util
-      require 'openstudio/workflow/util/measure'
-      require 'csv'
-      require 'rexml/document'
-
-      # This module serves as a wrapper around various post-processing tasks used to manage outputs
-      # @todo (rhorsey) ummmm. So some of this is pretty ugly. Since @dmacumber had ideas about this maybe he can figure
-      #   out what to do about it all
-      # @todo (nlong) the output adapter restructure will frack up the extraction method royally
-      #
-      module PostProcess
-        # This method loads a sql file into OpenStudio and returns it
-        #
-        # @param [String] sql_file Absolute path to the sql file to be loaded
-        # @return [Object, nil] The OpenStudio::SqlFile object, or nil if it could not be found
-        #
-        def load_sql_file(sql_file)
-          return nil unless File.exist? sql_file
-          OpenStudio::SqlFile.new(@sql_filename)
-        end
-
-        # This method parses all sorts of stuff which something needs
-        #
-        # @param [String] run_dir The directory that the simulation was run in
-        # @return [Hash, Hash] results and objective_function (which may be empty) are returned
-        # @todo (rhorsey) fix the description
-        #
-        def run_extract_inputs_and_outputs(run_dir, logger)
-          # For xml, the measure attributes are in the measure_attributes_xml.json file
-          # TODO: somehow pass the metadata around on which JSONs to suck into the database
-          results = {}
-          # Inputs are in the measure_attributes.json file
-          if File.exist? "#{run_dir}/measure_attributes.json"
-            h = JSON.parse(File.read("#{run_dir}/measure_attributes.json"), symbolize_names: true)
-            h = rename_hash_keys(h, logger)
-            results.merge! h
-          end
-
-          logger.info 'Saving the result hash to file'
-          File.open("#{run_dir}/results.json", 'w') { |f| f << JSON.pretty_generate(results) }
-
-          objective_functions = {}
-          if @registry[:analysis]
-            logger.info 'Iterating over Analysis JSON Output Variables'
-            # Save the objective functions to the object for sending back to the simulation executive
-            analysis_json = @registry[:analysis]
-            if analysis_json[:analysis] && analysis_json[:analysis][:output_variables]
-              analysis_json[:analysis][:output_variables].each do |variable|
-                # determine which ones are the objective functions (code smell: todo: use enumerator)
-                if variable[:objective_function]
-                  logger.info "Looking for objective function #{variable[:name]}"
-                  # TODO: move this to cleaner logic. Use ostruct?
-                  k, v = variable[:name].split('.')
-
-                  # look for the objective function key and make sure that it is not nil. False is an okay obj function.
-                  if results.key?(k.to_sym) && !results[k.to_sym][v.to_sym].nil?
-                    objective_functions["objective_function_#{variable[:objective_function_index] + 1}"] = results[k.to_sym][v.to_sym]
-                    if variable[:objective_function_target]
-                      logger.info "Found objective function target for #{variable[:name]}"
-                      objective_functions["objective_function_target_#{variable[:objective_function_index] + 1}"] = variable[:objective_function_target].to_f
-                    end
-                    if variable[:scaling_factor]
-                      logger.info "Found scaling factor for #{variable[:name]}"
-                      objective_functions["scaling_factor_#{variable[:objective_function_index] + 1}"] = variable[:scaling_factor].to_f
-                    end
-                    if variable[:objective_function_group]
-                      logger.info "Found objective function group for #{variable[:name]}"
-                      objective_functions["objective_function_group_#{variable[:objective_function_index] + 1}"] = variable[:objective_function_group].to_f
-                    end
-                  else
-                    logger.warn "No results for objective function #{variable[:name]}"
-                    objective_functions["objective_function_#{variable[:objective_function_index] + 1}"] = Float::MAX
-                    objective_functions["objective_function_target_#{variable[:objective_function_index] + 1}"] = nil
-                    objective_functions["scaling_factor_#{variable[:objective_function_index] + 1}"] = nil
-                    objective_functions["objective_function_group_#{variable[:objective_function_index] + 1}"] = nil
-                  end
-                end
-              end
-            end
-          end
-
-          return results, objective_functions
-        end
-
-        # Remove any invalid characters in the measure attribute keys. Periods and Pipes are the most problematic
-        #   because mongo does not allow hash keys with periods, and the pipes are used in the map/reduce method that
-        #   was written to speed up the data write in openstudio-server. Also remove any trailing underscores and spaces
-        #
-        # @param [Hash] hash Any hash with potentially problematic characters
-        # @param [Logger] logger Logger to write to
-        #
-        def rename_hash_keys(hash, logger)
-          # @todo should we log the name changes?
-          regex = /[|!@#\$%^&\*\(\)\{\}\\\[\];:'",<.>\/?\+=]+/
-
-          rename_keys = lambda do |h|
-            if Hash === h
-              h.each_key do |key|
-                if key.to_s =~ regex
-                  logger.warn "Renaming result key '#{key}' to remove invalid characters"
-                end
-              end
-              Hash[h.map { |k, v| [k.to_s.gsub(regex, '_').squeeze('_').gsub(/[_\s]+$/, '').chomp.to_sym, rename_keys[v]] }]
-            else
-              h
-            end
-          end
-
-          rename_keys[hash]
-        end
-
-
-        # Save reports to a common directory
-        #
-        # @param [String] run_dir
-        # @param [String] directory
-        # @param [String] logger
-        #
-        def gather_reports(run_dir, directory, workflow_json, logger)
-          logger.info run_dir
-          logger.info directory
-
-          FileUtils.mkdir_p "#{directory}/reports"
-
-          # try to find the energyplus result file
-          eplus_html = "#{run_dir}/eplustbl.htm"
-          if File.exist? eplus_html
-            # do some encoding on the html if possible
-            html = File.read(eplus_html)
-            html = html.force_encoding('ISO-8859-1').encode('utf-8', replace: nil)
-            logger.info "Saving EnergyPlus HTML report to #{directory}/reports/eplustbl.html"
-            File.open("#{directory}/reports/eplustbl.html", 'w') { |f| f << html }
-          end
-
-          # Also, find any "report*.*" files
-          Dir["#{run_dir}/*/report*.*"].each do |report|
-            # HRH: This is a temporary work-around to support PAT 2.1 pretty names AND the CLI while we roll a WorkflowJSON solution
-            measure_dir_name = File.dirname(report).split(File::SEPARATOR).last.gsub(/[0-9][0-9][0-9]_/, '')
-            measure_xml_path = File.absolute_path(File.join(File.dirname(report), '../../..', 'measures',
-                                                            measure_dir_name, 'measure.xml'))
-            logger.info "measure_xml_path: #{measure_xml_path}"
-            if File.exists? measure_xml_path
-              measure_xml = REXML::Document.new File.read(measure_xml_path)
-              measure_class_name = OpenStudio.toUnderscoreCase(measure_xml.root.elements['class_name'].text)
-            else
-              measure_class_name = OpenStudio.toUnderscoreCase(measure_dir_name)
-            end
-            file_ext = File.extname(report)
-            append_str = File.basename(report, '.*')
-            new_file_name = "#{directory}/reports/#{measure_class_name}_#{append_str}#{file_ext}"
-            logger.info "Saving report #{report} to #{new_file_name}"
-            FileUtils.copy report, new_file_name
-          end
-
-          # Remove empty directories in run folder
-          Dir["#{run_dir}/*"].select { |d| File.directory? d }.select { |d| (Dir.entries(d) - %w(. ..)).empty? }.each do |d|
-            logger.info "Removing empty directory #{d}"
-            Dir.rmdir d
-          end
-        end
-
-
-        # A general post-processing step which could be made significantly more modular
-        #
-        # @param [String] run_dir
-        #
-        def cleanup(run_dir, directory, logger)
-
-
-          paths_to_rm = []
-          # paths_to_rm << Pathname.glob("#{run_dir}/*.osm")
-          # paths_to_rm << Pathname.glob("#{run_dir}/*.idf") # keep the idfs
-          # paths_to_rm << Pathname.glob("*.audit")
-          # paths_to_rm << Pathname.glob("*.bnd")
-          # paths_to_rm << Pathname.glob("#{run_dir}/*.eso")
-          paths_to_rm << Pathname.glob("#{run_dir}/*.mtr")
-          paths_to_rm << Pathname.glob("#{run_dir}/*.epw")
-          #paths_to_rm << Pathname.glob("#{run_dir}/*.mtd")
-          #paths_to_rm << Pathname.glob("#{run_dir}/*.rdd")
-          paths_to_rm.each { |p| FileUtils.rm_rf(p) }
-        end
-      end
-    end
-  end
-end
+module OpenStudio
+  module Workflow
+    module Util
+      require 'openstudio/workflow/util/measure'
+      require 'csv'
+      require 'rexml/document'
+
+      # This module serves as a wrapper around various post-processing tasks used to manage outputs
+      # @todo (rhorsey) ummmm. So some of this is pretty ugly. Since @dmacumber had ideas about this maybe he can figure
+      #   out what to do about it all
+      # @todo (nlong) the output adapter restructure will frack up the extraction method royally
+      #
+      module PostProcess
+        # This method loads a sql file into OpenStudio and returns it
+        #
+        # @param [String] sql_file Absolute path to the sql file to be loaded
+        # @return [Object, nil] The OpenStudio::SqlFile object, or nil if it could not be found
+        #
+        def load_sql_file(sql_file)
+          return nil unless File.exist? sql_file
+          OpenStudio::SqlFile.new(@sql_filename)
+        end
+
+        # This method parses all sorts of stuff which something needs
+        #
+        # @param [String] run_dir The directory that the simulation was run in
+        # @return [Hash, Hash] results and objective_function (which may be empty) are returned
+        # @todo (rhorsey) fix the description
+        #
+        def run_extract_inputs_and_outputs(run_dir, logger)
+          # For xml, the measure attributes are in the measure_attributes_xml.json file
+          # TODO: somehow pass the metadata around on which JSONs to suck into the database
+          results = {}
+          # Inputs are in the measure_attributes.json file
+          if File.exist? "#{run_dir}/measure_attributes.json"
+            h = JSON.parse(File.read("#{run_dir}/measure_attributes.json"), symbolize_names: true)
+            h = rename_hash_keys(h, logger)
+            results.merge! h
+          end
+
+          logger.info 'Saving the result hash to file'
+          File.open("#{run_dir}/results.json", 'w') { |f| f << JSON.pretty_generate(results) }
+
+          objective_functions = {}
+          if @registry[:analysis]
+            logger.info 'Iterating over Analysis JSON Output Variables'
+            # Save the objective functions to the object for sending back to the simulation executive
+            analysis_json = @registry[:analysis]
+            if analysis_json[:analysis] && analysis_json[:analysis][:output_variables]
+              analysis_json[:analysis][:output_variables].each do |variable|
+                # determine which ones are the objective functions (code smell: todo: use enumerator)
+                if variable[:objective_function]
+                  logger.info "Looking for objective function #{variable[:name]}"
+                  # TODO: move this to cleaner logic. Use ostruct?
+                  k, v = variable[:name].split('.')
+
+                  # look for the objective function key and make sure that it is not nil. False is an okay obj function.
+                  if results.key?(k.to_sym) && !results[k.to_sym][v.to_sym].nil?
+                    objective_functions["objective_function_#{variable[:objective_function_index] + 1}"] = results[k.to_sym][v.to_sym]
+                    if variable[:objective_function_target]
+                      logger.info "Found objective function target for #{variable[:name]}"
+                      objective_functions["objective_function_target_#{variable[:objective_function_index] + 1}"] = variable[:objective_function_target].to_f
+                    end
+                    if variable[:scaling_factor]
+                      logger.info "Found scaling factor for #{variable[:name]}"
+                      objective_functions["scaling_factor_#{variable[:objective_function_index] + 1}"] = variable[:scaling_factor].to_f
+                    end
+                    if variable[:objective_function_group]
+                      logger.info "Found objective function group for #{variable[:name]}"
+                      objective_functions["objective_function_group_#{variable[:objective_function_index] + 1}"] = variable[:objective_function_group].to_f
+                    end
+                  else
+                    logger.warn "No results for objective function #{variable[:name]}"
+                    objective_functions["objective_function_#{variable[:objective_function_index] + 1}"] = Float::MAX
+                    objective_functions["objective_function_target_#{variable[:objective_function_index] + 1}"] = nil
+                    objective_functions["scaling_factor_#{variable[:objective_function_index] + 1}"] = nil
+                    objective_functions["objective_function_group_#{variable[:objective_function_index] + 1}"] = nil
+                  end
+                end
+              end
+            end
+          end
+
+          return results, objective_functions
+        end
+
+        # Remove any invalid characters in the measure attribute keys. Periods and Pipes are the most problematic
+        #   because mongo does not allow hash keys with periods, and the pipes are used in the map/reduce method that
+        #   was written to speed up the data write in openstudio-server. Also remove any trailing underscores and spaces
+        #
+        # @param [Hash] hash Any hash with potentially problematic characters
+        # @param [Logger] logger Logger to write to
+        #
+        def rename_hash_keys(hash, logger)
+          # @todo should we log the name changes?
+          regex = /[|!@#\$%^&\*\(\)\{\}\\\[\];:'",<.>\/?\+=]+/
+
+          rename_keys = lambda do |h|
+            if Hash === h
+              h.each_key do |key|
+                if key.to_s =~ regex
+                  logger.warn "Renaming result key '#{key}' to remove invalid characters"
+                end
+              end
+              Hash[h.map { |k, v| [k.to_s.gsub(regex, '_').squeeze('_').gsub(/[_\s]+$/, '').chomp.to_sym, rename_keys[v]] }]
+            else
+              h
+            end
+          end
+
+          rename_keys[hash]
+        end
+
+
+        # Save reports to a common directory
+        #
+        # @param [String] run_dir
+        # @param [String] directory
+        # @param [String] logger
+        #
+        def gather_reports(run_dir, directory, workflow_json, logger)
+          logger.info run_dir
+          logger.info directory
+
+          FileUtils.mkdir_p "#{directory}/reports"
+
+          # try to find the energyplus result file
+          eplus_html = "#{run_dir}/eplustbl.htm"
+          if File.exist? eplus_html
+            # do some encoding on the html if possible
+            html = File.read(eplus_html)
+            html = html.force_encoding('ISO-8859-1').encode('utf-8', replace: nil)
+            logger.info "Saving EnergyPlus HTML report to #{directory}/reports/eplustbl.html"
+            File.open("#{directory}/reports/eplustbl.html", 'w') { |f| f << html }
+          end
+
+          # Also, find any "report*.*" files
+          Dir["#{run_dir}/*/report*.*"].each do |report|
+            # HRH: This is a temporary work-around to support PAT 2.1 pretty names AND the CLI while we roll a WorkflowJSON solution
+            measure_dir_name = File.dirname(report).split(File::SEPARATOR).last.gsub(/[0-9][0-9][0-9]_/, '')
+            measure_xml_path = File.absolute_path(File.join(File.dirname(report), '../../..', 'measures',
+                                                            measure_dir_name, 'measure.xml'))
+            logger.info "measure_xml_path: #{measure_xml_path}"
+            if File.exists? measure_xml_path
+              measure_xml = REXML::Document.new File.read(measure_xml_path)
+              measure_class_name = OpenStudio.toUnderscoreCase(measure_xml.root.elements['class_name'].text)
+            else
+              measure_class_name = OpenStudio.toUnderscoreCase(measure_dir_name)
+            end
+            file_ext = File.extname(report)
+            append_str = File.basename(report, '.*')
+            new_file_name = "#{directory}/reports/#{measure_class_name}_#{append_str}#{file_ext}"
+            logger.info "Saving report #{report} to #{new_file_name}"
+            FileUtils.copy report, new_file_name
+          end
+
+          # Remove empty directories in run folder
+          Dir["#{run_dir}/*"].select { |d| File.directory? d }.select { |d| (Dir.entries(d) - %w(. ..)).empty? }.each do |d|
+            logger.info "Removing empty directory #{d}"
+            Dir.rmdir d
+          end
+        end
+
+
+        # A general post-processing step which could be made significantly more modular
+        #
+        # @param [String] run_dir
+        #
+        def cleanup(run_dir, directory, logger)
+
+
+          paths_to_rm = []
+          # paths_to_rm << Pathname.glob("#{run_dir}/*.osm")
+          # paths_to_rm << Pathname.glob("#{run_dir}/*.idf") # keep the idfs
+          # paths_to_rm << Pathname.glob("*.audit")
+          # paths_to_rm << Pathname.glob("*.bnd")
+          # paths_to_rm << Pathname.glob("#{run_dir}/*.eso")
+          paths_to_rm << Pathname.glob("#{run_dir}/*.mtr")
+          paths_to_rm << Pathname.glob("#{run_dir}/*.epw")
+          #paths_to_rm << Pathname.glob("#{run_dir}/*.mtd")
+          #paths_to_rm << Pathname.glob("#{run_dir}/*.rdd")
+          paths_to_rm.each { |p| FileUtils.rm_rf(p) }
+        end
+      end
+    end
+  end
+end