openstudio-standards 0.6.3 → 0.7.0

data/lib/openstudio-standards/standards/Standards.AirLoopHVAC.rb

@@ -297,11 +297,7 @@ class Standard
     end
 
     # Clean name of airloop
-    loop_name_clean = air_loop_hvac.name.get.to_s.gsub(/\W/, '').delete('_')
-    # If the name starts with a number, prepend with a letter
-    if loop_name_clean[0] =~ /[0-9]/
-      loop_name_clean = "SYS#{loop_name_clean}"
-    end
+    loop_name_clean = ems_friendly_name(air_loop_hvac.name)
 
     # Sensors
     oat_db_c_sen = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'Site Outdoor Air Drybulb Temperature')
@@ -333,14 +329,14 @@ class Standard
 
       # Actuators
       htg_sch_act = OpenStudio::Model::EnergyManagementSystemActuator.new(htg_sch, htg_sch_type, 'Schedule Value')
-      htg_sch_act.setName("#{loop_name_clean}HtgSch#{i}")
+      htg_sch_act.setName("#{loop_name_clean}_HtgSch#{i}")
 
       clg_sch_act = OpenStudio::Model::EnergyManagementSystemActuator.new(clg_sch, clg_sch_type, 'Schedule Value')
-      clg_sch_act.setName("#{loop_name_clean}ClgSch#{i}")
+      clg_sch_act.setName("#{loop_name_clean}_ClgSch#{i}")
 
       # Programs
       optstart_prg = OpenStudio::Model::EnergyManagementSystemProgram.new(air_loop_hvac.model)
-      optstart_prg.setName("#{loop_name_clean}OptimumStartProg#{i}")
+      optstart_prg.setName("#{loop_name_clean}_OptimumStartProg#{i}")
       optstart_prg_body = <<-EMS
       IF DaylightSavings==0 && DayOfWeek>1 && Hour==5 && #{oat_db_c_sen.handle}<23.9 && #{oat_db_c_sen.handle}>1.7
         SET #{clg_sch_act.handle} = 29.4
@@ -363,7 +359,7 @@ class Standard
 
       # Program Calling Managers
       setup_mgr = OpenStudio::Model::EnergyManagementSystemProgramCallingManager.new(air_loop_hvac.model)
-      setup_mgr.setName("#{loop_name_clean}OptimumStartCallingManager#{i}")
+      setup_mgr.setName("#{loop_name_clean}_OptimumStartCallingManager#{i}")
       setup_mgr.setCallingPoint('BeginTimestepBeforePredictor')
       setup_mgr.addProgram(optstart_prg)
     end
@@ -2080,7 +2076,7 @@ class Standard
           v_pz = clg_dsn_flow
         end
       else
-        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}: #{zone.name} clg_dsn_flow could not be found.")
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}: #{zone.name}, zone CoolingDesignAirFlowRate could not be found.")
       end
       htg_dsn_flow = zone.autosizedHeatingDesignAirFlowRate
       if htg_dsn_flow.is_initialized
@@ -2089,7 +2085,11 @@ class Standard
           v_pz = htg_dsn_flow
         end
       else
-        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}: #{zone.name} htg_dsn_flow could not be found.")
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}: #{zone.name}, zone HeatingDesignAirFlowRate could not be found.")
+      end
+
+      if v_pz.zero?
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}: #{zone.name}, neither the CoolingDesignAirFlowRate nor the HeatingDesignAirFlowRate could be found. The primary design air flow rate, v_pz, is zero. The zone may be missing a DesignSpecificationOutdoorAir object, or both heating and cooling load may be zero.")
       end
 
       # Get the minimum damper position
@@ -2135,7 +2135,7 @@ class Standard
       v_dz = v_pz * mdp
 
       # Zone discharge air fraction
-      z_d = v_oz / v_dz
+      z_d = v_dz.zero? || v_oz.zero? ? 0.0 : v_oz / v_dz
 
       # Zone ventilation effectiveness
       e_vz = 1.0 + x_s - z_d
@@ -2157,7 +2157,8 @@ class Standard
         v_dz_adj = v_oz / z_d_adj
 
         # Adjusted minimum damper position
-        mdp_adj = v_dz_adj / v_pz
+        # default to 0.2 if either values are zero
+        mdp_adj = v_dz_adj.zero? || v_pz.zero? ? 0.2 : v_dz_adj / v_pz
 
         # Don't allow values > 1
         if mdp_adj > 1.0
@@ -2931,17 +2932,11 @@ class Standard
     fan_control = air_loop_hvac_multi_stage_dx_cooling?(air_loop_hvac)
 
     # Scrub special characters from the system name
-    sn = air_loop_hvac.name.get.to_s
-    snc = sn.gsub(/\W/, '').delete('_')
-    # If the name starts with a number, prepend with a letter
-    if snc[0] =~ /[0-9]/
-      snc = "SYS#{snc}"
-    end
+    snc = ems_friendly_name(air_loop_hvac.name)
 
     # Get the zone name
     zone = air_loop_hvac.thermalZones[0]
-    zone_name = zone.name.get.to_s
-    zn_name_clean = zone_name.gsub(/\W/, '_')
+    zn_name_clean = ems_friendly_name(zone.name)
 
     # Zone air node
     zone_air_node = zone.zoneAirNode
@@ -3018,36 +3013,36 @@ class Standard
     oat_wb_c_sen.setKeyName('Environment')
 
     oa_sch_sen = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'Schedule Value')
-    oa_sch_sen.setName("#{snc}OASch")
+    oa_sch_sen.setName("#{snc}_OASch")
     oa_sch_sen.setKeyName(min_oa_sch.handle.to_s)
 
     oa_flow_sen = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'System Node Mass Flow Rate')
-    oa_flow_sen.setName("#{snc}OAFlowMass")
+    oa_flow_sen.setName("#{snc}_OAFlowMass")
     oa_flow_sen.setKeyName(oa_node.handle.to_s)
 
     dat_sen = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'System Node Setpoint Temperature')
-    dat_sen.setName("#{snc}DATRqd")
+    dat_sen.setName("#{snc}_DATRqd")
     dat_sen.setKeyName(sup_out_node.handle.to_s)
 
     # Internal Variables
     oa_flow_var = OpenStudio::Model::EnergyManagementSystemInternalVariable.new(air_loop_hvac.model, 'Outdoor Air Controller Minimum Mass Flow Rate')
-    oa_flow_var.setName("#{snc}OADesignMass")
+    oa_flow_var.setName("#{snc}_OADesignMass")
     oa_flow_var.setInternalDataIndexKeyName(oa_control.handle.to_s)
 
     # Global Variables
-    gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}NumberofStages")
+    gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}_NumberofStages")
 
     # Programs
     num_stg_prg = OpenStudio::Model::EnergyManagementSystemProgram.new(air_loop_hvac.model)
-    num_stg_prg.setName("#{snc}SetNumberofStages")
+    num_stg_prg.setName("#{snc}_SetNumberofStages")
     num_stg_prg_body = <<-EMS
-      SET #{snc}NumberofStages = #{num_stages}
+      SET #{snc}_NumberofStages = #{num_stages}
     EMS
     num_stg_prg.setBody(num_stg_prg_body)
 
     # Program Calling Managers
     setup_mgr = OpenStudio::Model::EnergyManagementSystemProgramCallingManager.new(air_loop_hvac.model)
-    setup_mgr.setName("#{snc}SetNumberofStagesCallingManager")
+    setup_mgr.setName("#{snc}_SetNumberofStagesCallingManager")
     setup_mgr.setCallingPoint('BeginNewEnvironment')
     setup_mgr.addProgram(num_stg_prg)
 
@@ -3057,11 +3052,11 @@ class Standard
       ### Economizer Control ###
       # Actuators
       econ_eff_act = OpenStudio::Model::EnergyManagementSystemActuator.new(max_oa_sch, 'Schedule:Year', 'Schedule Value')
-      econ_eff_act.setName("#{snc}TimestepEconEff")
+      econ_eff_act.setName("#{snc}_TimestepEconEff")
 
       # Programs
       econ_prg = OpenStudio::Model::EnergyManagementSystemProgram.new(air_loop_hvac.model)
-      econ_prg.setName("#{snc}EconomizerCTRLProg")
+      econ_prg.setName("#{snc}_EconomizerCTRLProg")
       econ_prg_body = <<-EMS
         SET #{econ_eff_act.handle} = 0.7
         SET MaxE = 0.7
@@ -3082,7 +3077,7 @@ class Standard
           SET CoolLoad = 0
         ENDIF
         IF EconoActive == 1
-          SET Stage = #{snc}NumberofStages
+          SET Stage = #{snc}_NumberofStages
           IF Stage == 2
             IF CoolLoad < 0.6
               SET #{econ_eff_act.handle} = MaxE
@@ -3114,72 +3109,72 @@ class Standard
 
       # Program Calling Managers
       econ_mgr = OpenStudio::Model::EnergyManagementSystemProgramCallingManager.new(air_loop_hvac.model)
-      econ_mgr.setName("#{snc}EcoManager")
+      econ_mgr.setName("#{snc}_EcoManager")
       econ_mgr.setCallingPoint('InsideHVACSystemIterationLoop')
       econ_mgr.addProgram(econ_prg)
 
       # Sensors
       zn_temp_sen = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'System Node Temperature')
-      zn_temp_sen.setName("#{zn_name_clean}Temp")
+      zn_temp_sen.setName("#{zn_name_clean}_Temp")
       zn_temp_sen.setKeyName(zone_air_node.handle.to_s)
 
       htg_rtf_sen = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'Heating Coil Runtime Fraction')
-      htg_rtf_sen.setName("#{snc}HeatingRTF")
+      htg_rtf_sen.setName("#{snc}_HeatingRTF")
       htg_rtf_sen.setKeyName(htg_coil.handle.to_s)
 
       clg_rtf_sen = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'Cooling Coil Runtime Fraction')
-      clg_rtf_sen.setName("#{snc}RTF")
+      clg_rtf_sen.setName("#{snc}_RTF")
       clg_rtf_sen.setKeyName(dx_coil.handle.to_s)
 
       spd_sen = OpenStudio::Model::EnergyManagementSystemSensor.new(air_loop_hvac.model, 'Coil System Compressor Speed Ratio')
-      spd_sen.setName("#{snc}SpeedRatio")
+      spd_sen.setName("#{snc}_SpeedRatio")
       spd_sen.setKeyName("#{dx_coil.handle} CoilSystem")
 
       # Internal Variables
       fan_pres_var = OpenStudio::Model::EnergyManagementSystemInternalVariable.new(air_loop_hvac.model, 'Fan Nominal Pressure Rise')
-      fan_pres_var.setName("#{snc}FanDesignPressure")
+      fan_pres_var.setName("#{snc}_FanDesignPressure")
       fan_pres_var.setInternalDataIndexKeyName(fan.handle.to_s)
 
       dsn_flow_var = OpenStudio::Model::EnergyManagementSystemInternalVariable.new(air_loop_hvac.model, 'Outdoor Air Controller Maximum Mass Flow Rate')
-      dsn_flow_var.setName("#{snc}DesignFlowMass")
+      dsn_flow_var.setName("#{snc}_DesignFlowMass")
       dsn_flow_var.setInternalDataIndexKeyName(oa_control.handle.to_s)
 
       # Actuators
       fan_pres_act = OpenStudio::Model::EnergyManagementSystemActuator.new(fan, 'Fan', 'Fan Pressure Rise')
-      fan_pres_act.setName("#{snc}FanPressure")
+      fan_pres_act.setName("#{snc}_FanPressure")
 
       # Global Variables
-      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}FanPwrExp")
-      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}Stg1Spd")
-      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}Stg2Spd")
-      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}HeatSpeed")
-      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}VenSpeed")
+      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}_FanPwrExp")
+      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}_Stg1Spd")
+      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}_Stg2Spd")
+      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}_HeatSpeed")
+      gvar = OpenStudio::Model::EnergyManagementSystemGlobalVariable.new(air_loop_hvac.model, "#{snc}_VenSpeed")
 
       # Programs
       fan_par_prg = OpenStudio::Model::EnergyManagementSystemProgram.new(air_loop_hvac.model)
-      fan_par_prg.setName("#{snc}SetFanPar")
+      fan_par_prg.setName("#{snc}_SetFanPar")
       fan_par_prg_body = <<-EMS
-        IF #{snc}NumberofStages == 1
+        IF #{snc}_NumberofStages == 1
           Return
         ENDIF
-        SET #{snc}FanPwrExp = 2.2
+        SET #{snc}_FanPwrExp = 2.2
         SET OAFrac = #{oa_flow_sen.handle}/#{dsn_flow_var.handle}
         IF  OAFrac < 0.66
-          SET #{snc}VenSpeed = 0.66
-          SET #{snc}Stg1Spd = 0.66
+          SET #{snc}_VenSpeed = 0.66
+          SET #{snc}_Stg1Spd = 0.66
         ELSE
-          SET #{snc}VenSpeed = OAFrac
-          SET #{snc}Stg1Spd = OAFrac
+          SET #{snc}_VenSpeed = OAFrac
+          SET #{snc}_Stg1Spd = OAFrac
         ENDIF
-        SET #{snc}Stg2Spd = 1.0
-        SET #{snc}HeatSpeed = 1.0
+        SET #{snc}_Stg2Spd = 1.0
+        SET #{snc}_HeatSpeed = 1.0
       EMS
       fan_par_prg.setBody(fan_par_prg_body)
 
       fan_ctrl_prg = OpenStudio::Model::EnergyManagementSystemProgram.new(air_loop_hvac.model)
-      fan_ctrl_prg.setName("#{snc}FanControl")
+      fan_ctrl_prg.setName("#{snc}_FanControl")
       fan_ctrl_prg_body = <<-EMS
-        IF #{snc}NumberofStages == 1
+        IF #{snc}_NumberofStages == 1
           Return
         ENDIF
         IF #{htg_rtf_sen.handle} > 0
@@ -3190,7 +3185,7 @@ class Standard
           SET Stage2 = 0
         ELSE
           SET Heating = 0
-          SET EcoSpeed = #{snc}VenSpeed
+          SET EcoSpeed = #{snc}_VenSpeed
           IF #{spd_sen.handle} == 0
             IF #{clg_rtf_sen.handle} > 0
               SET Stage1 = #{clg_rtf_sen.handle}
@@ -3198,7 +3193,7 @@ class Standard
               SET Ven = 1-#{clg_rtf_sen.handle}
               SET Eco = 0
               IF #{oa_flow_sen.handle} > (#{oa_flow_var.handle}*#{oa_sch_sen.handle})
-                SET #{snc}Stg1Spd = 1.0
+                SET #{snc}_Stg1Spd = 1.0
               ENDIF
             ELSE
               SET Stage1 = 0
@@ -3207,10 +3202,10 @@ class Standard
                 SET Eco = 1.0
                 SET Ven = 0
                 !Calculate the expected discharge air temperature if the system runs at its low speed
-                SET ExpDAT = #{dat_sen.handle}-(1-#{snc}VenSpeed)*#{zn_temp_sen.handle}
-                SET ExpDAT = ExpDAT/#{snc}VenSpeed
+                SET ExpDAT = #{dat_sen.handle}-(1-#{snc}_VenSpeed)*#{zn_temp_sen.handle}
+                SET ExpDAT = ExpDAT/#{snc}_VenSpeed
                 IF #{oat_db_c_sen.handle} > ExpDAT
-                  SET EcoSpeed = #{snc}Stg2Spd
+                  SET EcoSpeed = #{snc}_Stg2Spd
                 ENDIF
               ELSE
                 SET Eco = 0
@@ -3223,18 +3218,18 @@ class Standard
             SET Ven = 0
             SET Eco = 0
             IF #{oa_flow_sen.handle} > (#{oa_flow_var.handle}*#{oa_sch_sen.handle})
-              SET #{snc}Stg1Spd = 1.0
+              SET #{snc}_Stg1Spd = 1.0
             ENDIF
           ENDIF
         ENDIF
         ! For each mode (percent time in mode)*(fanSpeer^PwrExp) is the contribution to weighted fan power over time step
-        SET FPR = Ven*(#{snc}VenSpeed ^ #{snc}FanPwrExp)
-        SET FPR = FPR+Eco*(EcoSpeed^#{snc}FanPwrExp)
-        SET FPR1 = Stage1*(#{snc}Stg1Spd^#{snc}FanPwrExp)
+        SET FPR = Ven*(#{snc}_VenSpeed ^ #{snc}_FanPwrExp)
+        SET FPR = FPR+Eco*(EcoSpeed^#{snc}_FanPwrExp)
+        SET FPR1 = Stage1*(#{snc}_Stg1Spd^#{snc}_FanPwrExp)
         SET FPR = FPR+FPR1
-        SET FPR2 = Stage2*(#{snc}Stg2Spd^#{snc}FanPwrExp)
+        SET FPR2 = Stage2*(#{snc}_Stg2Spd^#{snc}_FanPwrExp)
         SET FPR = FPR+FPR2
-        SET FPR3 = Heating*(#{snc}HeatSpeed^#{snc}FanPwrExp)
+        SET FPR3 = Heating*(#{snc}_HeatSpeed^#{snc}_FanPwrExp)
         SET FanPwrRatio = FPR+ FPR3
         ! system fan power is directly proportional to static pressure so this change linearly adjusts fan energy for speed control
         SET #{fan_pres_act.handle} = #{fan_pres_var.handle}*FanPwrRatio
@@ -3247,7 +3242,7 @@ class Standard
       setup_mgr.addProgram(fan_par_prg)
 
       fan_ctrl_mgr = OpenStudio::Model::EnergyManagementSystemProgramCallingManager.new(air_loop_hvac.model)
-      fan_ctrl_mgr.setName("#{snc}FanMainManager")
+      fan_ctrl_mgr.setName("#{snc}_FanMainManager")
       fan_ctrl_mgr.setCallingPoint('BeginTimestepBeforePredictor')
       fan_ctrl_mgr.addProgram(fan_ctrl_prg)
 
@@ -3866,10 +3861,10 @@ class Standard
   # @param snc [String] System name
   # @return [OpenStudio::Model::ScheduleRuleset] Generated maximum outdoor air fraction schedule for later use
   def set_maximum_fraction_outdoor_air_schedule(air_loop_hvac, oa_control, snc)
-    max_oa_sch_name = "#{snc}maxOASch"
+    max_oa_sch_name = "#{snc}_maxOASch"
     max_oa_sch = OpenStudio::Model::ScheduleRuleset.new(air_loop_hvac.model)
     max_oa_sch.setName(max_oa_sch_name)
-    max_oa_sch.defaultDaySchedule.setName("#{max_oa_sch_name}Default")
+    max_oa_sch.defaultDaySchedule.setName("#{max_oa_sch_name}_Default")
     max_oa_sch.defaultDaySchedule.addValue(OpenStudio::Time.new(0, 24, 0, 0), 0.7)
     oa_control.setMaximumFractionofOutdoorAirSchedule(max_oa_sch)
     return max_oa_sch

data/lib/openstudio-standards/standards/Standards.CoilCoolingWaterToAirHeatPumpEquationFit.rb

@@ -48,6 +48,17 @@ class Standard
     end
     coil_props = model_find_object(standards_data[equipment_type], search_criteria, capacity_btu_per_hr, Date.today)
 
+    # Check to make sure properties were found
+    if coil_props.nil?
+      # search again without capacity
+      matching_objects = model_find_objects(standards_data[equipment_type], search_criteria, nil, Date.today)
+      if !matching_objects.empty? && (equipment_type == 'water_source_heat_pumps') && (capacity_btu_per_hr > 135000)
+        # Issue warning indicate the coil size is may be too large
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "The capacity of coil '#{coil_cooling_water_to_air_heat_pump.name}' is #{capacity_btu_per_hr.round} Btu/hr, which is larger than the 135,000 Btu/hr maximum capacity listed in the efficiency standard. This may be because of zone loads, zone size, or because zone equipment sizing in EnergyPlus includes zone multipliers. Will assume a capacity of 134,999 Btu/hr for the efficiency lookup.")
+        coil_props = model_find_object(standards_data[equipment_type], search_criteria, 134999, Date.today)
+      end
+    end
+
     # Check to make sure properties were found
     if coil_props.nil?
       OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
@@ -119,23 +130,10 @@ class Standard
       if matching_objects.empty?
         # This proves that the search_criteria has issue finding the correct coil prop
         OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
-      else
-        # Issue warning indicate the coil size is may be too large
-        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "The capacity of the coil: #{coil_cooling_water_to_air_heat_pump.name} maybe too large to be found in the efficiency standard. The coil capacity is #{capacity_btu_per_hr} Btu/hr.")
+        return sql_db_vars_map
       end
-      return sql_db_vars_map
     end
 
-    # @todo Add methods to set coefficients, and add coefficients to data spreadsheet
-    # using OS defaults for now
-    # tot_cool_cap_coeff1 = coil_props['tot_cool_cap_coeff1']
-    # if tot_cool_cap_coeff1
-    #   coil_cooling_water_to_air_heat_pump.setTotalCoolingCapacityCoefficient1(tot_cool_cap_coeff1)
-    # else
-    #   OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find tot_cool_cap_coeff1, will not be set.")
-    #   successfully_set_all_properties = false
-    # end
-
     # Preserve the original name
     orig_name = coil_cooling_water_to_air_heat_pump.name.to_s
 

data/lib/openstudio-standards/standards/Standards.CoilHeatingDXSingleSpeed.rb

@@ -133,12 +133,23 @@ class Standard
       # TABLE 6.8.1D
       # COP = pthp_cop_coeff_1 - (pthp_cop_coeff_2 * Cap / 1000)
       # Note c: Cap means the rated cooling capacity of the product in Btu/h.
-      # If the unit's capacity is less than 7000 Btu/h, use 7000 Btu/h in the calculation.
-      # If the unit's capacity is greater than 15,000 Btu/h, use 15,000 Btu/h in the calculation.
-      capacity_btu_per_hr = 7000 if capacity_btu_per_hr < 7000
-      capacity_btu_per_hr = 15_000 if capacity_btu_per_hr > 15_000
+
+      # If the unit's capacity is nil or less than 7000 Btu/h, use 7000 Btu/h in the calculation
+      # If the unit's capacity is greater than 15,000 Btu/h, use 15,000 Btu/h in the calculation
+      if capacity_btu_per_hr.nil?
+        capacity_btu_per_hr = 7000.0
+        capacity_kbtu_per_hr = capacity_btu_per_hr / 1000.0
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For PTHP units, 90.1 heating efficiency depends on paired cooling capacity. Cooling Capacity for #{coil_heating_dx_single_speed.name}: #{sub_category} is nil. This zone may not have heating. Using default equipment efficiency for a 7 kBtu/hr unit.")
+      elsif capacity_btu_per_hr < 7000
+        capacity_btu_per_hr = 7000.0
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For PTHP units, 90.1 heating efficiency depends on paired cooling capacity. Cooling Capacity for #{coil_heating_dx_single_speed.name}: #{sub_category} is #{capacity_btu_per_hr.round} Btu/hr, which is less than the typical minimum equipment size of 7 kBtu/hr. Using default equipment efficiency for a 7 kBtu/hr unit.")
+      elsif capacity_btu_per_hr > 15_000
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For PTHP units, 90.1 heating efficiency depends on paired cooling capacity. Cooling Capacity for #{coil_heating_dx_single_speed.name}: #{sub_category} is #{capacity_btu_per_hr.round} Btu/hr, which is more than the typical maximum equipment size of 15 kBtu/hr. Using default equipment efficiency for a 15 kBtu/hr unit.")
+        capacity_btu_per_hr = 15_000.0
+      end
+
       min_coph = pthp_cop_coeff_1 - (pthp_cop_coeff_2 * capacity_btu_per_hr / 1000.0)
-      cop = cop_heating_to_cop_heating_no_fan(min_coph, OpenStudio.convert(capacity_kbtu_per_hr, 'kBtu/hr', 'W').get)
+      cop = cop_heating_to_cop_heating_no_fan(min_coph, OpenStudio.convert(capacity_btu_per_hr, 'Btu/hr', 'W').get)
       new_comp_name = "#{coil_heating_dx_single_speed.name} #{capacity_kbtu_per_hr.round} Clg kBtu/hr #{min_coph.round(1)}COPH"
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{coil_heating_dx_single_speed.name}: #{sub_category} Cooling Capacity = #{capacity_kbtu_per_hr.round}kBtu/hr; COPH = #{min_coph.round(2)}")
     end

data/lib/openstudio-standards/standards/Standards.Model.rb

@@ -443,7 +443,7 @@ class Standard
         next if plant_loop_swh_loop?(plant_loop)
 
         plant_loop_apply_prm_number_of_boilers(plant_loop)
-        plant_loop_apply_prm_number_of_chillers(plant_loop, sizing_run_dir)
+        plant_loop_apply_prm_number_of_chillers(plant_loop)
       end
 
       # Set the baseline number of cooling towers
@@ -5504,7 +5504,7 @@ class Standard
   def model_does_require_wwr_adjustment?(wwr_limit, wwr_list)
     require_adjustment = false
     wwr_list.each do |wwr|
-      require_adjustment = true unless wwr > wwr_limit
+      require_adjustment = true if wwr > wwr_limit
     end
     return require_adjustment
   end

data/lib/openstudio-standards/standards/Standards.PlanarSurface.rb

@@ -94,9 +94,17 @@ class Standard
         end
         case stds_type
         when 'Metal Framing', 'Metal Framing with Thermal Break'
-          stds_type = 'Metal framing (all other)'
+          if template == '90.1-2013'
+            stds_type = 'Metal framing, fixed'
+          else
+            stds_type = 'Metal framing (all other)'
+          end
         when 'Non-Metal Framing'
-          stds_type = 'Nonmetal framing (all)'
+          if template == '90.1-2013'
+            stds_type = 'Nonmetal framing, all'
+          else
+            stds_type = 'Nonmetal framing (all)'
+          end
         when 'Any Vertical Glazing'
           stds_type = 'Any Vertical Glazing'
         else