openstudio-standards 0.6.0.rc2 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eeae37f1a829d1531a5036352d1a2c63593060c6efbefd3af99dba3daeb46c1a
-  data.tar.gz: c5272723e22efb67b5e3d5b99a1db683b1d00e7c92c535d94cd8e0abba7cbc9f
+  metadata.gz: 36e7f523d2cb10126059ecdf5e1284b63aa700608bdb4a9244d799836bdaf3af
+  data.tar.gz: afb385431a40c8a890e10374ee3512c4e539f2eaeaf73e817b53afcbdeb00e98
 SHA512:
-  metadata.gz: a1f549cfe400b25576b93541d5fadc0d3aad695ea33a10ddea9b4d39a22d841c603da92b8860a3622af478189ea88f5627c1660d6ad764d27fd5bf3047fd3057
-  data.tar.gz: 844646771ff16c9e1ecf3b8860c694ae0b36e493651e1399268d47f000917ea7de13487c329f734bbf4468eab9bbf773cd2edda135e43d5a13a8d07e57b92cd8
+  metadata.gz: b57b01c010bd7c8b6a3b5c7c291cec14073974a8128fc9eb48dc11f51cec9ff605848cae2ade96947eee9c77fd1f50d17f7962c25b7c7b96c20f1e6b419debcd
+  data.tar.gz: a3d1ec5b7bf7ad1c986c2b4b26ac39d99f8ae60411b0efcf8a5a84e6819c1c19cade76921293c13fb70e2c80740219a216442f23519e3c706df1e8081f3c6dc6

data/data/standards/export_OpenStudio_libraries.rb

@@ -438,9 +438,9 @@ def export_openstudio_libraries
 
       # Save the library
       pkg_dir = "#{__dir__}/../../pkg"
-      Dir.mkdir(pkg_dir) unless Dir.exists?(pkg_dir)
+      Dir.mkdir(pkg_dir) unless Dir.exist?(pkg_dir)
       osm_lib_dir = "#{pkg_dir}/libraries"
-      Dir.mkdir(osm_lib_dir) unless Dir.exists?(osm_lib_dir)
+      Dir.mkdir(osm_lib_dir) unless Dir.exist?(osm_lib_dir)
       library_path = "#{osm_lib_dir}/#{template_name.gsub(/\W/,'_')}.osm"
       puts "* Saving library #{library_path}"
       model.save(OpenStudio::Path.new(library_path), true)

data/data/standards/manage_OpenStudio_Standards.rb

@@ -204,7 +204,7 @@ end
 def check_google_drive_configuration
   require 'google_drive'
   client_config_path = File.join(Dir.home, '.credentials', "client_secret.json")
-  unless File.exists? client_config_path
+  unless File.exist? client_config_path
     puts "Unable to locate client_secret.json file at #{client_config_path}."
     return false
   end
@@ -228,7 +228,7 @@ end
 def download_google_spreadsheets(spreadsheet_titles)
   require 'google_drive'
   client_config_path = File.join(Dir.home, '.credentials', "client_secret.json")
-  unless File.exists? client_config_path
+  unless File.exist? client_config_path
     puts "Unable to locate client_secret.json file at #{client_config_path}."
     return false
   end

data/lib/openstudio-standards/btap/btap_result.rb

@@ -25,8 +25,6 @@ module BTAP
     # Create hash to store all the collected data.
     qaqc = {}
     error_warning=[]
-    qaqc[:os_standards_revision] = OpenstudioStandards::git_revision
-    qaqc[:os_standards_version] = OpenstudioStandards::VERSION
     # Store Building data.
     qaqc[:building] = {}
     qaqc[:building][:name] = model.building.get.name.get

data/lib/openstudio-standards/btap/envelope.rb

@@ -909,7 +909,7 @@ module BTAP
         #@return [Boolean] optional_construction_set
         def self.get_construction_set_from_library(construction_library_file, construction_set_name)
           #Load Contruction osm library.
-          if File.exists?(construction_library_file)
+          if File.exist?(construction_library_file)
             construction_lib = BTAP::FileIO::load_osm(construction_library_file)
             #Get construction set..
             optional_construction_set = construction_lib.getDefaultConstructionSetByName(construction_set_name)

data/lib/openstudio-standards/create_typical/create_typical.rb

@@ -144,7 +144,7 @@ module OpenstudioStandards
 
         # check that weekday start time plus duration does not exceed 24 hrs
         if (wkdy_op_hrs_start_time_hr + wkdy_op_hrs_duration_hr + (wkdy_op_hrs_start_time_min + wkdy_op_hrs_duration_min) / 60.0) > 24.0
-          OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CreateTypical', "Weekday start time of #{wkdy_op_hrs_start} plus duration of #{wkdy_op_hrs_duration} is more than 24 hrs, hours of operation overlap midnight.")
+          OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.CreateTypical', "Weekday start time of #{wkdy_op_hrs_start_time} plus duration of #{wkdy_op_hrs_duration} is more than 24 hrs, hours of operation overlap midnight.")
         end
       end
 

data/lib/openstudio-standards/geometry/create_bar.rb

@@ -190,7 +190,7 @@ module OpenstudioStandards
       building_overhang_area_w = 0.0
 
       # loop through stories based on mine z height of surfaces.
-      sorted_stories = sort_building_stories_and_get_min_multiplier(model).sort_by { |k, v| v }
+      sorted_stories = OpenstudioStandards::Geometry.model_sort_building_stories_and_get_min_multiplier(model).sort_by { |k, v| v }
       sorted_stories.each do |story, story_min_z|
         story_min_multiplier = nil
         story_footprint = nil
@@ -365,10 +365,10 @@ module OpenstudioStandards
         end
       end
 
-      envelope_data_hash[:building_overhang_proj_factor_n] = building_overhang_area_n / ext_surfaces_hash['northWindow']
-      envelope_data_hash[:building_overhang_proj_factor_s] = building_overhang_area_s / ext_surfaces_hash['southWindow']
-      envelope_data_hash[:building_overhang_proj_factor_e] = building_overhang_area_e / ext_surfaces_hash['eastWindow']
-      envelope_data_hash[:building_overhang_proj_factor_w] = building_overhang_area_w / ext_surfaces_hash['westWindow']
+      envelope_data_hash[:building_overhang_proj_factor_n] = building_overhang_area_n / ext_surfaces_hash['north_window']
+      envelope_data_hash[:building_overhang_proj_factor_s] = building_overhang_area_s / ext_surfaces_hash['south_window']
+      envelope_data_hash[:building_overhang_proj_factor_e] = building_overhang_area_e / ext_surfaces_hash['east_window']
+      envelope_data_hash[:building_overhang_proj_factor_w] = building_overhang_area_w / ext_surfaces_hash['west_window']
 
       # warn for spaces that are not on a story (in future could infer stories for these)
       model.getSpaces.sort.each do |space|
@@ -390,7 +390,7 @@ module OpenstudioStandards
       bounding_length = envelope_data_hash[:building_max_xyz][0] - envelope_data_hash[:building_min_xyz][0]
       bounding_width = envelope_data_hash[:building_max_xyz][1] - envelope_data_hash[:building_min_xyz][1]
       bounding_area = bounding_length * bounding_width
-      footprint_area = envelope_data_hash[:building_floor_area] / envelope_data_hash[:effective_num_stories].to_f
+      footprint_area = envelope_data_hash[:building_floor_area] / (envelope_data_hash[:effective_num_stories_above_grade]. + envelope_data_hash[:effective_num_stories_below_grade].to_f)
       area_multiplier = footprint_area / bounding_area
       edge_multiplier = Math.sqrt(area_multiplier)
       bar[:length] = bounding_length * edge_multiplier
@@ -408,7 +408,7 @@ module OpenstudioStandards
 
       bounding_length = envelope_data_hash[:building_max_xyz][0] - envelope_data_hash[:building_min_xyz][0]
       bounding_width = envelope_data_hash[:building_max_xyz][1] - envelope_data_hash[:building_min_xyz][1]
-      footprint_area = envelope_data_hash[:building_floor_area] / envelope_data_hash[:effective_num_stories].to_f
+      footprint_area = envelope_data_hash[:building_floor_area] / (envelope_data_hash[:effective_num_stories_above_grade]. + envelope_data_hash[:effective_num_stories_below_grade].to_f)
 
       if bounding_length >= bounding_width
         bar[:length] = bounding_length
@@ -430,7 +430,7 @@ module OpenstudioStandards
 
       bounding_length = envelope_data_hash[:building_max_xyz][0] - envelope_data_hash[:building_min_xyz][0]
       bounding_width = envelope_data_hash[:building_max_xyz][1] - envelope_data_hash[:building_min_xyz][1]
-      a = envelope_data_hash[:building_floor_area] / envelope_data_hash[:effective_num_stories].to_f
+      a = envelope_data_hash[:building_floor_area] / (envelope_data_hash[:effective_num_stories_above_grade]. + envelope_data_hash[:effective_num_stories_below_grade].to_f)
       p = envelope_data_hash[:building_perimeter]
 
       if bounding_length >= bounding_width

data/lib/openstudio-standards/prototypes/common/objects/Prototype.HeatExchangerAirToAirSensibleAndLatent.rb

@@ -119,12 +119,19 @@ class Standard
 
     heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat100HeatingAirFlow(full_htg_sens_eff)
     heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat100HeatingAirFlow(full_htg_lat_eff)
-    heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(part_htg_sens_eff)
-    heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(part_htg_lat_eff)
     heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat100CoolingAirFlow(full_cool_sens_eff)
     heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat100CoolingAirFlow(full_cool_lat_eff)
-    heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(part_cool_sens_eff)
-    heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(part_cool_lat_eff)
+    if model.version < OpenStudio::VersionString.new('3.8.0')
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(part_htg_sens_eff)
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(part_htg_lat_eff)
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(part_cool_sens_eff)
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(part_cool_lat_eff)
+    else
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(part_htg_sens_eff) unless part_htg_sens_eff.zero?
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(part_htg_lat_eff) unless part_htg_lat_eff.zero?
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(part_cool_sens_eff) unless part_cool_sens_eff.zero?
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(part_cool_lat_eff) unless part_cool_lat_eff.zero?
+    end
 
     OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.HeatExchangerSensLat', "For #{heat_exchanger_air_to_air_sensible_and_latent.name}: Set sensible and latent effectiveness calculated by using ERR.")
     return true

data/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb

@@ -5173,16 +5173,18 @@ class Standard
         space.surfaces.each do |surface|
           if radiant_type == 'floor'
             if surface.surfaceType == 'Floor'
-              if surface.outsideBoundaryCondition == 'Ground'
+              if surface.outsideBoundaryCondition.include? 'Ground'
                 surface.setConstruction(radiant_ground_slab_construction)
               elsif surface.outsideBoundaryCondition == 'Outdoors'
                 surface.setConstruction(radiant_exterior_slab_construction)
               else # interior floor
                 surface.setConstruction(radiant_interior_floor_slab_construction)
 
-                # also assign construciton to adjacent surface
-                adjacent_surface = surface.adjacentSurface.get
-                adjacent_surface.setConstruction(rev_radiant_interior_floor_slab_construction)
+                # also assign construction to adjacent surface
+                if surface.adjacentSurface.is_initialized
+                  adjacent_surface = surface.adjacentSurface.get
+                  adjacent_surface.setConstruction(rev_radiant_interior_floor_slab_construction)
+                end
               end
             end
           elsif radiant_type == 'ceiling'
@@ -5192,9 +5194,11 @@ class Standard
               else # interior ceiling
                 surface.setConstruction(radiant_interior_ceiling_slab_construction)
 
-                # also assign construciton to adjacent surface
-                adjacent_surface = surface.adjacentSurface.get
-                adjacent_surface.setConstruction(rev_radiant_interior_ceiling_slab_construction)
+                # also assign construction to adjacent surface
+                if surface.adjacentSurface.is_initialized
+                  adjacent_surface = surface.adjacentSurface.get
+                  adjacent_surface.setConstruction(rev_radiant_interior_ceiling_slab_construction)
+                end
               end
             end
           end

data/lib/openstudio-standards/schedules/parametric.rb

@@ -1341,6 +1341,11 @@ module OpenstudioStandards
 
       # Tell EnergyPlus to interpolate schedules to timestep so that it doesn't have to be done in this code
       # sch_day.setInterpolatetoTimestep(true)
+      # if model.version < OpenStudio::VersionString.new('3.8.0')
+      #   day_sch.setInterpolatetoTimestep(true)
+      # else
+      #   day_sch.setInterpolatetoTimestep('Average')
+      # end
 
       return schedule_day
     end

data/lib/openstudio-standards/standards/Standards.HeatExchangerSensLat.rb

@@ -11,12 +11,19 @@ class Standard
 
     heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat100HeatingAirFlow(full_htg_sens_eff)
     heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat100HeatingAirFlow(full_htg_lat_eff)
-    heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(part_htg_sens_eff)
-    heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(part_htg_lat_eff)
     heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat100CoolingAirFlow(full_cool_sens_eff)
     heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat100CoolingAirFlow(full_cool_lat_eff)
-    heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(part_cool_sens_eff)
-    heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(part_cool_lat_eff)
+    if heat_exchanger_air_to_air_sensible_and_latent.model.version < OpenStudio::VersionString.new('3.8.0')
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(part_htg_sens_eff)
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(part_htg_lat_eff)
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(part_cool_sens_eff)
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(part_cool_lat_eff)
+    else
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(part_htg_sens_eff) unless part_htg_sens_eff.zero?
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(part_htg_lat_eff) unless part_htg_lat_eff.zero?
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(part_cool_sens_eff) unless part_cool_sens_eff.zero?
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(part_cool_lat_eff) unless part_cool_lat_eff.zero?
+    end
 
     OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.HeatExchangerSensLat', "For #{heat_exchanger_air_to_air_sensible_and_latent.name}: Set sensible and latent effectiveness.")
 

data/lib/openstudio-standards/standards/Standards.Model.rb

@@ -2791,6 +2791,11 @@ class Standard
         day_sch = sch_ruleset.defaultDaySchedule
         day_sch.setName("#{schedule_name} Default")
         model_add_vals_to_sch(model, day_sch, sch_type, values)
+        if model.version < OpenStudio::VersionString.new('3.8.0')
+          day_sch.setInterpolatetoTimestep(false)
+        else
+          day_sch.setInterpolatetoTimestep('No')
+        end
       end
 
       # Winter Design Day
@@ -2800,6 +2805,11 @@ class Standard
         day_sch = sch_ruleset.winterDesignDaySchedule
         day_sch.setName("#{schedule_name} Winter Design Day")
         model_add_vals_to_sch(model, day_sch, sch_type, values)
+        if model.version < OpenStudio::VersionString.new('3.8.0')
+          day_sch.setInterpolatetoTimestep(false)
+        else
+          day_sch.setInterpolatetoTimestep('No')
+        end
       end
 
       # Summer Design Day
@@ -2809,6 +2819,11 @@ class Standard
         day_sch = sch_ruleset.summerDesignDaySchedule
         day_sch.setName("#{schedule_name} Summer Design Day")
         model_add_vals_to_sch(model, day_sch, sch_type, values)
+        if model.version < OpenStudio::VersionString.new('3.8.0')
+          day_sch.setInterpolatetoTimestep(false)
+        else
+          day_sch.setInterpolatetoTimestep('No')
+        end
       end
 
       # Other days (weekdays, weekends, etc)
@@ -2827,6 +2842,11 @@ class Standard
         day_sch = sch_rule.daySchedule
         day_sch.setName("#{schedule_name} #{day_types} Day")
         model_add_vals_to_sch(model, day_sch, sch_type, values)
+        if model.version < OpenStudio::VersionString.new('3.8.0')
+          day_sch.setInterpolatetoTimestep(false)
+        else
+          day_sch.setInterpolatetoTimestep('No')
+        end
 
         # Set the dates when the rule applies
         sch_rule.setStartDate(OpenStudio::Date.new(OpenStudio::MonthOfYear.new(start_date.month.to_i), start_date.day.to_i))

data/lib/openstudio-standards/standards/ashrae_90_1/nrel_zne_ready_2017/nrel_zne_ready_2017.AirLoopHVAC.rb

@@ -808,12 +808,14 @@ class NRELZNEReady2017 < ASHRAE901
       if erv_type == 'HRV'
         erv.setSensibleEffectivenessat100HeatingAirFlow(0.865)
         erv.setLatentEffectivenessat100HeatingAirFlow(0.0)
-        erv.setSensibleEffectivenessat75HeatingAirFlow(0.887)
-        erv.setLatentEffectivenessat75HeatingAirFlow(0.0)
         erv.setSensibleEffectivenessat100CoolingAirFlow(0.865)
         erv.setLatentEffectivenessat100CoolingAirFlow(0.0)
+        erv.setSensibleEffectivenessat75HeatingAirFlow(0.887)
         erv.setSensibleEffectivenessat75CoolingAirFlow(0.887)
-        erv.setLatentEffectivenessat75CoolingAirFlow(0.0)
+        if erv.model.version < OpenStudio::VersionString.new('3.8.0')
+          erv.setLatentEffectivenessat75HeatingAirFlow(0.0)
+          erv.setLatentEffectivenessat75CoolingAirFlow(0.0)
+        end
       else
         erv.setSensibleEffectivenessat100HeatingAirFlow(0.755)
         erv.setLatentEffectivenessat100HeatingAirFlow(0.564)
@@ -829,11 +831,13 @@ class NRELZNEReady2017 < ASHRAE901
         erv.setSensibleEffectivenessat100HeatingAirFlow(0.75)
         erv.setLatentEffectivenessat100HeatingAirFlow(0.0)
         erv.setSensibleEffectivenessat75HeatingAirFlow(0.79)
-        erv.setLatentEffectivenessat75HeatingAirFlow(0.0)
         erv.setSensibleEffectivenessat100CoolingAirFlow(0.75)
         erv.setLatentEffectivenessat100CoolingAirFlow(0.0)
         erv.setSensibleEffectivenessat75CoolingAirFlow(0.78)
-        erv.setLatentEffectivenessat75CoolingAirFlow(0.0)
+        if erv.model.version < OpenStudio::VersionString.new('3.8.0')
+          erv.setLatentEffectivenessat75HeatingAirFlow(0.0)
+          erv.setLatentEffectivenessat75CoolingAirFlow(0.0)
+        end
       else
         erv.setSensibleEffectivenessat100HeatingAirFlow(0.75)
         erv.setLatentEffectivenessat100HeatingAirFlow(0.74)

data/lib/openstudio-standards/standards/deer/data/deer.constructions.json

@@ -344,20 +344,20 @@
       "name": "DEER Metal Framed Window",
       "intended_surface_type": "ExteriorWindow",
       "standards_construction_type": "Nonmetal framing (all)",
-      "insulation_layer": "Simple Glazing",
+      "insulation_layer": null,
       "skylight_framing": null,
       "materials": [
-        "Simple Glazing"
+        "Simple Glazing U 1.23 SHGC 0.61 VT 0.25"
       ]
     },
     {
       "name": "DEER Skylight",
       "intended_surface_type": "ExteriorWindow",
       "standards_construction_type": "Nonmetal framing (all)",
-      "insulation_layer": "Simple Glazing",
+      "insulation_layer": null,
       "skylight_framing": null,
       "materials": [
-        "Simple Glazing"
+        "Simple Glazing U 1.23 SHGC 0.61 VT 0.25"
       ]
     },
     {

data/lib/openstudio-standards/standards/necb/NECB2011/hvac_systems.rb

@@ -383,12 +383,19 @@ class NECB2011
     heat_exchanger_air_to_air_sensible_and_latent.setHeatExchangerType(erv_info['HeatExchangerType'])
     heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat100HeatingAirFlow(erv_info['SensibleEffectivenessat100HeatingAirFlow'])
     heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat100HeatingAirFlow(erv_info['LatentEffectivenessat100HeatingAirFlow'])
-    heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(erv_info['SensibleEffectivenessat75HeatingAirFlow'])
-    heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(erv_info['LatentEffectivenessat75HeatingAirFlow'])
     heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat100CoolingAirFlow(erv_info['SensibleEffectivenessat100CoolingAirFlow'])
     heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat100CoolingAirFlow(erv_info['LatentEffectivenessat100CoolingAirFlow'])
-    heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(erv_info['SensibleEffectivenessat75CoolingAirFlow'])
-    heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(erv_info['LatentEffectivenessat75CoolingAirFlow'])
+    if heat_exchanger_air_to_air_sensible_and_latent.model.version < OpenStudio::VersionString.new('3.8.0')
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(erv_info['SensibleEffectivenessat75HeatingAirFlow'])
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(erv_info['LatentEffectivenessat75HeatingAirFlow'])
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(erv_info['SensibleEffectivenessat75CoolingAirFlow'])
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(erv_info['LatentEffectivenessat75CoolingAirFlow'])
+    else
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(erv_info['SensibleEffectivenessat75HeatingAirFlow']) unless erv_info['SensibleEffectivenessat75HeatingAirFlow'].zero?
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(erv_info['LatentEffectivenessat75HeatingAirFlow']) unless erv_info['LatentEffectivenessat75HeatingAirFlow'].zero?
+      heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(erv_info['SensibleEffectivenessat75CoolingAirFlow']) unless erv_info['SensibleEffectivenessat75CoolingAirFlow'].zero?
+      heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(erv_info['LatentEffectivenessat75CoolingAirFlow']) unless erv_info['LatentEffectivenessat75CoolingAirFlow'].zero?
+    end
     heat_exchanger_air_to_air_sensible_and_latent.setSupplyAirOutletTemperatureControl(erv_info['SupplyAirOutletTemperatureControl'])
     heat_exchanger_air_to_air_sensible_and_latent.setFrostControlType(erv_info['FrostControlType'])
     heat_exchanger_air_to_air_sensible_and_latent.setEconomizerLockout(erv_info['EconomizerLockout'])
@@ -1816,19 +1823,19 @@ class NECB2011
       # Determine if space is heated or cooled via spacetype heating or cooling setpoints also checking if the space is
       # a plenum by checking if there is a hvac system associtated with it
       if sp_type_info['heating_setpoint_schedule'].nil?
-        heated = FALSE
+        heated = false
       else
-        heated = TRUE
+        heated = true
       end
       if sp_type_info['cooling_setpoint_schedule'].nil?
-        cooled = FALSE
+        cooled = false
       else
-        cooled = TRUE
+        cooled = true
       end
       if (sp_type_info['necb_hvac_system_selection_type'] == '- undefined -') || /undefined/.match(sp_type_info['necb_hvac_system_selection_type'])
-        not_plenum = FALSE
+        not_plenum = false
       else
-        not_plenum = TRUE
+        not_plenum = true
       end
       # If the spaces are heated or cooled and are not a plenum then continue
       if (heated || cooled) && not_plenum

data/lib/openstudio-standards/standards/necb/NECB2011/qaqc/necb_qaqc.rb

@@ -224,10 +224,6 @@ class NECB2011
     qaqc = {}
     qaqc[:sql_data] = get_sql_tables_to_json(model)
     error_warning = []
-    qaqc[:os_standards_revision] = OpenstudioStandards.git_revision
-    qaqc[:os_standards_version] = OpenstudioStandards::VERSION
-    qaqc[:openstudio_version] = os_version.strip
-    qaqc[:energyplus_version] = eplus_version.strip
     # Store Building data.
     qaqc[:building] = {}
     qaqc[:building][:name] = model.building.get.name.get

data/lib/openstudio-standards/standards/necb/common/btap_datapoint.rb

@@ -112,7 +112,7 @@ class BTAPDatapoint
         epw_file = @options[:epw_file]
         epw_dir = nil
         local_epw_file_path = File.join(input_folder_cache,@options[:epw_file])
-        epw_dir = input_folder_cache if File.exists? local_epw_file_path
+        epw_dir = input_folder_cache if File.exist? local_epw_file_path
         weather_file_path = OpenstudioStandards::Weather.get_standards_weather_file_path(epw_file)
         OpenstudioStandards::Weather.model_set_building_location(model, weather_file_path: weather_file_path)
       else

data/lib/openstudio-standards/version.rb

@@ -13,5 +13,5 @@ module OpenstudioStandards
     end
     return 'git-not-found-on-this-system'
   end
-  VERSION = '0.6.0.rc2'.freeze
+  VERSION = '0.6.1'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openstudio-standards
 version: !ruby/object:Gem::Version
-  version: 0.6.0.rc2
+  version: 0.6.1
 platform: ruby
 authors:
 - Mark Adams
@@ -39,274 +39,288 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-19 00:00:00.000000000 Z
+date: 2024-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: minitest-reporters
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: 2.4.10
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: 2.4.10
 - !ruby/object:Gem::Dependency
-  name: minitest-parallel_fork
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.16'
 - !ruby/object:Gem::Dependency
-  name: ruby-progressbar
+  name: parallel_tests
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.7.0
 - !ruby/object:Gem::Dependency
-  name: parallel_tests
+  name: aes
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 3.7.0
+        version: 0.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 3.7.0
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
-  name: nokogiri
+  name: codecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: google_drive
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.4
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.4
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.3.1
+        version: 5.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.3.1
+        version: 5.14.0
 - !ruby/object:Gem::Dependency
-  name: yard
+  name: minitest-ci
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: minitest-parallel_fork
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.68.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.68.1
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-checkstyle_formatter
+  name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 1.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 1.4.2
 - !ruby/object:Gem::Dependency
-  name: minitest-ci
+  name: openstudio-api-stubs
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.10.3
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.10.3
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubyXL
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: google_drive
+  name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.2
 - !ruby/object:Gem::Dependency
-  name: simplecov-html
+  name: roo
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 2.7.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 2.7.1
 - !ruby/object:Gem::Dependency
-  name: codecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.50'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.50'
 - !ruby/object:Gem::Dependency
-  name: rest-client
+  name: rubocop-checkstyle_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: 0.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
-  name: aes
+  name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: roo
+  name: rubyXL
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: 0.22.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: 0.22.0
 - !ruby/object:Gem::Dependency
-  name: openstudio-api-stubs
+  name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: tbd
   requirement: !ruby/object:Gem::Requirement
@@ -640,7 +654,6 @@ files:
 - data/geometry/DOERefWarehouse.json
 - data/geometry/DOERefWarehouse.osm
 - data/inventory/thermal_bridging.csv
-- data/standards/OpenStudio_Standards-deer-comstock.xlsx
 - data/standards/exclude_list.csv
 - data/standards/export_OpenStudio_libraries.rb
 - data/standards/legacy_dd_results.csv
@@ -650,7 +663,6 @@ files:
 - data/standards/metadata_units_OpenStudio_Standards-ashrae_90_1.csv
 - data/standards/metadata_units_OpenStudio_Standards-ashrae_90_1space_types.csv
 - data/standards/metadata_units_OpenStudio_Standards-deer-ALL-comstockspace_types.csv
-- data/standards/openstudio_standards_duplicates_log.csv
 - data/standards/templates_to_climate_zones.json
 - data/standards/test_performance_expected_dd_results.csv
 - data/weather/ARCATA_725945_CZ2010.ddy
@@ -2516,7 +2528,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Creates OpenStudio models of typical buildings, creates standard baselines

data/data/standards/openstudio_standards_duplicates_log.csv

@@ -1,5 +0,0 @@
-Spreadsheet Name,Worksheet Name,Object Index in Worksheet,Similarity of Duplicate,Duplicate Object
-OpenStudio_Standards-ashrae_90_1,refrigerated_cases,38,different,90.1-2004|Any|Service Deli Cases|
-OpenStudio_Standards-ashrae_90_1,refrigerated_cases,80,different,90.1-2007|Any|Service Deli Cases|
-OpenStudio_Standards-ashrae_90_1,refrigerated_cases,122,different,90.1-2010|Any|Service Deli Cases|
-OpenStudio_Standards-ashrae_90_1,refrigerated_cases,164,different,90.1-2013|Any|Service Deli Cases|