openstudio-standards 0.2.6 → 0.2.7

data/lib/openstudio-standards/standards/Standards.Model.rb

@@ -1184,7 +1184,7 @@ class Standard
   def model_eliminate_outlier_zones(model, array_of_zones, key_to_inspect, tolerance, field_name, units)
     # Sort the zones by the desired key
     begin
-      array_of_zones = array_of_zones.sort_by {|hsh| hsh[key_to_inspect]}
+      array_of_zones = array_of_zones.sort_by { |hsh| hsh[key_to_inspect] }
     rescue ArgumentError => e
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.Model', "Unable to sort array_of_zones by #{key_to_inspect} due to #{e.message}, defaulting to order that was passed")
     end
@@ -1204,6 +1204,12 @@ class Standard
       all_areas << area.round
       all_zn_names << zn['zone'].name.get.to_s
     end
+
+    if total_area == 0
+      OpenStudio.logFree(OpenStudio::Error, 'openstudio.standards.Model', "Total area is zero for array_of_zones with key #{key_to_inspect}, unable to calculate area-weighted average.")
+      return false
+    end
+
     avg = total / total_area
     OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.Model', "Values for #{field_name}, tol = #{tolerance} #{units}, area ft2:")
     OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.Model', "vals  #{all_vals.join(', ')}")
@@ -1211,11 +1217,14 @@ class Standard
     OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.Model', "names #{all_zn_names.join(', ')}")
 
     # Calculate the biggest delta and the index of the biggest delta
-    biggest_delta_i = nil
+    biggest_delta_i = 0 # array at first item in case delta is 0
     biggest_delta = 0.0
     worst = nil
     array_of_zones.each_with_index do |zn, i|
       val = zn[key_to_inspect]
+      if worst.nil? # array at first item in case delta is 0
+        worst = val
+      end
       delta = (val - avg).abs
       if delta >= biggest_delta
         biggest_delta = delta

data/lib/openstudio-standards/standards/ashrae_90_1/nrel_zne_ready_2017/nrel_zne_ready_2017.AirLoopHVAC.rb

@@ -40,6 +40,11 @@ class NRELZNEReady2017 < ASHRAE901
     if air_loop_hvac_multizone_vav_system?(air_loop_hvac) && air_loop_hvac_terminal_reheat?(air_loop_hvac)
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', 'Applying multizone VAV Reheat system controls.')
 
+      # Energy Recovery Ventilation
+      if air_loop_hvac_energy_recovery_ventilator_required?(air_loop_hvac, climate_zone)
+        air_loop_hvac_apply_energy_recovery_ventilator(air_loop_hvac)
+      end
+
       # economizer controls
       air_loop_hvac_apply_economizer_limits(air_loop_hvac, climate_zone)
       air_loop_hvac_apply_economizer_integration(air_loop_hvac, climate_zone)
@@ -452,4 +457,257 @@ class NRELZNEReady2017 < ASHRAE901
     opt_start_required = true
     return opt_start_required
   end
+
+  # Check if ERV is required on this airloop.
+  #
+  # @return [Bool] Returns true if required, false if not.
+  def air_loop_hvac_energy_recovery_ventilator_required?(air_loop_hvac, climate_zone)
+
+    if air_loop_hvac.airLoopHVACOutdoorAirSystem.is_initialized
+      oa_system = air_loop_hvac.airLoopHVACOutdoorAirSystem.get
+      controller_oa = oa_system.getControllerOutdoorAir
+      controller_mv = controller_oa.controllerMechanicalVentilation
+    else
+      OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}, ERV not applicable because it has no OA intake.")
+      return false
+    end
+
+    # Get the AHU design supply air flow rate
+    dsn_flow_m3_per_s = nil
+    if air_loop_hvac.designSupplyAirFlowRate.is_initialized
+      dsn_flow_m3_per_s = air_loop_hvac.designSupplyAirFlowRate.get
+    elsif air_loop_hvac.autosizedDesignSupplyAirFlowRate.is_initialized
+      dsn_flow_m3_per_s = air_loop_hvac.autosizedDesignSupplyAirFlowRate.get
+    else
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name} design supply air flow rate is not available, cannot apply efficiency standard.")
+      return false
+    end
+    dsn_flow_cfm = OpenStudio.convert(dsn_flow_m3_per_s, 'm^3/s', 'cfm').get
+
+    # Get the minimum OA flow rate
+    min_oa_flow_m3_per_s = nil
+    if controller_oa.minimumOutdoorAirFlowRate.is_initialized
+      min_oa_flow_m3_per_s = controller_oa.minimumOutdoorAirFlowRate.get
+    elsif controller_oa.autosizedMinimumOutdoorAirFlowRate.is_initialized
+      min_oa_flow_m3_per_s = controller_oa.autosizedMinimumOutdoorAirFlowRate.get
+    else
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "For #{controller_oa.name}: minimum OA flow rate is not available, cannot apply efficiency standard.")
+      return false
+    end
+    min_oa_flow_cfm = OpenStudio.convert(min_oa_flow_m3_per_s, 'm^3/s', 'cfm').get
+
+    # Calculate the percent OA at design airflow
+    pct_oa = min_oa_flow_m3_per_s / dsn_flow_m3_per_s
+
+    # Determine the airflow limit
+    erv_cfm = air_loop_hvac_energy_recovery_ventilator_flow_limit(air_loop_hvac, climate_zone, pct_oa)
+
+    # Determine if an ERV is required
+    if erv_cfm.nil?
+      OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}, ERV not required based on #{(pct_oa * 100).round}% OA flow, design supply air flow of #{dsn_flow_cfm.round}cfm, and climate zone #{climate_zone}.")
+      erv_required = false
+    elsif dsn_flow_cfm < erv_cfm
+      OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}, ERV not required based on #{(pct_oa * 100).round}% OA flow, design supply air flow of #{dsn_flow_cfm.round}cfm, and climate zone #{climate_zone}. Does not exceed minimum flow requirement of #{erv_cfm}cfm.")
+      erv_required = false
+    else
+      OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}, ERV required based on #{(pct_oa * 100).round}% OA flow, design supply air flow of #{dsn_flow_cfm.round}cfm, and climate zone #{climate_zone}. Exceeds minimum flow requirement of #{erv_cfm}cfm.")
+      erv_required = true
+    end
+
+    return erv_required
+  end
+
+  # Determine the airflow limits that govern whether or not an ERV is required.
+  # Based on climate zone and % OA, plus the number of operating hours the system has.
+  # @return [Double] the flow rate above which an ERV is required.
+  # if nil, ERV is never required.
+  # based on ASHRAE 90.1-2016
+  def air_loop_hvac_energy_recovery_ventilator_flow_limit(air_loop_hvac, climate_zone, pct_oa)
+    # Calculate the number of system operating hours
+    # based on the availability schedule.
+    ann_op_hrs = 0.0
+    avail_sch = air_loop_hvac.availabilitySchedule
+    if avail_sch == air_loop_hvac.model.alwaysOnDiscreteSchedule
+      ann_op_hrs = 8760.0
+    elsif avail_sch.to_ScheduleRuleset.is_initialized
+      avail_sch = avail_sch.to_ScheduleRuleset.get
+      ann_op_hrs = schedule_ruleset_annual_hours_above_value(avail_sch, 0.0)
+    else
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}: could not determine annual operating hours. Assuming less than 8,000 for ERV determination.")
+    end
+
+    if ann_op_hrs < 8000.0
+      # Table 6.5.6.1-1, less than 8000 hrs
+      case climate_zone
+      when 'ASHRAE 169-2006-3B', 'ASHRAE 169-2006-3C', 'ASHRAE 169-2006-4B', 'ASHRAE 169-2006-4C', 'ASHRAE 169-2006-5B'
+        if pct_oa < 0.1
+          erv_cfm = nil
+        elsif pct_oa >= 0.1 && pct_oa < 0.2
+          erv_cfm = nil
+        elsif pct_oa >= 0.2 && pct_oa < 0.3
+          erv_cfm = nil
+        elsif pct_oa >= 0.3 && pct_oa < 0.4
+          erv_cfm = nil
+        elsif pct_oa >= 0.4 && pct_oa < 0.5
+          erv_cfm = nil
+        elsif pct_oa >= 0.5 && pct_oa < 0.6
+          erv_cfm = nil
+        elsif pct_oa >= 0.6 && pct_oa < 0.7
+          erv_cfm = nil
+        elsif pct_oa >= 0.7 && pct_oa < 0.8
+          erv_cfm = nil
+        elsif pct_oa >= 0.8
+          erv_cfm = nil
+        end
+      when 'ASHRAE 169-2006-1B', 'ASHRAE 169-2006-2B', 'ASHRAE 169-2006-5C'
+        if pct_oa < 0.1
+          erv_cfm = nil
+        elsif pct_oa >= 0.1 && pct_oa < 0.2
+          erv_cfm = nil
+        elsif pct_oa >= 0.2 && pct_oa < 0.3
+          erv_cfm = nil
+        elsif pct_oa >= 0.3 && pct_oa < 0.4
+          erv_cfm = nil
+        elsif pct_oa >= 0.4 && pct_oa < 0.5
+          erv_cfm = nil
+        elsif pct_oa >= 0.5 && pct_oa < 0.6
+          erv_cfm = 26_000
+        elsif pct_oa >= 0.6 && pct_oa < 0.7
+          erv_cfm = 12_000
+        elsif pct_oa >= 0.7 && pct_oa < 0.8
+          erv_cfm = 5000
+        elsif pct_oa >= 0.8
+          erv_cfm = 4000
+        end
+      when 'ASHRAE 169-2006-6B'
+        if pct_oa < 0.1
+          erv_cfm = nil
+        elsif pct_oa >= 0.1 && pct_oa < 0.2
+          erv_cfm = 28_000
+        elsif pct_oa >= 0.2 && pct_oa < 0.3
+          erv_cfm = 26_500
+        elsif pct_oa >= 0.3 && pct_oa < 0.4
+          erv_cfm = 11_000
+        elsif pct_oa >= 0.4 && pct_oa < 0.5
+          erv_cfm = 5500
+        elsif pct_oa >= 0.5 && pct_oa < 0.6
+          erv_cfm = 4500
+        elsif pct_oa >= 0.6 && pct_oa < 0.7
+          erv_cfm = 3500
+        elsif pct_oa >= 0.7 && pct_oa < 0.8
+          erv_cfm = 2500
+        elsif pct_oa >= 0.8
+          erv_cfm = 1500
+        end
+      when 'ASHRAE 169-2006-1A', 'ASHRAE 169-2006-2A', 'ASHRAE 169-2006-3A', 'ASHRAE 169-2006-4A', 'ASHRAE 169-2006-5A', 'ASHRAE 169-2006-6A'
+        if pct_oa < 0.1
+          erv_cfm = nil
+        elsif pct_oa >= 0.1 && pct_oa < 0.2
+          erv_cfm = 26_000
+        elsif pct_oa >= 0.2 && pct_oa < 0.3
+          erv_cfm = 16_000
+        elsif pct_oa >= 0.3 && pct_oa < 0.4
+          erv_cfm = 5500
+        elsif pct_oa >= 0.4 && pct_oa < 0.5
+          erv_cfm = 4500
+        elsif pct_oa >= 0.5 && pct_oa < 0.6
+          erv_cfm = 3500
+        elsif pct_oa >= 0.6 && pct_oa < 0.7
+          erv_cfm = 2000
+        elsif pct_oa >= 0.7 && pct_oa < 0.8
+          erv_cfm = 1000
+        elsif pct_oa >= 0.8
+          erv_cfm = 120
+        end
+      when 'ASHRAE 169-2006-7A', 'ASHRAE 169-2006-7B', 'ASHRAE 169-2006-8A', 'ASHRAE 169-2006-8B'
+        if pct_oa < 0.1
+          erv_cfm = nil
+        elsif pct_oa >= 0.1 && pct_oa < 0.2
+          erv_cfm = 4500
+        elsif pct_oa >= 0.2 && pct_oa < 0.3
+          erv_cfm = 4000
+        elsif pct_oa >= 0.3 && pct_oa < 0.4
+          erv_cfm = 2500
+        elsif pct_oa >= 0.4 && pct_oa < 0.5
+          erv_cfm = 1000
+        elsif pct_oa >= 0.5 && pct_oa < 0.6
+          erv_cfm = 140
+        elsif pct_oa >= 0.6 && pct_oa < 0.7
+          erv_cfm = 120
+        elsif pct_oa >= 0.7 && pct_oa < 0.8
+          erv_cfm = 100
+        elsif pct_oa >= 0.8
+          erv_cfm = 80
+        end
+      end
+    else
+      # Table 6.5.6.1-2, above 8000 hrs
+      case climate_zone
+      when 'ASHRAE 169-2006-3C'
+        erv_cfm = nil
+      when 'ASHRAE 169-2006-1B', 'ASHRAE 169-2006-2B', 'ASHRAE 169-2006-3B', 'ASHRAE 169-2006-4C', 'ASHRAE 169-2006-5C'
+        if pct_oa < 0.1
+          erv_cfm = nil
+        elsif pct_oa >= 0.1 && pct_oa < 0.2
+          erv_cfm = nil
+        elsif pct_oa >= 0.2 && pct_oa < 0.3
+          erv_cfm = 19_500
+        elsif pct_oa >= 0.3 && pct_oa < 0.4
+          erv_cfm = 9000
+        elsif pct_oa >= 0.4 && pct_oa < 0.5
+          erv_cfm = 5000
+        elsif pct_oa >= 0.5 && pct_oa < 0.6
+          erv_cfm = 4000
+        elsif pct_oa >= 0.6 && pct_oa < 0.7
+          erv_cfm = 3000
+        elsif pct_oa >= 0.7 && pct_oa < 0.8
+          erv_cfm = 1500
+        elsif pct_oa >= 0.8
+          erv_cfm = 120
+        end
+      when 'ASHRAE 169-2006-1A', 'ASHRAE 169-2006-2A', 'ASHRAE 169-2006-3A', 'ASHRAE 169-2006-4B', 'ASHRAE 169-2006-5B'
+        if pct_oa < 0.1
+          erv_cfm = nil
+        elsif pct_oa >= 0.1 && pct_oa < 0.2
+          erv_cfm = 2500
+        elsif pct_oa >= 0.2 && pct_oa < 0.3
+          erv_cfm = 2000
+        elsif pct_oa >= 0.3 && pct_oa < 0.4
+          erv_cfm = 1000
+        elsif pct_oa >= 0.4 && pct_oa < 0.5
+          erv_cfm = 500
+        elsif pct_oa >= 0.5 && pct_oa < 0.6
+          erv_cfm = 140
+        elsif pct_oa >= 0.6 && pct_oa < 0.7
+          erv_cfm = 120
+        elsif pct_oa >= 0.7 && pct_oa < 0.8
+          erv_cfm = 100
+        elsif pct_oa >= 0.8
+          erv_cfm = 80
+        end
+      when 'ASHRAE 169-2006-4A', 'ASHRAE 169-2006-5A', 'ASHRAE 169-2006-6A', 'ASHRAE 169-2006-6B', 'ASHRAE 169-2006-7A', 'ASHRAE 169-2006-7B', 'ASHRAE 169-2006-8A', 'ASHRAE 169-2006-8B'
+        if pct_oa < 0.1
+          erv_cfm = nil
+        elsif pct_oa >= 0.1 && pct_oa < 0.2
+          erv_cfm = 200
+        elsif pct_oa >= 0.2 && pct_oa < 0.3
+          erv_cfm = 130
+        elsif pct_oa >= 0.3 && pct_oa < 0.4
+          erv_cfm = 100
+        elsif pct_oa >= 0.4 && pct_oa < 0.5
+          erv_cfm = 80
+        elsif pct_oa >= 0.5 && pct_oa < 0.6
+          erv_cfm = 70
+        elsif pct_oa >= 0.6 && pct_oa < 0.7
+          erv_cfm = 60
+        elsif pct_oa >= 0.7 && pct_oa < 0.8
+          erv_cfm = 50
+        elsif pct_oa >= 0.8
+          erv_cfm = 40
+        end
+      end
+    end
+
+    return erv_cfm
+  end
 end

data/lib/openstudio-standards/utilities/logging.rb

@@ -19,7 +19,8 @@ def log_messages_to_runner(runner, debug = false)
               msg.logMessage.include?('UseWeatherFile') || # 'UseWeatherFile' is not yet a supported option for YearDescription
               msg.logMessage.include?('Successive data points') || # Successive data points (2004-Jan-31 to 2001-Feb-01, ending on line 753) are greater than 1 day apart in EPW file
               msg.logMessage.include?('has multiple parents') || # Bogus errors about curves having multiple parents
-              msg.logMessage.include?('does not have an Output') # Warning from EMS translation
+              msg.logMessage.include?('does not have an Output') || # Warning from EMS translation
+              msg.logMessage.include?('Prior to OpenStudio 2.6.2, this field was returning a double, it now returns an Optional double') # Warning about OS API change
 
       # Report the message in the correct way
       if msg.logLevel == OpenStudio::Info
@@ -54,7 +55,8 @@ def log_messages_to_file(file_path, debug = false)
                 msg.logMessage.include?('UseWeatherFile') || # 'UseWeatherFile' is not yet a supported option for YearDescription
                 msg.logMessage.include?('Successive data points') || # Successive data points (2004-Jan-31 to 2001-Feb-01, ending on line 753) are greater than 1 day apart in EPW file
                 msg.logMessage.include?('has multiple parents') || # Bogus errors about curves having multiple parents
-                msg.logMessage.include?('does not have an Output') # Warning from EMS translation
+                msg.logMessage.include?('does not have an Output') || # Warning from EMS translation
+                msg.logMessage.include?('Prior to OpenStudio 2.6.2, this field was returning a double, it now returns an Optional double') # Warning about OS API change
 
         # Report the message in the correct way
         if msg.logLevel == OpenStudio::Info
@@ -95,7 +97,8 @@ def get_logs(log_type = OpenStudio::Error)
               msg.logMessage.include?('UseWeatherFile') || # 'UseWeatherFile' is not yet a supported option for YearDescription
               msg.logMessage.include?('Successive data points') || # Successive data points (2004-Jan-31 to 2001-Feb-01, ending on line 753) are greater than 1 day apart in EPW file
               msg.logMessage.include?('has multiple parents') || # Bogus errors about curves having multiple parents
-              msg.logMessage.include?('does not have an Output') # Warning from EMS translation
+              msg.logMessage.include?('does not have an Output') || # Warning from EMS translation
+              msg.logMessage.include?('Prior to OpenStudio 2.6.2, this field was returning a double, it now returns an Optional double') # Warning about OS API change
       # Only fail on the errors
       if msg.logLevel == log_type
         errors << "[#{msg.logChannel}] #{msg.logMessage}"

data/lib/openstudio-standards/version.rb

@@ -13,5 +13,5 @@ module OpenstudioStandards
     end
     return 'git-not-found-on-this-system'
   end
-  VERSION = '0.2.6'.freeze
+  VERSION = '0.2.7'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openstudio-standards
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors:
 - Andrew Parker
@@ -21,7 +21,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-11 00:00:00.000000000 Z
+date: 2018-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest-reporters