openstudio-standards 0.2.17.rc2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e9530b5c7223d50af5e3798df58867485a369ce5cfd5e403381ea43e49b7a3f1
-  data.tar.gz: 1d8589faff7ca2883a68b757d537a2c744dcefb12d752e41ebe6b1e7c3b920c2
+  metadata.gz: 869188124d2251a59ea1f453f897450d7b25017970f0a507322ec8c569135ae9
+  data.tar.gz: d4107600d066939c8ee60b95df4d1dd7a18fd35039a575649b68866d27f95653
 SHA512:
-  metadata.gz: aa366a20854813054da39fadd020c4193beb14522231128775ec52f49fb646d09210f9d2a8a75d8a0e327ffd3d7f3699854012d5cb8a43391357a55857d50fc2
-  data.tar.gz: 88a723a11e10ac0f1b83278771bd8c039c45f1a1f4f58338a115a67a4bd920685f4b56b203573d0adf1d7dab1fbddfa2c94c4c7e7b63dd589608c41cc34f71c1
+  metadata.gz: c271293b7547a006dbd6594747f74a55278407633376060d51604320660ee86839c6bcefafaa8cf24d635fab0272236b85c496aee982aaea6f57a1b23771b987
+  data.tar.gz: 808dc8cc49bb9d67c8496e57eb8a504650c8417b6539be87a314c8b0165a6beef2bc93b10d48f67d2842651b33cbd42f4727307d802aca9fb468788b59c8a120

data/lib/openstudio-standards/prototypes/common/objects/Prototype.Model.exterior_lights.rb

@@ -59,7 +59,7 @@ class Standard
     end
 
     # add exterior lights for parking area
-    if area_length_count_hash[:parking_area_and_drives_area] > 0
+    if !area_length_count_hash[:parking_area_and_drives_area].nil? && area_length_count_hash[:parking_area_and_drives_area] > 0
 
       # lighting values
       multiplier = area_length_count_hash[:parking_area_and_drives_area] * onsite_parking_fraction
@@ -86,7 +86,7 @@ class Standard
     end
 
     # add exterior lights for facades
-    if area_length_count_hash[:building_facades] > 0
+    if !area_length_count_hash[:building_facades].nil? && area_length_count_hash[:building_facades] > 0
 
       # lighting values
       multiplier = area_length_count_hash[:building_facades]
@@ -113,7 +113,7 @@ class Standard
     end
 
     # add exterior lights for main entries
-    if area_length_count_hash[:main_entries] > 0
+    if !area_length_count_hash[:main_entries].nil? && area_length_count_hash[:main_entries] > 0
 
       # lighting values
       multiplier = area_length_count_hash[:main_entries]
@@ -140,7 +140,7 @@ class Standard
     end
 
     # add exterior lights for other doors
-    if area_length_count_hash[:other_doors] > 0
+    if !area_length_count_hash[:other_doors].nil? && area_length_count_hash[:other_doors] > 0
 
       # lighting values
       multiplier = area_length_count_hash[:other_doors]
@@ -167,7 +167,7 @@ class Standard
     end
 
     # add exterior lights for entry canopies
-    if area_length_count_hash[:canopy_entry_area] > 0
+    if !area_length_count_hash[:canopy_entry_area].nil? && area_length_count_hash[:canopy_entry_area] > 0
 
       # lighting values
       multiplier = area_length_count_hash[:canopy_entry_area]
@@ -194,7 +194,7 @@ class Standard
     end
 
     # add exterior lights for emergency canopies
-    if area_length_count_hash[:canopy_emergency_area] > 0
+    if !area_length_count_hash[:canopy_emergency_area].nil? && area_length_count_hash[:canopy_emergency_area] > 0
 
       # lighting values
       multiplier = area_length_count_hash[:canopy_emergency_area]
@@ -221,7 +221,7 @@ class Standard
     end
 
     # add exterior lights for drive through windows
-    if area_length_count_hash[:drive_through_windows] > 0
+    if !area_length_count_hash[:drive_through_windows].nil? && area_length_count_hash[:drive_through_windows] > 0
 
       # lighting values
       multiplier = area_length_count_hash[:drive_through_windows]

data/lib/openstudio-standards/prototypes/common/objects/Prototype.Model.rb

@@ -2721,7 +2721,11 @@ Standard.class_eval do
         end
       end
     end
-    return window_area / wall_area * 100 if wwr
+
+    # check wall area is non-zero
+    if wwr && wall_area > 0
+      return window_area / wall_area * 100
+    end
 
     # else
     return window_area

data/lib/openstudio-standards/prototypes/common/objects/Prototype.ServiceWaterHeating.rb

@@ -546,6 +546,14 @@ class Standard
       default_water_heater_ambient_temp_sch = model_add_constant_schedule_ruleset(model,
                                                                                   OpenStudio.convert(70.0, 'F', 'C').get,
                                                                                   name = 'Water Heater Ambient Temp Schedule - 70F')
+      if temp_sch_type_limits.nil?
+        temp_sch_type_limits = model_add_schedule_type_limits(model,
+                                                              name: 'Temperature Schedule Type Limits',
+                                                              lower_limit_value: 0.0,
+                                                              upper_limit_value: 100.0,
+                                                              numeric_type: 'Continuous',
+                                                              unit_type: 'Temperature')
+      end
       default_water_heater_ambient_temp_sch.setScheduleTypeLimits(temp_sch_type_limits)
       tank.setAmbientTemperatureIndicator('Schedule')
       tank.setAmbientTemperatureSchedule(default_water_heater_ambient_temp_sch)

data/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb

@@ -3264,7 +3264,9 @@ class Standard
       # To solve the issue, add economizer here for cold climates
       # select the climate zones with winter design temperature lower than -20C (for safer)
       cold_climates = ['ASHRAE 169-2006-6A', 'ASHRAE 169-2006-6B', 'ASHRAE 169-2006-7A',
-                       'ASHRAE 169-2006-7B', 'ASHRAE 169-2006-8A', 'ASHRAE 169-2006-8B']
+                       'ASHRAE 169-2006-7B', 'ASHRAE 169-2006-8A', 'ASHRAE 169-2006-8B',
+                       'ASHRAE 169-2013-6A', 'ASHRAE 169-2013-6B', 'ASHRAE 169-2013-7A',
+                       'ASHRAE 169-2013-7B', 'ASHRAE 169-2013-8A', 'ASHRAE 169-2013-8B']
       if cold_climates.include? climate_zone
         # Determine the economizer type in the prototype buildings, which depends on climate zone.
         economizer_type = model_economizer_type(model, climate_zone)

data/lib/openstudio-standards/standards/Standards.ThermalZone.rb

@@ -980,7 +980,7 @@ class Standard
         end
       elsif equip.to_ZoneHVACLowTemperatureRadiantElectric.is_initialized
         equip = equip.to_ZoneHVACLowTemperatureRadiantElectric.get
-        htg_sch = equip.heatingSetpointTemperatureSchedule.get
+        htg_sch = equip.heatingSetpointTemperatureSchedule
       elsif equip.to_ZoneHVACLowTempRadiantConstFlow.is_initialized
         equip = equip.to_ZoneHVACLowTempRadiantConstFlow.get
         htg_coil = equip.heatingCoil

data/lib/openstudio-standards/standards/Standards.WaterHeaterMixed.rb

@@ -169,15 +169,15 @@ class Standard
     end
 
     # Convert to SI
-    ua_btu_per_hr_per_c = OpenStudio.convert(ua_btu_per_hr_per_f, 'Btu/hr*R', 'W/K').get
-    OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.WaterHeaterMixed', "For #{water_heater_mixed.name}, skin-loss UA = #{ua_btu_per_hr_per_c} W/K.")
+    ua_w_per_k = OpenStudio.convert(ua_btu_per_hr_per_f, 'Btu/hr*R', 'W/K').get
+    OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.WaterHeaterMixed', "For #{water_heater_mixed.name}, skin-loss UA = #{ua_w_per_k} W/K.")
 
     # Set the water heater properties
     # Efficiency
     water_heater_mixed.setHeaterThermalEfficiency(water_heater_eff)
     # Skin loss
-    water_heater_mixed.setOffCycleLossCoefficienttoAmbientTemperature(ua_btu_per_hr_per_c)
-    water_heater_mixed.setOnCycleLossCoefficienttoAmbientTemperature(ua_btu_per_hr_per_c)
+    water_heater_mixed.setOffCycleLossCoefficienttoAmbientTemperature(ua_w_per_k)
+    water_heater_mixed.setOnCycleLossCoefficienttoAmbientTemperature(ua_w_per_k)
     # @todo Parasitic loss (pilot light)
     # PNNL document says pilot lights were removed, but IDFs
     # still have the on/off cycle parasitic fuel consumptions filled in
@@ -190,7 +190,7 @@ class Standard
 
     # Append the name with standards information
     water_heater_mixed.setName("#{water_heater_mixed.name} #{water_heater_eff.round(3)} Therm Eff")
-    OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr")
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr-R")
 
     return true
   end

data/lib/openstudio-standards/standards/ashrae_90_1/data/ashrae_90_1.entryways.json

@@ -9,7 +9,7 @@
       "emergency_canopies": null,
       "canopy_size": null,
       "floor_area_per_drive_through_window": null,
-      "notes": "match secondary school"
+      "notes": "match SecondarySchool"
     },
     {
       "building_type": "Courthouse",
@@ -20,7 +20,7 @@
       "emergency_canopies": null,
       "canopy_size": null,
       "floor_area_per_drive_through_window": null,
-      "notes": "match medium office"
+      "notes": "match MediumOffice"
     },
     {
       "building_type": "FullServiceRestaurant",
@@ -55,6 +55,17 @@
       "floor_area_per_drive_through_window": null,
       "notes": "No source for canopy size, Table 5.41. Exterior Lighting Savings Summary for Addendum 90.1-07i  doesn't indicate canopy lighting. Section 5.4.2 Exterior Lights in U.S. Department of Energy Commercial Reference Building Models of the National Building Stock shows their use."
     },
+    {
+      "building_type": "Laboratory",
+      "rollup_doors_per_10,000": 0.0,
+      "entrance_doors_per_10,000": 2.0,
+      "others_doors_per_10,000": 2.45,
+      "entrance_canopies": null,
+      "emergency_canopies": null,
+      "canopy_size": null,
+      "floor_area_per_drive_through_window": null,
+      "notes": "match SecondarySchool"
+    },
     {
       "building_type": "LargeDataCenterHighITE",
       "rollup_doors_per_10,000": null,

data/lib/openstudio-standards/standards/ashrae_90_1/data/ashrae_90_1.parking.json

@@ -7,7 +7,7 @@
       "students_per_spot": null,
       "beds_per_spot": null,
       "parking_area_per_spot": 405.0,
-      "notes": "Based on Table 4.17 Illuminated Parking Area from Achieving the 30% Goal: Energy and Cost Savings Analysis of ASHRAE Standard 90.1-2010"
+      "notes": "match MediumOffice"
     },
     {
       "building_type": "Courthouse",
@@ -16,7 +16,7 @@
       "students_per_spot": null,
       "beds_per_spot": null,
       "parking_area_per_spot": 405.0,
-      "notes": "Based on Table 4.17 Illuminated Parking Area from Achieving the 30% Goal: Energy and Cost Savings Analysis of ASHRAE Standard 90.1-2010"
+      "notes": "match MediumOffice"
     },
     {
       "building_type": "FullServiceRestaurant",
@@ -45,6 +45,15 @@
       "parking_area_per_spot": 405.0,
       "notes": "Based on Table 4.17 Illuminated Parking Area from Achieving the 30% Goal: Energy and Cost Savings Analysis of ASHRAE Standard 90.1-2010"
     },
+    {
+      "building_type": "Laboratory",
+      "building_area_per_spot": 250.0,
+      "units_per_spot": null,
+      "students_per_spot": null,
+      "beds_per_spot": null,
+      "parking_area_per_spot": 405.0,
+      "notes": "match MediumOffice"
+    },
     {
       "building_type": "LargeDataCenterHighITE",
       "building_area_per_spot": 0.0,

data/lib/openstudio-standards/standards/necb/NECB2011/service_water_heating.rb

@@ -222,7 +222,7 @@ class NECB2011
 
     # Append the name with standards information
     water_heater_mixed.setName("#{water_heater_mixed.name} #{water_heater_eff.round(3)} Therm Eff")
-    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr")
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr-R")
     return true
   end
 

data/lib/openstudio-standards/standards/necb/NECB2020/service_water_heating.rb

@@ -153,7 +153,7 @@ class NECB2020
 
     # Append the name with standards information
     water_heater_mixed.setName("#{water_heater_mixed.name} #{water_heater_eff.round(3)} Therm Eff")
-    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr")
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.WaterHeaterMixed', "For #{template}: #{water_heater_mixed.name}; thermal efficiency = #{water_heater_eff.round(3)}, skin-loss UA = #{ua_btu_per_hr_per_f.round}Btu/hr-R")
     return true
   end
 end

data/lib/openstudio-standards/version.rb

@@ -13,5 +13,5 @@ module OpenstudioStandards
     end
     return 'git-not-found-on-this-system'
   end
-  VERSION = '0.2.17.rc2'.freeze
+  VERSION = '0.3.0'.freeze
 end

data/lib/openstudio-standards/weather/Weather.Model.rb

@@ -98,6 +98,11 @@ class Standard
       weather_dir = File.expand_path(File.join(Dir.pwd, 'extracted_files/weather/'))
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.weather.Model', "Extracting weather files from OpenStudio CLI to #{weather_dir}")
       FileUtils.mkdir_p(weather_dir)
+
+      path_length = "#{weather_dir}/#{weather_file_name}".length
+      if path_length > 260
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.weather.Model', "Weather file path length #{path_length} is >260 characters and may cause issues in Windows environments.")
+      end
       File.open("#{weather_dir}/#{weather_file_name}", 'wb') { |f| f << epw_string; f.flush }
       File.open("#{weather_dir}/#{weather_file_name.gsub('.epw', '.ddy')}", 'wb') { |f| f << ddy_string; f.flush }
       File.open("#{weather_dir}/#{weather_file_name.gsub('.epw', '.stat')}", 'wb') { |f| f << stat_string; f.flush }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openstudio-standards
 version: !ruby/object:Gem::Version
-  version: 0.2.17.rc2
+  version: 0.3.0
 platform: ruby
 authors:
 - Andrew Parker
@@ -28,7 +28,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-20 00:00:00.000000000 Z
+date: 2022-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest-reporters