openstudio-standards 0.2.17.rc1 → 0.2.17.rc2

data/lib/openstudio-standards/btap/measures.rb

@@ -24,28 +24,28 @@ require "#{File.dirname(__FILE__)}/btap"
 
 class OSMArg
   ARGUMENT_TYPES = [
-    "BOOL",         
-    "STRING",       
-    "INTEGER",      
-    "FLOAT",        
+    "BOOL",
+    "STRING",
+    "INTEGER",
+    "FLOAT",
     "STRINGCHOICE",
-    "WSCHOICE"     
+    "WSCHOICE"
   ]
-        
-        
-        
-  attr_accessor :runner, 
-    :variable_name, 
+
+
+
+  attr_accessor :runner,
+    :variable_name,
     :type,
-    :required,  
+    :required,
     :model_dependant,
-    :display_name, 
-    :default_value, 
-    :min_value,  
-    :max_value,  
-    :string_choice_array,  	
+    :display_name,
+    :default_value,
+    :min_value,
+    :max_value,
+    :string_choice_array,
     :os_object_type
-        
+
   def self.bool( variable_name,display_name,required,default_value )
     raise "#{default_value} defaut value is not a bool." unless default_value.is_a?(Bool)
     default_value.respond_to?(:to_s)
@@ -53,47 +53,47 @@ class OSMArg
     arg.default_value = default_value
     return arg
   end
-        
+
   def self.string( variable_name,display_name,required,default_value )
     raise "#{default_value} defaut value is not a string." unless default_value.respond_to?(:to_s)
     arg = OSMArg.new( "STRING", variable_name, display_name, required)
     arg.default_value = default_value
     return arg
   end
-        
+
   def self.integer( variable_name,display_name,required,default_value,min_value,max_value )
     raise "#{default_value} defaut value is not a integer." unless default_value.respond_to?(:to_i)
     arg = OSMArg.new( "INTEGER", variable_name, display_name, required)
     arg.default_value = default_value
     arg.min_value = min_value
     arg.max_value = max_value
-    return arg          
+    return arg
   end
-        
+
   def self.float( variable_name, display_name, required,default_value,min_value, max_value )
     raise "#{default_value} defaut value is not a float." unless default_value.respond_to?(:to_f)
     arg = OSMArg.new( "INTEGER", variable_name, display_name, required)
     arg.default_value = default_value
     arg.min_value = min_value
     arg.max_value = max_value
-    return arg          
+    return arg
   end
-        
+
   def self.choice(variable_name,display_name,required,default_value,string_choice_array)
-    raise "#{default_value} defaut value is not an array." unless default_value.is_a?(Array)    
+    raise "#{default_value} defaut value is not an array." unless default_value.is_a?(Array)
     arg = OSMArg.new( "STRINGCHOICE", variable_name, display_name, required)
     arg.default_value = default_value
     arg.string_choice_array = string_choice_array
     return arg
   end
-        
+
   def self.wschoice( variable_name, display_name, required, default_value, os_object_type)
     arg = OSMArg.new( "WSCHOICE", variable_name, display_name, required )
     arg.default_value = default_value
     arg.os_object_type = os_object_type
-    return arg          
+    return arg
   end
-        
+
   def initialize( type, variable_name, display_name, required )
     self.type = type
     self.variable_name = variable_name
@@ -106,9 +106,9 @@ class OSMArg
       self.model_dependant = false
     end
     return self
-  end  
+  end
 end
-      
+
 
 
 
@@ -116,10 +116,10 @@ end
 module BTAP
   module Measures
     module OSMeasures
-      
-      
-      
-      
+
+
+
+
       class BTAPModelUserScript < OpenStudio::Ruleset::ModelUserScript
         #if and E+ measure replace OpenStudio::Ruleset::ModelUserScript with OpenStudio::Ruleset::WorkspaceUserScript
         #Array containing information of all inputs required by measure.
@@ -134,8 +134,8 @@ module BTAP
           "BTAPModelUserScript"
           OSMArgument.new
         end
-        
-        #this method will output the ruby macro to perform the change. 
+
+        #this method will output the ruby macro to perform the change.
         def generate_ruby_macro(model,runner)
           if @file == nil or @file == ""
             @file = "Enter_Path_To_#{self.class.name}_measure.rb_File!"
@@ -190,8 +190,8 @@ module BTAP
           if not runner.validateUserArguments(self.arguments(model),user_arguments)
             return false
           end
-          
-          #Set argument to instance variables. 
+
+          #Set argument to instance variables.
           self.argument_getter(model, runner,user_arguments)
           #will run the childs method measure_code
           result =  self.measure_code(model,runner)
@@ -201,7 +201,7 @@ module BTAP
 
         def argument_setter(model,args)
           #***boilerplate code starts. Do not edit...
-          
+
 
           #iterate through array of hashes and make arguments based on type and set
           # max and min values where applicable.
@@ -247,7 +247,7 @@ module BTAP
           unless @argument_array == nil
             @argument_array.each do |row|
               name = row.variable_name
-            
+
               case row.type
               when "BOOL"
                 value = runner.getBoolArgumentValue(name, user_arguments)
@@ -269,7 +269,7 @@ module BTAP
                 value = runner.getDoubleArgumentValue(name, user_arguments)
                 instance_variable_set("@#{name}",value)
                 @arg_table << [name,value]
-                
+
                 if ( not row.min_value.nil?  and instance_variable_get("@#{name}") < row.min_value ) or ( not row.max_value.nil? and instance_variable_get("@#{name}") > row.max_value )
                   runner.registerError("#{row.display_name} must be greater than or equal to #{row.min_value} and less than or equal to #{row.max_value}.  You entered #{instance_variable_get("@#{name}")}.")
                   return false
@@ -288,10 +288,10 @@ module BTAP
             end #end do
           end
           return @arg_table
-        end        
-        
+        end
+
       end
-      #Measure Template simplified. 
+      #Measure Template simplified.
       class TemplateModelMeasure < BTAPModelUserScript
 
         def name
@@ -391,14 +391,14 @@ module BTAP
         def run(model, runner, user_arguments)
           #run the super
           parent_method_is_true = super(model, runner, user_arguments)
-          
-          
+
+
           ###############
-          
-          #Set Archetype name in runner. 
+
+          #Set Archetype name in runner.
           runner.registerValue('archetype_name',@archetype_name)
-          
-          #Set path to OSM files. 
+
+          #Set path to OSM files.
           alternative_model_path = OpenStudio::Path.new("#{File.dirname(__FILE__)}/#{@archetype_name}.osm")
           #load model and test.
           translator = OpenStudio::OSVersion::VersionTranslator.new
@@ -561,7 +561,7 @@ module BTAP
             model = self.load_base_model_building()
             self.set_weather_file(model)
             self.set_hourly_output(model)
-          
+
             model,log = self.apply_ecms(model,@csv_data)
             BTAP::FileIO::save_osm( model, "#{output_folder}/#{BTAP::FileIO::get_name(model)}.osm") unless output_folder.nil?
             File.open("#{output_folder}/#{BTAP::FileIO::get_name(model)}.log", 'w') { |file| file.write(log) }  unless output_folder.nil?
@@ -621,7 +621,7 @@ module BTAP
           "cost_per_building"
         ]
         self.set_instance_variables( measure_values )
-        
+
         #cost per building and building area
         building = model.building.get
         raise ("you did not enter a cost for measure #{@measure_id}. All measures must have a cost of at least 0.0 .  Please add a cost_per_building field.") if @cost_per_building.nil?
@@ -753,7 +753,7 @@ module BTAP
             @total_building_construction_set_cost
           )
 
-          #Give adiabatic surfaces a construction. Does not matter what. This is a bug in Openstudio that leave these surfaces unassigned by the default construction set.
+          #Give adiabatic surfaces a construction. Does not matter what. This is a bug in OpenStudio that leave these surfaces unassigned by the default construction set.
           all_adiabatic_surfaces = BTAP::Geometry::Surfaces::filter_by_boundary_condition(model.getSurfaces, "Adiabatic")
           unless all_adiabatic_surfaces.empty?
             BTAP::Geometry::Surfaces::set_surfaces_construction( all_adiabatic_surfaces, model.building.get.defaultConstructionSet.get.defaultInteriorSurfaceConstructions.get.wallConstruction.get)
@@ -772,7 +772,7 @@ module BTAP
           "infiltration_flow_per_exterior_area",
           "infiltration_air_changes_per_hour"
         ]
-    
+
         #Set all the above instance variables to the @csv_data values or, if not set or == 'na', to nil.
         self.set_instance_variables(measure_values)
 
@@ -811,7 +811,7 @@ module BTAP
             fan.setMotorEfficiency( @fan_motor_eff ) unless @fan_motor_eff.nil?
             log  << fan.name.get.to_s << ",#{fan.fanEfficiency},#{fan.motorEfficiency}\n"
           end
-          
+
         end
 
         case @fan_volume_type
@@ -975,7 +975,9 @@ module BTAP
           model.getCoilCoolingDXSingleSpeeds.sort.each do |cooling_coil|
             cooling_coil.setRatedCOP( OpenStudio::OptionalDouble.new( @cop ) ) unless @cop.nil?
             cop = "NA"
-            cop = cooling_coil.ratedCOP.get unless cooling_coil.ratedCOP.empty?
+            # Prior to 3.5.0, it was an optional double, now it's a double
+            cop_ = OpenStudio::OptionalDouble.new(cooling_coil.ratedCOP)
+            cop = cop_.get unless cop_.empty?
             log  << cooling_coil.name.get.to_s << ",#{cop}\n"
 
           end
@@ -987,9 +989,11 @@ module BTAP
             cooling_coil.setRatedHighSpeedCOP( @cop  ) unless @cop.nil?
             cooling_coil.setRatedLowSpeedCOP(  @cop  ) unless @cop.nil?
             cop_high = "NA"
-            cop_high = cooling_coil.ratedHighSpeedCOP.get unless cooling_coil.ratedHighSpeedCOP.empty?
+            cop_ = OpenStudio::OptionalDouble.new(cooling_coil.ratedHighSpeedCOP)
+            cop_high = cop_.get unless cop_.empty?
             cop_low = "NA"
-            cop_low = cooling_coil.ratedLowSpeedCOP.get unless cooling_coil.ratedLowSpeedCOP.empty?
+            cop_ = OpenStudio::OptionalDouble.new(cooling_coil.ratedLowSpeedCOP)
+            cop_low = cop_.get unless cop_.empty?
             log  << cooling_coil.name.get.to_s << ",#{cop_high},#{cop_low}\n"
           end
         end
@@ -1296,8 +1300,8 @@ module BTAP
             @erv_nominal_electric_power,
             @erv_economizer_lockout.to_bool
           ).each { |erv| log << erv.to_s }
-          
-          
+
+
           #Add setpoint manager to all OA object in airloops.
           model.getHeatExchangerAirToAirSensibleAndLatents.sort.each do |erv|
 

data/lib/openstudio-standards/btap/vintagizer.rb

@@ -99,7 +99,7 @@ class Vintagizer
     new_construction_set.setName(construction_id)
     constructions_model.building.get.setDefaultConstructionSet( new_construction_set.clone( constructions_model ).to_DefaultConstructionSet.get )
 
-    #Give adiabatic surfaces a construction. Does not matter what. This is a bug in Openstudio that leave these surfaces unassigned by the default construction set.
+    #Give adiabatic surfaces a construction. Does not matter what. This is a bug in OpenStudio that leave these surfaces unassigned by the default construction set.
     all_adiabatic_surfaces = BTAP::Geometry::Surfaces::filter_by_boundary_condition(constructions_model.getSurfaces, "Adiabatic")
     BTAP::Geometry::Surfaces::set_surfaces_construction( all_adiabatic_surfaces, constructions_model.building.get.defaultConstructionSet.get.defaultInteriorSurfaceConstructions.get.wallConstruction.get)
 

data/lib/openstudio-standards/prototypes/common/objects/Prototype.SizingSystem.rb

@@ -57,14 +57,20 @@ class Standard
     end
 
     sizing_system = air_loop_hvac.sizingSystem
-    sizing_system.setSystemOutdoorAirMethod('VentilationRateProcedure')
-    # Set the minimum zone ventilation efficiency to be 0.6
+    if air_loop_hvac.model.version < OpenStudio::VersionString.new('3.3.0')
+      sizing_system.setSystemOutdoorAirMethod('VentilationRateProcedure')
+    else
+      sizing_system.setSystemOutdoorAirMethod('Standard62.1VentilationRateProcedure')
+    end
+
+    # Set the minimum zone ventilation efficiency
+    min_ventilation_efficiency = air_loop_hvac_minimum_zone_ventilation_efficiency(air_loop_hvac)
     air_loop_hvac.thermalZones.sort.each do |zone|
       sizing_zone = zone.sizingZone
       if air_loop_hvac.model.version < OpenStudio::VersionString.new('3.0.0')
         OpenStudio.logFree(OpenStudio::Warn, 'openstudio.prototype.SizingSystem', "The design minimum zone ventilation efficiency cannot be set for #{sizing_system.name}. It can only be set OpenStudio 3.0.0 and later.")
       else
-        sizing_zone.setDesignMinimumZoneVentilationEfficiency(0.6)
+        sizing_zone.setDesignMinimumZoneVentilationEfficiency(min_ventilation_efficiency)
       end
     end
 

data/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb

@@ -1757,13 +1757,21 @@ class Standard
     # set air loop availability controls and night cycle manager, after oa system added
     air_loop.setAvailabilitySchedule(hvac_op_sch)
     air_loop.setNightCycleControlType('CycleOnAny')
-    avail_mgr = air_loop.availabilityManager
-    if avail_mgr.is_initialized
-      avail_mgr = avail_mgr.get
-      if avail_mgr.to_AvailabilityManagerNightCycle.is_initialized
-        avail_mgr = avail_mgr.to_AvailabilityManagerNightCycle.get
-        avail_mgr.setCyclingRunTime(1800)
-      end
+
+    if model.version < OpenStudio::VersionString.new('3.5.0')
+      avail_mgr = air_loop.availabilityManager
+      if avail_mgr.is_initialized
+        avail_mgr = avail_mgr.get
+      else
+        avail_mgr = nil
+      end 
+    else 
+      avail_mgr = air_loop.availabilityManagers[0]
+    end
+
+    if !avail_mgr.nil? && avail_mgr.to_AvailabilityManagerNightCycle.is_initialized
+      avail_mgr = avail_mgr.to_AvailabilityManagerNightCycle.get
+      avail_mgr.setCyclingRunTime(1800)
     end
 
     # hook the VAV system to each zone
@@ -2113,13 +2121,21 @@ class Standard
     # set air loop availability controls and night cycle manager, after oa system added
     air_loop.setAvailabilitySchedule(hvac_op_sch)
     air_loop.setNightCycleControlType('CycleOnAny')
-    avail_mgr = air_loop.availabilityManager
-    if avail_mgr.is_initialized
-      avail_mgr = avail_mgr.get
-      if avail_mgr.to_AvailabilityManagerNightCycle.is_initialized
-        avail_mgr = avail_mgr.to_AvailabilityManagerNightCycle.get
-        avail_mgr.setCyclingRunTime(1800)
-      end
+
+    if model.version < OpenStudio::VersionString.new('3.5.0')
+      avail_mgr = air_loop.availabilityManager
+      if avail_mgr.is_initialized
+        avail_mgr = avail_mgr.get
+      else
+        avail_mgr = nil
+      end 
+    else 
+      avail_mgr = air_loop.availabilityManagers[0]
+    end
+
+    if !avail_mgr.nil? && avail_mgr.to_AvailabilityManagerNightCycle.is_initialized
+      avail_mgr = avail_mgr.to_AvailabilityManagerNightCycle.get
+      avail_mgr.setCyclingRunTime(1800)
     end
 
     # attach the VAV system to each zone
@@ -2727,13 +2743,21 @@ class Standard
       # set air loop availability controls and night cycle manager, after oa system added
       air_loop.setAvailabilitySchedule(hvac_op_sch)
       air_loop.setNightCycleControlType('CycleOnAny')
-      avail_mgr = air_loop.availabilityManager
-      if avail_mgr.is_initialized
-        avail_mgr = avail_mgr.get
-        if avail_mgr.to_AvailabilityManagerNightCycle.is_initialized
-          avail_mgr = avail_mgr.to_AvailabilityManagerNightCycle.get
-          avail_mgr.setCyclingRunTime(1800)
-        end
+
+      if model.version < OpenStudio::VersionString.new('3.5.0')
+        avail_mgr = air_loop.availabilityManager
+        if avail_mgr.is_initialized
+          avail_mgr = avail_mgr.get
+        else
+          avail_mgr = nil
+        end 
+      else 
+        avail_mgr = air_loop.availabilityManagers[0]
+      end
+
+      if !avail_mgr.nil? && avail_mgr.to_AvailabilityManagerNightCycle.is_initialized
+        avail_mgr = avail_mgr.to_AvailabilityManagerNightCycle.get
+        avail_mgr.setCyclingRunTime(1800)
       end
 
       # create a diffuser and attach the zone/diffuser pair to the air loop
@@ -5080,7 +5104,11 @@ class Standard
                                                        name: "#{air_loop.name} heating coil",
                                                        type: 'Residential Central Air Source HP',
                                                        cop: hspf_to_cop_heating_no_fan(hspf))
-        htg_coil.setRatedSupplyFanPowerPerVolumeFlowRate(ac_w_per_cfm / OpenStudio.convert(1.0, 'cfm', 'm^3/s').get)
+        if model.version < OpenStudio::VersionString.new('3.5.0')
+          htg_coil.setRatedSupplyFanPowerPerVolumeFlowRate(ac_w_per_cfm / OpenStudio.convert(1.0, 'cfm', 'm^3/s').get)
+        else
+          htg_coil.setRatedSupplyFanPowerPerVolumeFlowRate2017(ac_w_per_cfm / OpenStudio.convert(1.0, 'cfm', 'm^3/s').get)
+        end
         htg_coil.setMinimumOutdoorDryBulbTemperatureforCompressorOperation(OpenStudio.convert(min_hp_oat_f, 'F', 'C').get)
         htg_coil.setMaximumOutdoorDryBulbTemperatureforDefrostOperation(OpenStudio.convert(40.0, 'F', 'C').get)
         htg_coil.setCrankcaseHeaterCapacity(crank_case_heat_w)

data/lib/openstudio-standards/standards/Standards.AirLoopHVAC.rb

@@ -1895,7 +1895,11 @@ class Standard
       oa_system = air_loop_hvac.airLoopHVACOutdoorAirSystem.get
       controller_oa = oa_system.getControllerOutdoorAir
       controller_mv = controller_oa.controllerMechanicalVentilation
-      controller_mv.setSystemOutdoorAirMethod('VentilationRateProcedure')
+      if air_loop_hvac.model.version < OpenStudio::VersionString.new('3.3.0')
+        controller_mv.setSystemOutdoorAirMethod('VentilationRateProcedure')
+      else
+        controller_mv.setSystemOutdoorAirMethod('Standard62.1VentilationRateProcedureWithLimit')
+      end
       # Change the min flow rate in the controller outdoor air
       controller_oa.setMinimumOutdoorAirFlowRate(0.0)
     else
@@ -1924,6 +1928,16 @@ class Standard
     end
   end
 
+  # Determine minimum ventilation efficiency for zones.
+  # This is used to decrease the overall system minimum OA flow rate
+  # such that a few zones do not drive the overall system OA flow rate too
+  # high.
+  def air_loop_hvac_minimum_zone_ventilation_efficiency(air_loop_hvac)
+    min_ventilation_efficiency = 0.6
+
+    return min_ventilation_efficiency
+  end
+
   # Set the minimum VAV damper positions.
   #
   # @param air_loop_hvac [OpenStudio::Model::AirLoopHVAC] air loop

data/lib/openstudio-standards/standards/Standards.Construction.rb

@@ -529,7 +529,7 @@ class Standard
   # Calculate the fenestration U-Factor base on the glass, frame,
   # and divider performance and area calculated by EnergyPlus.
   #
-  # @param [OpenStudio:Model:Construction] Openstudio Construction object
+  # @param [OpenStudio:Model:Construction] OpenStudio Construction object
   #
   # @return [Double] the U-Factor in W/m^2*K
   def construction_calculated_fenestration_u_factor_w_frame(construction)

data/lib/openstudio-standards/standards/Standards.Model.rb

@@ -19,21 +19,18 @@ class Standard
   # @note Per 90.1, the Performance Rating Method "does NOT offer an alternative compliance path for minimum standard compliance."
   # This means you can't use this method for code compliance to get a permit.
   # @param user_model [OpenStudio::model::Model] User specified OpenStudio model
-  # @param building_type [String] the building type
   # @param climate_zone [String] the climate zone
   # @param hvac_building_type [String] the building type for baseline HVAC system determination (90.1-2016 and onward)
   # @param wwr_building_type [String] the building type for baseline WWR determination (90.1-2016 and onward)
   # @param swh_building_type [String] the building type for baseline SWH determination (90.1-2016 and onward)
-  # @param custom [String] the custom logic that will be applied during baseline creation.  Valid choices are 'Xcel Energy CO EDA' or '90.1-2007 with addenda dn'.
-  #   If nothing is specified, no custom logic will be applied; the process will follow the template logic explicitly.
-  # @param sizing_run_dir [String] the directory where the sizing runs will be performed
+  # @param output_dir [String] the directory where the PRM generations will be performed
   # @param run_all_orients [Boolean] indicate weather a baseline model should be created for all 4 orientations: same as user model, +90 deg, +180 deg, +270 deg
   # @param debug [Boolean] If true, will report out more detailed debugging output
   # @return [Bool] returns true if successful, false if not
 
   # Method used for 90.1-2016 and onward
-  def model_create_prm_stable_baseline_building(model, building_type, climate_zone, hvac_building_type, wwr_building_type, swh_building_type, custom = nil, sizing_run_dir = Dir.pwd, run_all_orients = true, unmet_load_hours_check = true, debug = false)
-    model_create_prm_any_baseline_building(model, building_type, climate_zone, hvac_building_type, wwr_building_type, swh_building_type, true, custom, sizing_run_dir, run_all_orients, unmet_load_hours_check, debug)
+  def model_create_prm_stable_baseline_building(model, climate_zone, hvac_building_type, wwr_building_type, swh_building_type, output_dir = Dir.pwd, unmet_load_hours_check = true, debug = false)
+    model_create_prm_any_baseline_building(model, '', climate_zone, hvac_building_type, wwr_building_type, swh_building_type, true, false, output_dir, true, unmet_load_hours_check, debug)
   end
 
   # Creates a Performance Rating Method (aka Appendix G aka LEED) baseline building model
@@ -77,6 +74,9 @@ class Standard
           OpenStudio.logFree(OpenStudio::Error, 'prm.log', "Proposed model unmet load hours exceed 300. Baseline model(s) won't be created.")
           raise "Proposed model unmet load hours exceed 300. Baseline model(s) won't be created."
         end
+      else
+        OpenStudio.logFree(OpenStudio::Error, 'prm.log', "Simulation failed. Check the model to make sure no severe errors.")
+        raise "Simulation on proposed model failed. Baseline generation is stopped."
       end
     end
 
@@ -1885,9 +1885,9 @@ class Standard
           # separate the primary zones from the secondary zones.
           # Add the baseline system type to the primary zones
           # and add the suplemental system type to the secondary zones.
-          story_zone_lists.each do |zones|
+          story_zone_lists.each do |story_group|
             # Differentiate primary and secondary zones
-            pri_sec_zone_lists = model_differentiate_primary_secondary_thermal_zones(model, story_group, zone_fan_scheds)
+            pri_sec_zone_lists = model_differentiate_primary_secondary_thermal_zones(model, story_group)
             # Record the primary zone system types
             pri_sec_zone_lists['primary'].each do |zone|
               zone_to_sys_type[zone] = pri_system_type
@@ -6926,7 +6926,7 @@ class Standard
   # include data source from:
   # 1. user data csv files
   # 2. data from measure and OpenStudio interface
-  # @param [Openstudio:model:Model] model
+  # @param [OpenStudio:model:Model] model
   # @param [String] climate_zone
   # @param [String] default_hvac_building_type
   # @param [String] default_wwr_building_type
@@ -6940,7 +6940,7 @@ class Standard
   # Template method for adding a setpoint manager for a coil control logic to a heating coil.
   # ASHRAE 90.1-2019 Appendix G.
   #
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   # @param thermalZones Array([OpenStudio::Model::ThermalZone]) thermal zone array
   # @param coil Heating Coils
   # @return [Boolean] true
@@ -6951,7 +6951,7 @@ class Standard
   # Template method for adding zone additional property "zone DCV implemented in user model"
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_mark_zone_dcv_existence(model)
     return true
   end
@@ -6960,7 +6960,7 @@ class Standard
   # The default shall be true
   #
   # @param [Boolean] run_all_orients: user inputs to indicate whether it is required to run all orientations
-  # @param [OpenStudio::Model::Model] Openstudio model
+  # @param [OpenStudio::Model::Model] OpenStudio model
   def run_all_orientations(run_all_orients, user_model)
     return run_all_orients
   end
@@ -6968,7 +6968,7 @@ class Standard
   # Template method for reading user data and adding to zone additional properties
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_add_dcv_user_exception_properties(model)
     return true
   end
@@ -6976,7 +6976,7 @@ class Standard
   # Template method for raising user model DCV warning and errors
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_raise_user_model_dcv_errors(model)
     return true
   end
@@ -6984,7 +6984,7 @@ class Standard
   # Template method for adding zone additional property "airloop dcv required by 901" and "zone dcv required by 901"
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_add_dcv_requirement_properties(model)
     return true
   end
@@ -6993,7 +6993,7 @@ class Standard
   # Zone additional property 'apxg no need to have DCV' added
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_add_apxg_dcv_properties(model)
     return true
   end
@@ -7001,14 +7001,14 @@ class Standard
   # Template method for setting DCV in baseline HVAC system if required
   #
   # @author Xuechen (Jerry) Lei, PNNL
-  # @param model [OpenStudio::Model::Model] Openstudio model
+  # @param model [OpenStudio::Model::Model] OpenStudio model
   def model_set_baseline_demand_control_ventilation(model, climate_zone)
     return true
   end
 
   # Identify the return air type associated with each thermal zone
   #
-  # @param model [OpenStudio::Model::Model] Openstudio model object
+  # @param model [OpenStudio::Model::Model] OpenStudio model object
   def model_identify_return_air_type(model)
     # air-loop based system
     model.getThermalZones.each do |zone|

data/lib/openstudio-standards/standards/Standards.PlanarSurface.rb

@@ -7,7 +7,7 @@ class Standard
   # create a construction that meets those properties and assign it to this surface.
   # 90.1-2007, 90.1-2010, 90.1-2013
   #
-  # @param planar_surface [Openstudio::Model:PlanarSurface] surface object
+  # @param planar_surface [OpenStudio::Model:PlanarSurface] surface object
   # @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
   # @param previous_construction_map [Hash] a hash where the keys are an array of inputs
   #   [template, climate_zone, intended_surface_type, standards_construction_type, occ_type]

data/lib/openstudio-standards/standards/Standards.ZoneHVACComponent.rb

@@ -144,6 +144,7 @@ class Standard
     # Zone HVAC operating schedule if providing ventilation
     # Zone HVAC components return an OptionalSchedule object for supplyAirFanOperatingModeSchedule
     # except for ZoneHVACTerminalUnitVariableRefrigerantFlow which returns a Schedule
+    # and starting at 3.5.0, PTAC / PTHP also return a Schedule, optional before that
     existing_sch = nil
     if zone_hvac_component.to_ZoneHVACFourPipeFanCoil.is_initialized
       zone_hvac_component = zone_hvac_component.to_ZoneHVACFourPipeFanCoil.get
@@ -161,7 +162,7 @@ class Standard
         ventilation = true if oa_rate > 0.0
       end
       ventilation = true if zone_hvac_component.isOutdoorAirFlowRateWhenNoCoolingorHeatingisNeededAutosized
-      fan_op_sch = zone_hvac_component.supplyAirFanOperatingModeSchedule
+      fan_op_sch = OpenStudio::Model::OptionalSchedule.new(zone_hvac_component.supplyAirFanOperatingModeSchedule)
       existing_sch = fan_op_sch.get if fan_op_sch.is_initialized
     elsif zone_hvac_component.to_ZoneHVACPackagedTerminalHeatPump.is_initialized
       zone_hvac_component = zone_hvac_component.to_ZoneHVACPackagedTerminalHeatPump.get
@@ -170,7 +171,7 @@ class Standard
         ventilation = true if oa_rate > 0.0
       end
       ventilation = true if zone_hvac_component.isOutdoorAirFlowRateWhenNoCoolingorHeatingisNeededAutosized
-      fan_op_sch = zone_hvac_component.supplyAirFanOperatingModeSchedule
+      fan_op_sch = OpenStudio::Model::OptionalSchedule.new(zone_hvac_component.supplyAirFanOperatingModeSchedule)
       existing_sch = fan_op_sch.get if fan_op_sch.is_initialized
     elsif zone_hvac_component.to_ZoneHVACTerminalUnitVariableRefrigerantFlow.is_initialized
       zone_hvac_component = zone_hvac_component.to_ZoneHVACTerminalUnitVariableRefrigerantFlow.get