openstudio-standards 0.2.15.pre.rc1 → 0.2.16.rc1

data/lib/openstudio-standards/standards/necb/BTAPPRE1980/hvac_system_6.rb

@@ -34,8 +34,10 @@ class BTAPPRE1980
     # zone data
     system_data[:max_system_supply_air_temperature] = 43.0
     system_data[:min_system_supply_air_temperature] = 13.0
-    system_data[:ZoneCoolingDesignSupplyAirTemperature] = 13.0
-    system_data[:ZoneHeatingDesignSupplyAirTemperature] = 43.0
+    system_data[:ZoneCoolingDesignSupplyAirTemperatureInputMethod] = 'TemperatureDifference'
+    system_data[:ZoneCoolingDesignSupplyAirTemperatureDifference] = 11.0
+    system_data[:ZoneHeatingDesignSupplyAirTemperatureInputMethod] = 'TemperatureDifference'
+    system_data[:ZoneHeatingDesignSupplyAirTemperatureDifference] = 21.0
     system_data[:ZoneCoolingSizingFactor] = 1.1
     system_data[:ZoneHeatingSizingFactor] = 1.3
     system_data[:ZoneVAVMinFlowFactorPerFloorArea] = 0.002
@@ -115,8 +117,10 @@ class BTAPPRE1980
         (BTAP::Geometry::BuildingStoreys.get_zones_from_storey(story) & zones).each do |zone|
           # Zone sizing parameters
           sizing_zone = zone.sizingZone
-          sizing_zone.setZoneCoolingDesignSupplyAirTemperature(system_data[:ZoneCoolingDesignSupplyAirTemperature])
-          sizing_zone.setZoneHeatingDesignSupplyAirTemperature(system_data[:ZoneHeatingDesignSupplyAirTemperature])
+          sizing_zone.setZoneCoolingDesignSupplyAirTemperatureInputMethod(system_data[:ZoneCoolingDesignSupplyAirTemperatureInputMethod])
+          sizing_zone.setZoneCoolingDesignSupplyAirTemperatureDifference(system_data[:ZoneCoolingDesignSupplyAirTemperatureDifference])
+          sizing_zone.setZoneHeatingDesignSupplyAirTemperatureInputMethod(system_data[:ZoneHeatingDesignSupplyAirTemperatureInputMethod])
+          sizing_zone.setZoneHeatingDesignSupplyAirTemperatureDifference(system_data[:ZoneHeatingDesignSupplyAirTemperatureDifference])
           sizing_zone.setZoneCoolingSizingFactor(system_data[:ZoneCoolingSizingFactor])
           sizing_zone.setZoneHeatingSizingFactor(system_data[:ZoneHeatingSizingFactor])
 
@@ -197,8 +201,10 @@ class BTAPPRE1980
     # zone data
     system_6_data[:max_system_supply_air_temperature] = 43.0
     system_6_data[:min_system_supply_air_temperature] = 13.0
-    system_6_data[:ZoneCoolingDesignSupplyAirTemperature] = 13.0
-    system_6_data[:ZoneHeatingDesignSupplyAirTemperature] = 43.0
+    system_6_data[:ZoneCoolingDesignSupplyAirTemperatureInputMethod] = 'TemperatureDifference'
+    system_6_data[:ZoneCoolingDesignSupplyAirTemperatureDifference] = 11.0
+    system_6_data[:ZoneHeatingDesignSupplyAirTemperatureInputMethod] = 'TemperatureDifference'
+    system_6_data[:ZoneHeatingDesignSupplyAirTemperatureDifference] = 21.0
     system_6_data[:ZoneCoolingSizingFactor] = 1.1
     system_6_data[:ZoneHeatingSizingFactor] = 1.3
     system_6_data[:ZoneVAVMinFlowFactorPerFloorArea] = 0.002
@@ -285,8 +291,10 @@ class BTAPPRE1980
         (BTAP::Geometry::BuildingStoreys.get_zones_from_storey(story) & zones).each do |zone|
           # Zone sizing parameters
           sizing_zone = zone.sizingZone
-          sizing_zone.setZoneCoolingDesignSupplyAirTemperature(system_data[:ZoneCoolingDesignSupplyAirTemperature])
-          sizing_zone.setZoneHeatingDesignSupplyAirTemperature(system_data[:ZoneHeatingDesignSupplyAirTemperature])
+          sizing_zone.setZoneCoolingDesignSupplyAirTemperatureInputMethod(system_data[:ZoneCoolingDesignSupplyAirTemperatureInputMethod])
+          sizing_zone.setZoneCoolingDesignSupplyAirTemperatureDifference(system_data[:ZoneCoolingDesignSupplyAirTemperatureDifference])
+          sizing_zone.setZoneHeatingDesignSupplyAirTemperatureInputMethod(system_data[:ZoneHeatingDesignSupplyAirTemperatureInputMethod])
+          sizing_zone.setZoneHeatingDesignSupplyAirTemperatureDifference(system_data[:ZoneHeatingDesignSupplyAirTemperatureDifference])
           sizing_zone.setZoneCoolingSizingFactor(system_data[:ZoneCoolingSizingFactor])
           sizing_zone.setZoneHeatingSizingFactor(system_data[:ZoneHeatingSizingFactor])
 

data/lib/openstudio-standards/standards/necb/ECMS/ecms.rb

@@ -39,42 +39,32 @@ class ECMS < NECB2011
     @standards_data['curves'] = standards_data['tables']['curves']['table']
   end
 
-  def apply_system_ecm(model:, ecm_system_name: nil, template_standard:, runner: nil, primary_heating_fuel: nil)
+  def apply_system_ecm(model:, ecm_system_name: nil, template_standard:, runner: nil, primary_heating_fuel: nil, ecm_system_zones_map_option: 'NECB_Default')
     # Do nothing if nil or other usual suspects.. covering all bases for now.
     return if ecm_system_name.nil? || ecm_system_name == 'none' || ecm_system_name == 'NECB_Default'
+    ecm_system_zones_map_option = 'NECB_Default' if ecm_system_zones_map_option.nil? || ecm_system_zones_map_option == 'none'
 
     ecm_std = Standard.build('ECMS')
     systems = model.getAirLoopHVACs
     map_system_to_zones, system_doas_flags = ecm_std.get_map_systems_to_zones(systems)
-    zone_clg_eqpt_type = ecm_std.get_zone_clg_eqpt_type(model)
-    # when the ecm is associated with adding a new HVAC system, then remove existing system components and loops
     ecm_add_method_name = "add_ecm_#{ecm_system_name.downcase}"
 
     raise("the method #{ecm_add_method_name} does not exist in the ECM class. Please verify that this should be called.") unless ecm_std.respond_to? ecm_add_method_name
 
+    # when the ecm is associated with adding a new HVAC system, then remove existing system components and loops
     ecm_std.remove_all_zone_eqpt(systems)
     ecm_std.remove_air_loops(model)
     ecm_std.remove_hw_loops(model)
     ecm_std.remove_chw_loops(model)
     ecm_std.remove_cw_loops(model)
 
-    # Rather than go through every add_ecm class to add 'the primary_heating_fuel' argument I added this statement to
-    # only include it when it is used (for now in the add_ecm_remove_airloops_add_zone_baseboards method).
-    if ecm_add_method_name == 'add_ecm_remove_airloops_add_zone_baseboards'
-      ecm_std.send(ecm_add_method_name,
-                   model: model,
-                   system_zones_map: map_system_to_zones,
-                   system_doas_flags: system_doas_flags,
-                   zone_clg_eqpt_type: zone_clg_eqpt_type,
-                   standard: template_standard,
-                   primary_heating_fuel: primary_heating_fuel)
-    else
-      ecm_std.send(ecm_add_method_name,
-                   model: model,
-                   system_zones_map: map_system_to_zones,
-                   system_doas_flags: system_doas_flags)
-    end
-    # ecm_std.add_ecm_hs09_ccashpsys(model:model,system_zones_map:,system_doas_flags:,zone_clg_eqpt_type: nil,standard:,baseboard_flag: true)
+    ecm_std.send(ecm_add_method_name,
+                 model: model,
+                 system_zones_map: map_system_to_zones,
+                 system_doas_flags: system_doas_flags,
+                 ecm_system_zones_map_option: ecm_system_zones_map_option,
+                 standard: template_standard,
+                 heating_fuel: primary_heating_fuel)
   end
 
   def apply_system_efficiencies_ecm(model:, ecm_system_name: nil)

data/lib/openstudio-standards/standards/necb/ECMS/hvac_systems.rb

@@ -309,7 +309,7 @@ class ECMS
 
   # =============================================================================================================================
   # Method to determine whether zone can have terminal vrf equipment. Zones with no vrf terminal equipment are characterized by
-  # transient occupancy such is the case for corridors, stairwells, storage, etc ...
+  # transient occupancy such is the case for corridors, stairwells, storage, ...
   def zone_with_no_vrf_eqpt?(zone)
     space_types_to_skip = {}
     space_types_to_skip['NECB2011'] = ['Atrium - H < 13m',
@@ -413,6 +413,56 @@ class ECMS
     end
   end
 
+  #=============================================================================================================================
+  # Get building storey for a zone
+  def get_zone_storey(zone)
+    zone_storey = nil
+    zone.model.getBuildingStorys.each do |storey|
+      storey.spaces.each do |space|
+        if space.thermalZone.get.name.to_s == zone.name.to_s
+          zone_storey = storey
+          break
+        end
+      end
+      break if !zone_storey.nil?
+    end
+    return zone_storey
+  end
+
+  #==============================================================================================================================
+  # Get a map of bldg storeys and zones
+  def get_storey_zones_map(system_zones_map)
+    storey_zones_map = {}
+    system_zones_map.each do |sys,zones|
+      zones.each do |zone|
+        storey = get_zone_storey(zone)
+        storey_zones_map[storey.name.to_s] = [] if !storey_zones_map.has_key? storey.name.to_s
+        storey_zones_map[storey.name.to_s] << zone
+      end
+    end
+    return storey_zones_map
+  end
+  
+  #==============================================================================================================================
+  # Update the map between systems and zones
+  def update_system_zones_map(model,system_zones_map,system_zones_map_option,system_key)
+    updated_system_zones_map = {}
+    if system_zones_map_option == 'one_sys_per_bldg'
+      system_zones_map.each do |sname,zones|
+        updated_system_zones_map[system_key] = [] if !updated_system_zones_map.has_key? system_key
+        updated_system_zones_map[system_key] += zones
+      end
+    elsif system_zones_map_option == 'one_sys_per_floor'
+      storey_zones_map = get_storey_zones_map(system_zones_map)
+      storey_zones_map.each do |storey_name,zones|
+        sys_name = "#{system_key}_#{storey_name.gsub(' ','_')}"
+        updated_system_zones_map[sys_name] = [] if !updated_system_zones_map.has_key? sys_name
+        updated_system_zones_map[sys_name] += zones
+      end
+    end
+    return updated_system_zones_map
+  end
+
   # =============================================================================================================================
   # Add equipment for ECM 'hs08_ccashp_vrf':
   #   -Constant-volume DOAS with air-source heat pump for heating and cooling and electric backup
@@ -422,24 +472,45 @@ class ECMS
     model:,
     system_zones_map:,
     system_doas_flags:,
-    air_sys_eqpt_type: 'ccashp'
-  )
+    ecm_system_zones_map_option:,
+    heating_fuel:,
+    standard:,
+    air_sys_eqpt_type: 'ccashp')
+
+    # Update system zones map if needed
+    if ecm_system_zones_map_option != 'NECB_Default'
+      system_zones_map = update_system_zones_map(model,system_zones_map,ecm_system_zones_map_option,'sys_1')
+    else
+      updated_system_zones_map = {}
+      system_zones_map.each {|sname,zones| updated_system_zones_map["sys_1#{sname[5..]}"] = zones}  # doas unit is an NECB sys_1 
+      system_zones_map = updated_system_zones_map
+    end
     # Add outdoor VRF unit
     outdoor_vrf_unit = add_outdoor_vrf_unit(model: model, ecm_name: 'hs08_ccashp_vrf')
     # Update system doas flags
-    system_doas_flags.keys.each { |sname| system_doas_flags[sname] = true }
+    system_doas_flags = {}
+    system_zones_map.keys.each { |sname| system_doas_flags[sname] = true }
+    # Set heating fuel
+    updated_heating_fuel = heating_fuel
+    if heating_fuel == 'DefaultFuel'
+      epw = BTAP::Environment::WeatherFile.new(model.weatherFile.get.path.get)
+      updated_heating_fuel = standard.standards_data['regional_fuel_use'].detect { |fuel_sources| fuel_sources['state_province_regions'].include?(epw.state_province_region) }['fueltype_set']
+    end
+    raise("Heating fuel for ECM 'HS08_CCASHP_VRF' is neither Electricity nor NaturalGas") if ((updated_heating_fuel != 'Electricity') && (updated_heating_fuel != 'NaturalGas'))
     # use system zones map and generate new air system and zonal equipment
     system_zones_map.sort.each do |sys_name, zones|
       sys_info = air_sys_comps_assumptions(sys_name: sys_name,
                                            zones: zones,
                                            system_doas_flags: system_doas_flags)
+      sys_supp_htg_eqpt_type = 'coil_electric'
+      sys_supp_htg_eqpt_type = 'coil_gas' if updated_heating_fuel == 'NaturalGas'
       airloop, return_fan = add_air_system(model: model,
                                            zones: zones,
                                            sys_abbr: sys_info['sys_abbr'],
                                            sys_vent_type: sys_info['sys_vent_type'],
                                            sys_heat_rec_type: sys_info['sys_heat_rec_type'],
                                            sys_htg_eqpt_type: air_sys_eqpt_type,
-                                           sys_supp_htg_eqpt_type: 'coil_electric',
+                                           sys_supp_htg_eqpt_type: sys_supp_htg_eqpt_type,
                                            sys_clg_eqpt_type: air_sys_eqpt_type,
                                            sys_supp_fan_type: sys_info['sys_supp_fan_type'],
                                            sys_ret_fan_type: sys_info['sys_ret_fan_type'],
@@ -477,7 +548,7 @@ class ECMS
                     zone_supp_htg_eqpt_type: 'none',
                     zone_clg_eqpt_type: 'vrf',
                     zone_fan_type: 'On_Off')
-      # add electric unit heaters fpr backup
+      # add electric baseboards for backup
       add_zone_eqpt(model: model,
                     airloop: airloop,
                     zones: zones,
@@ -486,7 +557,7 @@ class ECMS
                     zone_htg_eqpt_type: 'baseboard_electric',
                     zone_supp_htg_eqpt_type: 'none',
                     zone_clg_eqpt_type: 'none',
-                    zone_fan_type: 'none') # OS doesn't support onoff fans for unit heaters
+                    zone_fan_type: 'none')
       # Now we can find and apply maximum horizontal and vertical distances between outdoor vrf unit and zones with vrf terminal units
       max_hor_pipe_length, max_vert_pipe_length = get_max_vrf_pipe_lengths(model)
       outdoor_vrf_unit.setEquivalentPipingLengthusedforPipingCorrectionFactorinCoolingMode(max_hor_pipe_length)
@@ -636,6 +707,9 @@ class ECMS
     when 'coil_electric'
       htg_eqpt = OpenStudio::Model::CoilHeatingElectric.new(model, always_on)
       htg_eqpt.setName('CoilHeatingElectric')
+    when 'coil_gas'
+      htg_eqpt = OpenStudio::Model::CoilHeatingGas.new(model, always_on)
+      htg_eqpt.setName('CoilHeatingGas')
     when 'ashp'
       htg_eqpt = OpenStudio::Model::CoilHeatingDXSingleSpeed.new(model)
       htg_eqpt.setName('CoilHeatingDXSingleSpeed_ASHP')
@@ -931,14 +1005,27 @@ class ECMS
   #   -Electric baseboards
   def add_ecm_hs09_ccashp_baseboard(model:,
                                     system_zones_map:,    # hash of ailoop names as keys and array of zones as values
-                                    system_doas_flags:)   # hash of system names as keys and flag for DOAS as values
-
+                                    system_doas_flags:,   # hash of system names as keys and flag for DOAS as values
+                                    ecm_system_zones_map_option:,
+                                    heating_fuel:,
+                                    standard:)
+
+    # Set heating fuel
+    updated_heating_fuel = heating_fuel
+    if heating_fuel == 'DefaultFuel'
+      epw = BTAP::Environment::WeatherFile.new(model.weatherFile.get.path.get)
+      updated_heating_fuel = standard.standards_data['regional_fuel_use'].detect { |fuel_sources| fuel_sources['state_province_regions'].include?(epw.state_province_region)}['fueltype_set']
+    end
+    raise("Heating fuel for ECM 'HS09_CCASHP_Baseboard' is neither Electricity nor NaturalGas") if ((updated_heating_fuel != 'Electricity') && (updated_heating_fuel != 'NaturalGas'))
+    # Set supplemental heating for air loop
+    sys_supp_htg_eqpt_type = 'coil_electric'
+    sys_supp_htg_eqpt_type = 'coil_gas' if updated_heating_fuel == 'NaturalGas'
     systems = []
     system_zones_map.sort.each do |sys_name, zones|
       sys_info = air_sys_comps_assumptions(sys_name: sys_name,
                                            zones: zones,
                                            system_doas_flags: system_doas_flags)
-      # add air loop and its equipment
+      # add airloop and its equipment
       airloop, return_fan = add_air_system(
         model: model,
         zones: zones,
@@ -946,7 +1033,7 @@ class ECMS
         sys_vent_type: sys_info['sys_vent_type'],
         sys_heat_rec_type: sys_info['sys_heat_rec_type'],
         sys_htg_eqpt_type: 'ccashp',
-        sys_supp_htg_eqpt_type: 'coil_electric',
+        sys_supp_htg_eqpt_type: sys_supp_htg_eqpt_type,
         sys_clg_eqpt_type: 'ccashp',
         sys_supp_fan_type: sys_info['sys_supp_fan_type'],
         sys_ret_fan_type: sys_info['sys_ret_fan_type'],
@@ -1016,6 +1103,8 @@ class ECMS
           htg_dx_coil = icomp.to_CoilHeatingDXVariableSpeed.get
         elsif icomp.to_CoilHeatingElectric.is_initialized
           backup_coil = icomp.to_CoilHeatingElectric.get
+        elsif icomp.to_CoilHeatingGas.is_initialized
+          backup_coil = icomp.to_CoilHeatingGas.get
         elsif icomp.to_FanConstantVolume.is_initialized
           fans << icomp.to_FanConstantVolume.get
         elsif icomp.to_FanVariableVolume.is_initialized
@@ -1034,16 +1123,40 @@ class ECMS
               supply_fan = fan # assume supply fan has higher pressure drop
             end
           end
-          fan_power = supply_fan.autosizedMaximumFlowRate.to_f * max_pd / supply_fan.fanTotalEfficiency.to_f
+          # There is an error in EnergyPlus in the estimated capacity of the coil "CoilCoolingDXVariableSpeed".
+          # Here the capacity reported by OS is adjusted to estimate an appropriate capacity for the cooling coil.
+          # The autosized capacity is corrected for the actual fan flow rate and fan power.
+          if supply_fan.autosizedMaximumFlowRate.is_initialized 
+            fan_max_afr = supply_fan.autosizedMaximumFlowRate.to_f
+          elsif supply_fan.maximumFlowRate.is_initialized
+            fan_max_afr = supply_fan.maximumFlowRate.to_f
+          else
+            raise "Fan flow rate is undefined for fan #{supply_fan.name.to_s}"
+          end
+          if clg_dx_coil.autosizedRatedAirFlowRateAtSelectedNominalSpeedLevel.is_initialized
+            clg_dx_coil_afr = clg_dx_coil.autosizedRatedAirFlowRateAtSelectedNominalSpeedLevel.to_f
+          elsif clg_dx_coil.ratedAirFlowRateAtSelectedNominalSpeedLevel.is_initialized
+             clg_dx_coil_afr = clg_dx_coil.ratedAirFlowRateAtSelectedNominalSpeedLevel.to_f
+          else
+            raise "Rated air flow rate at selected nominal speed level is undefined for coil #{clg_dx_coil.name.to_s}"
+          end
+          fan_power = fan_max_afr * max_pd / supply_fan.fanTotalEfficiency.to_f
           clg_dx_coil_cap = clg_dx_coil.autosizedGrossRatedTotalCoolingCapacityAtSelectedNominalSpeedLevel.to_f *
-                            supply_fan.autosizedMaximumFlowRate.to_f / clg_dx_coil.autosizedRatedAirFlowRateAtSelectedNominalSpeedLevel.to_f +
-                            fan_power / clg_dx_coil.speeds.last.referenceUnitGrossRatedSensibleHeatRatio.to_f
-        else
+                            fan_max_afr / clg_dx_coil_afr + fan_power / clg_dx_coil.speeds.last.referenceUnitGrossRatedSensibleHeatRatio.to_f
+        elsif clg_dx_coil.grossRatedTotalCoolingCapacityAtSelectedNominalSpeedLevel.is_initialized
           clg_dx_coil_cap = clg_dx_coil.grossRatedTotalCoolingCapacityAtSelectedNominalSpeedLevel.to_f
+        else
+          raise "Rated total cooling capacity at selected nominal speed is undefined for coil #{clg_dx_coil.name.to_s}"
         end
         htg_dx_coil_init_name = get_hvac_comp_init_name(htg_dx_coil, false)
         htg_dx_coil.setName(htg_dx_coil_init_name)
-        backup_coil_cap = backup_coil.autosizedNominalCapacity.to_f
+        if backup_coil.autosizedNominalCapacity.is_initialized
+           backup_coil_cap = backup_coil.autosizedNominalCapacity.to_f
+        elsif backup_coil.nominalCapacity.is_initialized
+           backup_coil_cap = backup_coil.nominalCapacity.to_f
+        else
+          raise "Nominal capacity is undefiled for coil #{backup_coil.name.to_s}"
+        end
         # Set the DX capacities to the maximum of the fraction of the backup coil capacity or the cooling capacity needed
         dx_cap = fr_backup_coil_cap_as_dx_coil_cap * backup_coil_cap
         if dx_cap < clg_dx_coil_cap then dx_cap = clg_dx_coil_cap end
@@ -1063,10 +1176,32 @@ class ECMS
   #   -Packaged-Terminal air-source heat pumps with electric backup
   def add_ecm_hs11_ashp_pthp(model:,
                              system_zones_map:,
-                             system_doas_flags:)
-
+                             system_doas_flags:,
+                             ecm_system_zones_map_option:,
+                             standard:,
+                             heating_fuel:)
+
+    # Set heating fuel
+    updated_heating_fuel = heating_fuel
+    if heating_fuel == 'DefaultFuel'
+      epw = BTAP::Environment::WeatherFile.new(model.weatherFile.get.path.get)
+      updated_heating_fuel = standard.standards_data['regional_fuel_use'].detect { |fuel_sources| fuel_sources['state_province_regions'].include?(epw.state_province_region)}['fueltype_set']
+    end
+    raise("Heating fuel for ECM 'HS11_ASHP_PTHP' is neither Electricity nor NaturalGas") if ((updated_heating_fuel != 'Electricity') && (updated_heating_fuel != 'NaturalGas'))
+    # Set supplemental heaing for airloop
+    sys_supp_htg_eqpt_type = 'coil_electric'
+    sys_supp_htg_eqpt_type = 'coil_gas' if updated_heating_fuel == 'NaturalGas'
+    # Update system zones map if needed
+    if ecm_system_zones_map_option != 'NECB_Default'
+      system_zones_map = update_system_zones_map(model,system_zones_map,ecm_system_zones_map_option,'sys_1')
+    else
+      updated_system_zones_map = {}
+      system_zones_map.each {|sname,zones| updated_system_zones_map["sys_1#{sname[5..]}"] = zones}
+      system_zones_map = updated_system_zones_map
+    end
     # Update system doas flags
-    system_doas_flags.keys.each { |sname| system_doas_flags[sname] = true }
+    system_doas_flags = {}
+    system_zones_map.keys.each { |sname| system_doas_flags[sname] = true }
     # use system zones map and generate new air system and zonal equipment
     systems = []
     system_zones_map.sort.each do |sys_name, zones|
@@ -1079,7 +1214,7 @@ class ECMS
                                            sys_vent_type: sys_info['sys_vent_type'],
                                            sys_heat_rec_type: sys_info['sys_heat_rec_type'],
                                            sys_htg_eqpt_type: 'ashp',
-                                           sys_supp_htg_eqpt_type: 'coil_electric',
+                                           sys_supp_htg_eqpt_type: sys_supp_htg_eqpt_type,
                                            sys_clg_eqpt_type: 'ashp',
                                            sys_supp_fan_type: sys_info['sys_supp_fan_type'],
                                            sys_ret_fan_type: sys_info['sys_ret_fan_type'],
@@ -1161,12 +1296,20 @@ class ECMS
             clg_dx_coil.setName(clg_dx_coil_init_name)
             if clg_dx_coil.autosizedRatedTotalCoolingCapacity.is_initialized
               clg_dx_coil_cap = clg_dx_coil.autosizedRatedTotalCoolingCapacity.to_f
-            else
+            elsif clg_dx_coil.ratedTotalCoolingCapacity.is_initialized
               clg_dx_coil_cap = clg_dx_coil.ratedTotalCoolingCapacity.to_f
+            else
+              raise "The total cooling capacity is undefined for coil #{clg_dx_coil_cap.name.to_s}"
             end
             htg_dx_coil_init_name = get_hvac_comp_init_name(htg_dx_coil, true)
             htg_dx_coil.setName(htg_dx_coil_init_name)
-            backup_coil_cap = backup_coil.autosizedNominalCapacity.to_f
+            if backup_coil.autosizedNominalCapacity.is_initialized
+              backup_coil_cap = backup_coil.autosizedNominalCapacity.to_f
+            elsif backup_coil.nominalCapacity.is_initialized
+              backup_coil_cap = backup_coil.nominalCapacity.to_f
+            else
+              raise "The nominal capacity is undefined for coil #{backup_coil.name.to_s}"
+            end
             # Set the DX capacities to the maximum of the fraction of the backup coil capacity or the cooling capacity needed
             dx_cap = fr_backup_coil_cap_as_dx_coil_cap * backup_coil_cap
             if dx_cap < clg_dx_coil_cap then dx_cap = clg_dx_coil_cap end
@@ -1193,8 +1336,21 @@ class ECMS
   #   -Electric baseboards
   def add_ecm_hs12_ashp_baseboard(model:,
                                   system_zones_map:,
-                                  system_doas_flags:)
-
+                                  system_doas_flags:,
+                                  ecm_system_zones_map_option:,
+                                  standard:,
+                                  heating_fuel:)
+
+    # Set heating fuel
+    updated_heating_fuel = heating_fuel
+    if heating_fuel == 'DefaultFuel'
+      epw = BTAP::Environment::WeatherFile.new(model.weatherFile.get.path.get)
+      updated_heating_fuel = standard.standards_data['regional_fuel_use'].detect { |fuel_sources| fuel_sources['state_province_regions'].include?(epw.state_province_region)}['fueltype_set']
+    end
+    raise("Heating fuel for ECM 'HS12_ASHP_Baseboard' is neither Electricity nor NaturalGas") if ((updated_heating_fuel != 'Electricity') && (updated_heating_fuel != 'NaturalGas'))
+    # Set supplemental heating fuel for airloop
+    sys_supp_htg_eqpt_type = 'coil_electric'
+    sys_supp_htg_eqpt_type = 'coil_gas' if updated_heating_fuel == 'NaturalGas'
     systems = []
     system_zones_map.sort.each do |sys_name, zones|
       sys_info = air_sys_comps_assumptions(sys_name: sys_name,
@@ -1207,7 +1363,7 @@ class ECMS
                                            sys_vent_type: sys_info['sys_vent_type'],
                                            sys_heat_rec_type: sys_info['sys_heat_rec_type'],
                                            sys_htg_eqpt_type: 'ashp',
-                                           sys_supp_htg_eqpt_type: 'coil_electric',
+                                           sys_supp_htg_eqpt_type: sys_supp_htg_eqpt_type,
                                            sys_clg_eqpt_type: 'ashp',
                                            sys_supp_fan_type: sys_info['sys_supp_fan_type'],
                                            sys_ret_fan_type: sys_info['sys_ret_fan_type'],
@@ -1290,6 +1446,8 @@ class ECMS
           htg_dx_coil = icomp.to_CoilHeatingDXSingleSpeed.get
         elsif icomp.to_CoilHeatingElectric.is_initialized
           backup_coil = icomp.to_CoilHeatingElectric.get
+        elsif icomp.to_CoilHeatingGas.is_initialized
+          backup_coil = icomp.to_CoilHeatingGas.get
         end
       end
       if clg_dx_coil && htg_dx_coil && backup_coil
@@ -1298,12 +1456,20 @@ class ECMS
         clg_dx_coil.setName(clg_dx_coil_init_name)
         if clg_dx_coil.autosizedRatedTotalCoolingCapacity.is_initialized
           clg_dx_coil_cap = clg_dx_coil.autosizedRatedTotalCoolingCapacity.to_f
-        else
+        elsif clg_dx_coil.ratedTotalCoolingCapacity.is_initialized
           clg_dx_coil_cap = clg_dx_coil.ratedTotalCoolingCapacity.to_f
+        else
+          raise "Rated total cooling capacity is undefined for coil #{clg_dx_coil.name.to_s}"
         end
         htg_dx_coil_init_name = get_hvac_comp_init_name(htg_dx_coil, true)
         htg_dx_coil.setName(htg_dx_coil_init_name)
-        backup_coil_cap = backup_coil.autosizedNominalCapacity.to_f
+        if backup_coil.autosizedNominalCapacity.is_initialized
+          backup_coil_cap = backup_coil.autosizedNominalCapacity.to_f
+        elsif backup_coil.nominalCapacity.is_initialized
+          backup_coil_cap = backup_coil.nominalCapacity.to_f
+        else
+          raise "Nominal capacity is undefined for coil #{backup_coil.name.to_s}"
+        end
         # set the DX capacities to the maximum of the fraction of the backup coil capacity or the cooling capacity needed
         dx_cap = fr_backup_coil_cap_as_dx_coil_cap * backup_coil_cap
         if dx_cap < clg_dx_coil_cap then dx_cap = clg_dx_coil_cap end
@@ -1323,11 +1489,17 @@ class ECMS
   #   -Zonal VRF terminal units for heating and cooling with electric baseboards
   def add_ecm_hs13_ashp_vrf(model:,
                             system_zones_map:,
-                            system_doas_flags:)
+                            system_doas_flags:,
+                            ecm_system_zones_map_option:,
+                            standard:,
+                            heating_fuel:)
     # call method for ECM hs08 with ASHP in the air system
     add_ecm_hs08_ccashp_vrf(model: model,
                             system_zones_map: system_zones_map,
                             system_doas_flags: system_doas_flags,
+                            ecm_system_zones_map_option: ecm_system_zones_map_option,
+                            standard: standard,
+                            heating_fuel: heating_fuel,
                             air_sys_eqpt_type: 'ashp')
   end
 
@@ -2451,7 +2623,7 @@ class ECMS
     else
       eff_measure_name = eff['name']
     end
-    new_boiler_name = boiler_primacy + eff_measure_name + " #{boiler_size_kbtu_per_hour.round(0)}kBtu/hr #{component.nominalThermalEfficiency} Thermal Eff"
+    new_boiler_name = (boiler_primacy + eff_measure_name + " #{boiler_size_kbtu_per_hour.round(0)}kBtu/hr #{component.nominalThermalEfficiency} Thermal Eff").strip
     component.setName(new_boiler_name)
   end
 
@@ -2532,7 +2704,7 @@ class ECMS
       ecm_package_name = eff['name']
     end
     furnace_num = component.name.to_s.gsub(/[^0-9]/, '')
-    new_furnace_name = ecm_package_name + " #{furnace_num}"
+    new_furnace_name = (ecm_package_name + " #{furnace_num}").strip
     component.setName(new_furnace_name)
   end
 
@@ -2629,7 +2801,7 @@ class ECMS
     else
       shw_ecm_package_name = eff['name']
     end
-    shw_name = "#{shw_vol_gal} Gal #{shw_ecm_package_name} Water Heater - #{shw_capacity_kBtu_hr}kBtu/hr #{eff['efficiency']} Therm Eff"
+    shw_name = ("#{shw_vol_gal} Gal #{shw_ecm_package_name} Water Heater - #{shw_capacity_kBtu_hr}kBtu/hr #{eff['efficiency']} Therm Eff").strip
     component.setName(shw_name)
   end
 
@@ -2729,19 +2901,19 @@ class ECMS
   def add_ecm_remove_airloops_add_zone_baseboards(model:,
                                                   system_zones_map:,
                                                   system_doas_flags: nil,
-                                                  zone_clg_eqpt_type: nil,
+                                                  ecm_system_zones_map_option:,
                                                   standard:,
-                                                  primary_heating_fuel:)
+                                                  heating_fuel:)
     # Set the primary fuel set to default to to specific fuel type.
     standards_info = standard.standards_data
 
-    if primary_heating_fuel == 'DefaultFuel'
+    if heating_fuel == 'DefaultFuel'
       epw = BTAP::Environment::WeatherFile.new(model.weatherFile.get.path.get)
-      primary_heating_fuel = standards_info['regional_fuel_use'].detect { |fuel_sources| fuel_sources['state_province_regions'].include?(epw.state_province_region) }['fueltype_set']
+      heating_fuel = standards_info['regional_fuel_use'].detect { |fuel_sources| fuel_sources['state_province_regions'].include?(epw.state_province_region) }['fueltype_set']
     end
     # Get fuelset.
-    system_fuel_defaults = standards_info['fuel_type_sets'].detect { |fuel_type_set| fuel_type_set['name'] == primary_heating_fuel }
-    raise("fuel_type_sets named #{primary_heating_fuel} not found in fuel_type_sets table.") if system_fuel_defaults.nil?
+    system_fuel_defaults = standards_info['fuel_type_sets'].detect { |fuel_type_set| fuel_type_set['name'] == heating_fuel }
+    raise("fuel_type_sets named #{heating_fuel} not found in fuel_type_sets table.") if system_fuel_defaults.nil?
 
     # Assign fuel sources.
     boiler_fueltype = system_fuel_defaults['boiler_fueltype']

data/lib/openstudio-standards/standards/necb/ECMS/loads.rb

@@ -90,4 +90,5 @@ class ECMS
       end
     end
   end
+
 end

data/lib/openstudio-standards/standards/necb/ECMS/pv_ground.rb

@@ -69,7 +69,9 @@ class ECMS
     dc_system_capacity = pv_number_panels * pv_watt
     generator = OpenStudio::Model::GeneratorPVWatts.new(model, dc_system_capacity)
     generator.setModuleType(pv_ground_module_type)
-    generator.setArrayType('OneAxis') # Note: "tilt and azimuth are fixed" for this array type (see E+ I/O Reference). This array type has been chosen as per Mike Lubun's costing spec.
+    # generator.setArrayType('OneAxis') # Note: "tilt and azimuth are fixed" for this array type (see E+ I/O Reference). This array type has been chosen as per Mike Lubun's costing spec.
+    generator.setArrayType('FixedOpenRack') # Note: The 'FixedOpenRack' array type has been used instead of 'OneAxis' since the 'OneAxis' array type did not allow to have a non-zero tilt angle in OpenStudio 3.2.1.
+    # (As per E+ I/O Reference: 'FixedOpenRack' is used for ground mounted arrays, assumes air flows freely around the array.)
     generator.setTiltAngle(pv_ground_tilt_angle)
     generator.setAzimuthAngle(pv_ground_azimuth_angle)
 
@@ -78,11 +80,11 @@ class ECMS
     inverter.setDCToACSizeRatio(1.1) # Note: This is EnergyPlus' default value; This default value has been chosen for ground-mounted PV, assuming no storage as per Mike Lubun's costing spec.
     inverter.setInverterEfficiency(0.96) # Note: This is EnergyPlus' default value; This default value has been chosen as per Mike Lubun's costing spec.
 
-    ##### Get distribution systems and set relevant parameters
-    model.getElectricLoadCenterDistributions.sort.each do |elc_distribution|
-      elc_distribution.setInverter(inverter)
-      elc_distribution.setGeneratorOperationSchemeType('Baseload') # E+ I/O Reference: "The Baseload scheme requests all generators scheduled ON (available) to operate, even if the amount of electric power generated exceeds the total facility electric power demand." This scheme type has been chosen as per Mike Lubun's costing spec.
-    end
+    ##### Add distribution systems, set relevant parameters, and add created generator to it
+    elc_distribution = OpenStudio::Model::ElectricLoadCenterDistribution.new(model)
+    elc_distribution.setInverter(inverter)
+    elc_distribution.setGeneratorOperationSchemeType('Baseload') # E+ I/O Reference: "The Baseload scheme requests all generators scheduled ON (available) to operate, even if the amount of electric power generated exceeds the total facility electric power demand." This scheme type has been chosen as per Mike Lubun's costing spec.
+    elc_distribution.addGenerator(generator)
   end
 
   # Method for calculating footprint of the building model

data/lib/openstudio-standards/standards/necb/NECB2011/autozone.rb

@@ -93,7 +93,7 @@ class NECB2011
 
   # Organizes Zones and assigns them to appropriate systems according to NECB 2011-17 systems spacetype rules in Sec 8.
   # requires requires fuel type to be assigned for each system aspect. Defaults to gas hydronic.
-  def apply_systems(model:, primary_heating_fuel:, sizing_run_dir:)
+  def apply_systems(model:, primary_heating_fuel:, sizing_run_dir:, shw_scale:, baseline_system_zones_map_option:)
     raise('validation of model failed.') unless validate_initial_model(model)
 
     # Check to see if model is using another vintage of spacetypes. If so overwrite the @standards for the object with the
@@ -151,7 +151,8 @@ class NECB2011
                                heating_coil_type_sys6: heating_coil_type_sys6,
                                mau_cooling_type: mau_cooling_type,
                                mau_heating_coil_type: mau_heating_coil_type,
-                               mau_type: mau_type)
+                               mau_type: mau_type,
+                               baseline_system_zones_map_option: baseline_system_zones_map_option)
 
     # Assign a single system 4 for all wet spaces.. and assign the control zone to the one with the largest load.
     auto_system_wet_spaces(baseboard_type: baseboard_type,
@@ -181,8 +182,9 @@ class NECB2011
                                  heating_coil_type_sys6: heating_coil_type_sys6,
                                  mau_cooling_type: mau_cooling_type,
                                  mau_heating_coil_type: mau_heating_coil_type,
-                                 mau_type: mau_type)
-    model_add_swh(model: model, swh_fueltype: system_fuel_defaults['swh_fueltype'])
+                                 mau_type: mau_type
+    )
+    model_add_swh(model: model, swh_fueltype: system_fuel_defaults['swh_fueltype'], shw_scale: shw_scale)
     model_apply_sizing_parameters(model)
     # set a larger tolerance for unmet hours from default 0.2 to 1.0C
     model.getOutputControlReportingTolerances.setToleranceforTimeHeatingSetpointNotMet(1.0)
@@ -1000,8 +1002,8 @@ class NECB2011
                        zones: zones)
   end
 
-  # This methos will ensure that all dwelling units are assigned to a system 1 or 3. There is an option to have a shared
-  # AHU or not. Currently set to false. So by default all dwelling units will have their own AHU.
+  # This method will ensure that all dwelling units are assigned to a system 1 or 3.
+  # There is an option to have a shared AHU or not.
 
   def auto_system_dwelling_units(baseboard_type:,
                                  boiler_fueltype:,
@@ -1014,11 +1016,16 @@ class NECB2011
                                  mau_cooling_type:,
                                  mau_heating_coil_type:,
                                  mau_type:,
-                                 model:)
+                                 model:,
+                                 baseline_system_zones_map_option:)
 
     system_zones_hash = {}
-    # Detemine if dwelling units have a shared AHU.  If user entered building stories > 4 then set to true.
-    dwelling_shared_ahu = model.getBuilding.standardsNumberOfAboveGroundStories.get > 4
+    # Determine if dwelling units have a shared AHU.  If user entered building stories > 4 then set to true.
+    if baseline_system_zones_map_option == 'one_sys_per_dwelling_unit'
+      dwelling_shared_ahu = false
+    elsif baseline_system_zones_map_option == 'one_sys_per_bldg' || baseline_system_zones_map_option == 'NECB_Default' || baseline_system_zones_map_option == 'none' || baseline_system_zones_map_option == nil
+      dwelling_shared_ahu = true
+    end
     # store dwelling zones into array
     zones = []
     model.getSpaces.select { |space| is_a_necb_dwelling_unit?(space) }.each do |space|