openstudio-geb 0.4.0 → 0.6.0

data/lib/measures/add_ceiling_fan/measure.rb

@@ -406,7 +406,7 @@ class AddCeilingFan < OpenStudio::Measure::ModelMeasure
 
     end
 
-    def adjust_cool_sch(model, sch, cool_stp_inc, start_date, end_date, start_time, end_time)
+    def adjust_cool_sch(model, runner, sch, cool_stp_inc, start_date, end_date, start_time, end_time)
       new_sch = sch.get.clone(model)
       new_sch = new_sch.to_Schedule.get
       new_sch.setName("#{sch.get.name.to_s} increased by #{cool_stp_inc}C due to ceiling fan")
@@ -532,7 +532,7 @@ class AddCeilingFan < OpenStudio::Measure::ModelMeasure
       end
 
       runner.registerInfo("adjusting schedule #{clg_set_sch.get.name.to_s}")
-      new_sch = adjust_cool_sch(model, clg_set_sch, cool_stp_increase_C, os_start_date, os_end_date, os_start_time, os_end_time)
+      new_sch = adjust_cool_sch(model, runner, clg_set_sch, cool_stp_increase_C, os_start_date, os_end_date, os_start_time, os_end_time)
 
       # hook up clone to thermostat
       thermostat.setCoolingSetpointTemperatureSchedule(new_sch)

data/lib/measures/add_chilled_water_storage_tank/measure.rb

@@ -477,9 +477,9 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       #   return false
       # end
       run_output_path = runner.getPathArgumentValue('run_output_path', user_arguments)
-      Dir.mkdir(run_output_path.to_s) unless File.exists?(run_output_path.to_s)
+      Dir.mkdir(run_output_path.to_s) unless File.exist?(run_output_path.to_s)
       sizing_output_path = File.expand_path(File.join(run_output_path.to_s, 'sizing_run'))
-      Dir.mkdir(sizing_output_path.to_s) unless File.exists?(sizing_output_path.to_s)
+      Dir.mkdir(sizing_output_path.to_s) unless File.exist?(sizing_output_path.to_s)
 
       # Change the simulation to only run the sizing days
       sim_control = model.getSimulationControl

data/lib/measures/add_exterior_blinds_and_control/measure.rb

@@ -7,11 +7,11 @@
 # http://nrel.github.io/OpenStudio-user-documentation/reference/measure_writing_guide/
 
 # start the measure
-require 'openstudio/extension/core/os_lib_helper_methods'
-require 'openstudio/extension/core/os_lib_schedules'
+# require 'openstudio/extension/core/os_lib_helper_methods'
+# require 'openstudio/extension/core/os_lib_schedules'
+require 'openstudio-standards'
 class AddExteriorBlindsAndControl < OpenStudio::Measure::ModelMeasure
-  include OsLib_HelperMethods
-  include OsLib_Schedules
+
   # human readable name
   def name
     # Measure name should be the title case of the class name.
@@ -142,7 +142,8 @@ class AddExteriorBlindsAndControl < OpenStudio::Measure::ModelMeasure
                           'default_day' => ["default day"] + normal_day_data_pairs,
                           'rules' => [['Adjusted days', "#{start_month}/#{start_day}-#{end_month}/#{end_day}",
                                        'Sun/Mon/Tue/Wed/Thu/Fri/Sat'] + adjusted_day_data_pairs] }
-              global_shading_schedule = OsLib_Schedules.createComplexSchedule(model, options)
+              # global_shading_schedule = OsLib_Schedules.createComplexSchedule(model, options)
+              global_shading_schedule = OpenstudioStandards::Schedules.create_complex_schedule(model, options)
               runner.registerInfo("A new schedule 'Exterior blinds schedule' has been created for new shading control objects.")
             end
             unless space_shading_control

data/lib/measures/add_interior_blinds_and_control/measure.rb

@@ -9,11 +9,10 @@
 # http://nrel.github.io/OpenStudio-user-documentation/reference/measure_writing_guide/
 
 # start the measure
-require 'openstudio/extension/core/os_lib_helper_methods'
-require 'openstudio/extension/core/os_lib_schedules'
+# require 'openstudio/extension/core/os_lib_helper_methods'
+# require 'openstudio/extension/core/os_lib_schedules'
+require 'openstudio-standards'
 class AddInteriorBlindsAndControl < OpenStudio::Measure::ModelMeasure
-  include OsLib_HelperMethods
-  include OsLib_Schedules
   # human readable name
   def name
     # Measure name should be the title case of the class name.
@@ -144,7 +143,8 @@ class AddInteriorBlindsAndControl < OpenStudio::Measure::ModelMeasure
                           'default_day' => ["default day"] + normal_day_data_pairs,
                           'rules' => [['Adjusted days', "#{start_month}/#{start_day}-#{end_month}/#{end_day}",
                                        'Sun/Mon/Tue/Wed/Thu/Fri/Sat'] + adjusted_day_data_pairs] }
-              global_shading_schedule = OsLib_Schedules.createComplexSchedule(model, options)
+              # global_shading_schedule = OsLib_Schedules.createComplexSchedule(model, options)
+              global_shading_schedule = OpenstudioStandards::Schedules.create_complex_schedule(model, options)
               runner.registerInfo("A new schedule 'Interior blinds schedule' has been created for new shading control objects.")
             end
             unless space_shading_control

data/lib/measures/add_rooftop_pv_simple/measure.rb

@@ -7,9 +7,10 @@
 # http://nrel.github.io/OpenStudio-user-documentation/measures/measure_writing_guide/
 
 # load OpenStudio measure libraries from openstudio-extension gem
-require 'openstudio-extension'
-require 'openstudio/extension/core/os_lib_helper_methods'
-require 'openstudio/extension/core/os_lib_schedules'
+# require 'openstudio-extension'
+# require 'openstudio/extension/core/os_lib_helper_methods'
+# require 'openstudio/extension/core/os_lib_schedules'
+require 'openstudio-standards'
 
 # start the measure
 # this measure originally came from BCL (https://bcl.nrel.gov/results/?fq=bundle:measure&fq=measure_tags:Onsite%20Power%20Generation.Photovoltaic&show_rows=25)
@@ -69,8 +70,9 @@ class AddRooftopPV < OpenStudio::Measure::ModelMeasure
     end
 
     # assign the user inputs to variables
-    args = OsLib_HelperMethods.createRunVariables(runner, model, user_arguments, arguments(model))
-    if !args then return false end
+    # args = OsLib_HelperMethods.createRunVariables(runner, model, user_arguments, arguments(model))
+    args = runner.getArgumentValues(arguments(model), user_arguments)
+    unless args then return false end
 
     # check expected values of double arguments
     # todo - not sure why this isn't working. Elsewhere it is used on E+ and reporting measures.
@@ -87,7 +89,7 @@ class AddRooftopPV < OpenStudio::Measure::ModelMeasure
 
     # create the inverter
     inverter = OpenStudio::Model::ElectricLoadCenterInverterSimple.new(model)
-    inverter.setInverterEfficiency(args['inverter_efficiency'])
+    inverter.setInverterEfficiency(args[:inverter_efficiency])
     runner.registerInfo("Created inverter with efficiency of #{inverter.inverterEfficiency}")
 
     # create the distribution system
@@ -95,14 +97,15 @@ class AddRooftopPV < OpenStudio::Measure::ModelMeasure
     elcd.setInverter(inverter)
 
     # create shared shading transmittance schedule
-    target_transmittance = 1.0 - args['fraction_of_surface'].to_f
+    target_transmittance = 1.0 - args[:fraction_of_surface].to_f
     inputs = {
       'name' => 'PV Shading Transmittance Schedule',
       'winterTimeValuePairs' => { 24.0 => target_transmittance },
       'summerTimeValuePairs' => { 24.0 => target_transmittance },
       'defaultTimeValuePairs' => { 24.0 => target_transmittance }
     }
-    pv_shading_transmittance_schedule = OsLib_Schedules.createSimpleSchedule(model, inputs)
+    # pv_shading_transmittance_schedule = OsLib_Schedules.createSimpleSchedule(model, inputs)
+    pv_shading_transmittance_schedule = OpenstudioStandards::Schedules.create_simple_schedule(model, inputs)
     runner.registerInfo("Created transmittance schedule for PV shading surfaces with constant value of #{target_transmittance}")
 
     model.getSurfaces.each do |surface|
@@ -129,8 +132,8 @@ class AddRooftopPV < OpenStudio::Measure::ModelMeasure
         panel = OpenStudio::Model::GeneratorPhotovoltaic.simple(model)
         panel.setSurface(shading_surface)
         performance = panel.photovoltaicPerformance.to_PhotovoltaicPerformanceSimple.get
-        performance.setFractionOfSurfaceAreaWithActiveSolarCells(args['fraction_of_surface'])
-        performance.setFixedEfficiency(args['cell_efficiency'])
+        performance.setFractionOfSurfaceAreaWithActiveSolarCells(args[:fraction_of_surface])
+        performance.setFixedEfficiency(args[:cell_efficiency])
 
         # connect panel to electric load center distribution
         elcd.addGenerator(panel)

data/lib/measures/apply_dynamic_coating_to_roof_wall/measure.rb

@@ -332,9 +332,9 @@ class ApplyDynamicCoatingToRoofWall < OpenStudio::Measure::EnergyPlusMeasure
       string_objects = []
 
       mat_list.each do |mat|
-        puts "mat: #{mat}"
-        mat_name = mat.getString(0).to_s  # name
+        mat_name = mat.getString(0)  # name
         # no need to clone the material object (in case it is also used in other constructions) because thermal and solar absorptances only matter when the material is on the outside layer
+        puts mat_name.to_s.split(',')
         puts "mat_name: #{mat_name}"
 
         # based on applied surfaces type, add material objects

data/lib/measures/average_ventilation_for_peak_hours/measure.rb

@@ -9,11 +9,10 @@
 # http://nrel.github.io/OpenStudio-user-documentation/reference/measure_writing_guide/
 
 # start the measure
-require 'openstudio/extension/core/os_lib_helper_methods'
-require 'openstudio/extension/core/os_lib_schedules'
+# require 'openstudio/extension/core/os_lib_helper_methods'
+# require 'openstudio/extension/core/os_lib_schedules'
+require 'openstudio-standards'
 class AverageVentilationForPeakHours < OpenStudio::Measure::ModelMeasure
-  include OsLib_HelperMethods
-  include OsLib_Schedules
   # human readable name
   def name
     return "Average Ventilation for Peak Hours"
@@ -188,7 +187,8 @@ class AverageVentilationForPeakHours < OpenStudio::Measure::ModelMeasure
                     'default_day' => ["default day"] + normal_day_data_pairs,
                     'rules' => [['Adjusted days', "#{start_month1}/#{start_day1}-#{end_month1}/#{end_day1}",
                                  'Sun/Mon/Tue/Wed/Thu/Fri/Sat'] + adjusted_day_data_pairs] }
-        new_oa_sch = OsLib_Schedules.createComplexSchedule(model, options)
+        # new_oa_sch = OsLib_Schedules.createComplexSchedule(model, options)
+        new_oa_sch = OpenstudioStandards::Schedules.create_complex_schedule(model, options)
         outdoor_air_object.setOutdoorAirFlowRateFractionSchedule(new_oa_sch)
       else
         if schedules.key?(oa_sch.get.name.to_s)

data/lib/measures/enable_occupancy_driven_lighting/measure.rb

@@ -66,9 +66,9 @@ class EnableOccupancyDrivenLighting < OpenStudio::Measure::ModelMeasure
     end
     runner.registerInfo("Pre-run output path: #{run_output_path}")
 
-    Dir.mkdir(run_output_path) unless File.exists?(run_output_path)
+    Dir.mkdir(run_output_path) unless File.exist?(run_output_path)
     prerun_dir = File.join(run_output_path, 'pre-run')
-    Dir.mkdir(prerun_dir) unless File.exists?(prerun_dir)
+    Dir.mkdir(prerun_dir) unless File.exist?(prerun_dir)
     prerun_osw_path = File.join(prerun_dir, 'sizing.osm')
     model.save(prerun_osw_path, true)  # true is overwrite