openstudio-geb 0.4.0 → 0.5.0

data/lib/measures/AddElectricVehicleChargingLoad/tests/add_electric_vehicle_charging_load_test.rb

@@ -10,6 +10,7 @@ require 'openstudio/measure/ShowRunnerOutput'
 require 'minitest/autorun'
 require_relative '../measure.rb'
 require 'fileutils'
+require 'json'
 
 class AddElectricVehicleChargingLoadTest < Minitest::Test
   # def setup
@@ -28,137 +29,8 @@ class AddElectricVehicleChargingLoadTest < Minitest::Test
     # create an instance of a runner
     runner = OpenStudio::Measure::OSRunner.new(OpenStudio::WorkflowJSON.new)
 
-    # get arguments and test that they are what we are expecting
-    arguments = measure.arguments(model)
-    assert_equal(10, arguments.size)
-    assert_equal('bldg_use_type', arguments[0].name)
-    assert_equal('home', arguments[0].printValue)
-
-
-    # set argument values to bad values and run the measure
-    argument_map = OpenStudio::Measure.convertOSArgumentVectorToMap(arguments)
-
-    bldg_use_type = arguments[0].clone
-    assert(bldg_use_type.setValue('workplace'))
-    argument_map['bldg_use_type'] = bldg_use_type
-
-    num_ev_chargers = arguments[1].clone
-    assert(num_ev_chargers.setValue(3))
-    argument_map['num_ev_chargers'] = num_ev_chargers
-
-    num_evs = arguments[2].clone
-    assert(num_evs.setValue(10))
-    argument_map['num_evs'] = num_evs
-
-    # avg_arrival_time = arguments[4].clone
-    # assert(avg_arrival_time.setValue('9:00'))
-    # argument_map['avg_arrival_time'] = avg_arrival_time
-    #
-    avg_leave_time = arguments[5].clone
-    assert(avg_leave_time.setValue('23:30'))
-    argument_map['avg_leave_time'] = avg_leave_time
-
-    start_charge_time = arguments[6].clone
-    assert(start_charge_time.setValue('17:00'))
-    argument_map['start_charge_time'] = start_charge_time
-
-    avg_charge_hours = arguments[7].clone
-    assert(avg_charge_hours.setValue(4))
-    argument_map['avg_charge_hours'] = avg_charge_hours
-
-    # charge_on_sat = arguments[8].clone
-    # assert(charge_on_sat.setValue(false))
-    # argument_map['charge_on_sat'] = charge_on_sat
-    #
-    # charge_on_sun = arguments[9].clone
-    # assert(charge_on_sun.setValue(false))
-    # argument_map['charge_on_sun'] = charge_on_sun
-
-
-    measure.run(model, runner, argument_map)
-    result = runner.result
-    puts "errors: #{result.errors.inspect}"
-    puts "warnings: "
-    result.warnings.each{|warning| puts warning.logMessage}
-    show_output(result)
-    assert(result.value.valueName == 'Success')
-    assert(result.errors.empty?)
-
-    # save the model
-    # output_file_path = OpenStudio::Path.new('tests/test.osm')
-    output_file_path = File.join(File.dirname(__FILE__), 'test.osm')
-    model.save(output_file_path,true)
-  end
-
-  def test_number_of_arguments_and_argument_names
-    # create an instance of the measure
-    measure = AddElectricVehicleChargingLoad.new
-
-    # make an empty model
-    model = OpenStudio::Model::Model.new
-
-    # get arguments and test that they are what we are expecting
-    arguments = measure.arguments(model)
-    assert_equal(1, arguments.size)
-    assert_equal('space_name', arguments[0].name)
-  end
-
-  def test_bad_argument_values
-    # create an instance of the measure
-    measure = AddElectricVehicleChargingLoad.new
-
-    # create runner with empty OSW
-    osw = OpenStudio::WorkflowJSON.new
-    runner = OpenStudio::Measure::OSRunner.new(osw)
-
-    # make an empty model
-    model = OpenStudio::Model::Model.new
-
     # get arguments
     arguments = measure.arguments(model)
-    argument_map = OpenStudio::Measure.convertOSArgumentVectorToMap(arguments)
-
-    # create hash of argument values
-    args_hash = {}
-    args_hash['space_name'] = ''
-
-    # populate argument with specified hash value if specified
-    arguments.each do |arg|
-      temp_arg_var = arg.clone
-      if args_hash.key?(arg.name)
-        assert(temp_arg_var.setValue(args_hash[arg.name]))
-      end
-      argument_map[arg.name] = temp_arg_var
-    end
-
-    # run the measure
-    measure.run(model, runner, argument_map)
-    result = runner.result
-
-    # show the output
-    show_output(result)
-
-    # assert that it ran correctly
-    assert_equal('Fail', result.value.valueName)
-  end
-
-  def test_good_argument_values
-    # create an instance of the measure
-    measure = AddElectricVehicleChargingLoad.new
-
-    # create runner with empty OSW
-    osw = OpenStudio::WorkflowJSON.new
-    runner = OpenStudio::Measure::OSRunner.new(osw)
-
-    # load the test model
-    translator = OpenStudio::OSVersion::VersionTranslator.new
-    path = "#{File.dirname(__FILE__)}/example_model.osm"
-    model = translator.loadModel(path)
-    assert(!model.empty?)
-    model = model.get
-
-    # store the number of spaces in the seed model
-    num_spaces_seed = model.getSpaces.size
 
     # get arguments
     arguments = measure.arguments(model)
@@ -167,7 +39,26 @@ class AddElectricVehicleChargingLoadTest < Minitest::Test
     # create hash of argument values.
     # If the argument has a default that you want to use, you don't need it in the hash
     args_hash = {}
-    args_hash['space_name'] = 'New Space'
+    # for workplace
+    # args_hash['bldg_use_type'] = 'workplace'
+    # args_hash['num_ev_chargers'] = 3
+    # args_hash['num_evs'] = 10
+    # args_hash['charger_level'] = 'Level 2'
+    # args_hash['avg_arrival_time'] = '9:00'
+    # args_hash['arrival_time_variation_in_mins'] = 60
+    # args_hash['avg_charge_hours'] = 2.5
+    # args_hash['charge_time_variation_in_mins'] = 60
+
+    # for commercial station
+    args_hash['bldg_use_type'] = 'commercial station'
+    args_hash['num_ev_chargers'] = 7
+    args_hash['num_evs'] = 28
+    args_hash['charger_level'] = 'DC charger'
+    args_hash['avg_arrival_time'] = '14:00'
+    args_hash['arrival_time_variation_in_mins'] = 300
+    args_hash['avg_charge_hours'] = 2
+    args_hash['charge_time_variation_in_mins'] = 30
+
     # using defaults values from measure.rb for other arguments
 
     # populate argument with specified hash value if specified
@@ -179,23 +70,31 @@ class AddElectricVehicleChargingLoadTest < Minitest::Test
       argument_map[arg.name] = temp_arg_var
     end
 
-    # run the measure
     measure.run(model, runner, argument_map)
     result = runner.result
-
-    # show the output
+    puts "errors: #{result.errors.inspect}"
+    puts "warnings: "
+    result.warnings.each{|warning| puts warning.logMessage}
     show_output(result)
-
-    # assert that it ran correctly
-    assert_equal('Success', result.value.valueName)
-    assert(result.info.size == 1)
-    assert(result.warnings.empty?)
-
-    # check that there is now 1 space
-    assert_equal(1, model.getSpaces.size - num_spaces_seed)
+    assert(result.value.valueName == 'Success')
+    assert(result.errors.empty?)
 
     # save the model to test output directory
     output_file_path = "#{File.dirname(__FILE__)}//output/test_output.osm"
     model.save(output_file_path, true)
+
+    # test run the modified model
+    osw = {}
+    osw["weather_file"] = File.join(File.dirname(__FILE__ ), "CZ06RV2.epw")
+    osw["seed_file"] = output_file_path
+    osw_path = "#{File.dirname(__FILE__)}//output/test_output.osw"
+    File.open(osw_path, 'w') do |f|
+      f << JSON.pretty_generate(osw)
+    end
+    cli_path = OpenStudio.getOpenStudioCLI
+    cmd = "\"#{cli_path}\" run -w \"#{osw_path}\""
+    puts cmd
+    system(cmd)
   end
+
 end

data/lib/measures/AddElectricVehicleChargingLoad/tests/test.osm

@@ -1,47 +1,47 @@
 
 OS:Version,
-  {15c822a5-8680-412d-9051-4c5f5bf84af1}, !- Handle
-  3.1.0;                                  !- Version Identifier
+  {710267aa-03b7-4f18-b675-4210bf362bb2}, !- Handle
+  3.7.0;                                  !- Version Identifier
 
 OS:Schedule:Ruleset,
-  {cd6f08cb-2d6b-4ead-b510-9973ab57fb3c}, !- Handle
+  {5e51be1d-47a4-45a6-831f-69e2b394fc9c}, !- Handle
   EV Charging Power Draw,                 !- Name
-  {49fe0c88-4ae2-4960-b3e1-046e84601563}, !- Schedule Type Limits Name
-  {4af36474-1ece-45a3-872e-112cb929f330}; !- Default Day Schedule Name
+  {f4a971c0-7bb6-4f09-b54b-593ad91e646f}, !- Schedule Type Limits Name
+  {6bcacd24-481f-4f28-9dba-45fc1174e22a}; !- Default Day Schedule Name
 
 OS:Schedule:Day,
-  {4af36474-1ece-45a3-872e-112cb929f330}, !- Handle
+  {6bcacd24-481f-4f28-9dba-45fc1174e22a}, !- Handle
   EV Charging Default,                    !- Name
-  {49fe0c88-4ae2-4960-b3e1-046e84601563}, !- Schedule Type Limits Name
+  {f4a971c0-7bb6-4f09-b54b-593ad91e646f}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   8,                                      !- Hour 1
-  0,                                      !- Minute 1
+  8,                                      !- Minute 1
   0,                                      !- Value Until Time 1
   8,                                      !- Hour 2
-  6,                                      !- Minute 2
+  19,                                     !- Minute 2
   0.333333333333333,                      !- Value Until Time 2
   8,                                      !- Hour 3
-  13,                                     !- Minute 3
+  20,                                     !- Minute 3
   0.666666666666667,                      !- Value Until Time 3
-  20,                                     !- Hour 4
-  5,                                      !- Minute 4
+  14,                                     !- Hour 4
+  34,                                     !- Minute 4
   1,                                      !- Value Until Time 4
-  20,                                     !- Hour 5
-  20,                                     !- Minute 5
+  14,                                     !- Hour 5
+  39,                                     !- Minute 5
   0.666666666666667,                      !- Value Until Time 5
-  23,                                     !- Hour 6
-  8,                                      !- Minute 6
+  16,                                     !- Hour 6
+  21,                                     !- Minute 6
   0.333333333333333,                      !- Value Until Time 6
   24,                                     !- Hour 7
   0,                                      !- Minute 7
-  0;                                      !- Value Until Time 7
+  -1.2335811384724e-16;                   !- Value Until Time 7
 
 OS:Schedule:Rule,
-  {311feac1-7062-41ae-b8f1-51dc8e415ed6}, !- Handle
+  {f33ae947-b72d-4290-aaef-fe86f9501ffc}, !- Handle
   EV Charging Power Saturday,             !- Name
-  {cd6f08cb-2d6b-4ead-b510-9973ab57fb3c}, !- Schedule Ruleset Name
+  {5e51be1d-47a4-45a6-831f-69e2b394fc9c}, !- Schedule Ruleset Name
   1,                                      !- Rule Order
-  {6d266ac8-247e-491c-b8cd-a96ec0f017e7}, !- Day Schedule Name
+  {8ec2458e-65f1-4aeb-990f-bedc9b3fadfa}, !- Day Schedule Name
   ,                                       !- Apply Sunday
   ,                                       !- Apply Monday
   ,                                       !- Apply Tuesday
@@ -51,83 +51,83 @@ OS:Schedule:Rule,
   Yes;                                    !- Apply Saturday
 
 OS:Schedule:Day,
-  {6d266ac8-247e-491c-b8cd-a96ec0f017e7}, !- Handle
+  {8ec2458e-65f1-4aeb-990f-bedc9b3fadfa}, !- Handle
   EV Charging Default 1,                  !- Name
-  {49fe0c88-4ae2-4960-b3e1-046e84601563}, !- Schedule Type Limits Name
+  {f4a971c0-7bb6-4f09-b54b-593ad91e646f}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   8,                                      !- Hour 1
-  0,                                      !- Minute 1
+  8,                                      !- Minute 1
   0,                                      !- Value Until Time 1
   8,                                      !- Hour 2
-  6,                                      !- Minute 2
+  19,                                     !- Minute 2
   0.333333333333333,                      !- Value Until Time 2
   8,                                      !- Hour 3
-  13,                                     !- Minute 3
+  20,                                     !- Minute 3
   0.666666666666667,                      !- Value Until Time 3
-  20,                                     !- Hour 4
-  5,                                      !- Minute 4
+  14,                                     !- Hour 4
+  34,                                     !- Minute 4
   1,                                      !- Value Until Time 4
-  20,                                     !- Hour 5
-  20,                                     !- Minute 5
+  14,                                     !- Hour 5
+  39,                                     !- Minute 5
   0.666666666666667,                      !- Value Until Time 5
-  23,                                     !- Hour 6
-  8,                                      !- Minute 6
+  16,                                     !- Hour 6
+  21,                                     !- Minute 6
   0.333333333333333,                      !- Value Until Time 6
   24,                                     !- Hour 7
   0,                                      !- Minute 7
-  0;                                      !- Value Until Time 7
+  -1.2335811384724e-16;                   !- Value Until Time 7
 
 OS:Schedule:Rule,
-  {f7becaf9-071a-4de9-979d-ee534e725aa2}, !- Handle
+  {a4dc317b-a25b-488b-8b39-3a45a92069f4}, !- Handle
   EV Charging Power Sunday,               !- Name
-  {cd6f08cb-2d6b-4ead-b510-9973ab57fb3c}, !- Schedule Ruleset Name
+  {5e51be1d-47a4-45a6-831f-69e2b394fc9c}, !- Schedule Ruleset Name
   0,                                      !- Rule Order
-  {8a773ccc-0531-4ec0-8b6c-00d4f6f4dc2d}, !- Day Schedule Name
+  {41604025-03c3-4af2-8370-f6ac84c8e3b7}, !- Day Schedule Name
   Yes;                                    !- Apply Sunday
 
 OS:Schedule:Day,
-  {8a773ccc-0531-4ec0-8b6c-00d4f6f4dc2d}, !- Handle
+  {41604025-03c3-4af2-8370-f6ac84c8e3b7}, !- Handle
   EV Charging Default 2,                  !- Name
-  {49fe0c88-4ae2-4960-b3e1-046e84601563}, !- Schedule Type Limits Name
+  {f4a971c0-7bb6-4f09-b54b-593ad91e646f}, !- Schedule Type Limits Name
   ,                                       !- Interpolate to Timestep
   8,                                      !- Hour 1
-  0,                                      !- Minute 1
+  8,                                      !- Minute 1
   0,                                      !- Value Until Time 1
   8,                                      !- Hour 2
-  6,                                      !- Minute 2
+  19,                                     !- Minute 2
   0.333333333333333,                      !- Value Until Time 2
   8,                                      !- Hour 3
-  13,                                     !- Minute 3
+  20,                                     !- Minute 3
   0.666666666666667,                      !- Value Until Time 3
-  20,                                     !- Hour 4
-  5,                                      !- Minute 4
+  14,                                     !- Hour 4
+  34,                                     !- Minute 4
   1,                                      !- Value Until Time 4
-  20,                                     !- Hour 5
-  20,                                     !- Minute 5
+  14,                                     !- Hour 5
+  39,                                     !- Minute 5
   0.666666666666667,                      !- Value Until Time 5
-  23,                                     !- Hour 6
-  8,                                      !- Minute 6
+  16,                                     !- Hour 6
+  21,                                     !- Minute 6
   0.333333333333333,                      !- Value Until Time 6
   24,                                     !- Hour 7
   0,                                      !- Minute 7
-  0;                                      !- Value Until Time 7
+  -1.2335811384724e-16;                   !- Value Until Time 7
 
 OS:Exterior:FuelEquipment:Definition,
-  {e3509498-6b91-4e72-83b1-4e5ae20fef10}, !- Handle
-  21000.0 w EV Charging Definition,       !- Name
-  21000;                                  !- Design Level {W}
+  {1c7425ee-61c5-4424-a7a2-680290c07aab}, !- Handle
+  28799.999999999996 w EV Charging Definition, !- Name
+  28800;                                  !- Design Level {W}
 
 OS:Exterior:FuelEquipment,
-  {7a05dd98-4879-49b2-bd7d-bca187c06148}, !- Handle
-  21000.0 w EV Charger,                   !- Name
-  {e3509498-6b91-4e72-83b1-4e5ae20fef10}, !- Exterior Fuel Equipment Definition Name
-  {cd6f08cb-2d6b-4ead-b510-9973ab57fb3c}, !- Schedule Name
+  {31a42d85-55dc-43ec-b0a8-beace3568b41}, !- Handle
+  28799.999999999996 w EV Charger,        !- Name
+  {1c7425ee-61c5-4424-a7a2-680290c07aab}, !- Exterior Fuel Equipment Definition Name
+  {5e51be1d-47a4-45a6-831f-69e2b394fc9c}, !- Schedule Name
   Electricity,                            !- Fuel Use Type
   ,                                       !- Multiplier
   Electric Vehicles;                      !- End-Use Subcategory
 
 OS:ScheduleTypeLimits,
-  {49fe0c88-4ae2-4960-b3e1-046e84601563}, !- Handle
+  {f4a971c0-7bb6-4f09-b54b-593ad91e646f}, !- Handle
   Fractional,                             !- Name
   0,                                      !- Lower Limit Value
   1,                                      !- Upper Limit Value

data/lib/measures/add_chilled_water_storage_tank/measure.rb

@@ -477,9 +477,9 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       #   return false
       # end
       run_output_path = runner.getPathArgumentValue('run_output_path', user_arguments)
-      Dir.mkdir(run_output_path.to_s) unless File.exists?(run_output_path.to_s)
+      Dir.mkdir(run_output_path.to_s) unless File.exist?(run_output_path.to_s)
       sizing_output_path = File.expand_path(File.join(run_output_path.to_s, 'sizing_run'))
-      Dir.mkdir(sizing_output_path.to_s) unless File.exists?(sizing_output_path.to_s)
+      Dir.mkdir(sizing_output_path.to_s) unless File.exist?(sizing_output_path.to_s)
 
       # Change the simulation to only run the sizing days
       sim_control = model.getSimulationControl

data/lib/measures/add_exterior_blinds_and_control/measure.rb

@@ -7,11 +7,11 @@
 # http://nrel.github.io/OpenStudio-user-documentation/reference/measure_writing_guide/
 
 # start the measure
-require 'openstudio/extension/core/os_lib_helper_methods'
-require 'openstudio/extension/core/os_lib_schedules'
+# require 'openstudio/extension/core/os_lib_helper_methods'
+# require 'openstudio/extension/core/os_lib_schedules'
+require 'openstudio-standards'
 class AddExteriorBlindsAndControl < OpenStudio::Measure::ModelMeasure
-  include OsLib_HelperMethods
-  include OsLib_Schedules
+
   # human readable name
   def name
     # Measure name should be the title case of the class name.
@@ -142,7 +142,8 @@ class AddExteriorBlindsAndControl < OpenStudio::Measure::ModelMeasure
                           'default_day' => ["default day"] + normal_day_data_pairs,
                           'rules' => [['Adjusted days', "#{start_month}/#{start_day}-#{end_month}/#{end_day}",
                                        'Sun/Mon/Tue/Wed/Thu/Fri/Sat'] + adjusted_day_data_pairs] }
-              global_shading_schedule = OsLib_Schedules.createComplexSchedule(model, options)
+              # global_shading_schedule = OsLib_Schedules.createComplexSchedule(model, options)
+              global_shading_schedule = OpenstudioStandards::Schedules.create_complex_schedule(model, options)
               runner.registerInfo("A new schedule 'Exterior blinds schedule' has been created for new shading control objects.")
             end
             unless space_shading_control

data/lib/measures/add_interior_blinds_and_control/measure.rb

@@ -9,11 +9,10 @@
 # http://nrel.github.io/OpenStudio-user-documentation/reference/measure_writing_guide/
 
 # start the measure
-require 'openstudio/extension/core/os_lib_helper_methods'
-require 'openstudio/extension/core/os_lib_schedules'
+# require 'openstudio/extension/core/os_lib_helper_methods'
+# require 'openstudio/extension/core/os_lib_schedules'
+require 'openstudio-standards'
 class AddInteriorBlindsAndControl < OpenStudio::Measure::ModelMeasure
-  include OsLib_HelperMethods
-  include OsLib_Schedules
   # human readable name
   def name
     # Measure name should be the title case of the class name.
@@ -144,7 +143,8 @@ class AddInteriorBlindsAndControl < OpenStudio::Measure::ModelMeasure
                           'default_day' => ["default day"] + normal_day_data_pairs,
                           'rules' => [['Adjusted days', "#{start_month}/#{start_day}-#{end_month}/#{end_day}",
                                        'Sun/Mon/Tue/Wed/Thu/Fri/Sat'] + adjusted_day_data_pairs] }
-              global_shading_schedule = OsLib_Schedules.createComplexSchedule(model, options)
+              # global_shading_schedule = OsLib_Schedules.createComplexSchedule(model, options)
+              global_shading_schedule = OpenstudioStandards::Schedules.create_complex_schedule(model, options)
               runner.registerInfo("A new schedule 'Interior blinds schedule' has been created for new shading control objects.")
             end
             unless space_shading_control

data/lib/measures/add_rooftop_pv_simple/measure.rb

@@ -7,9 +7,10 @@
 # http://nrel.github.io/OpenStudio-user-documentation/measures/measure_writing_guide/
 
 # load OpenStudio measure libraries from openstudio-extension gem
-require 'openstudio-extension'
-require 'openstudio/extension/core/os_lib_helper_methods'
-require 'openstudio/extension/core/os_lib_schedules'
+# require 'openstudio-extension'
+# require 'openstudio/extension/core/os_lib_helper_methods'
+# require 'openstudio/extension/core/os_lib_schedules'
+require 'openstudio-standards'
 
 # start the measure
 # this measure originally came from BCL (https://bcl.nrel.gov/results/?fq=bundle:measure&fq=measure_tags:Onsite%20Power%20Generation.Photovoltaic&show_rows=25)
@@ -69,8 +70,9 @@ class AddRooftopPV < OpenStudio::Measure::ModelMeasure
     end
 
     # assign the user inputs to variables
-    args = OsLib_HelperMethods.createRunVariables(runner, model, user_arguments, arguments(model))
-    if !args then return false end
+    # args = OsLib_HelperMethods.createRunVariables(runner, model, user_arguments, arguments(model))
+    args = runner. (arguments(model), user_arguments)
+    unless args then return false end
 
     # check expected values of double arguments
     # todo - not sure why this isn't working. Elsewhere it is used on E+ and reporting measures.
@@ -87,7 +89,7 @@ class AddRooftopPV < OpenStudio::Measure::ModelMeasure
 
     # create the inverter
     inverter = OpenStudio::Model::ElectricLoadCenterInverterSimple.new(model)
-    inverter.setInverterEfficiency(args['inverter_efficiency'])
+    inverter.setInverterEfficiency(args[:inverter_efficiency])
     runner.registerInfo("Created inverter with efficiency of #{inverter.inverterEfficiency}")
 
     # create the distribution system
@@ -95,14 +97,15 @@ class AddRooftopPV < OpenStudio::Measure::ModelMeasure
     elcd.setInverter(inverter)
 
     # create shared shading transmittance schedule
-    target_transmittance = 1.0 - args['fraction_of_surface'].to_f
+    target_transmittance = 1.0 - args[:fraction_of_surface].to_f
     inputs = {
       'name' => 'PV Shading Transmittance Schedule',
       'winterTimeValuePairs' => { 24.0 => target_transmittance },
       'summerTimeValuePairs' => { 24.0 => target_transmittance },
       'defaultTimeValuePairs' => { 24.0 => target_transmittance }
     }
-    pv_shading_transmittance_schedule = OsLib_Schedules.createSimpleSchedule(model, inputs)
+    # pv_shading_transmittance_schedule = OsLib_Schedules.createSimpleSchedule(model, inputs)
+    pv_shading_transmittance_schedule = OpenstudioStandards::Schedules.create_simple_schedule(model, inputs)
     runner.registerInfo("Created transmittance schedule for PV shading surfaces with constant value of #{target_transmittance}")
 
     model.getSurfaces.each do |surface|
@@ -129,8 +132,8 @@ class AddRooftopPV < OpenStudio::Measure::ModelMeasure
         panel = OpenStudio::Model::GeneratorPhotovoltaic.simple(model)
         panel.setSurface(shading_surface)
         performance = panel.photovoltaicPerformance.to_PhotovoltaicPerformanceSimple.get
-        performance.setFractionOfSurfaceAreaWithActiveSolarCells(args['fraction_of_surface'])
-        performance.setFixedEfficiency(args['cell_efficiency'])
+        performance.setFractionOfSurfaceAreaWithActiveSolarCells(args[:fraction_of_surface])
+        performance.setFixedEfficiency(args[:cell_efficiency])
 
         # connect panel to electric load center distribution
         elcd.addGenerator(panel)

data/lib/measures/average_ventilation_for_peak_hours/measure.rb

@@ -9,11 +9,10 @@
 # http://nrel.github.io/OpenStudio-user-documentation/reference/measure_writing_guide/
 
 # start the measure
-require 'openstudio/extension/core/os_lib_helper_methods'
-require 'openstudio/extension/core/os_lib_schedules'
+# require 'openstudio/extension/core/os_lib_helper_methods'
+# require 'openstudio/extension/core/os_lib_schedules'
+require 'openstudio-standards'
 class AverageVentilationForPeakHours < OpenStudio::Measure::ModelMeasure
-  include OsLib_HelperMethods
-  include OsLib_Schedules
   # human readable name
   def name
     return "Average Ventilation for Peak Hours"
@@ -188,7 +187,8 @@ class AverageVentilationForPeakHours < OpenStudio::Measure::ModelMeasure
                     'default_day' => ["default day"] + normal_day_data_pairs,
                     'rules' => [['Adjusted days', "#{start_month1}/#{start_day1}-#{end_month1}/#{end_day1}",
                                  'Sun/Mon/Tue/Wed/Thu/Fri/Sat'] + adjusted_day_data_pairs] }
-        new_oa_sch = OsLib_Schedules.createComplexSchedule(model, options)
+        # new_oa_sch = OsLib_Schedules.createComplexSchedule(model, options)
+        new_oa_sch = OpenstudioStandards::Schedules.create_complex_schedule(model, options)
         outdoor_air_object.setOutdoorAirFlowRateFractionSchedule(new_oa_sch)
       else
         if schedules.key?(oa_sch.get.name.to_s)

data/lib/measures/enable_occupancy_driven_lighting/measure.rb

@@ -66,9 +66,9 @@ class EnableOccupancyDrivenLighting < OpenStudio::Measure::ModelMeasure
     end
     runner.registerInfo("Pre-run output path: #{run_output_path}")
 
-    Dir.mkdir(run_output_path) unless File.exists?(run_output_path)
+    Dir.mkdir(run_output_path) unless File.exist?(run_output_path)
     prerun_dir = File.join(run_output_path, 'pre-run')
-    Dir.mkdir(prerun_dir) unless File.exists?(prerun_dir)
+    Dir.mkdir(prerun_dir) unless File.exist?(prerun_dir)
     prerun_osw_path = File.join(prerun_dir, 'sizing.osm')
     model.save(prerun_osw_path, true)  # true is overwrite
 

data/lib/openstudio/geb/run.rb

@@ -74,6 +74,8 @@ module OpenStudio
       def apply_measures(osw_result_folder)
         # create osw_file
         osw_path = File.join(osw_result_folder, "geb.osw")
+        # get the folder of measures
+        measures_path = File.expand_path("../../../measures/", __FILE__ )
 
         steps = []
         # measure_dict: hash of measures and their arguments => {measure_name: arguments}
@@ -82,7 +84,8 @@ module OpenStudio
         report_measures = {}
         @measure_dict.each_pair do |m_name, para_dict|
           # get all EnergyPlus and Reporting measures out and remove original ones
-          File.open("#{para_dict['measure_dir_name']}/measure.rb", 'r') do |file|
+          # now measure_dir_name uses folder name rather than absolute path, adding "measure_paths" to the osw file
+          File.open("#{measures_path}/#{para_dict['measure_dir_name']}/measure.rb", 'r') do |file|
             file.each_line do |line|
               if line =~ /class.+EnergyPlusMeasure/
                 energyplus_measures[m_name] = @measure_dict[m_name]
@@ -119,6 +122,7 @@ module OpenStudio
         end
 
         osw = {}
+        osw["measure_paths"] = [measures_path]
         osw["weather_file"] = @weather_file_path
         osw["seed_file"] = @baseline_dir_str
         osw["steps"] = steps

data/lib/openstudio/geb/utilities.rb

@@ -52,7 +52,8 @@ def list_all_geb_measures
   measures.each do |measure|
     measure_name = measure.split('/')[-2]
     measure_list[measure_name] = {}
-    measure_list[measure_name]['measure_dir_name'] = File.dirname(measure)
+    # now measure_dir_name uses folder name rather than absolute path, adding "measure_paths" to the osw file
+    measure_list[measure_name]['measure_dir_name'] = File.basename(File.dirname(measure))  # get just this folder name
   end
 
 =begin
@@ -114,7 +115,7 @@ end
 def postprocess_out_osw(outdir)
 
   out_osw = File.join(outdir, 'out.osw')
-  raise "Cannot find file #{out_osw}" if !File.exists?(out_osw)
+  raise "Cannot find file #{out_osw}" if !File.exist?(out_osw)
 
   result_osw = nil
   File.open(out_osw, 'r') do |f|

data/lib/openstudio/geb/version.rb

@@ -5,6 +5,6 @@
 
 module OpenStudio
   module Geb
-    VERSION = '0.4.0'.freeze
+    VERSION = '0.5.0'.freeze
   end
 end

data/openstudio-geb.gemspec

@@ -22,11 +22,14 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 2.1'
+  spec.required_ruby_version = '~> 3.2.2'
+
+  spec.add_dependency 'openstudio-extension', '~> 0.8.0'
+  spec.add_dependency 'openstudio-standards', '0.6.1'
+
+  spec.add_development_dependency 'bundler', '~> 2.4.10'
   spec.add_development_dependency 'rake', '~> 13.0'
-  spec.add_development_dependency 'rspec', '3.7.0'
-  spec.add_development_dependency 'rubocop', '~> 1.15.0'
+  spec.add_development_dependency 'rspec', '~> 3.9'
+  spec.add_development_dependency 'rubocop', '1.50'
 
-  spec.add_dependency 'openstudio-extension', '~> 0.7.0'
-  spec.add_dependency 'openstudio-standards', '~> 0.5.0'
 end