openstudio-geb 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 99e02016d3d2f307848fee0b326a4d746f5179c39322f9c3352acd9bd93ed5eb
-  data.tar.gz: e649a232a4b34ca064aa7ccde7f6eab8990252739c6f793dbb6cbeb4351da8ea
+  metadata.gz: 1f5c6ce73d5eeff3672c2dded24ac1b0ee7f3444a622e8504f8fa4fd92fd257a
+  data.tar.gz: 4a67b1901225ede4ace75c4b7e1a99efb7af844582d8956cf11ebc4f9a860265
 SHA512:
-  metadata.gz: 21a9dc08165e2b8d913e1233b345e868792578dd26f6b8ea4a06047a3211099886e00afd4e437ac2e2673d1ae7f5db086223e08c44f07eece261a2b4ba46086c
-  data.tar.gz: 43441ee2003eb9e9852e5650a7cfc242da5060882704b48d5d05f762c5c99db2380cc69e0890d64100f5b5eae626d17f235608e56aaf014ad0b85bc6d06c0cac
+  metadata.gz: 907d8d052909600300259a16e78aeab672e89e17fe484ff1af3d3f1943ac24ed0a6fe5a629ab75638c06158e2da9df3682b87535741c8c82b302d60d8f9dcb42
+  data.tar.gz: 731d919ced3ef43ab5cc79bd52a6fdf2dbfe8aad71b3ef07a850ab809e96c789588f823462fc68af9031170c1954a0519d36e988ff5ce5034bbfdf6136d7993f

data/lib/measures/add_chilled_water_storage_tank/measure.rb

@@ -536,8 +536,6 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     sizing_pri_plant.setDesignLoopExitTemperature(primary_loop_sp)
     sizing_pri_plant.setLoopDesignTemperatureDifference(primary_delta_t)
 
-
-
     # add chilled water tank to the primary loop as demand and secondary loop as supply
     chw_storage_tank = OpenStudio::Model::ThermalStorageChilledWaterStratified.new(model)
     tank_temp_sch = OpenStudio::Model::ScheduleRuleset.new(model)
@@ -546,6 +544,16 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     chw_storage_tank.setSetpointTemperatureSchedule(tank_temp_sch)
     sec_loop.addSupplyBranchForComponent(chw_storage_tank)
     selected_primary_loop.addDemandBranchForComponent(chw_storage_tank)
+
+    # create discharging and charging schedule and apply to chilled water tank and primary loop
+    discharge_sch = create_sch(model, 'Chilled water tank discharge schedule', discharge_start, discharge_end, thermal_storage_season, wknds)
+    charge_sch = create_sch(model, 'Chilled water tank charge schedule', charge_start, charge_end, thermal_storage_season, wknds)
+    chw_storage_tank.setUseSideAvailabilitySchedule(discharge_sch)
+    chw_storage_tank.setSourceSideAvailabilitySchedule(charge_sch)
+    avm_sch =  OpenStudio::Model::AvailabilityManagerScheduled.new(model)
+    avm_sch.setSchedule(charge_sch)
+    selected_primary_loop.addAvailabilityManager(avm_sch)
+
     if objective == "Partial Storage"
       sec_chiller = OpenStudio::Model::ChillerElectricEIR.new(model)  # use default curves
       sec_chiller.setName("CoolSysSecondary Chiller")
@@ -558,27 +566,29 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       end
 
       # add plant equipment operation schema if partial storage
-      clg_op_scheme = OpenStudio::Model::PlantEquipmentOperationCoolingLoad.new(model)
-      tank_supply_watt = 2.0 * (4182 * tank_vol * 1000 * secondary_delta_t / (3600 * lasting_hrs))   # double the cooling cap in case thermal storage is not used at larger cooling load.
-      # the sequence of addEquipment and addLoadRange can't be switched
-      clg_op_scheme.addEquipment(sec_chiller)
-      clg_op_scheme.addLoadRange(tank_supply_watt, [chw_storage_tank])
-      sec_loop.setPlantEquipmentOperationCoolingLoad(clg_op_scheme)
+      clg_op_scheme_tank = OpenStudio::Model::PlantEquipmentOperationCoolingLoad.new(model)
+      clg_op_scheme_tank.addEquipment(chw_storage_tank)
+      clg_op_scheme_sec_chiller = OpenStudio::Model::PlantEquipmentOperationCoolingLoad.new(model)
+      clg_op_scheme_sec_chiller.addEquipment(sec_chiller)
+      undischarge_sch = create_sch(model, 'Chilled water tank not discharge schedule', discharge_end, discharge_start, thermal_storage_season, wknds)
+      # in this way, sequence in E+ will be tank first then chiller. In fact the sequence here doesn't matter as each schema is coupled with schedule
+      sec_loop.setPlantEquipmentOperationCoolingLoad(clg_op_scheme_tank)
+      sec_loop.setPlantEquipmentOperationCoolingLoadSchedule(discharge_sch)
+      sec_loop.setPrimaryPlantEquipmentOperationScheme(clg_op_scheme_sec_chiller)
+      sec_loop.setPrimaryPlantEquipmentOperationSchemeSchedule(undischarge_sch)
+
+      # clg_op_scheme = OpenStudio::Model::PlantEquipmentOperationCoolingLoad.new(model)
+      # tank_supply_watt = 2.0 * (4182 * tank_vol * 1000 * secondary_delta_t / (3600 * lasting_hrs))   # double the cooling cap in case thermal storage is not used at larger cooling load.
+      # # the sequence of addEquipment and addLoadRange can't be switched
+      # clg_op_scheme.addEquipment(sec_chiller)
+      # clg_op_scheme.addLoadRange(tank_supply_watt, [chw_storage_tank])
+      # sec_loop.setPlantEquipmentOperationCoolingLoad(clg_op_scheme)
     end
     # add secondary loop bypass pipe
     sec_supply_bypass = OpenStudio::Model::PipeAdiabatic.new(model)
     sec_supply_bypass.setName("Chilled Water Secondary Loop Supply Bypass Pipe")
     sec_loop.addSupplyBranchForComponent(sec_supply_bypass)
 
-    # create discharging and charging schedule and apply to chilled water tank and primary loop
-    discharge_sch = create_sch(model, 'Chilled water tank discharge schedule', discharge_start, discharge_end, thermal_storage_season, wknds)
-    charge_sch = create_sch(model, 'Chilled water tank charge schedule', charge_start, charge_end, thermal_storage_season, wknds)
-    chw_storage_tank.setUseSideAvailabilitySchedule(discharge_sch)
-    chw_storage_tank.setSourceSideAvailabilitySchedule(charge_sch)
-    avm_sch =  OpenStudio::Model::AvailabilityManagerScheduled.new(model)
-    avm_sch.setSchedule(charge_sch)
-    selected_primary_loop.addAvailabilityManager(avm_sch)
-
     # move all primary loop demand components (except inlet and outlet pipes) to the secondary loop
     selected_primary_loop.demandComponents(selected_primary_loop.demandSplitter, selected_primary_loop.demandMixer).each do |demand_comp|
       if demand_comp.to_StraightComponent.is_initialized

data/lib/openstudio/geb/version.rb

@@ -35,6 +35,6 @@
 
 module OpenStudio
   module Geb
-    VERSION = '0.1.0'.freeze
+    VERSION = '0.1.1'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openstudio-geb
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Kaiyu Sun
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-10-25 00:00:00.000000000 Z
+date: 2022-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler