openstudio-geb 0.0.2 → 0.0.3r

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b4fdc606895d1c09377ee2006ac33a6ee08e8b5d1b2b39a7b7cdf30dd4f1a670
-  data.tar.gz: e79afcd13e858096851fd8d53234fa23cb2f3c6d85c65635b3209a007416aad1
+  metadata.gz: 95736fe58727e0f60da222a3f643c02dc5e5465dc77b5e6513012a59949d9d85
+  data.tar.gz: 55105af8ce0bf75e1005123a36f77e61268136554663d6b476091e1995396bae
 SHA512:
-  metadata.gz: 5af05c44e546a83fdbabd60c633c5cb07ea3ff8ea80929df22b98a4c5edf2604ff312bcece947ee04d0d15dc86421a3e35d3f571b93f11ae31a12c0ea492b847
-  data.tar.gz: 1da5382c95a52c84d562947b3637efa61f259793b4034febf99bb2d48b441183165a4b185a74e089faaf77b4650056dca08c8088f945118a188ce20abf7cb4f9
+  metadata.gz: 63d3ff9b2cc8415a52ba1906a61146ed28ba6a977da91393e84fa0ed7e6845240beea11c03d20483b86f92b56b4f779fff42a08f093544bc59e43dcce0453605
+  data.tar.gz: 02f4cfd1f7b5e87d3c14c142a15cf370aa19793a3f280fd772b39a972c844680d817fb40123caf7c8f914a4686c85a14de4375078de197c77196b79a619ef390

data/.gitignore

@@ -33,4 +33,6 @@ lib/measures/*/tests/baseline
 runner.conf
 
 # built gem file
-*.gem
+*.gem
+
+.DS_Store

data/lib/measures/AdjustThermostatSetpointsByDegreesForPeakHours/measure.rb

@@ -673,7 +673,7 @@ class AdjustThermostatSetpointsByDegreesForPeakHours < OpenStudio::Measure::Mode
       elsif vec_time[i]>time_begin && vec_time[i]<=time_end && count==1
         sch_day.addValue(vec_time[i], vec_value[i])
       elsif vec_time[i]>time_end && count == 1
-        sch_day.addValue(time_end, target_temp_si)
+        sch_day.addValue(time_end, target_temp_si.value)
         sch_day.addValue(vec_time[i], vec_value[i])
         count = 2
       else

data/lib/measures/add_chilled_water_storage_tank/measure.rb

@@ -49,9 +49,9 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
         loop_choices << loop.name.to_s
       end
     end
-
+    loop_choices << ""
     # Make choice argument for primary loop selection
-    selected_primary_loop_name = OpenStudio::Measure::OSArgument.makeChoiceArgument('selected_primary_loop_name', loop_choices, true)
+    selected_primary_loop_name = OpenStudio::Measure::OSArgument.makeChoiceArgument('selected_primary_loop_name', loop_choices, false)
     selected_primary_loop_name.setDisplayName('Select Primary Loop:')
     selected_primary_loop_name.setDescription('This is the primary cooling loop on which the chilled water tank will be added.')
     pri_loop_name = nil
@@ -62,6 +62,7 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       selected_primary_loop_name.setDefaultValue(pri_loop_name)
     else
       selected_primary_loop_name.setDescription('Error: No Cooling Loop Found')
+      selected_primary_loop_name.setDefaultValue("")
     end
     args << selected_primary_loop_name
 
@@ -156,12 +157,13 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     args << wknds
 
     # Output path, for sizing run
-    run_output_path = OpenStudio::Measure::OSArgument.makePathArgument('run_output_path', true, "")
+    run_output_path = OpenStudio::Measure::OSArgument.makePathArgument('run_output_path', true, "", false)
     run_output_path.setDisplayName('Output path for tank sizing run (if tank volume is not provided)')
+    run_output_path.setDefaultValue(".")
     args << run_output_path
 
     # epw file path, for sizing run
-    epw_path = OpenStudio::Measure::OSArgument.makePathArgument('epw_path', true, "")
+    epw_path = OpenStudio::Measure::OSArgument.makePathArgument('epw_path', true, "", false)
     epw_path.setDisplayName('epw file path for tank sizing run (if tank volume is not provided)')
     args << epw_path
 
@@ -187,6 +189,36 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     # assign the user inputs to variables
     objective = runner.getStringArgumentValue('objective', user_arguments)
     selected_primary_loop_name = runner.getStringArgumentValue('selected_primary_loop_name', user_arguments)
+    # if user_arguments['selected_primary_loop_name'].hasValue
+    #   selected_primary_loop_name = runner.getStringArgumentValue('selected_primary_loop_name', user_arguments)
+    if !selected_primary_loop_name.empty?
+      # get the primary cooling loop
+      selected_primary_loop = model.getModelObjectByName(selected_primary_loop_name)
+      if selected_primary_loop.is_initialized
+        selected_primary_loop = selected_primary_loop.get.to_PlantLoop.get
+      else
+        # The provided value is not a plant loop in the model
+        runner.registerError("The provided primary loop name doesn't exist in the model.")
+        return false
+      end
+    else
+      loop_choices = []
+      model.getPlantLoops.each do |loop|
+        if loop.sizingPlant.loopType.to_s == 'Cooling'
+          loop_choices << loop.name.to_s
+        end
+      end
+      if loop_choices.empty?
+        # No cooling loop; the measure is not applicable
+        runner.registerAsNotApplicable("No cooling loop in the model. The measure is not applicable.")
+        return true
+      else
+        # There is cooling loop in the model but user didn't specify one,
+        # and the cooling loop name does not include 'chilled water loop'
+        runner.registerError("Please select a primary loop name to run the measure. The available cooling loop(s) in the model is #{loop_choices.join(', ')}")
+        return false
+      end
+    end
     primary_loop_sp = runner.getDoubleArgumentValue('primary_loop_sp', user_arguments)
     secondary_loop_sp = runner.getDoubleArgumentValue('secondary_loop_sp', user_arguments)
     tank_charge_sp = runner.getDoubleArgumentValue('tank_charge_sp', user_arguments)
@@ -199,6 +231,7 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     charge_end = runner.getStringArgumentValue('charge_end', user_arguments)
     wknds = runner.getBoolArgumentValue('wknds', user_arguments)
 
+
     # check time format
     begin
       discharge_start = Time.strptime(discharge_start, '%H:%M')
@@ -293,14 +326,7 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       return false
     end
 
-    # get the primary cooling loop
-    selected_primary_loop = model.getModelObjectByName(selected_primary_loop_name)
-    if selected_primary_loop.is_initialized
-      selected_primary_loop = selected_primary_loop.get.to_PlantLoop.get
-    else
-      runner.registerError("Error: No Primary Cooling Loop Found. ")
-      return false
-    end
+
     # report initial condition of model
     runner.registerInitialCondition("Original primary chilled water loop: #{selected_primary_loop.name}.")
 
@@ -312,17 +338,112 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       primary_delta_t = selected_primary_loop.sizingPlant.loopDesignTemperatureDifference
     end
 
+    # get the condenser water loop
+    cw_loop = nil
+    model.getPlantLoops.each do |loop|
+      if loop.sizingPlant.loopType.to_s.downcase == 'condenser'
+        cw_loop = loop if cw_loop.nil?
+        # confirm if this condenser loop contains demand component of chiller that is in the selected_primary_loop
+        common_comps = cw_loop.demandComponents & selected_primary_loop.supplyComponents
+        chiller_in_both_loops = false
+        common_comps.each do |comp|
+          chiller_in_both_loops = true if comp.to_ChillerElectricEIR.is_initialized || comp.to_ChillerAbsorption.is_initialized || comp.to_ChillerAbsorptionIndirect.is_initialized
+        end
+        cw_loop = nil unless chiller_in_both_loops
+      end
+    end
+    # not necessarily can find a cw_loop as the existing primary chiller might be air cooled.
+
+    def hardsize_cooling_tower_two_speed(tower)
+      # implement the applySizingValues function for CoolingTowerTwoSpeed here since it's not yet implemented in OS standards
+      rated_water_flow_rate = tower.autosizedDesignWaterFlowRate
+      if rated_water_flow_rate.is_initialized
+        tower.setDesignWaterFlowRate(rated_water_flow_rate.get)
+      end
+
+      high_fan_speed_fan_power = tower.autosizedHighFanSpeedFanPower
+      if high_fan_speed_fan_power.is_initialized
+        tower.setHighFanSpeedFanPower(high_fan_speed_fan_power.get)
+      end
+
+      high_fan_speed_air_flow_rate = tower.autosizedHighFanSpeedAirFlowRate
+      if high_fan_speed_air_flow_rate.is_initialized
+        tower.setHighFanSpeedAirFlowRate(high_fan_speed_air_flow_rate.get)
+      end
+
+      high_fan_speed_u_factor_times_area_value = tower.autosizedHighFanSpeedUFactorTimesAreaValue
+      if high_fan_speed_u_factor_times_area_value.is_initialized
+        tower.setHighFanSpeedUFactorTimesAreaValue(high_fan_speed_u_factor_times_area_value.get)
+      end
+
+      low_fan_speed_air_flow_rate = tower.autosizedLowFanSpeedAirFlowRate
+      if low_fan_speed_air_flow_rate.is_initialized
+        tower.setLowFanSpeedAirFlowRate(low_fan_speed_air_flow_rate.get)
+      end
+
+      low_fan_speed_fan_power = tower.autosizedLowFanSpeedFanPower
+      if low_fan_speed_fan_power.is_initialized
+        tower.setLowFanSpeedFanPower(low_fan_speed_fan_power.get)
+      end
+
+      low_fan_speed_u_factor_times_area_value = tower.autosizedLowFanSpeedUFactorTimesAreaValue
+      if low_fan_speed_u_factor_times_area_value.is_initialized
+        tower.setLowFanSpeedUFactorTimesAreaValue(low_fan_speed_u_factor_times_area_value.get)
+      end
+
+      free_convection_regime_air_flow_rate = tower.autosizedFreeConvectionRegimeAirFlowRate
+      if free_convection_regime_air_flow_rate.is_initialized
+        tower.setFreeConvectionRegimeAirFlowRate(free_convection_regime_air_flow_rate.get)
+      end
+
+      free_convection_regime_u_factor_times_area_value = tower.autosizedFreeConvectionRegimeUFactorTimesAreaValue
+      if free_convection_regime_u_factor_times_area_value.is_initialized
+        tower.setFreeConvectionRegimeUFactorTimesAreaValue(free_convection_regime_u_factor_times_area_value.get)
+      end
+    end
+
     # if user provides this input, if not, do autosizing
     if user_arguments['tank_vol'].hasValue
       tank_vol = runner.getDoubleArgumentValue('tank_vol', user_arguments)
-    else
-      unless user_arguments['run_output_path'].hasValue
-        runner.registerError("Need to provide run output path for sizing run of tank volume. ")
-        return false
+      if cw_loop
+        # autosize cooling tower in the condenser loop to avoid invalid hard-sized parameters
+        cw_loop.supplyComponents.each do |comp|
+          if comp.to_CoolingTowerSingleSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerSingleSpeed.get
+            cooling_tower.autosizeDesignWaterFlowRate
+            cooling_tower.autosizeFanPoweratDesignAirFlowRate
+            cooling_tower.autosizeDesignAirFlowRate
+            cooling_tower.autosizeUFactorTimesAreaValueatDesignAirFlowRate
+            cooling_tower.autosizeAirFlowRateinFreeConvectionRegime
+            cooling_tower.autosizeUFactorTimesAreaValueatFreeConvectionAirFlowRate
+            runner.registerInfo("CoolingTowerSingleSpeed #{cooling_tower.name} has been set to autosize.")
+          elsif comp.to_CoolingTowerTwoSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerTwoSpeed.get
+            cooling_tower.autosizeDesignWaterFlowRate
+            cooling_tower.autosizeHighFanSpeedFanPower
+            cooling_tower.autosizeHighFanSpeedAirFlowRate
+            cooling_tower.autosizeHighFanSpeedUFactorTimesAreaValue
+            cooling_tower.autosizeLowFanSpeedAirFlowRate
+            cooling_tower.autosizeLowFanSpeedFanPower
+            cooling_tower.autosizeLowFanSpeedUFactorTimesAreaValue
+            cooling_tower.autosizeFreeConvectionRegimeAirFlowRate
+            cooling_tower.autosizeFreeConvectionRegimeUFactorTimesAreaValue
+            runner.registerInfo("CoolingTowerTwoSpeed #{cooling_tower.name} has been set to autosize.")
+          elsif comp.to_CoolingTowerVariableSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerVariableSpeed.get
+            cooling_tower.autosize
+            runner.registerInfo("CoolingTowerVariableSpeed #{cooling_tower.name} has been set to autosize.")
+          end
+        end
       end
+    else
+      # unless user_arguments['run_output_path'].hasValue
+      #   runner.registerError("Need to provide run output path for sizing run of tank volume. ")
+      #   return false
+      # end
       run_output_path = runner.getPathArgumentValue('run_output_path', user_arguments)
       Dir.mkdir(run_output_path.to_s) unless File.exists?(run_output_path.to_s)
-      sizing_output_path = File.join(run_output_path.to_s, 'sizing_run')
+      sizing_output_path = File.expand_path(File.join(run_output_path.to_s, 'sizing_run'))
       Dir.mkdir(sizing_output_path.to_s) unless File.exists?(sizing_output_path.to_s)
 
       # Change the simulation to only run the sizing days
@@ -351,11 +472,18 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       File.open(osw_path, 'w') do |f|
         f << JSON.pretty_generate(osw)
       end
+      model.resetSqlFile
       run_osw(osw_path)
       sleep(1)
-      sql = model.sqlFile
-      unless sql.is_initialized
-        model.setSqlFile(OpenStudio::SqlFile.new(OpenStudio::Path.new(File.join(sizing_output_path.to_s, "run", "eplusout.sql"))))
+      sql_path = OpenStudio::Path.new(File.join(sizing_output_path.to_s, "run", "eplusout.sql"))
+      if OpenStudio.exists(sql_path)
+        sql = OpenStudio::SqlFile.new(sql_path)
+        unless sql.connectionOpen
+          runner.registerError("The sizing run failed without valid a sql file. Look at the eplusout.err file in #{File.dirname(sql_path.to_s)} to see the cause.")
+          return false
+        end
+        # Attach the sql file from the run to the model
+        model.setSqlFile(sql)
       end
 
       total_cooling_cap = 0  # initial
@@ -368,6 +496,24 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
           total_cooling_cap += comp.to_ChillerAbsorptionIndirect.get.autosizedNominalCapacity.get
         end
       end
+      if cw_loop
+        # hard size cooling tower in the condenser loop
+        cw_loop.supplyComponents.each do |comp|
+          if comp.to_CoolingTowerSingleSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerSingleSpeed.get
+            cooling_tower.applySizingValues
+            runner.registerInfo("Autosized parameters from the sizing run have been set to CoolingTowerSingleSpeed #{cooling_tower.name}")
+          elsif comp.to_CoolingTowerTwoSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerTwoSpeed.get
+            hardsize_cooling_tower_two_speed(cooling_tower)
+            runner.registerInfo("Autosized parameters from the sizing run have been set to CoolingTowerTwoSpeed #{cooling_tower.name}")
+          elsif comp.to_CoolingTowerVariableSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerVariableSpeed.get
+            cooling_tower.applySizingValues
+            runner.registerInfo("Autosized parameters from the sizing run have been set to CoolingTowerVariableSpeed #{cooling_tower.name}")
+          end
+        end
+      end
 
       # assuming average load ratio of chiller is 1/3 throughout the day
       tank_vol = total_cooling_cap/3.0 * 3600 * lasting_hrs / (4182 * 1000 * secondary_delta_t)  # heat capacity of water 4182J/kg.K, water density 1000g/m3, lasting 8 hours
@@ -380,7 +526,6 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
 
     sec_loop = OpenStudio::Model::PlantLoop.new(model)
     sec_loop.setName("Chilled Water Secondary Loop")
-    selected_primary_loop = model.getPlantLoopByName("Chilled Water Loop").get
     selected_primary_loop.setName("Chilled Water Primary Loop")
     sizing_sec_plant = sec_loop.sizingPlant
     sizing_sec_plant.setLoopType('Cooling')
@@ -391,21 +536,7 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     sizing_pri_plant.setDesignLoopExitTemperature(primary_loop_sp)
     sizing_pri_plant.setLoopDesignTemperatureDifference(primary_delta_t)
 
-    # get the condenser water loop
-    cw_loop = nil
-    model.getPlantLoops.each do |loop|
-      if loop.sizingPlant.loopType.to_s.downcase == 'condenser'
-        cw_loop = loop if cw_loop.nil?
-        # confirm if this condenser loop contains demand component of chiller that is in the selected_primary_loop
-        common_comps = cw_loop.demandComponents & selected_primary_loop.supplyComponents
-        chiller_in_both_loops = false
-        common_comps.each do |comp|
-          chiller_in_both_loops = true if comp.to_ChillerElectricEIR.is_initialized || comp.to_ChillerAbsorption.is_initialized || comp.to_ChillerAbsorptionIndirect.is_initialized
-        end
-        cw_loop = nil unless chiller_in_both_loops
-      end
-    end
-    # not necessarily can find a cw_loop as the existing primary chiller might be air cooled.
+
 
     # add chilled water tank to the primary loop as demand and secondary loop as supply
     chw_storage_tank = OpenStudio::Model::ThermalStorageChilledWaterStratified.new(model)