openstudio-geb 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 45ce7a6b389311aa0a2910b98859e3e23d283c1b7cb16a4e932e2c52457b3b05
-  data.tar.gz: edf5e2693b3924602b03bb73477c99c88003cc391cf4f8b25d22f109befc3a5a
+  metadata.gz: 347d9430484e0647ed589317e8c8324f250e08d4d6f95bcd17e3a66fa84237cd
+  data.tar.gz: bd0f0c3f362792e18e8bddba9dea2c4d2cf8310cf6759fa91b4f50af864d914a
 SHA512:
-  metadata.gz: a1e6bce96aa3833cd9b5dd6e9920cef45211c2daf0a1be06d751a3795f53f235f104281848b534361333fc7a8d914e498369811d40b16e10ac608efd7a925bef
-  data.tar.gz: ae19c84f57043ed7b82ad19c8c5102907ce2fbf5b47308dc0ebdff84a1320340324bec466768b77cc7c0557fbeeca40845737165d026390a4a915326cbfa6b1d
+  metadata.gz: 01a593ed9e93044ee79e09dd8b98d697b7a609def6ba532cd37603e06dfef767b519730e443f946f52cffa2b357a0784dbf9ead1a47f5a00c665b5b61b6f9925
+  data.tar.gz: c2e3606e8c44287fe02e60caac0e6c57b4d0bdd82aa266d1701d47125bfeae7f869e55f89b0a8c65b88d530e634cc102118b38f6a32afe2e914d89d431d73ddb

data/.gitignore

@@ -31,3 +31,8 @@ lib/measures/*/tests/baseline
 
 # runner conf
 runner.conf
+
+# built gem file
+*.gem
+
+.DS_Store

data/lib/measures/add_chilled_water_storage_tank/measure.rb

@@ -51,7 +51,7 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     end
 
     # Make choice argument for primary loop selection
-    selected_primary_loop_name = OpenStudio::Measure::OSArgument.makeChoiceArgument('selected_primary_loop_name', loop_choices, true)
+    selected_primary_loop_name = OpenStudio::Measure::OSArgument.makeChoiceArgument('selected_primary_loop_name', loop_choices, false)
     selected_primary_loop_name.setDisplayName('Select Primary Loop:')
     selected_primary_loop_name.setDescription('This is the primary cooling loop on which the chilled water tank will be added.')
     pri_loop_name = nil
@@ -156,12 +156,13 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     args << wknds
 
     # Output path, for sizing run
-    run_output_path = OpenStudio::Measure::OSArgument.makePathArgument('run_output_path', true, "")
+    run_output_path = OpenStudio::Measure::OSArgument.makePathArgument('run_output_path', true, "", false)
     run_output_path.setDisplayName('Output path for tank sizing run (if tank volume is not provided)')
+    run_output_path.setDefaultValue(".")
     args << run_output_path
 
     # epw file path, for sizing run
-    epw_path = OpenStudio::Measure::OSArgument.makePathArgument('epw_path', true, "")
+    epw_path = OpenStudio::Measure::OSArgument.makePathArgument('epw_path', true, "", false)
     epw_path.setDisplayName('epw file path for tank sizing run (if tank volume is not provided)')
     args << epw_path
 
@@ -187,6 +188,34 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     # assign the user inputs to variables
     objective = runner.getStringArgumentValue('objective', user_arguments)
     selected_primary_loop_name = runner.getStringArgumentValue('selected_primary_loop_name', user_arguments)
+    if selected_primary_loop_name
+      # get the primary cooling loop
+      selected_primary_loop = model.getModelObjectByName(selected_primary_loop_name)
+      if selected_primary_loop.is_initialized
+        selected_primary_loop = selected_primary_loop.get.to_PlantLoop.get
+      else
+        # The provided value is not a plant loop in the model
+        runner.registerError("The provided primary loop name doesn't exist in the model.")
+        return false
+      end
+    else
+      loop_choices = []
+      model.getPlantLoops.each do |loop|
+        if loop.sizingPlant.loopType.to_s == 'Cooling'
+          loop_choices << loop.name.to_s
+        end
+      end
+      if loop_choices.empty?
+        # No cooling loop; the measure is not applicable
+        runner.registerAsNotApplicable("No cooling loop in the model. The measure is not applicable.")
+        return true
+      else
+        # There is cooling loop in the model but user didn't specify one,
+        # and the cooling loop name does not include 'chilled water loop'
+        runner.registerError("Please select a primary loop name to run the measure. The available cooling loop(s) in the model is #{loop_choices.join(', ')}")
+        return false
+      end
+    end
     primary_loop_sp = runner.getDoubleArgumentValue('primary_loop_sp', user_arguments)
     secondary_loop_sp = runner.getDoubleArgumentValue('secondary_loop_sp', user_arguments)
     tank_charge_sp = runner.getDoubleArgumentValue('tank_charge_sp', user_arguments)
@@ -199,6 +228,7 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     charge_end = runner.getStringArgumentValue('charge_end', user_arguments)
     wknds = runner.getBoolArgumentValue('wknds', user_arguments)
 
+
     # check time format
     begin
       discharge_start = Time.strptime(discharge_start, '%H:%M')
@@ -293,14 +323,7 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       return false
     end
 
-    # get the primary cooling loop
-    selected_primary_loop = model.getModelObjectByName(selected_primary_loop_name)
-    if selected_primary_loop.is_initialized
-      selected_primary_loop = selected_primary_loop.get.to_PlantLoop.get
-    else
-      runner.registerError("Error: No Primary Cooling Loop Found. ")
-      return false
-    end
+
     # report initial condition of model
     runner.registerInitialCondition("Original primary chilled water loop: #{selected_primary_loop.name}.")
 
@@ -312,17 +335,112 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       primary_delta_t = selected_primary_loop.sizingPlant.loopDesignTemperatureDifference
     end
 
+    # get the condenser water loop
+    cw_loop = nil
+    model.getPlantLoops.each do |loop|
+      if loop.sizingPlant.loopType.to_s.downcase == 'condenser'
+        cw_loop = loop if cw_loop.nil?
+        # confirm if this condenser loop contains demand component of chiller that is in the selected_primary_loop
+        common_comps = cw_loop.demandComponents & selected_primary_loop.supplyComponents
+        chiller_in_both_loops = false
+        common_comps.each do |comp|
+          chiller_in_both_loops = true if comp.to_ChillerElectricEIR.is_initialized || comp.to_ChillerAbsorption.is_initialized || comp.to_ChillerAbsorptionIndirect.is_initialized
+        end
+        cw_loop = nil unless chiller_in_both_loops
+      end
+    end
+    # not necessarily can find a cw_loop as the existing primary chiller might be air cooled.
+
+    def hardsize_cooling_tower_two_speed(tower)
+      # implement the applySizingValues function for CoolingTowerTwoSpeed here since it's not yet implemented in OS standards
+      rated_water_flow_rate = tower.autosizedDesignWaterFlowRate
+      if rated_water_flow_rate.is_initialized
+        tower.setDesignWaterFlowRate(rated_water_flow_rate.get)
+      end
+
+      high_fan_speed_fan_power = tower.autosizedHighFanSpeedFanPower
+      if high_fan_speed_fan_power.is_initialized
+        tower.setHighFanSpeedFanPower(high_fan_speed_fan_power.get)
+      end
+
+      high_fan_speed_air_flow_rate = tower.autosizedHighFanSpeedAirFlowRate
+      if high_fan_speed_air_flow_rate.is_initialized
+        tower.setHighFanSpeedAirFlowRate(high_fan_speed_air_flow_rate.get)
+      end
+
+      high_fan_speed_u_factor_times_area_value = tower.autosizedHighFanSpeedUFactorTimesAreaValue
+      if high_fan_speed_u_factor_times_area_value.is_initialized
+        tower.setHighFanSpeedUFactorTimesAreaValue(high_fan_speed_u_factor_times_area_value.get)
+      end
+
+      low_fan_speed_air_flow_rate = tower.autosizedLowFanSpeedAirFlowRate
+      if low_fan_speed_air_flow_rate.is_initialized
+        tower.setLowFanSpeedAirFlowRate(low_fan_speed_air_flow_rate.get)
+      end
+
+      low_fan_speed_fan_power = tower.autosizedLowFanSpeedFanPower
+      if low_fan_speed_fan_power.is_initialized
+        tower.setLowFanSpeedFanPower(low_fan_speed_fan_power.get)
+      end
+
+      low_fan_speed_u_factor_times_area_value = tower.autosizedLowFanSpeedUFactorTimesAreaValue
+      if low_fan_speed_u_factor_times_area_value.is_initialized
+        tower.setLowFanSpeedUFactorTimesAreaValue(low_fan_speed_u_factor_times_area_value.get)
+      end
+
+      free_convection_regime_air_flow_rate = tower.autosizedFreeConvectionRegimeAirFlowRate
+      if free_convection_regime_air_flow_rate.is_initialized
+        tower.setFreeConvectionRegimeAirFlowRate(free_convection_regime_air_flow_rate.get)
+      end
+
+      free_convection_regime_u_factor_times_area_value = tower.autosizedFreeConvectionRegimeUFactorTimesAreaValue
+      if free_convection_regime_u_factor_times_area_value.is_initialized
+        tower.setFreeConvectionRegimeUFactorTimesAreaValue(free_convection_regime_u_factor_times_area_value.get)
+      end
+    end
+
     # if user provides this input, if not, do autosizing
     if user_arguments['tank_vol'].hasValue
       tank_vol = runner.getDoubleArgumentValue('tank_vol', user_arguments)
-    else
-      unless user_arguments['run_output_path'].hasValue
-        runner.registerError("Need to provide run output path for sizing run of tank volume. ")
-        return false
+      if cw_loop
+        # autosize cooling tower in the condenser loop to avoid invalid hard-sized parameters
+        cw_loop.supplyComponents.each do |comp|
+          if comp.to_CoolingTowerSingleSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerSingleSpeed.get
+            cooling_tower.autosizeDesignWaterFlowRate
+            cooling_tower.autosizeFanPoweratDesignAirFlowRate
+            cooling_tower.autosizeDesignAirFlowRate
+            cooling_tower.autosizeUFactorTimesAreaValueatDesignAirFlowRate
+            cooling_tower.autosizeAirFlowRateinFreeConvectionRegime
+            cooling_tower.autosizeUFactorTimesAreaValueatFreeConvectionAirFlowRate
+            runner.registerInfo("CoolingTowerSingleSpeed #{cooling_tower.name} has been set to autosize.")
+          elsif comp.to_CoolingTowerTwoSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerTwoSpeed.get
+            cooling_tower.autosizeDesignWaterFlowRate
+            cooling_tower.autosizeHighFanSpeedFanPower
+            cooling_tower.autosizeHighFanSpeedAirFlowRate
+            cooling_tower.autosizeHighFanSpeedUFactorTimesAreaValue
+            cooling_tower.autosizeLowFanSpeedAirFlowRate
+            cooling_tower.autosizeLowFanSpeedFanPower
+            cooling_tower.autosizeLowFanSpeedUFactorTimesAreaValue
+            cooling_tower.autosizeFreeConvectionRegimeAirFlowRate
+            cooling_tower.autosizeFreeConvectionRegimeUFactorTimesAreaValue
+            runner.registerInfo("CoolingTowerTwoSpeed #{cooling_tower.name} has been set to autosize.")
+          elsif comp.to_CoolingTowerVariableSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerVariableSpeed.get
+            cooling_tower.autosize
+            runner.registerInfo("CoolingTowerVariableSpeed #{cooling_tower.name} has been set to autosize.")
+          end
+        end
       end
+    else
+      # unless user_arguments['run_output_path'].hasValue
+      #   runner.registerError("Need to provide run output path for sizing run of tank volume. ")
+      #   return false
+      # end
       run_output_path = runner.getPathArgumentValue('run_output_path', user_arguments)
       Dir.mkdir(run_output_path.to_s) unless File.exists?(run_output_path.to_s)
-      sizing_output_path = File.join(run_output_path.to_s, 'sizing_run')
+      sizing_output_path = File.expand_path(File.join(run_output_path.to_s, 'sizing_run'))
       Dir.mkdir(sizing_output_path.to_s) unless File.exists?(sizing_output_path.to_s)
 
       # Change the simulation to only run the sizing days
@@ -351,11 +469,18 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
       File.open(osw_path, 'w') do |f|
         f << JSON.pretty_generate(osw)
       end
+      model.resetSqlFile
       run_osw(osw_path)
       sleep(1)
-      sql = model.sqlFile
-      unless sql.is_initialized
-        model.setSqlFile(OpenStudio::SqlFile.new(OpenStudio::Path.new(File.join(sizing_output_path.to_s, "run", "eplusout.sql"))))
+      sql_path = OpenStudio::Path.new(File.join(sizing_output_path.to_s, "run", "eplusout.sql"))
+      if OpenStudio.exists(sql_path)
+        sql = OpenStudio::SqlFile.new(sql_path)
+        unless sql.connectionOpen
+          runner.registerError("The sizing run failed without valid a sql file. Look at the eplusout.err file in #{File.dirname(sql_path.to_s)} to see the cause.")
+          return false
+        end
+        # Attach the sql file from the run to the model
+        model.setSqlFile(sql)
       end
 
       total_cooling_cap = 0  # initial
@@ -368,6 +493,24 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
           total_cooling_cap += comp.to_ChillerAbsorptionIndirect.get.autosizedNominalCapacity.get
         end
       end
+      if cw_loop
+        # hard size cooling tower in the condenser loop
+        cw_loop.supplyComponents.each do |comp|
+          if comp.to_CoolingTowerSingleSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerSingleSpeed.get
+            cooling_tower.applySizingValues
+            runner.registerInfo("Autosized parameters from the sizing run have been set to CoolingTowerSingleSpeed #{cooling_tower.name}")
+          elsif comp.to_CoolingTowerTwoSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerTwoSpeed.get
+            hardsize_cooling_tower_two_speed(cooling_tower)
+            runner.registerInfo("Autosized parameters from the sizing run have been set to CoolingTowerTwoSpeed #{cooling_tower.name}")
+          elsif comp.to_CoolingTowerVariableSpeed.is_initialized
+            cooling_tower = comp.to_CoolingTowerVariableSpeed.get
+            cooling_tower.applySizingValues
+            runner.registerInfo("Autosized parameters from the sizing run have been set to CoolingTowerVariableSpeed #{cooling_tower.name}")
+          end
+        end
+      end
 
       # assuming average load ratio of chiller is 1/3 throughout the day
       tank_vol = total_cooling_cap/3.0 * 3600 * lasting_hrs / (4182 * 1000 * secondary_delta_t)  # heat capacity of water 4182J/kg.K, water density 1000g/m3, lasting 8 hours
@@ -380,7 +523,6 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
 
     sec_loop = OpenStudio::Model::PlantLoop.new(model)
     sec_loop.setName("Chilled Water Secondary Loop")
-    selected_primary_loop = model.getPlantLoopByName("Chilled Water Loop").get
     selected_primary_loop.setName("Chilled Water Primary Loop")
     sizing_sec_plant = sec_loop.sizingPlant
     sizing_sec_plant.setLoopType('Cooling')
@@ -391,21 +533,7 @@ class AddChilledWaterStorageTank < OpenStudio::Measure::ModelMeasure
     sizing_pri_plant.setDesignLoopExitTemperature(primary_loop_sp)
     sizing_pri_plant.setLoopDesignTemperatureDifference(primary_delta_t)
 
-    # get the condenser water loop
-    cw_loop = nil
-    model.getPlantLoops.each do |loop|
-      if loop.sizingPlant.loopType.to_s.downcase == 'condenser'
-        cw_loop = loop if cw_loop.nil?
-        # confirm if this condenser loop contains demand component of chiller that is in the selected_primary_loop
-        common_comps = cw_loop.demandComponents & selected_primary_loop.supplyComponents
-        chiller_in_both_loops = false
-        common_comps.each do |comp|
-          chiller_in_both_loops = true if comp.to_ChillerElectricEIR.is_initialized || comp.to_ChillerAbsorption.is_initialized || comp.to_ChillerAbsorptionIndirect.is_initialized
-        end
-        cw_loop = nil unless chiller_in_both_loops
-      end
-    end
-    # not necessarily can find a cw_loop as the existing primary chiller might be air cooled.
+
 
     # add chilled water tank to the primary loop as demand and secondary loop as supply
     chw_storage_tank = OpenStudio::Model::ThermalStorageChilledWaterStratified.new(model)

data/lib/measures/average_ventilation_for_peak_hours/measure.rb

@@ -19,7 +19,7 @@ class AverageVentilationForPeakHours < OpenStudio::Measure::ModelMeasure
   end
   # human readable description of modeling approach
   def modeler_description
-    return "The outdoor air flow rate will be reduced by the percentage specified by the user during the peak hours specified by the user. Then the decreased air flow rate will be added to the hours after the peak time."
+    return "The outdoor air flow rate will be reduced by the percentage specified by the user during the peak hours specified by the user. Then the decreased air flow rate will be added to the same number of hours before the peak time."
   end
   # define the arguments that the user will input
   def arguments(model)
@@ -34,14 +34,14 @@ class AverageVentilationForPeakHours < OpenStudio::Measure::ModelMeasure
     start_time = OpenStudio::Measure::OSArgument.makeStringArgument('start_time', false)
     start_time.setDisplayName('Start Time for the Reduction')
     start_time.setDescription('In HH:MM:SS format')
-    start_time.setDefaultValue('14:00:00')
+    start_time.setDefaultValue('12:00:00')
     args << start_time
 
     # make an argument for the end time of the reduction
     end_time = OpenStudio::Measure::OSArgument.makeStringArgument('end_time', false)
     end_time.setDisplayName('End Time for the Reduction')
     end_time.setDescription('In HH:MM:SS format')
-    end_time.setDefaultValue('16:00:00')
+    end_time.setDefaultValue('14:00:00')
     args << end_time
 
     # make an argument for the start date of the reduction
@@ -55,7 +55,7 @@ class AverageVentilationForPeakHours < OpenStudio::Measure::ModelMeasure
     end_date1 = OpenStudio::Ruleset::OSArgument.makeStringArgument('end_date1', false)
     end_date1.setDisplayName('End Date for Average Ventilation')
     end_date1.setDescription('In MM-DD format')
-    end_date1.setDefaultValue('08-01')
+    end_date1.setDefaultValue('08-31')
     args << end_date1
 
 
@@ -144,7 +144,8 @@ class AverageVentilationForPeakHours < OpenStudio::Measure::ModelMeasure
       if oa_sch.empty?
         new_oa_sch_name = "#{outdoor_air_object.name} fraction schedule"
         runner.registerInfo("#{outdoor_air_object.name} doesn't have a schedule. A new schedule '#{new_oa_sch_name}' will be added.")
-        # The fraction schedule cannot have value > 1
+        # The fraction schedule cannot have value > 1,
+        # so in order to increase the ventilation rate before peak hours, the original base value need to be increased
         outdoor_air_object.setOutdoorAirFlowperPerson(outdoor_air_object.outdoorAirFlowperPerson * (1+vent_reduce_percent*0.01))
         outdoor_air_object.setOutdoorAirFlowperFloorArea(outdoor_air_object.outdoorAirFlowperFloorArea * (1+vent_reduce_percent*0.01))
         outdoor_air_object.setOutdoorAirFlowAirChangesperHour(outdoor_air_object.outdoorAirFlowAirChangesperHour * (1+vent_reduce_percent*0.01))
@@ -156,15 +157,25 @@ class AverageVentilationForPeakHours < OpenStudio::Measure::ModelMeasure
         h, m, s  = end_time.split(':')
         end_hour = h.to_i +  m.to_i/60
         time_span = end_hour - start_hour
-        end_hour_2 = end_hour + time_span
-        if end_hour_2 > 24.0
-          end_hour_2 -= 24.0
+        increase_start_hour = start_hour - time_span
+        if increase_start_hour < 0
+          increase_start_hour += 24
         end
-        if end_hour_2 < start_hour
-          adjusted_day_data_pairs = [[end_hour_2, 1], [start_hour, percent_back], [end_hour, percent_reduce], [24, 1]]
+        if increase_start_hour < start_hour
+          adjusted_day_data_pairs = [[increase_start_hour, percent_back], [start_hour, 1], [end_hour, percent_reduce], [24, percent_back]]
         else
-          adjusted_day_data_pairs = [[start_hour, percent_back], [end_hour, percent_reduce], [end_hour_2, 1], [24, percent_back]]
+          adjusted_day_data_pairs = [[start_hour, 1], [end_hour, percent_reduce], [increase_start_hour, percent_back], [24, 1]]
         end
+        # end_hour_2 = end_hour + time_span
+        # if end_hour_2 > 24.0
+        #   end_hour_2 -= 24.0
+        # end
+        # if end_hour_2 < start_hour
+        #   adjusted_day_data_pairs = [[end_hour_2, 1], [start_hour, percent_back], [end_hour, percent_reduce], [24, 1]]
+        # else
+        #   adjusted_day_data_pairs = [[start_hour, percent_back], [end_hour, percent_reduce], [end_hour_2, 1], [24, percent_back]]
+        # end
+
         normal_day_data_pairs = [[24, percent_back]]
         options = { 'name' => new_oa_sch_name,
                     'winter_design_day' => normal_day_data_pairs,