openstudio-extension 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e410744afb54a4a4c19ee59dd2d7a9edd77da75d67df9968f0ed2e0a304f0f7
-  data.tar.gz: 3949d1e1bb9a929b251e473aac854d50abff6da4800be4b10318f786b0c5c082
+  metadata.gz: c1d5fc1ae05ebc04e7ba917e74002f1c9c574fb03354c1dc9a8a12dd5fa1f897
+  data.tar.gz: 876541d14c4ccc7a97eb7a617d40c7dc68f58f1a49959491d51919e8af068f17
 SHA512:
-  metadata.gz: 82b88a5b66d29367fca57cb38228ccf7f782a798b98e09a220c11eb6d7bfe6e959a947e4a44f97fd391a7eec123fb37c1894e7dfd04803108fca75fd02a0bccb
-  data.tar.gz: 451ea32b090a21701eda6df859714bb213e212c2fdcdab086de7c51dd71031e9eaab493b04df671eccc9c01483408f40595127246997c91e810e0b1d3f4b3847
+  metadata.gz: d3df31fdd6f8bd2805af4c69effc71f3ebb50c4ea1863f728737140623b42b87ebd5f2a05555b13eb8a0b2237a1eb73b8184723593bd89805a157bed4ec545ff
+  data.tar.gz: 20e1d537b0bd4ac570a6c8e90aa44de68434aaa573b1142fe560b340c9b9d8dca2182cea1c3dc9b6ca42c688afebe25ca3c5f1d2cf9382ed549645aa06a46ce3

data/CHANGELOG.md

@@ -1,16 +1,19 @@
 # OpenStudio Extension Gem
 
+## Version 0.5.1
+
+* Fix adjancent surface matching 
+
 ## Version 0.5.0
 
 * Update OpenStudio Workflow Gem to 2.3.0 (support for epJSON)
-
-- Fixed [#133]( https://github.com/NREL/openstudio-extension-gem/pull/133 ), cleanup readme and rework BCL tasks
-- Fixed [#135]( https://github.com/NREL/openstudio-extension-gem/pull/135 ), Intersect tests 072021
-- Fixed [#136]( https://github.com/NREL/openstudio-extension-gem/pull/136 ), Osm from haystack
-- Fixed [#137]( https://github.com/NREL/openstudio-extension-gem/issues/137 ), Edge case error in hospital bar
-- Fixed [#138]( https://github.com/NREL/openstudio-extension-gem/issues/138 ), os_lib_model_generation does not assign SWH type correctly
-- Fixed [#139]( https://github.com/NREL/openstudio-extension-gem/pull/139 ), fix swh_src assignment operators
-- Fixed [#142]( https://github.com/NREL/openstudio-extension-gem/pull/142 ), added arg for hoo_var_method and updated test to use it
+* Fixed [#133]( https://github.com/NREL/openstudio-extension-gem/pull/133 ), cleanup readme and rework BCL tasks
+* Fixed [#135]( https://github.com/NREL/openstudio-extension-gem/pull/135 ), Intersect tests 072021
+* Fixed [#136]( https://github.com/NREL/openstudio-extension-gem/pull/136 ), Osm from haystack
+* Fixed [#137]( https://github.com/NREL/openstudio-extension-gem/issues/137 ), Edge case error in hospital bar
+* Fixed [#138]( https://github.com/NREL/openstudio-extension-gem/issues/138 ), os_lib_model_generation does not assign SWH type correctly
+* Fixed [#139]( https://github.com/NREL/openstudio-extension-gem/pull/139 ), fix swh_src assignment operators
+* Fixed [#142]( https://github.com/NREL/openstudio-extension-gem/pull/142 ), added arg for hoo_var_method and updated test to use it
 
 ## Version 0.4.4
 

data/lib/openstudio/extension/core/os_lib_model_generation.rb

@@ -1146,13 +1146,13 @@ module OsLib_ModelGeneration
               spaces_temp = OpenStudio::Model::SpaceVector.new
               spaces_temp << space_a
               spaces_temp << space_b
-              # disable until enhanced intersectio nand matching, will make walls adiabatic and exterior within create_bar workflow
+              # attempt to intersect and match walls on a story, but later secondary match will look for missted matches and turn them to adiabaitc
               # intersect and sort
-              # OpenStudio::Model.intersectSurfaces(spaces_temp)
-              # OpenStudio::Model.matchSurfaces(spaces_temp)
+              OpenStudio::Model.intersectSurfaces(spaces_temp)
+              OpenStudio::Model.matchSurfaces(spaces_temp)
             end
           end
-          runner.registerInfo("Intersecting and matching surfaces in story #{story.name}, this will create additional geometry.")
+          runner.registerInfo("Intersecting and matching surfaces in story #{story.name}, this will create additional geometry. Diagnstoic intersection and matching done a in paris of spaces.")
         end
       end
 
@@ -1173,11 +1173,11 @@ module OsLib_ModelGeneration
           story.spaces.sort.each do |space|
             story_spaces << space
           end
-          # disable until enhanced intersectio nand matching, will make walls adiabatic and exterior within create_bar workflow
+          # attempt to intersect and match walls on a story, but later secondary match will look for missted matches and turn them to adiabaitc
           # intersect and sort
-          # OpenStudio::Model.intersectSurfaces(story_spaces)
-          # OpenStudio::Model.matchSurfaces(story_spaces)
-          #runner.registerInfo("Intersecting and matching surfaces in story #{story.name}, this will create additional geometry.")
+          OpenStudio::Model.intersectSurfaces(story_spaces)
+          OpenStudio::Model.matchSurfaces(story_spaces)
+          runner.registerInfo("Intersecting and matching surfaces in story #{story.name}, this will create additional geometry.")
         end
       end
 
@@ -1205,7 +1205,9 @@ module OsLib_ModelGeneration
       runner.registerInfo("Finding non-exterior walls and setting boundary condition to adiabatic")
 
       # need to organize by story incase top story is partial story
+      # should also be only for a single bar
       story_bounding = {}
+      missed_match_count = 0
 
       # gather new spaces by story
       new_spaces.each do |space|
@@ -1238,6 +1240,7 @@ module OsLib_ModelGeneration
         v[:spaces].each do |space|
           space.surfaces.each do |space_surface|
             next if not space_surface.surfaceType == "Wall"
+            next if space_surface.outsideBoundaryCondition == "Surface" # if if found a match leave it alone, don't change to adiabiatc
             surface_bounding_box = OpenStudio::BoundingBox.new
             surface_bounding_box.addPoints(space.transformation * space_surface.vertices)
             surface_on_outside = false
@@ -1253,10 +1256,16 @@ module OsLib_ModelGeneration
             # change if not exterior
             if !surface_on_outside
               space_surface.setOutsideBoundaryCondition("Adiabatic")
+              missed_match_count += 1
             end
           end
         end
       end
+
+      if missed_match_count > 0
+        runner.registerInfo("#{missed_match_count} surfaces that were exterior appear to be interior walls and had boundary condition chagned to adiabiatic.")
+      end
+
     end
 
     # sort stories (by name for now but need better way)

data/lib/openstudio/extension/version.rb

@@ -35,6 +35,6 @@
 
 module OpenStudio
   module Extension
-    VERSION = '0.5.0'.freeze
+    VERSION = '0.5.1'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openstudio-extension
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Katherine Fleming
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-10-21 00:00:00.000000000 Z
+date: 2021-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bcl
@@ -233,7 +233,7 @@ licenses: []
 metadata:
   bug_tracker_uri: https://github.com/NREL/openstudio-extension-gem/issues
   changelog_uri: https://github.com/NREL/openstudio-extension-gem/blob/develop/CHANGELOG.md
-  source_code_uri: https://github.com/NREL/openstudio-extension-gem/tree/v0.5.0
+  source_code_uri: https://github.com/NREL/openstudio-extension-gem/tree/v0.5.1
 post_install_message: 
 rdoc_options: []
 require_paths: