openstudio-ee 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e1f51dd9876af66e73f11f916596a843d40abef627ca4920effca222b1a12518
-  data.tar.gz: 8764a7e76b29e452ba9b12945c92a164f985ee6ada6849498368aea3caa0f4f8
+  metadata.gz: 0247d977cb8a0949c64794b9dd08254ee6a1437a87b73fd836fcb07b35ce69be
+  data.tar.gz: 9e96d741e93ab51f4ed08c7a700522ce590b31a7ab736c38f9bbc844da2f1631
 SHA512:
-  metadata.gz: 2f9b65251ccef1b28f7e16a95d4dedc9265b11899ec9128db9503bc66e50262622c1399ac834eaa60e264af2a5e1558d85a441925ea42ca9f067787ab4a96851
-  data.tar.gz: 517716774a902e7852c8527ab68b181af8f6754d6f10830b51815864f13e65330415583c042d6d34152ad21e6576c90f92e23b133802191941b9460f679b90ef
+  metadata.gz: 74fe06c5122a0cbe4e45f33d12818b7e5278c1dba119d9e13eb926604026742f409d76d5cb58d151603f0a56b096c5f2c3e530cec09698207a0af579f09ff150
+  data.tar.gz: 07cb1f9e69ec817df5add2de647feb1c304f762714884f439be4a32de51b93eb4311485f6fcfd955313c330a340819804d754a52bd55e791bf75310986bd2ff9

data/.rubocop.yml

@@ -2,4 +2,4 @@ AllCops:
   Exclude:
     - 'spec/test_measures/**/*'
 inherit_from:
-  - http://s3.amazonaws.com/openstudio-resources/styles/rubocop.yml
+  - http://s3.amazonaws.com/openstudio-resources/styles/rubocop_v3.yml

data/CHANGELOG.md

@@ -1,6 +1,13 @@
 # OpenStudio EE Gem
 
+## Version 0.3.0
+
+* Support for OpenStudio 3.1
+    * Update OpenStudio Standards to 0.2.12
+    * Update OpenStudio Extension gem to 0.3.1
+
 ## Version 0.2.1
+
 * Update openstudio-extension to 0.2.5
 * Adds the following to lib/measures:
     * ImproveFanTotalEfficiencyByPercentage

data/Rakefile

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 # *******************************************************************************
 # OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
 # All rights reserved.

data/lib/measures/GLHEProExportLoadsforGroundHeatExchangerSizing/measure.rb

@@ -53,7 +53,7 @@ class GLHEProExportLoadsforGroundHeatExchangerSizing < OpenStudio::Measure::Repo
   end
 
   # define the arguments that the user will input
-  def arguments
+  def arguments(model = nil)
     args = OpenStudio::Measure::OSArgumentVector.new
 
     return args

data/lib/measures/GLHEProExportLoadsforGroundHeatExchangerSizing/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>glhe_pro_export_loadsfor_ground_heat_exchanger_sizing</name>
   <uid>7bb0ce67-cffb-4ef6-b7fb-093c7c43e263</uid>
-  <version_id>9e7b6db7-cdf7-46cd-98af-e527072e4431</version_id>
-  <version_modified>20200423T205217Z</version_modified>
+  <version_id>ba9023aa-374a-4a78-9c7d-09cbd752e093</version_id>
+  <version_modified>20200714T172140Z</version_modified>
   <xml_checksum>2C8A3EEF</xml_checksum>
   <class_name>GLHEProExportLoadsforGroundHeatExchangerSizing</class_name>
   <display_name>GLHEProExportLoadsforGroundHeatExchangerSizing</display_name>
@@ -164,7 +164,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>6358E258</checksum>
+      <checksum>496F92E3</checksum>
     </file>
     <file>
       <filename>README.md</filename>
@@ -174,4 +174,3 @@
     </file>
   </files>
 </measure>
-<error>wrong number of arguments (given 1, expected 0)</error>

data/lib/measures/nze_hvac/measure.rb

@@ -427,18 +427,20 @@ class NzeHvac < OpenStudio::Measure::ModelMeasure
         return false
     end
 
-    # check that the directory name isn't too long for a sizing run; sometimes this isn't necessary
-    # if "#{Dir.pwd} }/SizingRun".length > 90
-    #   runner.registerError("Directory path #{Dir.pwd}/SizingRun is greater than 90 characters and too long perform a sizing run.")
-    #   return false
-    # end
-
     # check that weather file exists for a sizing run
     if !model.weatherFile.is_initialized
       runner.registerError('Weather file not set. Cannot perform sizing run.')
       return false
     end
 
+    # ensure sizing OA method is aligned
+    model.getControllerMechanicalVentilations.each do |controller|
+      controller.setSystemOutdoorAirMethod('ZoneSum')
+    end
+
+    # logic to ensure variable, not cycling, pump operation for chillers
+    model.getChillerElectricEIRs.each { |chiller| chiller.setChillerFlowMode('LeavingSetpointModulated') }
+
     # log the build messages and errors to a file before sizing run in case of failure
     log_messages_to_file("#{Dir.pwd}/openstudio-standards.log", debug = true)
 

data/lib/measures/nze_hvac/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>nze_hvac</name>
   <uid>f060dff2-b28d-4194-a6af-e66d88ddb33c</uid>
-  <version_id>83e77929-f391-407a-8aef-20994f5b7e37</version_id>
-  <version_modified>20200316T215557Z</version_modified>
+  <version_id>6d156aab-dd02-41ed-9285-82c07a45707c</version_id>
+  <version_modified>20201112T192500Z</version_modified>
   <xml_checksum>0E5E4776</xml_checksum>
   <class_name>NzeHvac</class_name>
   <display_name>NZEHVAC</display_name>
@@ -309,6 +309,12 @@
       <usage_type>license</usage_type>
       <checksum>E0468DD6</checksum>
     </file>
+    <file>
+      <filename>NZEHVAC_Test.rb</filename>
+      <filetype>rb</filetype>
+      <usage_type>test</usage_type>
+      <checksum>1BA0611D</checksum>
+    </file>
     <file>
       <version>
         <software_program>OpenStudio</software_program>
@@ -318,13 +324,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>B06BEFD1</checksum>
-    </file>
-    <file>
-      <filename>NZEHVAC_Test.rb</filename>
-      <filetype>rb</filetype>
-      <usage_type>test</usage_type>
-      <checksum>1BA0611D</checksum>
+      <checksum>CF08F01B</checksum>
     </file>
   </files>
 </measure>

data/lib/openstudio/ee_measures/version.rb

@@ -37,6 +37,6 @@
 
 module OpenStudio
   module EeMeasures
-    VERSION = '0.2.1'
+    VERSION = '0.3.0'
   end
 end

data/openstudio-ee.gemspec

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'openstudio/ee_measures/version'
@@ -14,10 +12,10 @@ Gem::Specification.new do |spec|
   spec.summary       = 'Library and measures for OpenStudio for energy efficiency use cases'
   spec.description   = 'Library and measures for OpenStudio for energy efficiency use cases'
   spec.metadata = {
-    'bug_tracker_uri' => 'https://github.com/NREL/openstudio-ee-gem/issues',
-    'changelog_uri' => 'https://github.com/NREL/openstudio-ee-gem/blob/develop/CHANGELOG.md',
-    # 'documentation_uri' =>  'https://www.rubydoc.info/gems/openstudio-ee-gem/#{gem.version}',
-    'source_code_uri' => "https://github.com/NREL/openstudio-ee-gem/tree/v#{spec.version}"
+      'bug_tracker_uri' => 'https://github.com/NREL/openstudio-ee-gem/issues',
+      'changelog_uri' => 'https://github.com/NREL/openstudio-ee-gem/blob/develop/CHANGELOG.md',
+      # 'documentation_uri' =>  'https://www.rubydoc.info/gems/openstudio-ee-gem/#{gem.version}',
+      'source_code_uri' => "https://github.com/NREL/openstudio-ee-gem/tree/v#{spec.version}"
   }
 
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
@@ -30,8 +28,8 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '~> 2.5.0'
 
   spec.add_dependency 'bundler', '~> 2.1'
-  spec.add_dependency 'openstudio-extension', '~> 0.2.5'
-  spec.add_dependency 'openstudio-standards', '~> 0.2.11'
+  spec.add_dependency 'openstudio-extension', '~> 0.3.1'
+  spec.add_dependency 'openstudio-standards', '~> 0.2.12'
 
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.9'

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: openstudio-ee
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - David Goldwasser
 - Nicholas Long
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-10-28 00:00:00.000000000 Z
+date: 2020-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -31,28 +31,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.5
+        version: 0.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.5
+        version: 0.3.1
 - !ruby/object:Gem::Dependency
   name: openstudio-standards
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.11
+        version: 0.2.12
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.11
+        version: 0.2.12
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -158,8 +158,6 @@ files:
 - lib/measures/ImproveFanBeltEfficiency/README.md.erb
 - lib/measures/ImproveFanBeltEfficiency/measure.rb
 - lib/measures/ImproveFanBeltEfficiency/measure.xml
-- lib/measures/ImproveFanTotalEfficiencybyPercentage/measure.rb
-- lib/measures/ImproveFanTotalEfficiencybyPercentage/measure.xml
 - lib/measures/ImproveMotorEfficiency/LICENSE.md
 - lib/measures/ImproveMotorEfficiency/README.md
 - lib/measures/ImproveMotorEfficiency/README.md.erb
@@ -205,12 +203,6 @@ files:
 - lib/measures/ReduceVentilationByPercentage/README.md.erb
 - lib/measures/ReduceVentilationByPercentage/measure.rb
 - lib/measures/ReduceVentilationByPercentage/measure.xml
-- lib/measures/ReplaceFanTotalEfficiency/measure.rb
-- lib/measures/ReplaceFanTotalEfficiency/measure.xml
-- lib/measures/add_apszhp_to_each_zone/measure.rb
-- lib/measures/add_apszhp_to_each_zone/measure.xml
-- lib/measures/add_energy_recovery_ventilator/measure.rb
-- lib/measures/add_energy_recovery_ventilator/measure.xml
 - lib/measures/add_variable_speed_rtu_control_logic/LICENSE.md
 - lib/measures/add_variable_speed_rtu_control_logic/README.md
 - lib/measures/add_variable_speed_rtu_control_logic/README.md.erb
@@ -227,47 +219,16 @@ files:
 - lib/measures/fan_assist_night_ventilation/measure.rb
 - lib/measures/fan_assist_night_ventilation/measure.xml
 - lib/measures/fan_assist_night_ventilation/resources/FanAssistNightVentilationMeasureGuide.pdf
-- lib/measures/improve_simple_glazing_by_percentage/measure.rb
-- lib/measures/improve_simple_glazing_by_percentage/measure.xml
 - lib/measures/nze_hvac/LICENSE.md
 - lib/measures/nze_hvac/README.md
 - lib/measures/nze_hvac/README.md.erb
 - lib/measures/nze_hvac/measure.rb
 - lib/measures/nze_hvac/measure.xml
-- lib/measures/reduce_water_use_by_percentage/measure.rb
-- lib/measures/reduce_water_use_by_percentage/measure.xml
-- lib/measures/replace_hvac_with_gshp_and_doas/measure.rb
-- lib/measures/replace_hvac_with_gshp_and_doas/measure.xml
-- lib/measures/replace_hvac_with_gshp_and_doas/resources/OsLib_AedgMeasures.rb
-- lib/measures/replace_hvac_with_gshp_and_doas/resources/OsLib_Constructions.rb
-- lib/measures/replace_hvac_with_gshp_and_doas/resources/OsLib_Geometry.rb
-- lib/measures/replace_hvac_with_gshp_and_doas/resources/OsLib_HVAC.rb
-- lib/measures/replace_hvac_with_gshp_and_doas/resources/OsLib_HelperMethods.rb
-- lib/measures/replace_hvac_with_gshp_and_doas/resources/OsLib_LightingAndEquipment.rb
-- lib/measures/replace_hvac_with_gshp_and_doas/resources/OsLib_Schedules.rb
-- lib/measures/replace_simple_glazing/measure.rb
-- lib/measures/replace_simple_glazing/measure.xml
 - lib/measures/replace_water_heater_mixed_with_thermal_storage_chilled_water/LICENSE.md
 - lib/measures/replace_water_heater_mixed_with_thermal_storage_chilled_water/README.md
 - lib/measures/replace_water_heater_mixed_with_thermal_storage_chilled_water/README.md.erb
 - lib/measures/replace_water_heater_mixed_with_thermal_storage_chilled_water/measure.rb
 - lib/measures/replace_water_heater_mixed_with_thermal_storage_chilled_water/measure.xml
-- lib/measures/set_boiler_thermal_efficiency/measure.rb
-- lib/measures/set_boiler_thermal_efficiency/measure.xml
-- lib/measures/set_water_heater_efficiency_heat_lossand_peak_water_flow_rate/measure.rb
-- lib/measures/set_water_heater_efficiency_heat_lossand_peak_water_flow_rate/measure.xml
-- lib/measures/tenant_star_internal_loads/measure.rb
-- lib/measures/tenant_star_internal_loads/measure.xml
-- lib/measures/tenant_star_internal_loads/resources/os_lib_helper_methods.rb
-- lib/measures/vr_fwith_doas/measure.rb
-- lib/measures/vr_fwith_doas/measure.xml
-- lib/measures/vr_fwith_doas/resources/OsLib_AedgMeasures.rb
-- lib/measures/vr_fwith_doas/resources/OsLib_Constructions.rb
-- lib/measures/vr_fwith_doas/resources/OsLib_Geometry.rb
-- lib/measures/vr_fwith_doas/resources/OsLib_HVAC.rb
-- lib/measures/vr_fwith_doas/resources/OsLib_HelperMethods.rb
-- lib/measures/vr_fwith_doas/resources/OsLib_LightingAndEquipment.rb
-- lib/measures/vr_fwith_doas/resources/OsLib_Schedules.rb
 - lib/openstudio-ee-measures.rb
 - lib/openstudio/ee_measures.rb
 - lib/openstudio/ee_measures/extension.rb
@@ -278,8 +239,8 @@ licenses: []
 metadata:
   bug_tracker_uri: https://github.com/NREL/openstudio-ee-gem/issues
   changelog_uri: https://github.com/NREL/openstudio-ee-gem/blob/develop/CHANGELOG.md
-  source_code_uri: https://github.com/NREL/openstudio-ee-gem/tree/v0.2.1
-post_install_message:
+  source_code_uri: https://github.com/NREL/openstudio-ee-gem/tree/v0.3.0
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -294,9 +255,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
+rubyforge_project: 
 rubygems_version: 2.7.6.2
-signing_key:
+signing_key: 
 specification_version: 4
 summary: Library and measures for OpenStudio for energy efficiency use cases
 test_files: []

data/lib/measures/ImproveFanTotalEfficiencybyPercentage/measure.rb

@@ -1,333 +0,0 @@
-# frozen_string_literal: true
-
-# start the measure
-class ImproveFanTotalEfficiencybyPercentage < OpenStudio::Ruleset::ModelUserScript
-  # define the name that a user will see, this method may be deprecated as
-  # the display name in PAT comes from the name field in measure.xml
-  def name
-    return 'Improve Fan Total Efficiency by Percentage'
-  end
-
-  # define the arguments that the user will input
-  def arguments(model)
-    args = OpenStudio::Ruleset::OSArgumentVector.new
-
-    # populate choice argument for constructions that are applied to surfaces in the model
-    loop_handles = OpenStudio::StringVector.new
-    loop_display_names = OpenStudio::StringVector.new
-
-    # putting air loops and names into hash
-    loop_args = model.getAirLoopHVACs
-    loop_args_hash = {}
-    loop_args.each do |loop_arg|
-      loop_args_hash[loop_arg.name.to_s] = loop_arg
-    end
-
-    # looping through sorted hash of air loops
-    loop_args_hash.sort.map do |key, value|
-      show_loop = false
-      components = value.supplyComponents
-      components.each do |component|
-        if !component.to_FanConstantVolume.empty?
-          show_loop = true
-        end
-        if !component.to_FanVariableVolume.empty?
-          show_loop = true
-        end
-        if !component.to_FanOnOff.empty?
-          show_loop = true
-        end
-      end
-
-      # if loop as object of correct type then add to hash.
-      if show_loop == true
-        loop_handles << value.handle.to_s
-        loop_display_names << key
-      end
-    end
-
-    # add building to string vector with air loops
-    building = model.getBuilding
-    loop_handles << building.handle.to_s
-    loop_display_names << '*All Air Loops*'
-
-    # make an argument for air loops
-    object = OpenStudio::Ruleset::OSArgument.makeChoiceArgument('object', loop_handles, loop_display_names, true)
-    object.setDisplayName('Choose an Air Loop to Alter.')
-    object.setDefaultValue('*All Air Loops*') # if no loop is chosen this will run on all air loops
-    args << object
-
-    # TODO: - change this to choice list from design document
-    # make an argument to add new space true/false
-    motor_eff = OpenStudio::Ruleset::OSArgument.makeDoubleArgument('motor_eff', true)
-    motor_eff.setDisplayName('Fan Total Efficiency Improvement(%).')
-    motor_eff.setDefaultValue(3.0)
-    args << motor_eff
-
-    # bool argument to remove existing costs
-    remove_costs = OpenStudio::Ruleset::OSArgument.makeBoolArgument('remove_costs', true)
-    remove_costs.setDisplayName('Remove Baseline Costs From Effected Fans?')
-    remove_costs.setDefaultValue(false)
-    args << remove_costs
-
-    # make an argument for material and installation cost
-    material_cost = OpenStudio::Ruleset::OSArgument.makeDoubleArgument('material_cost', true)
-    material_cost.setDisplayName('Material and Installation Costs per Motor ($).')
-    material_cost.setDefaultValue(0.0)
-    args << material_cost
-
-    # make an argument for demolition cost
-    demolition_cost = OpenStudio::Ruleset::OSArgument.makeDoubleArgument('demolition_cost', true)
-    demolition_cost.setDisplayName('Demolition Costs per Motor ($).')
-    demolition_cost.setDefaultValue(0.0)
-    args << demolition_cost
-
-    # make an argument for duration in years until costs start
-    years_until_costs_start = OpenStudio::Ruleset::OSArgument.makeIntegerArgument('years_until_costs_start', true)
-    years_until_costs_start.setDisplayName('Years Until Costs Start (whole years).')
-    years_until_costs_start.setDefaultValue(0)
-    args << years_until_costs_start
-
-    # make an argument to determine if demolition costs should be included in initial construction
-    demo_cost_initial_const = OpenStudio::Ruleset::OSArgument.makeBoolArgument('demo_cost_initial_const', true)
-    demo_cost_initial_const.setDisplayName('Demolition Costs Occur During Initial Construction?')
-    demo_cost_initial_const.setDefaultValue(false)
-    args << demo_cost_initial_const
-
-    # make an argument for expected life
-    expected_life = OpenStudio::Ruleset::OSArgument.makeIntegerArgument('expected_life', true)
-    expected_life.setDisplayName('Expected Life (whole years).')
-    expected_life.setDefaultValue(20)
-    args << expected_life
-
-    # make an argument for o&m cost
-    om_cost = OpenStudio::Ruleset::OSArgument.makeDoubleArgument('om_cost', true)
-    om_cost.setDisplayName('O & M Costs per Motor ($).')
-    om_cost.setDefaultValue(0.0)
-    args << om_cost
-
-    # make an argument for o&m frequency
-    om_frequency = OpenStudio::Ruleset::OSArgument.makeIntegerArgument('om_frequency', true)
-    om_frequency.setDisplayName('O & M Frequency (whole years).')
-    om_frequency.setDefaultValue(1)
-    args << om_frequency
-
-    return args
-  end # end the arguments method
-
-  # define what happens when the measure is cop
-  def run(model, runner, user_arguments)
-    super(model, runner, user_arguments)
-
-    # use the built-in error checking
-    if !runner.validateUserArguments(arguments(model), user_arguments)
-      return false
-    end
-
-    # assign the user inputs to variables
-    object = runner.getOptionalWorkspaceObjectChoiceValue('object', user_arguments, model) # model is passed in because of argument type
-    motor_eff = runner.getDoubleArgumentValue('motor_eff', user_arguments)
-    remove_costs = runner.getBoolArgumentValue('remove_costs', user_arguments)
-    material_cost = runner.getDoubleArgumentValue('material_cost', user_arguments)
-    demolition_cost = runner.getDoubleArgumentValue('demolition_cost', user_arguments)
-    years_until_costs_start = runner.getIntegerArgumentValue('years_until_costs_start', user_arguments)
-    demo_cost_initial_const = runner.getBoolArgumentValue('demo_cost_initial_const', user_arguments)
-    expected_life = runner.getIntegerArgumentValue('expected_life', user_arguments)
-    om_cost = runner.getDoubleArgumentValue('om_cost', user_arguments)
-    om_frequency = runner.getIntegerArgumentValue('om_frequency', user_arguments)
-
-    # check the loop for reasonableness
-    apply_to_all_loops = false
-    loop = nil
-    if object.empty?
-      handle = runner.getStringArgumentValue('loop', user_arguments)
-      if handle.empty?
-        runner.registerError('No loop was chosen.')
-      else
-        runner.registerError("The selected loop with handle '#{handle}' was not found in the model. It may have been removed by another measure.")
-      end
-      return false
-    else
-      if !object.get.to_Loop.empty?
-        loop = object.get.to_Loop.get
-      elsif !object.get.to_Building.empty?
-        apply_to_all_loops = true
-      else
-        runner.registerError('Script Error - argument not showing up as loop.')
-        return false
-      end
-    end # end of if loop.empty?
-
-    # check the user_name for reasonableness
-    if (motor_eff <= 1) ||  (motor_eff >= 5)
-      runner.registerWarning('Requested motor efficiency improvement is not between expected values of 1% and 5%')
-    end
-    # motor efficiency will be checked motor by motor to see warn if higher than 0.96 and error if not between or equal to 0 and 1
-
-    # set flags to use later
-    costs_requested = false
-
-    # set values to use later
-    yr0_capital_totalCosts_baseline = 0
-    yr0_capital_totalCosts_proposed = 0
-
-    # If demo_cost_initial_const is true then will be applied once in the lifecycle. Future replacements use the demo cost of the new construction.
-    demo_costs_of_baseline_objects = 0
-
-    # check costs for reasonableness
-    if material_cost.abs + demolition_cost.abs + om_cost.abs == 0
-      runner.registerInfo('No costs were requested for motors improvements.')
-    else
-      costs_requested = true
-    end
-
-    # check lifecycle arguments for reasonableness
-    if (years_until_costs_start < 0) && (years_until_costs_start > expected_life)
-      runner.registerError('Years until costs start should be a non-negative integer less than Expected Life.')
-    end
-    if (expected_life < 1) && (expected_life > 100)
-      runner.registerError('Choose an integer greater than 0 and less than or equal to 100 for Expected Life.')
-    end
-    if om_frequency < 1
-      runner.registerError('Choose an integer greater than 0 for O & M Frequency.')
-    end
-
-    # short def to make numbers pretty (converts 4125001.25641 to 4,125,001.26 or 4,125,001). The definition be called through this measure
-    def neat_numbers(number, roundto = 2) # round to 0 or 2)
-      if roundto == 2
-        number = format '%.2f', number
-      else
-        number = number.round
-      end
-      # regex to add commas
-      number.to_s.reverse.gsub(/([0-9]{3}(?=([0-9])))/, '\\1,').reverse
-    end # end def neat_numbers
-
-    # helper that loops through lifecycle costs getting total costs under "Construction" or "Salvage" category and add to counter if occurs during year 0
-    def get_total_costs_for_objects(objects)
-      counter = 0
-      objects.each do |object|
-        object_LCCs = object.lifeCycleCosts
-        object_LCCs.each do |object_LCC|
-          if (object_LCC.category == 'Construction') || (object_LCC.category == 'Salvage')
-            if object_LCC.yearsFromStart == 0
-              counter += object_LCC.totalCost
-            end
-          end
-        end
-      end
-      return counter
-    end # end of def get_total_costs_for_objects(objects)
-
-    # get loops for measure
-    if apply_to_all_loops
-      loops = model.getAirLoopHVACs
-    else
-      loops = []
-      loops << loop # only run on a single space type
-    end
-
-    # get cop values
-    initial_motor_efficiency_values = []
-    missing_initial_motor_efficiency = 0
-
-    # loop through air loops
-    loops.each do |loop|
-      supply_components = loop.supplyComponents
-
-      # find fans on loop
-      supply_components.each do |supply_component|
-        hVACComponent = supply_component.to_FanConstantVolume
-        if hVACComponent.empty?
-          hVACComponent = supply_component.to_FanVariableVolume
-        end
-        if hVACComponent.empty?
-          hVACComponent = supply_component.to_FanOnOff
-        end
-
-        # alter components of correct type
-        if !hVACComponent.empty?
-          hVACComponent = hVACComponent.get
-
-          # change and report changes to fans and motors
-          initial_motor_efficiency = hVACComponent.fanEfficiency
-          target_motor_efficiency = initial_motor_efficiency + motor_eff * 0.01
-          initial_motor_efficiency_values << initial_motor_efficiency
-          if target_motor_efficiency > 1
-            hVACComponent.setFanEfficiency(1.0)
-            runner.registerWarning("Requested efficiency of #{target_motor_efficiency * 100}% for #{hVACComponent.name} is not possible. Setting motor efficiency to 100%.")
-          elsif target_motor_efficiency < 0
-            hVACComponent.setFanEfficiency(0.0)
-            runner.registerWarning("Requested efficiency of #{target_motor_efficiency * 100}% for #{hVACComponent.name} is not possible. Setting motor efficiency to 0%.")
-          else
-            hVACComponent.setFanEfficiency(target_motor_efficiency)
-            runner.registerInfo("Changing the motor efficiency from #{initial_motor_efficiency * 100}% to #{target_motor_efficiency * 100}% for '#{hVACComponent.name}' onloop '#{loop.name}.'")
-            if target_motor_efficiency > 0.96
-              runner.registerWarning("Requested efficiency for #{hVACComponent.name} is greater than 96%.")
-            end
-          end
-
-          # get initial year 0 cost
-          yr0_capital_totalCosts_baseline += get_total_costs_for_objects([hVACComponent])
-
-          # demo value of baseline costs associated with unit
-          demo_LCCs = hVACComponent.lifeCycleCosts
-          demo_LCCs.each do |demo_LCC|
-            if demo_LCC.category == 'Salvage'
-              demo_costs_of_baseline_objects += demo_LCC.totalCost
-            end
-          end
-
-          # remove all old costs
-          if !hVACComponent.lifeCycleCosts.empty? && (remove_costs == true)
-            runner.registerInfo("Removing existing lifecycle cost objects associated with #{hVACComponent.name}")
-            removed_costs = hVACComponent.removeLifeCycleCosts
-          end
-
-          # add new costs
-          if costs_requested == true
-
-            # adding new cost items
-            lcc_mat = OpenStudio::Model::LifeCycleCost.createLifeCycleCost("LCC_Mat - #{hVACComponent.name}", hVACComponent, material_cost, 'CostPerEach', 'Construction', expected_life, years_until_costs_start)
-            # cost for if demo_initial_Construction == true is added at the end of the measure
-            lcc_demo = OpenStudio::Model::LifeCycleCost.createLifeCycleCost("LCC_Demo - #{hVACComponent.name}", hVACComponent, demolition_cost, 'CostPerEach', 'Salvage', expected_life, years_until_costs_start + expected_life)
-            lcc_om = OpenStudio::Model::LifeCycleCost.createLifeCycleCost("LCC_OM - #{hVACComponent.name}", hVACComponent, om_cost, 'CostPerEach', 'Maintenance', om_frequency, 0)
-
-            # get final year 0 cost
-            yr0_capital_totalCosts_proposed += get_total_costs_for_objects([hVACComponent])
-
-          end # end of costs_requested == true
-
-        end # end if not hVACComponent.empty?
-      end # end supply_components.each do
-    end # end loops.each do
-
-    # add one time demo cost of removed windows if appropriate
-    if demo_cost_initial_const == true
-      building = model.getBuilding
-      lcc_baseline_demo = OpenStudio::Model::LifeCycleCost.createLifeCycleCost('LCC_baseline_demo', building, demo_costs_of_baseline_objects, 'CostPerEach', 'Salvage', 0, years_until_costs_start).get # using 0 for repeat period since one time cost.
-      runner.registerInfo("Adding one time cost of $#{neat_numbers(lcc_baseline_demo.totalCost, 0)} related to demolition of baseline objects.")
-
-      # if demo occurs on year 0 then add to initial capital cost counter
-      if lcc_baseline_demo.yearsFromStart == 0
-        yr0_capital_totalCosts_proposed += lcc_baseline_demo.totalCost
-      end
-    end
-
-    if initial_motor_efficiency_values.size + missing_initial_motor_efficiency == 0
-      runner.registerAsNotApplicable('The affected loop(s) does not contain any fans, the model will not be altered.')
-      return true
-    end
-
-    # reporting initial condition of model
-    runner.registerInitialCondition("The starting motor efficiency values in affected loop(s) range from #{initial_motor_efficiency_values.min * 100}% to #{initial_motor_efficiency_values.max * 100}%. Initial year 0 capital costs for affected fans is $#{neat_numbers(yr0_capital_totalCosts_baseline, 0)}.")
-
-    # reporting final condition of model
-    runner.registerFinalCondition("#{initial_motor_efficiency_values.size + missing_initial_motor_efficiency} fans had motor efficiency values set to altered. Final year 0 capital costs for affected fans is $#{neat_numbers(yr0_capital_totalCosts_proposed, 0)}.")
-
-    return true
-  end # end the cop method
-end # end the measure
-
-# this allows the measure to be used by the application
-ImproveFanTotalEfficiencybyPercentage.new.registerWithApplication