openstudio-ee 0.12.3 → 0.12.4

data/lib/measures/ReduceNightTimeLightingLoads/measure.rb

@@ -9,7 +9,7 @@
 class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
   # define the name that a user will see
   def name
-    return 'Reduce Night Time Lighting Loads'
+    'Reduce Night Time Lighting Loads'
   end
 
   # define the arguments that the user will input
@@ -29,14 +29,15 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
 
     # looping through sorted hash of load defs
     light_def_args_hash.sort.map do |key, value|
-      if !value.instances.empty?
+      unless value.instances.empty?
         lights_def_handles << value.handle.to_s
         lights_def_display_names << key
       end
     end
 
     # make an argument for lights definition
-    lights_def = OpenStudio::Measure::OSArgument.makeChoiceArgument('lights_def', lights_def_handles, lights_def_display_names)
+    lights_def = OpenStudio::Measure::OSArgument.makeChoiceArgument('lights_def', lights_def_handles,
+                                                                    lights_def_display_names)
     lights_def.setDisplayName('Pick a Lighting Definition From the Model (schedules using this will be altered)')
     args << lights_def
 
@@ -130,7 +131,7 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
     om_frequency.setDefaultValue(1)
     args << om_frequency
 
-    return args
+    args
   end
 
   # define what happens when the measure is run
@@ -138,9 +139,7 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
     super(model, runner, user_arguments)
 
     # use the built-in error checking
-    if !runner.validateUserArguments(arguments(model), user_arguments)
-      return false
-    end
+    return false unless runner.validateUserArguments(arguments(model), user_arguments)
 
     # assign the user inputs to variables
     lights_def = runner.getOptionalWorkspaceObjectChoiceValue('lights_def', user_arguments, model)
@@ -169,13 +168,11 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
         runner.registerError("A Lighting Definition with handle '#{lights_def}' was not found in the model. It may have been removed by another measure.")
       end
       return false
+    elsif !lights_def.get.to_LightsDefinition.empty?
+      lights_def = lights_def.get.to_LightsDefinition.get
     else
-      if !lights_def.get.to_LightsDefinition.empty?
-        lights_def = lights_def.get.to_LightsDefinition.get
-      else
-        runner.registerError('Script Error - argument not showing up as lights definition.')
-        return false
-      end
+      runner.registerError('Script Error - argument not showing up as lights definition.')
+      return false
     end
 
     # check the fraction for reasonableness
@@ -294,17 +291,15 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
     if (expected_life < 1) && (expected_life > 100)
       runner.registerError('Choose an integer greater than 0 and less than or equal to 100 for Expected Life.')
     end
-    if om_frequency < 1
-      runner.registerError('Choose an integer greater than 0 for O & M Frequency.')
-    end
+    runner.registerError('Choose an integer greater than 0 for O & M Frequency.') if om_frequency < 1
 
     # short def to make numbers pretty (converts 4125001.25641 to 4,125,001.26 or 4,125,001). The definition be called through this measure
     def neat_numbers(number, roundto = 2) # round to 0 or 2)
-      if roundto == 2
-        number = format '%.2f', number
-      else
-        number = number.round
-      end
+      number = if roundto == 2
+                 format '%.2f', number
+               else
+                 number.round
+               end
       # regex to add commas
       number.to_s.reverse.gsub(/([0-9]{3}(?=([0-9])))/, '\\1,').reverse
     end
@@ -328,12 +323,13 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
     # get schedules for lights instances that user the picked
     lighting_instances.each do |light|
       next unless light.lightsDefinition == lights_def
+
       lighting_instances_using_def << light
-      if !light.schedule.empty?
-        lights_sch = light.schedule.get
-        lights_schs[lights_sch.name.to_s] = lights_sch
-        lights_sch_names << lights_sch.name.to_s
-      end
+      next if light.schedule.empty?
+
+      lights_sch = light.schedule.get
+      lights_schs[lights_sch.name.to_s] = lights_sch
+      lights_sch_names << lights_sch.name.to_s
     end
 
     # reporting initial condition of model
@@ -343,7 +339,9 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
     # and reducing schedule fraction before and after the specified times
     lights_sch_names.uniq.each do |lights_sch_name|
       lights_sch = lights_schs[lights_sch_name]
-      if !lights_sch.to_ScheduleRuleset.empty?
+      if lights_sch.to_ScheduleRuleset.empty?
+        runner.registerWarning("Schedule '#{lights_sch_name}' isn't a ScheduleRuleset object and won't be altered by this measure.")
+      else
         new_lights_sch = lights_sch.clone(model).to_ScheduleRuleset.get
         new_lights_sch.setName("#{lights_sch_name} NightLightingControl")
         reduced_lights_schs[lights_sch_name] = new_lights_sch
@@ -392,14 +390,16 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
         if new_lights_sch.scheduleRules.empty?
           runner.registerWarning("Schedule '#{new_lights_sch.name}' applies to all days.  It has been treated as a Weekday schedule.")
         end
-        reduce_schedule(new_lights_sch.defaultDaySchedule, wk_before_hour, wk_before_min, wk_before_value, wk_after_hour, wk_after_min, wk_after_value)
+        reduce_schedule(new_lights_sch.defaultDaySchedule, wk_before_hour, wk_before_min, wk_before_value,
+                        wk_after_hour, wk_after_min, wk_after_value)
 
         # reduce weekdays
         new_lights_sch.scheduleRules.each do |sch_rule|
-          if apply_weekday
-            if sch_rule.applyMonday || sch_rule.applyTuesday || sch_rule.applyWednesday || sch_rule.applyThursday || sch_rule.applyFriday
-              reduce_schedule(sch_rule.daySchedule, wk_before_hour, wk_before_min, wk_before_value, wk_after_hour, wk_after_min, wk_after_value)
-            end
+          next unless apply_weekday
+
+          if sch_rule.applyMonday || sch_rule.applyTuesday || sch_rule.applyWednesday || sch_rule.applyThursday || sch_rule.applyFriday
+            reduce_schedule(sch_rule.daySchedule, wk_before_hour, wk_before_min, wk_before_value, wk_after_hour,
+                            wk_after_min, wk_after_value)
           end
         end
 
@@ -409,7 +409,8 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
             if sch_rule.applyMonday || sch_rule.applyTuesday || sch_rule.applyWednesday || sch_rule.applyThursday || sch_rule.applyFriday
               runner.registerWarning("Rule '#{sch_rule.name}' for schedule '#{new_lights_sch.name}' applies to both Saturdays and Weekdays.  It has been treated as a Weekday schedule.")
             else
-              reduce_schedule(sch_rule.daySchedule, sat_before_hour, sat_before_min, sat_before_value, sat_after_hour, sat_after_min, sat_after_value)
+              reduce_schedule(sch_rule.daySchedule, sat_before_hour, sat_before_min, sat_before_value, sat_after_hour,
+                              sat_after_min, sat_after_value)
             end
           end
         end
@@ -422,13 +423,12 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
             elsif sch_rule.applySaturday
               runner.registerWarning("Rule '#{sch_rule.name}' for schedule '#{new_lights_sch.name}' applies to both Saturdays and Sundays.  It has been  treated as a Saturday schedule.")
             else
-              reduce_schedule(sch_rule.daySchedule, sun_before_hour, sun_before_min, sun_before_value, sun_after_hour, sun_after_min, sun_after_value)
+              reduce_schedule(sch_rule.daySchedule, sun_before_hour, sun_before_min, sun_before_value, sun_after_hour,
+                              sun_after_min, sun_after_value)
             end
           end
         end
 
-      else
-        runner.registerWarning("Schedule '#{lights_sch_name}' isn't a ScheduleRuleset object and won't be altered by this measure.")
       end
     end
 
@@ -446,9 +446,7 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
     end
 
     # na if no schedules to change
-    if lights_sch_names.uniq.empty?
-      runner.registerNotAsApplicable('There are no schedules to change.')
-    end
+    runner.registerNotAsApplicable('There are no schedules to change.') if lights_sch_names.uniq.empty?
 
     measure_cost = 0
 
@@ -457,15 +455,19 @@ class ReduceNightTimeLightingLoads < OpenStudio::Measure::ModelMeasure
     if costs_requested == true
       quantity = lights_def.quantity
       # adding new cost items
-      lcc_mat = OpenStudio::Model::LifeCycleCost.createLifeCycleCost("LCC_Mat - #{lights_def.name} night reduction", building, material_cost * quantity, 'CostPerEach', 'Construction', expected_life, years_until_costs_start)
-      lcc_om = OpenStudio::Model::LifeCycleCost.createLifeCycleCost("LCC_OM - #{lights_def.name} night reduction", building, om_cost * quantity, 'CostPerEach', 'Maintenance', om_frequency, 0)
+      lcc_mat = OpenStudio::Model::LifeCycleCost.createLifeCycleCost("LCC_Mat - #{lights_def.name} night reduction",
+                                                                     building, material_cost * quantity, 'CostPerEach', 'Construction', expected_life, years_until_costs_start)
+      lcc_om = OpenStudio::Model::LifeCycleCost.createLifeCycleCost("LCC_OM - #{lights_def.name} night reduction",
+                                                                    building, om_cost * quantity, 'CostPerEach', 'Maintenance', om_frequency, 0)
       measure_cost = material_cost * quantity
     end
 
     # reporting final condition of model
-    runner.registerFinalCondition("#{lights_sch_names.uniq.size} schedule(s) were edited. The cost for the measure is #{neat_numbers(measure_cost, 0)}.")
+    runner.registerFinalCondition("#{lights_sch_names.uniq.size} schedule(s) were edited. The cost for the measure is #{neat_numbers(
+      measure_cost, 0
+    )}.")
 
-    return true
+    true
   end
 end
 

data/lib/measures/ReduceNightTimeLightingLoads/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.1</schema_version>
   <name>reduce_night_time_lighting_loads</name>
   <uid>acce8fde-a5d7-4c27-af89-28327132bafa</uid>
-  <version_id>3058c4c5-c326-4929-90d7-57e2b4e4d988</version_id>
-  <version_modified>2025-08-08T15:15:58Z</version_modified>
+  <version_id>64d7f496-fa8e-409f-9e9a-9a69c3a0022f</version_id>
+  <version_modified>2025-09-25T15:33:44Z</version_modified>
   <xml_checksum>0AC58119</xml_checksum>
   <class_name>ReduceNightTimeLightingLoads</class_name>
   <display_name>Reduce Night Time Lighting Loads</display_name>
@@ -224,7 +224,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>2641F702</checksum>
+      <checksum>A5407321</checksum>
     </file>
     <file>
       <filename>EnvelopeAndLoadTestModel_01.osm</filename>
@@ -236,7 +236,7 @@
       <filename>ReduceNightTimeLightingLoads_Test.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>926E0720</checksum>
+      <checksum>4CB3E9CB</checksum>
     </file>
   </files>
 </measure>

data/lib/measures/ReduceSpaceInfiltrationByPercentage/measure.rb

@@ -19,17 +19,17 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
   # define the name that a user will see, this method may be deprecated as
   # the display name in PAT comes from the name field in measure.xml
   def name
-    return 'ReduceSpaceInfiltrationByPercentage'
+    'ReduceSpaceInfiltrationByPercentage'
   end
 
   # human readable description
   def description
-    return 'This measure will reduce space infiltration rates by the requested percentage. A cost per square foot of building area can be added to the model.'
+    'This measure will reduce space infiltration rates by the requested percentage. A cost per square foot of building area can be added to the model.'
   end
 
   # human readable description of modeling approach
   def modeler_description
-    return 'This can be run across a space type or the entire building. Costs will be associated with the building. If infiltration objects are removed at a later date, the costs will remain.'
+    'This can be run across a space type or the entire building. Costs will be associated with the building. If infiltration objects are removed at a later date, the costs will remain.'
   end
 
   # define the arguments that the user will input
@@ -50,7 +50,7 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     # looping through sorted hash of model objects
     space_type_args_hash.sort.map do |key, value|
       # only include if space type is used in the model
-      if !value.spaces.empty?
+      unless value.spaces.empty?
         space_type_handles << value.handle.to_s
         space_type_display_names << key
       end
@@ -62,13 +62,16 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     space_type_display_names << '*Entire Building*'
 
     # make a choice argument for space type
-    space_type = OpenStudio::Measure::OSArgument.makeChoiceArgument('space_type', space_type_handles, space_type_display_names)
+    space_type = OpenStudio::Measure::OSArgument.makeChoiceArgument('space_type', space_type_handles,
+                                                                    space_type_display_names)
     space_type.setDisplayName('Apply the Measure to a Specific Space Type or to the Entire Model.')
     space_type.setDefaultValue('*Entire Building*') # if no space type is chosen this will run on the entire building
     args << space_type
 
     # make an argument for reduction percentage
-    space_infiltration_reduction_percent = OpenStudio::Measure::OSArgument.makeDoubleArgument('space_infiltration_reduction_percent', true)
+    space_infiltration_reduction_percent = OpenStudio::Measure::OSArgument.makeDoubleArgument(
+      'space_infiltration_reduction_percent', true
+    )
     space_infiltration_reduction_percent.setDisplayName('Space Infiltration Power Reduction')
     space_infiltration_reduction_percent.setDefaultValue(30.0)
     space_infiltration_reduction_percent.setUnits('%')
@@ -93,7 +96,9 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     args << wind_speed_coefficient
 
     # make an argument for wind_speed_squared_coefficient
-    wind_speed_squared_coefficient = OpenStudio::Measure::OSArgument.makeDoubleArgument('wind_speed_squared_coefficient', true)
+    wind_speed_squared_coefficient = OpenStudio::Measure::OSArgument.makeDoubleArgument(
+      'wind_speed_squared_coefficient', true
+    )
     wind_speed_squared_coefficient.setDisplayName('Wind Speed Squared Coefficient')
     wind_speed_squared_coefficient.setDefaultValue(0.0)
     args << wind_speed_squared_coefficient
@@ -106,7 +111,9 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     args << alter_coef
 
     # make an argument for material and installation cost
-    material_and_installation_cost = OpenStudio::Measure::OSArgument.makeDoubleArgument('material_and_installation_cost', true)
+    material_and_installation_cost = OpenStudio::Measure::OSArgument.makeDoubleArgument(
+      'material_and_installation_cost', true
+    )
     material_and_installation_cost.setDisplayName('Increase in Material and Installation Costs for Building per Affected Floor Area')
     material_and_installation_cost.setDefaultValue(0.0)
     material_and_installation_cost.setUnits('$/ft^2')
@@ -126,7 +133,7 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     om_frequency.setUnits('whole years')
     args << om_frequency
 
-    return args
+    args
   end
 
   # define what happens when the measure is run
@@ -134,13 +141,12 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     super(model, runner, user_arguments)
 
     # use the built-in error checking
-    if !runner.validateUserArguments(arguments(model), user_arguments)
-      return false
-    end
+    return false unless runner.validateUserArguments(arguments(model), user_arguments)
 
     # assign the user inputs to variables
     object = runner.getOptionalWorkspaceObjectChoiceValue('space_type', user_arguments, model)
-    space_infiltration_reduction_percent = runner.getDoubleArgumentValue('space_infiltration_reduction_percent', user_arguments)
+    space_infiltration_reduction_percent = runner.getDoubleArgumentValue('space_infiltration_reduction_percent',
+                                                                         user_arguments)
     constant_coefficient = runner.getDoubleArgumentValue('constant_coefficient', user_arguments)
     temperature_coefficient = runner.getDoubleArgumentValue('temperature_coefficient', user_arguments)
     wind_speed_coefficient = runner.getDoubleArgumentValue('wind_speed_coefficient', user_arguments)
@@ -161,15 +167,13 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
         runner.registerError("The selected space type with handle '#{handle}' was not found in the model. It may have been removed by another measure.")
       end
       return false
+    elsif !object.get.to_SpaceType.empty?
+      space_type = object.get.to_SpaceType.get
+    elsif !object.get.to_Building.empty?
+      apply_to_building = true
     else
-      if !object.get.to_SpaceType.empty?
-        space_type = object.get.to_SpaceType.get
-      elsif !object.get.to_Building.empty?
-        apply_to_building = true
-      else
-        runner.registerError('Script Error - argument not showing up as space type or building.')
-        return false
-      end
+      runner.registerError('Script Error - argument not showing up as space type or building.')
+      return false
     end
 
     # check the space_infiltration_reduction_percent and for reasonableness
@@ -188,17 +192,15 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
 
     # TODO: - currently not checking for negative $/ft^2 for material_and_installation_cost and om_cost, confirm if E+ will allow negative cost
 
-    if om_frequency < 1
-      runner.registerError('Choose an integer greater than 0 for O & M Frequency.')
-    end
+    runner.registerError('Choose an integer greater than 0 for O & M Frequency.') if om_frequency < 1
 
     # helper to make numbers pretty (converts 4125001.25641 to 4,125,001.26 or 4,125,001). The definition be called through this measure.
     def neat_numbers(number, roundto = 2) # round to 0 or 2)
-      if roundto == 2
-        number = format '%.2f', number
-      else
-        number = number.round
-      end
+      number = if roundto == 2
+                 format '%.2f', number
+               else
+                 number.round
+               end
       # regex to add commas
       number.to_s.reverse.gsub(/([0-9]{3}(?=([0-9])))/, '\\1,').reverse
     end
@@ -212,10 +214,10 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     affected_area_si = 0
 
     # reporting initial condition of model
-    if !space_infiltration_objects.empty?
-      runner.registerInitialCondition("The initial model contained #{space_infiltration_objects.size} space infiltration objects.")
-    else
+    if space_infiltration_objects.empty?
       runner.registerInitialCondition('The initial model did not contain any space infiltration objects.')
+    else
+      runner.registerInitialCondition("The initial model contained #{space_infiltration_objects.size} space infiltration objects.")
     end
 
     # get space types in model
@@ -230,39 +232,42 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     end
 
     # def to alter performance and life cycle costs of objects
-    def alter_performance(object, space_infiltration_reduction_percent, constant_coefficient, temperature_coefficient, wind_speed_coefficient, wind_speed_squared_coefficient, alter_coef, runner)
+    def alter_performance(object, space_infiltration_reduction_percent, constant_coefficient, temperature_coefficient,
+                          wind_speed_coefficient, wind_speed_squared_coefficient, alter_coef, runner)
       # edit instance based on percentage reduction
       instance = object
       if !instance.designFlowRate.empty?
-        new_infiltration_design_flow_rate = instance.setDesignFlowRate(instance.designFlowRate.get - instance.designFlowRate.get * space_infiltration_reduction_percent * 0.01)
+        new_infiltration_design_flow_rate = instance.setDesignFlowRate(instance.designFlowRate.get - (instance.designFlowRate.get * space_infiltration_reduction_percent * 0.01))
       elsif !instance.flowperSpaceFloorArea.empty?
-        new_infiltration_flow_floor_area = instance.setFlowperSpaceFloorArea(instance.flowperSpaceFloorArea.get - instance.flowperSpaceFloorArea.get * space_infiltration_reduction_percent * 0.01)
+        new_infiltration_flow_floor_area = instance.setFlowperSpaceFloorArea(instance.flowperSpaceFloorArea.get - (instance.flowperSpaceFloorArea.get * space_infiltration_reduction_percent * 0.01))
       elsif !instance.flowperExteriorSurfaceArea.empty?
-        new_infiltration_flow_ext_area = instance.setFlowperExteriorSurfaceArea(instance.flowperExteriorSurfaceArea.get - instance.flowperExteriorSurfaceArea.get * space_infiltration_reduction_percent * 0.01)
+        new_infiltration_flow_ext_area = instance.setFlowperExteriorSurfaceArea(instance.flowperExteriorSurfaceArea.get - (instance.flowperExteriorSurfaceArea.get * space_infiltration_reduction_percent * 0.01))
       elsif !instance.flowperExteriorWallArea.empty?
-        new_infiltration_flow_ext_area = instance.setFlowperExteriorWallArea(instance.flowperExteriorWallArea.get - instance.flowperExteriorWallArea.get * space_infiltration_reduction_percent * 0.01)
+        new_infiltration_flow_ext_area = instance.setFlowperExteriorWallArea(instance.flowperExteriorWallArea.get - (instance.flowperExteriorWallArea.get * space_infiltration_reduction_percent * 0.01))
       elsif !instance.airChangesperHour.empty?
-        new_infiltration_ach = instance.setAirChangesperHour(instance.airChangesperHour.get - instance.airChangesperHour.get * space_infiltration_reduction_percent * 0.01)
+        new_infiltration_ach = instance.setAirChangesperHour(instance.airChangesperHour.get - (instance.airChangesperHour.get * space_infiltration_reduction_percent * 0.01))
       else
         runner.registerWarning("'#{instance.name}' is used by one or more instances and has no load values.")
       end
 
       # only alter coefficients if requested
-      if alter_coef
-        instance.setConstantTermCoefficient(constant_coefficient)
-        instance.setTemperatureTermCoefficient(temperature_coefficient)
-        instance.setVelocityTermCoefficient(wind_speed_coefficient)
-        instance.setVelocitySquaredTermCoefficient(wind_speed_squared_coefficient)
-      end
+      return unless alter_coef
+
+      instance.setConstantTermCoefficient(constant_coefficient)
+      instance.setTemperatureTermCoefficient(temperature_coefficient)
+      instance.setVelocityTermCoefficient(wind_speed_coefficient)
+      instance.setVelocitySquaredTermCoefficient(wind_speed_squared_coefficient)
     end
 
     # loop through space types
     space_types.each do |space_type|
       next if space_type.spaces.size <= 0
+
       space_type_infiltration_objects = space_type.spaceInfiltrationDesignFlowRates
       space_type_infiltration_objects.each do |space_type_infiltration_object|
         # call def to alter performance and life cycle costs
-        alter_performance(space_type_infiltration_object, space_infiltration_reduction_percent, constant_coefficient, temperature_coefficient, wind_speed_coefficient, wind_speed_squared_coefficient, alter_coef, runner)
+        alter_performance(space_type_infiltration_object, space_infiltration_reduction_percent, constant_coefficient,
+                          temperature_coefficient, wind_speed_coefficient, wind_speed_squared_coefficient, alter_coef, runner)
 
         # rename
         updated_instance_name = space_type_infiltration_object.setName("#{space_type_infiltration_object.name} #{space_infiltration_reduction_percent} percent reduction")
@@ -276,17 +281,16 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     # get space types in model
     if apply_to_building
       spaces = model.getSpaces
-    else
-      if !space_type.spaces.empty?
-        spaces = space_type.spaces # only run on a single space type
-      end
+    elsif !space_type.spaces.empty?
+      spaces = space_type.spaces
     end
 
     spaces.each do |space|
       space_infiltration_objects = space.spaceInfiltrationDesignFlowRates
       space_infiltration_objects.each do |space_infiltration_object|
         # call def to alter performance and life cycle costs
-        alter_performance(space_infiltration_object, space_infiltration_reduction_percent, constant_coefficient, temperature_coefficient, wind_speed_coefficient, wind_speed_squared_coefficient, alter_coef, runner)
+        alter_performance(space_infiltration_object, space_infiltration_reduction_percent, constant_coefficient,
+                          temperature_coefficient, wind_speed_coefficient, wind_speed_squared_coefficient, alter_coef, runner)
 
         # rename
         updated_instance_name = space_infiltration_object.setName("#{space_infiltration_object.name} #{space_infiltration_reduction_percent} percent reduction")
@@ -311,9 +315,11 @@ class ReduceSpaceInfiltrationByPercentage < OpenStudio::Measure::ModelMeasure
     end
 
     # report final condition
-    runner.registerFinalCondition("#{altered_instances} space infiltration objects in the model were altered affecting #{neat_numbers(affected_area_ip, 0)}(ft^2) at a total cost of $#{neat_numbers(final_cost, 0)}.")
+    runner.registerFinalCondition("#{altered_instances} space infiltration objects in the model were altered affecting #{neat_numbers(
+      affected_area_ip, 0
+    )}(ft^2) at a total cost of $#{neat_numbers(final_cost, 0)}.")
 
-    return true
+    true
   end
 end
 

data/lib/measures/ReduceSpaceInfiltrationByPercentage/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.1</schema_version>
   <name>reduce_space_infiltration_by_percentage</name>
   <uid>6e9de4b1-aa97-4010-80c8-529e53ffe943</uid>
-  <version_id>f3a4891c-715f-4736-a1a5-3b1cbddbe343</version_id>
-  <version_modified>2025-08-08T15:15:56Z</version_modified>
+  <version_id>b1bd09e1-4ba1-4759-b642-65dfa8bcf283</version_id>
+  <version_modified>2025-09-25T15:33:42Z</version_modified>
   <xml_checksum>EACB548E</xml_checksum>
   <class_name>ReduceSpaceInfiltrationByPercentage</class_name>
   <display_name>ReduceSpaceInfiltrationByPercentage</display_name>
@@ -17,10 +17,10 @@
       <type>Choice</type>
       <required>true</required>
       <model_dependent>false</model_dependent>
-      <default_value>{e9970f4e-07dd-433b-adc1-e7dedcd762b3}</default_value>
+      <default_value>{873fd05a-3dff-4e05-80d4-59a5b492c31f}</default_value>
       <choices>
         <choice>
-          <value>{e9970f4e-07dd-433b-adc1-e7dedcd762b3}</value>
+          <value>{873fd05a-3dff-4e05-80d4-59a5b492c31f}</value>
           <display_name>*Entire Building*</display_name>
         </choice>
       </choices>
@@ -158,7 +158,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>F7F6B0AE</checksum>
+      <checksum>155D496B</checksum>
     </file>
     <file>
       <filename>EnvelopeAndLoadTestModel_01.osm</filename>
@@ -176,7 +176,7 @@
       <filename>ReduceSpaceInfiltrationByPercentage_Test.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>9F83F933</checksum>
+      <checksum>E9669F9A</checksum>
     </file>
   </files>
 </measure>