openstudio-aws 0.7.0.alpha0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5fb9aaca2642160b5eac43e603457fd77c65d4a2
-  data.tar.gz: 3b400a0863047b7032d8e5d6e11be3e53358e9e8
+  metadata.gz: 3a8f166aa5280130c5e02e2bbca8e7916c5a4f18
+  data.tar.gz: 44e37969328af52966ae23f81a8ee47da2ce006e
 SHA512:
-  metadata.gz: 37303ed113a04f581b786e30071afc8a66313dd8fe9cc1adb5df85ff1f4cb0a8c7f7813ba62040674a2feb521d8d1770952dd6377f40c6f4775204e2055e834c
-  data.tar.gz: 6220220f3210530359bdda6a1b8823d776ac123383a705b39bfe4d6265af74233da098e407dc2ac58b6f729c2fcd2e383efe06c6b02299aca4c05434c514dcb7
+  metadata.gz: e3af181f0922fc772948ad6010d40390c654e1f8d04efe688802ea74fd72778f0fa987473990cc2029746446c3a8358b1d05948d50adb677f729d07fd9dc7b68
+  data.tar.gz: 44de6b22099110cda2aced58100800adc3d9a0881cc1b4999cea68544afdefb224a19c43cc696d77903a2c0f0c56fa7b492e90e74e1040bea6e0344812374eca

data/.gitignore

@@ -19,3 +19,5 @@ spec/output
 *.pem
 *.pub
 *.config
+.rubocop-http*
+gems

data/.rubocop.yml

@@ -1,133 +1,10 @@
 AllCops:
   Exclude:
     - 'doc/**/*'
+    - 'gems/**/*'
 
-# ==================== Linters ====================
-Lint/AmbiguousOperator:
-  Enabled: true
-
-Lint/BlockAlignment:
-  Enabled: true
-
-Lint/ParenthesesAsGroupedExpression:
-  Enabled: true
-
-Lint/RequireParentheses:
-  Enabled: true
-
-# Offense count: 1
-Lint/UnreachableCode:
-  Enabled: false
-
-# Offense count: 51
-Lint/UselessAssignment:
-  Enabled: true
-
-# ==================== Styles / Metrics====================
-# Offense count: 4
-Metrics/BlockNesting:
-  Max: 4
-
-# Offense count: 18
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 500
-
-# Offense count: 27
-Metrics/CyclomaticComplexity:
-  Max: 48
-
-# Offense count: 974
-Metrics/LineLength:
-  Max: 1200
-
-# Offense count: 87
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 350
-
-# Offense count: 1
-# Configuration parameters: CountKeywordArgs.
-Metrics/ParameterLists:
-  Max: 8
-
-# ==================== Disabled on Purpose ====================
-# Offense count: 3
-Style/AccessorMethodName:
-  Enabled: true
-
-# Need to allow indented case statements
-# Offense count: 9
-# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep.
-Style/CaseIndentation:
-  Enabled: false
-
-# Offense count: 18
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-# Offense count: 2
-Style/ClassVars:
-  Enabled: false
-
-# Offense count: 42
-Style/Documentation:
+Security/YAMLLoad:
   Enabled: false
 
-# Offense count: 1
-Style/EachWithObject:
-  Enabled: false
-
-# Offense count: 2
-# Configuration parameters: AllowedVariables.
-Style/GlobalVars:
-  Enabled: false
-
-# Offense count: 7
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: true
-
-# Offense count: 17
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
-  Enabled: false
-
-# Do NOT enable.  For some reason this is catchy any next which I feel are okay.
-# Offense count: 18
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/Next:
-  Enabled: false
-
-# Do NOT enable this because it appears $? is different than $CHILD_STATUS.
-# Offense count: 7
-# Cop supports --auto-correct.
-Style/SpecialGlobalVars:
-  Enabled: false
-
-# More Changes per DLM -- pulled from https://github.com/bbatsov/rubocop/blob/master/config/enabled.yml
-Style/RedundantReturn:
-  Description: 'Do not use return where it is not required.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-explicit-return'
-  Enabled: false
-
-Style/NumericLiterals:
-  Description: 'Add underscores to large numeric literals to improve readability.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscores-in-numerics'
-  Enabled: false
-
-Lint/UnusedBlockArgument:
-  Description: 'Checks for unused block arguments.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars'
-  Enabled: false
-
-Lint/UnusedMethodArgument:
-  Description: 'Checks for unused method arguments.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars'
-  Enabled: false
-
-Lint/UselessAssignment:
-  Description: 'Checks for useless assignment to a local variable.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars'
-  Enabled: false
+inherit_from:
+  - http://s3.amazonaws.com/openstudio-resources/styles/rubocop.yml

data/.travis.yml

@@ -1,6 +1,5 @@
 language: ruby
 rvm:
-  - 2.1.7
-  - 2.0.0
+  - 2.2.4
 script:
   - bundle exec rake spec:no_auth

data/CHANGELOG.md

@@ -1,6 +1,16 @@
 OpenStudio AWS Gem Change Log
 ==================================
 
+
+Version 0.7.0
+-------------
+* Fix worker off by one bug
+* Update Net SSH and Net SCP
+
+Version 0.5 - 0.6
+-----------------
+* These releases did not include change logs
+
 Version 0.4.2
 -------------
 * Fix net-ssh to 3.0.2 because newer version caused infinite loop

data/Gemfile

@@ -3,8 +3,8 @@ source 'http://rubygems.org'
 gemspec
 
 group :test do
-  gem 'rspec', '~> 3.3'
   gem 'ci_reporter_rspec'
-  gem 'rubocop', '~> 0.31'
+  gem 'rspec', '~> 3.8.0'
+  gem 'rubocop', '~> 0.68.1'
   gem 'rubocop-checkstyle_formatter', '~> 0.2'
 end

data/Rakefile

@@ -1,3 +1,38 @@
+# *******************************************************************************
+# OpenStudio(R), Copyright (c) 2008-2019, Alliance for Sustainable Energy, LLC.
+# All rights reserved.
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# (1) Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# (2) Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# (3) Neither the name of the copyright holder nor the names of any contributors
+# may be used to endorse or promote products derived from this software without
+# specific prior written permission from the respective party.
+#
+# (4) Other than as required in clauses (1) and (2), distributions in any form
+# of modifications or other derivative works may not use the "OpenStudio"
+# trademark, "OS", "os", or any other confusingly similar designation without
+# specific prior written permission from Alliance for Sustainable Energy, LLC.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER, THE UNITED STATES
+# GOVERNMENT, OR ANY CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+# LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
+# EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# *******************************************************************************
+
 require 'bundler'
 Bundler.setup
 
@@ -10,21 +45,21 @@ require 'ci/reporter/rake/rspec'
 # Gem tasks
 require 'bundler/gem_tasks'
 
-$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('lib', __dir__)
 require 'openstudio-aws'
 
 RSpec::Core::RakeTask.new('spec') do |spec|
-  spec.rspec_opts = %w(--format progress --format CI::Reporter::RSpec)
+  spec.rspec_opts = ['--format', 'progress', '--format', 'CI::Reporter::RSpec']
   spec.pattern = 'spec/**/*_spec.rb'
 end
 
 RSpec::Core::RakeTask.new('spec:api') do |spec|
-  spec.rspec_opts = %w(--format progress --format CI::Reporter::RSpec)
+  spec.rspec_opts = ['--format', 'progress', '--format', 'CI::Reporter::RSpec']
   spec.pattern = 'spec/**/*_spec_api.rb'
 end
 
 RSpec::Core::RakeTask.new('spec:no_auth') do |spec|
-  spec.rspec_opts = %w(--format progress --format CI::Reporter::RSpec)
+  spec.rspec_opts = ['--format', 'progress', '--format', 'CI::Reporter::RSpec']
 
   file_list = FileList['spec/**/*_spec.rb']
   file_list = file_list.exclude('spec/**/aws_wrapper_spec.rb')

data/lib/openstudio/aws/aws.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2016, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2019, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -40,7 +40,7 @@ module OpenStudio
       :proxy, :credentials, :ami_lookup_version, :openstudio_version,
       :openstudio_server_version, :region, :ssl_verify_peer, :host, :url, :stable,
       :save_directory, :subnet_id
-    ]
+    ].freeze
 
     class Aws
       include Logging
@@ -64,7 +64,7 @@ module OpenStudio
       def initialize(options = {})
         invalid_options = options.keys - VALID_OPTIONS
         if invalid_options.any?
-          fail ArgumentError, "invalid option(s): #{invalid_options.join(', ')}"
+          raise ArgumentError, "invalid option(s): #{invalid_options.join(', ')}"
         end
 
         # merge in some defaults
@@ -87,12 +87,12 @@ module OpenStudio
 
           # populate the credentials
           options[:credentials] =
-              {
-                access_key_id: config_file.access_key,
-                secret_access_key: config_file.secret_key,
-                region: options[:region],
-                ssl_verify_peer: options[:ssl_verify_peer]
-              }
+            {
+              access_key_id: config_file.access_key,
+              secret_access_key: config_file.secret_key,
+              region: options[:region],
+              ssl_verify_peer: options[:ssl_verify_peer]
+            }
         else
           options[:credentials][:region] = options[:region]
           options[:credentials][:ssl_verify_peer] = options[:ssl_verify_peer]
@@ -111,7 +111,7 @@ module OpenStudio
         @os_aws = OpenStudioAwsWrapper.new(options)
         @os_cloudwatch = OpenStudioCloudWatch.new(options)
 
-        @dockerized = options[:ami_lookup_version] == 3 ? true : false
+        @dockerized = options[:ami_lookup_version] == 3
 
         # this will grab the default version of openstudio ami versions
         # get the arugments for the AMI lookup
@@ -157,14 +157,14 @@ module OpenStudio
         end
 
         if options[:aws_key_pair_name]
-          fail 'Must pass in the private_key_file_name' unless options[:private_key_file_name]
-          fail "Private key was not found: #{options[:private_key_file_name]}" unless File.exist? options[:private_key_file_name]
+          raise 'Must pass in the private_key_file_name' unless options[:private_key_file_name]
+          raise "Private key was not found: #{options[:private_key_file_name]}" unless File.exist? options[:private_key_file_name]
         end
 
         if options[:security_groups].empty?
           # if the user has not specified any security groups, then create one called: 'openstudio-server-sg-v2'
           @os_aws.create_or_retrieve_default_security_group(tmp_name = 'openstudio-server-sg-v2.2',
-                                                            vpc_id=options[:vpc_id])
+                                                            vpc_id = options[:vpc_id])
         else
           @os_aws.security_groups = options[:security_groups]
         end
@@ -232,7 +232,8 @@ module OpenStudio
           options[:image_id] = determine_image_type(options[:instance_type])
         end
 
-        fail "Can't create workers without a server instance running" if @os_aws.server.nil?
+        raise "Can't create workers without a server instance running" if @os_aws.server.nil?
+
         user_data_file = @dockerized ? 'worker_script.sh.docker.template' : 'worker_script.sh.template'
 
         unless number_of_instances == 0
@@ -259,8 +260,8 @@ module OpenStudio
           else
             @os_aws.configure_server_and_workers
           end
-        rescue => e
-          fail "Configuring the cluster failed with error `#{e.message}` in:\n#{e.backtrace.join('\n')}"
+        rescue StandardError => e
+          raise "Configuring the cluster failed with error `#{e.message}` in:\n#{e.backtrace.join('\n')}"
         end
       end
 
@@ -272,7 +273,7 @@ module OpenStudio
         puts ''
         puts 'Server SSH Command:'
         puts "ssh -i #{@os_aws.private_key_file_name} ubuntu@#{@os_aws.server.data[:dns]}"
-        if @os_aws.workers.size > 0
+        if !@os_aws.workers.empty?
           puts ''
           puts 'Worker SSH Command:'
           @os_aws.workers.each do |worker|
@@ -402,7 +403,7 @@ module OpenStudio
 
       # Warning, it appears that this terminates all the instances
       def terminate_instances_by_group_id(group_id)
-        fail 'Group ID not defined' unless group_id
+        raise 'Group ID not defined' unless group_id
 
         instances = @os_aws.describe_running_instances(group_id)
         logger.info instances
@@ -423,7 +424,7 @@ module OpenStudio
       end
 
       def load_instance_info_from_file(filename)
-        fail 'Could not find instance description JSON file' unless File.exist? filename
+        raise 'Could not find instance description JSON file' unless File.exist? filename
 
         h = JSON.parse(File.read(filename), symbolize_names: true)
         if h[:location] == 'AWS'
@@ -444,10 +445,12 @@ module OpenStudio
       def upload_file(server_or_workers, local_file, remote_file)
         case server_or_workers
           when :server
-            fail 'Server node is nil' unless @os_aws.server
+            raise 'Server node is nil' unless @os_aws.server
+
             return @os_aws.server.upload_file(local_file, remote_file)
           when :worker
-            fail 'Worker list is empty' if @os_aws.workers.empty?
+            raise 'Worker list is empty' if @os_aws.workers.empty?
+
             return @os_aws.workers.each { |w| w.upload_file(local_file, remote_file) }
         end
       end
@@ -455,10 +458,12 @@ module OpenStudio
       def shell_command(server_or_workers, command, load_env = true)
         case server_or_workers
           when :server
-            fail 'Server node is nil' unless @os_aws.server
+            raise 'Server node is nil' unless @os_aws.server
+
             return @os_aws.server.shell_command(command, load_env)
           when :worker
-            fail 'Worker list is empty' if @os_aws.workers.empty?
+            raise 'Worker list is empty' if @os_aws.workers.empty?
+
             return @os_aws.workers.each { |w| w.shell_command(command, load_env) }
         end
       end
@@ -468,10 +473,11 @@ module OpenStudio
       def download_remote_file(server_or_workers, remote_file, local_file)
         case server_or_workers
           when :server
-            fail 'Server node is nil' unless @os_aws.server
+            raise 'Server node is nil' unless @os_aws.server
+
             return @os_aws.server.download_file(remote_file, local_file)
           when :worker
-            fail 'Worker file download is not available'
+            raise 'Worker file download is not available'
         end
       end
 
@@ -498,7 +504,7 @@ module OpenStudio
       def os_aws_file_location
         # Get the location of the os-aws.rb file.  Use the relative path from where this file exists
         os_aws_file = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib', 'os-aws.rb'))
-        fail "os_aws_file does not exist where it is expected: #{os_aws_file}" unless File.exist?(os_aws_file)
+        raise "os_aws_file does not exist where it is expected: #{os_aws_file}" unless File.exist?(os_aws_file)
 
         os_aws_file
       end

data/lib/openstudio/aws/config.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2016, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2019, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -59,7 +59,7 @@ module OpenStudio
 
           unless File.exist?(@yml_config_file)
             write_config_file
-            fail "Config file not found. A template has been added, please edit and save: #{@yml_config_file}"
+            raise "Config file not found. A template has been added, please edit and save: #{@yml_config_file}"
             exit 1
           end
 
@@ -71,7 +71,7 @@ module OpenStudio
 
             @access_key = @config[:access_key_id]
             @secret_key = @config[:secret_access_key]
-          rescue
+          rescue StandardError
             raise "Couldn't read config file #{@yml_config_file}. Delete file then recreate by rerunning script"
           end
         end

data/lib/openstudio/aws/version.rb

@@ -1,5 +1,40 @@
+# *******************************************************************************
+# OpenStudio(R), Copyright (c) 2008-2019, Alliance for Sustainable Energy, LLC.
+# All rights reserved.
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# (1) Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# (2) Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# (3) Neither the name of the copyright holder nor the names of any contributors
+# may be used to endorse or promote products derived from this software without
+# specific prior written permission from the respective party.
+#
+# (4) Other than as required in clauses (1) and (2), distributions in any form
+# of modifications or other derivative works may not use the "OpenStudio"
+# trademark, "OS", "os", or any other confusingly similar designation without
+# specific prior written permission from Alliance for Sustainable Energy, LLC.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER, THE UNITED STATES
+# GOVERNMENT, OR ANY CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+# LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
+# EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# *******************************************************************************
+
 module OpenStudio
   module Aws
-    VERSION = '0.7.0.alpha0'
+    VERSION = '0.7.0'.freeze
   end
 end

data/lib/openstudio/core_ext/hash.rb

@@ -1,3 +1,38 @@
+# *******************************************************************************
+# OpenStudio(R), Copyright (c) 2008-2019, Alliance for Sustainable Energy, LLC.
+# All rights reserved.
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# (1) Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# (2) Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# (3) Neither the name of the copyright holder nor the names of any contributors
+# may be used to endorse or promote products derived from this software without
+# specific prior written permission from the respective party.
+#
+# (4) Other than as required in clauses (1) and (2), distributions in any form
+# of modifications or other derivative works may not use the "OpenStudio"
+# trademark, "OS", "os", or any other confusingly similar designation without
+# specific prior written permission from Alliance for Sustainable Energy, LLC.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER, THE UNITED STATES
+# GOVERNMENT, OR ANY CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+# LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
+# EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# *******************************************************************************
+
 # From: https://github.com/rails/rails/blob/001b270611cd9cb653124775899bdbc2548333ab/activesupport/lib/active_support/core_ext/hash/except.rb
 class Hash
   # Returns a hash that includes everything but the given keys.

data/lib/openstudio/lib/ami_list.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2016, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2019, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -40,7 +40,7 @@ class OpenStudioAmis
 
   VALID_OPTIONS = [
     :openstudio_version, :openstudio_server_version, :host, :url, :stable
-  ]
+  ].freeze
 
   # Initializer for listing the AMIs and grabbing the correct version of the AMIs based on the OpenStudio version or
   # OpenStudio Server version.
@@ -52,11 +52,11 @@ class OpenStudioAmis
   def initialize(version = 1, options = {})
     invalid_options = options.keys - VALID_OPTIONS
     if invalid_options.any?
-      fail ArgumentError, "invalid option(s): #{invalid_options.join(', ')}"
+      raise ArgumentError, "invalid option(s): #{invalid_options.join(', ')}"
     end
 
     if options[:openstudio_version] && options[:openstudio_server_version]
-      fail 'Must pass only an openstudio_version or openstudio_server_version when looking up AMIs'
+      raise 'Must pass only an openstudio_version or openstudio_server_version when looking up AMIs'
     end
 
     # merge in some defaults
@@ -73,7 +73,7 @@ class OpenStudioAmis
     @options = defaults.merge(options)
 
     if @options[:openstudio_version] != 'default' && @options[:openstudio_server_version] != 'default'
-      fail 'Must pass either the openstudio_version or openstudio_server_version when looking up AMIs, not both'
+      raise 'Must pass either the openstudio_version or openstudio_server_version when looking up AMIs, not both'
     end
   end
 
@@ -100,10 +100,10 @@ class OpenStudioAmis
     if OpenStudioAmis.method_defined?(command)
       amis = send(command)
     else
-      fail "Unknown api version command #{command}"
+      raise "Unknown api version command #{command}"
     end
 
-    fail "Could not find any amis for #{@version}" if amis.nil?
+    raise "Could not find any amis for #{@version}" if amis.nil?
 
     amis
   end
@@ -141,8 +141,10 @@ class OpenStudioAmis
           value = json[:openstudio_server][stable.to_sym]
           amis = value[:amis]
         else
-          logger.info "Could not find a stable version for OpenStudio version #{@options[:openstudio_version]}. "\
-                      'Looking up older versions to find the latest stable.' unless stable
+          unless stable
+            logger.info "Could not find a stable version for OpenStudio version #{@options[:openstudio_version]}. "\
+                        'Looking up older versions to find the latest stable.'
+          end
 
           json[:openstudio].each do |os_version, values|
             next if os_version == :default
@@ -160,12 +162,13 @@ class OpenStudioAmis
             end
           end
 
-          fail "Could not find a stable version for openstudio version #{@options[:openstudio_version]}" unless amis
+          raise "Could not find a stable version for openstudio version #{@options[:openstudio_version]}" unless amis
         end
       else
         # return the default version (which is the latest)
         default = json[:openstudio][@options[:openstudio_version].to_sym][:default]
-        fail "Could not find a default version for openstudio version #{@options[:openstudio_version]}" unless default
+        raise "Could not find a default version for openstudio version #{@options[:openstudio_version]}" unless default
+
         value = json[:openstudio][@options[:openstudio_version].to_sym][default.to_sym]
         amis = value[:amis]
       end
@@ -189,14 +192,16 @@ class OpenStudioAmis
     elsif @options[:openstudio_server_version] != 'default'
       hash_array = json[:builds]
       hash = hash_array.select { |hash| hash[:name] == @options[:openstudio_server_version] }
-      fail "Multiple | no entries found matching name key `#{@options[:openstudio_server_version]}`" unless hash.length == 1
+      raise "Multiple | no entries found matching name key `#{@options[:openstudio_server_version]}`" unless hash.length == 1
+
       amis = {}
       amis[:server] = hash.first[:ami]
       amis[:worker] = hash.first[:ami]
     elsif @options[:openstudio_version] != 'default'
-      fail 'Currently the openstudio_version lookup is not supported in v3.'
+      raise 'Currently the openstudio_version lookup is not supported in v3.'
     end
-    fail 'The requested AMI key is NULL.' if amis[:server] == nil
+    raise 'The requested AMI key is NULL.' if amis[:server].nil?
+
     logger.info "AMI IDs are #{amis}" if amis
 
     amis
@@ -207,7 +212,7 @@ class OpenStudioAmis
   # fetch the URL with redirects
   def fetch(uri_str, limit = 10)
     # You should choose better exception.
-    fail ArgumentError, 'HTTP redirect too deep' if limit == 0
+    raise ArgumentError, 'HTTP redirect too deep' if limit == 0
 
     url = URI.parse(uri_str)
     req = Net::HTTP::Get.new(url.path)
@@ -229,7 +234,7 @@ class OpenStudioAmis
     if resp.code == '200'
       result = JSON.parse(resp.body, symbolize_names: true)
     else
-      fail "#{resp.code} Unable to download AMI IDs"
+      raise "#{resp.code} Unable to download AMI IDs"
     end
 
     result