openstax_utilities 4.0.0 → 4.1.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NjczMjZiNWYzMjljMzM4ZjMyM2FlYjg2MGMxNzhlZDUxODNiOWY1MQ==
-  data.tar.gz: !binary |-
-    ZDMzZDg3N2E2MzRmZjYzNDIxYjA5YjNiOTNmYjBkODllNjM1ODE0ZA==
+SHA1:
+  metadata.gz: 5f74a54eb979770038bb0b7a22dd9ab49c7d0bd7
+  data.tar.gz: 24be3a1eba292de415db675f55c93fcb127bf693
 SHA512:
-  metadata.gz: !binary |-
-    NzA2YTc4MGI1ZDhjZmU0ZWVlMzc3YzAzMDBlMGZjMzZjODE4NDNjZGNlNzRj
-    YTNkYzU0NDA2YTgzOWUxNTkxZWEzYjZmODAxNDRkOTc0MDZjNzVlMGMwYzYy
-    ZGY0NzQxMGI2ZTJkNWNhMzI3ZGRhOWYwYjRkZDdkNTYzMGQwMWI=
-  data.tar.gz: !binary |-
-    MzZiN2YyYzBmMTRhOTMzNDFkNTA2MWZiY2JlZDFmZWVmNGJhZGJiN2YwYmM3
-    OGUzYThkOGIxMTQ1ZmY1MDljNTQ5NTZlNTVjNWVlZmQ4N2ZlNGUyM2E0NDg4
-    NGQxMDM1ZWMyNzYwNmFiNWY4MTE1M2VmYjI4YjVkZjM3NGE3NDA=
+  metadata.gz: 3cd0d23114ea4b34234afab28e67ee749af4150a50510fc85c12ec740a10a45518be29405ca8a350ee713eda378850e205394207d3d09ee74ae4c68ab6fac132
+  data.tar.gz: 77855c34ee526501c39e723164036aa2af493cb473fb4f7c68b481795844641ca6170ed8da1f39a5c6b5a15cdd99bd42ebce9b5d7f379823330f2209bc6598e8

data/app/handlers/openstax/utilities/{abstract_keyword_search_handler.rb → keyword_search_handler.rb}

@@ -5,12 +5,12 @@
 # Values are comma-separated, while keywords are space-separated
 # See https://github.com/bruce/keyword_search for more information
 #
-# Subclasses must set the search_routine class variable,
-# as well as the authorized? method
+# Callers must pass the search_routine and search_relation options:
 #
 # Required:
 #
-#   search_routine - the Lev::Routine that will handle the search
+#   search_routine  - the Lev::Routine that will handle the search
+#   search_relation - the ActiveRecord::Relation that will be searched
 #
 # Optional (recommended to prevent scraping):
 #
@@ -19,13 +19,13 @@
 #                    than the minimum number of characters allowed
 #                    default: nil (disabled)
 #
-#   max_items - the maximum number of matching items allowed to be returned
-#               no results will be returned if this number is exceeded,
-#               but the total result count will still be returned
-#               applies even if pagination is enabled
-#               default: nil (disabled)
+#   max_items      - the maximum number of matching items allowed to be returned
+#                    no results will be returned if this number is exceeded,
+#                    but the total result count will still be returned
+#                    applies even if pagination is enabled
+#                    default: nil (disabled)
 #
-# This handler expects the following parameters from the user or the UI:
+# This handler also expects the following parameters from the user or the UI:
 #
 # Required:
 #
@@ -50,35 +50,38 @@ require 'lev'
 
 module OpenStax
   module Utilities
-    class AbstractKeywordSearchHandler
+    class KeywordSearchHandler
 
       lev_handler
 
       protected
 
-      class_attribute :search_routine, :max_items, :min_characters
-
       def authorized?
-        false
+        routine = options[:search_routine]
+        relation = options[:search_relation]
+        raise ArgumentError if routine.nil? || relation.nil?
+        OSU::AccessPolicy.action_allowed?(:search, caller, relation.base_class)
       end
 
       def handle
-        raise NotImplementedError if search_routine.nil?
-
-        query = params[:q] || params[:query]
-
-        fatal_error(code: :no_query,
+        query = params[:q]
+        fatal_error(code: :query_blank,
                     message: 'You must provide a query parameter (q or query).') if query.nil?
+
+        min_characters = options[:min_characters]
         fatal_error(code: :query_too_short,
                     message: "The provided query is too short (minimum #{
                       min_characters} characters).") \
           if !min_characters.nil? && query.length < min_characters
 
-        items = run(search_routine, query, params).outputs[:items]
+        routine = options[:search_routine]
+        relation = options[:search_relation]
+        items = run(routine, relation, query, params).outputs[:items]
 
         outputs[:total_count] = items.limit(nil).offset(nil).count
 
-        fatal_error(code: :too_many_matches,
+        max_items = options[:max_items]
+        fatal_error(code: :too_many_items,
                     message: "The number of matches exceeded the allowed limit of #{
                       max_items} matches. Please refine your query and try again.") \
           if !max_items.nil? && outputs[:total_count] > max_items

data/app/routines/openstax/utilities/abstract_keyword_search_routine.rb

@@ -5,17 +5,14 @@
 # Values are comma-separated, while keywords are space-separated
 # See https://github.com/bruce/keyword_search for more information
 #
-# Subclasses must set the initial_relation, search_proc and sortable_fields class variables
-#
-#   initial_relation - the ActiveRecord::Relation that contains all
-#                      records to be searched, usually ClassName.unscoped
+# Subclasses must set the search_proc and sortable_fields class variables
 #
 #   search_proc - a proc passed to keyword_search's `search` method
 #                 it receives keyword_search's `with` object as argument
 #                 this proc must define the `keyword` blocks for keyword_search
 #                 the relation to be scoped is contained in the @items instance variable
-#
-#   The `to_string_array` helper can help with parsing strings from the query
+#                 the `to_string_array` helper can help with
+#                 parsing strings from the query
 #
 #   sortable_fields_map - a Hash that maps the lowercase names of fields
 #                         which can be used to sort the results to symbols
@@ -24,11 +21,16 @@
 #                         in options[:order_by]
 #                         values are the corresponding database column names
 #                         that will be passed to the order() method
+#                         columns from other tables can be specified either
+#                         through Arel attributes (Class.arel_table[:column])
+#                         or through literal strings
 #
-# Callers of subclass routines provides a query argument and an options hash
+# Callers of subclass routines provide a relation argument,
+# a query argument and an options hash
 #
 # Required arguments:
 #
+#   relation - the initial relation to start searching on
 #   query - a string that follows the keyword format above
 #
 # Options hash:
@@ -37,7 +39,7 @@
 #
 #       :order_by - list of fields to sort by, with optional sort directions
 #                   can be a String, Array of Strings or Array of Hashes
-#                   default: {"created_at" => :asc}
+#                   default: {:created_at => :asc}
 #
 #     Pagination:
 #
@@ -66,15 +68,15 @@ module OpenStax
 
       protected
 
-      class_attribute :initial_relation, :search_proc, :sortable_fields_map
+      class_attribute :search_proc, :sortable_fields_map
 
-      def exec(query, options = {})
-        raise NotImplementedError if initial_relation.nil? || \
-          search_proc.nil? || sortable_fields_map.nil?
+      def exec(relation, query, options = {})
+        raise NotImplementedError if search_proc.nil? || sortable_fields_map.nil?
 
-        @items = initial_relation
+        raise ArgumentError \
+          unless relation.is_a?(ActiveRecord::Relation) && query.is_a?(String)
 
-        return @items.none unless query.is_a? String
+        @items = relation
 
         # Scoping
 
@@ -101,7 +103,14 @@ module OpenStax
       def sanitize_order_by(field, dir = nil)
         sanitized_field = sortable_fields_map[field.to_s.downcase] || :created_at
         sanitized_dir = dir.to_s.downcase == 'desc' ? :desc : :asc
-        {sanitized_field => sanitized_dir}
+        case sanitized_field
+        when Symbol
+          {sanitized_field => sanitized_dir}
+        when Arel::Attributes::Attribute
+          sanitized_field.send sanitized_dir
+        else
+          "#{sanitized_field.to_s} #{sanitized_dir.to_s.upcase}"
+        end
       end
 
       def sanitize_order_bys(order_bys)

data/lib/openstax/utilities/version.rb

@@ -1,5 +1,5 @@
 module OpenStax
   module Utilities
-    VERSION = "4.0.0"
+    VERSION = "4.1.0"
   end
 end

data/spec/dummy/app/access_policies/dummy_access_policy.rb

@@ -7,4 +7,4 @@ class DummyAccessPolicy
     @@last_resource = resource
     true
   end
-end
+end

data/spec/dummy/app/routines/search_users.rb

@@ -1,7 +1,6 @@
 # Dummy routine for testing the general keyword search
 
 class SearchUsers < OpenStax::Utilities::AbstractKeywordSearchRoutine
-  self.initial_relation = User.unscoped
   self.search_proc = lambda { |with|
     with.keyword :username do |names|
       snames = to_string_array(names, append_wildcard: true)

data/spec/dummy/config/initializers/access_policies.rb

@@ -0,0 +1 @@
+OSU::AccessPolicy.register(User, DummyAccessPolicy)

data/spec/handlers/openstax/utilities/{abstract_keyword_search_handler_spec.rb → keyword_search_handler_spec.rb}

@@ -2,9 +2,15 @@ require 'rails_helper'
 
 module OpenStax
   module Utilities
-    describe AbstractKeywordSearchHandler do
+    describe KeywordSearchHandler do
 
-      let!(:users_search) { UsersSearch.new }
+      options = {
+        caller: FactoryGirl.create(:user),
+        search_routine: SearchUsers,
+        search_relation: User.unscoped,
+        max_items: 10,
+        min_characters: 3
+      }
 
       let!(:john_doe) { FactoryGirl.create :user, name: "John Doe",
                                            username: "doejohn",
@@ -22,12 +28,20 @@ module OpenStax
         100.times do
           FactoryGirl.create(:user)
         end
+
+        DummyAccessPolicy.last_action = nil
+        DummyAccessPolicy.last_requestor = nil
+        DummyAccessPolicy.last_resource = nil
       end
 
       it "passes its params to the search routine and sets the total_count output" do
-        outputs = users_search.call(params: {q: 'username:dOe'}).outputs
+        outputs = KeywordSearchHandler.call(options.merge(
+                                              params: {q: 'username:dOe'})).outputs
         total_count = outputs[:total_count]
         items = outputs[:items]
+        expect(DummyAccessPolicy.last_action).to eq :search
+        expect(DummyAccessPolicy.last_requestor).to eq options[:caller]
+        expect(DummyAccessPolicy.last_resource).to eq User
         expect(total_count).to eq items.count
         expect(items).to include(john_doe)
         expect(items).to include(jane_doe)
@@ -41,10 +55,17 @@ module OpenStax
           expect(item.username).to match(/\Adoe[\w]*\z/i)
         end
 
-        outputs = users_search.call(params: {order_by: 'cReAtEd_At DeSc, iD dEsC',
-                                             q: 'username:DoE'}).outputs
+        DummyAccessPolicy.last_action = nil
+        DummyAccessPolicy.last_requestor = nil
+        DummyAccessPolicy.last_resource = nil
+        outputs = KeywordSearchHandler.call(options.merge(
+                                              params: {order_by: 'cReAtEd_At DeSc, iD dEsC',
+                                                     q: 'username:DoE'})).outputs
         total_count = outputs[:total_count]
         items = outputs[:items]
+        expect(DummyAccessPolicy.last_action).to eq :search
+        expect(DummyAccessPolicy.last_requestor).to eq options[:caller]
+        expect(DummyAccessPolicy.last_resource).to eq User
         expect(total_count).to eq items.count
         expect(items).to include(john_doe)
         expect(items).to include(jane_doe)
@@ -60,32 +81,44 @@ module OpenStax
       end
 
       it "errors out if no query is provided" do
-        routine = users_search.call(params: {})
+        routine = KeywordSearchHandler.call(options.merge(params: {}))
         outputs = routine.outputs
         errors = routine.errors
+        expect(DummyAccessPolicy.last_action).to eq :search
+        expect(DummyAccessPolicy.last_requestor).to eq options[:caller]
+        expect(DummyAccessPolicy.last_resource).to eq User
         expect(outputs).to be_empty
         expect(errors).not_to be_empty
-        expect(errors.first.code).to eq :no_query
+        expect(errors.first.code).to eq :query_blank
       end
 
       it "errors out if the query is too short" do
-        routine = users_search.call(params: {q: 'a'})
+        routine = KeywordSearchHandler.call(options.merge(params: {q: 'a'}))
         outputs = routine.outputs
         errors = routine.errors
+        expect(DummyAccessPolicy.last_action).to eq :search
+        expect(DummyAccessPolicy.last_requestor).to eq options[:caller]
+        expect(DummyAccessPolicy.last_resource).to eq User
         expect(outputs).to be_empty
         expect(errors).not_to be_empty
         expect(errors.first.code).to eq :query_too_short
       end
 
       it "errors out if too many items match" do
-        routine = users_search.call(params: {q: 'username:a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,r,s,t,u,v,w,x,y,z,0,1,2,3,4,5,6,7,8,9,-,_'})
+        routine = KeywordSearchHandler.call(options.merge(
+                                              params: {
+                                                q: 'username:a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,r,s,t,u,v,w,x,y,z,0,1,2,3,4,5,6,7,8,9,-,_'
+                                              }))
         outputs = routine.outputs
         errors = routine.errors
+        expect(DummyAccessPolicy.last_action).to eq :search
+        expect(DummyAccessPolicy.last_requestor).to eq options[:caller]
+        expect(DummyAccessPolicy.last_resource).to eq User
         expect(outputs).not_to be_empty
         expect(outputs[:total_count]).to eq User.count
         expect(outputs[:items]).to be_nil
         expect(errors).not_to be_empty
-        expect(errors.first.code).to eq :too_many_matches
+        expect(errors.first.code).to eq :too_many_items
       end
 
     end

data/spec/routines/openstax/utilities/abstract_keyword_search_routine_spec.rb

@@ -23,7 +23,7 @@ module OpenStax
       end
 
       it "filters results based on one field" do
-        items = SearchUsers.call('last_name:dOe').outputs[:items]
+        items = SearchUsers.call(User.unscoped, 'last_name:dOe').outputs[:items]
 
         expect(items).to include(john_doe)
         expect(items).to include(jane_doe)
@@ -34,7 +34,8 @@ module OpenStax
       end
 
       it "filters results based on multiple fields" do
-        items = SearchUsers.call('first_name:jOhN last_name:DoE').outputs[:items]
+        items = SearchUsers.call(User.unscoped, 'first_name:jOhN last_name:DoE')
+                           .outputs[:items]
 
         expect(items).to include(john_doe)
         expect(items).not_to include(jane_doe)
@@ -45,7 +46,8 @@ module OpenStax
       end
 
       it "filters results based on multiple keywords per field" do
-        items = SearchUsers.call('first_name:JoHn,JaNe last_name:dOe').outputs[:items]
+        items = SearchUsers.call(User.unscoped, 'first_name:JoHn,JaNe last_name:dOe')
+                           .outputs[:items]
 
         expect(items).to include(john_doe)
         expect(items).to include(jane_doe)
@@ -55,8 +57,21 @@ module OpenStax
         end
       end
 
+      it "filters scoped results" do
+        items = SearchUsers.call(User.where{name.like 'jOhN%'},
+                                 'last_name:dOe').outputs[:items]
+
+        expect(items).to include(john_doe)
+        expect(items).not_to include(jane_doe)
+        expect(items).not_to include(jack_doe)
+        items.each do |item|
+          expect(item.name.downcase).to match(/\Ajohn[\w]* doe[\w]*\z/i)
+        end
+      end
+
       it "orders results by multiple fields in different directions" do
-        items = SearchUsers.call('username:DoE', order_by: 'cReAtEd_At AsC, iD')
+        items = SearchUsers.call(User.unscoped, 'username:DoE',
+                                 order_by: 'cReAtEd_At AsC, iD')
                           .outputs[:items]
         expect(items).to include(john_doe)
         expect(items).to include(jane_doe)
@@ -70,7 +85,8 @@ module OpenStax
           expect(item.username).to match(/\Adoe[\w]*\z/i)
         end
 
-        items = SearchUsers.call('username:dOe', order_by: 'CrEaTeD_aT dEsC, Id DeSc')
+        items = SearchUsers.call(User.unscoped, 'username:dOe',
+                                 order_by: 'CrEaTeD_aT dEsC, Id DeSc')
                           .outputs[:items]
         expect(items).to include(john_doe)
         expect(items).to include(jane_doe)
@@ -86,23 +102,25 @@ module OpenStax
       end
 
       it "paginates results" do
-        all_items = SearchUsers.call('').outputs[:items].to_a
+        all_items = SearchUsers.call(User.unscoped, '').outputs[:items].to_a
 
-        items = SearchUsers.call('', per_page: 20).outputs[:items]
+        items = SearchUsers.call(User.unscoped, '', per_page: 20).outputs[:items]
         expect(items.limit(nil).offset(nil).count).to eq all_items.count
         expect(items.limit(nil).offset(nil).to_a).to eq all_items
         expect(items.count).to eq 20
         expect(items.to_a).to eq all_items[0..19]
 
         for page in 1..5
-          items = SearchUsers.call('', page: page, per_page: 20).outputs[:items]
+          items = SearchUsers.call(User.unscoped, '', page: page, per_page: 20)
+                             .outputs[:items]
           expect(items.limit(nil).offset(nil).count).to eq all_items.count
           expect(items.limit(nil).offset(nil).to_a).to eq all_items
           expect(items.count).to eq 20
           expect(items.to_a).to eq all_items.slice(20*(page-1), 20)
         end
 
-        items = SearchUsers.call('', page: 1000, per_page: 20).outputs[:items]
+        items = SearchUsers.call(User.unscoped, '', page: 1000, per_page: 20)
+                           .outputs[:items]
         expect(items.limit(nil).offset(nil).count).to eq all_items.count
         expect(items.limit(nil).offset(nil).to_a).to eq all_items
         expect(items.count).to eq 0

metadata

@@ -1,125 +1,125 @@
 --- !ruby/object:Gem::Specification
 name: openstax_utilities
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.1.0
 platform: ruby
 authors:
 - JP Slavinsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-07 00:00:00.000000000 Z
+date: 2014-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: lev
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: keyword_search
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: factory_girl_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: squeel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Shared utilities for OpenStax web sites
@@ -132,7 +132,7 @@ files:
 - MIT-LICENSE
 - README.md
 - Rakefile
-- app/handlers/openstax/utilities/abstract_keyword_search_handler.rb
+- app/handlers/openstax/utilities/keyword_search_handler.rb
 - app/routines/openstax/utilities/abstract_keyword_search_routine.rb
 - app/views/osu/shared/_action_list.html.erb
 - lib/openstax/utilities/access.rb
@@ -162,7 +162,6 @@ files:
 - spec/dummy/app/assets/javascripts/application.js
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
-- spec/dummy/app/handlers/users_search.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/models/user.rb
 - spec/dummy/app/routines/search_users.rb
@@ -178,6 +177,7 @@ files:
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb
 - spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/access_policies.rb
 - spec/dummy/config/initializers/assets.rb
 - spec/dummy/config/initializers/backtrace_silencers.rb
 - spec/dummy/config/initializers/cookies_serializer.rb
@@ -196,7 +196,7 @@ files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/factories/user.rb
-- spec/handlers/openstax/utilities/abstract_keyword_search_handler_spec.rb
+- spec/handlers/openstax/utilities/keyword_search_handler_spec.rb
 - spec/lib/openstax/utilities/access_policy_spec.rb
 - spec/rails_helper.rb
 - spec/routines/openstax/utilities/abstract_keyword_search_routine_spec.rb
@@ -211,17 +211,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Utilities for OpenStax web sites
@@ -230,7 +230,6 @@ test_files:
 - spec/dummy/app/assets/javascripts/application.js
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
-- spec/dummy/app/handlers/users_search.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/models/user.rb
 - spec/dummy/app/routines/search_users.rb
@@ -245,6 +244,7 @@ test_files:
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb
 - spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/access_policies.rb
 - spec/dummy/config/initializers/assets.rb
 - spec/dummy/config/initializers/backtrace_silencers.rb
 - spec/dummy/config/initializers/cookies_serializer.rb
@@ -266,7 +266,7 @@ test_files:
 - spec/dummy/Rakefile
 - spec/dummy/README.md
 - spec/factories/user.rb
-- spec/handlers/openstax/utilities/abstract_keyword_search_handler_spec.rb
+- spec/handlers/openstax/utilities/keyword_search_handler_spec.rb
 - spec/lib/openstax/utilities/access_policy_spec.rb
 - spec/rails_helper.rb
 - spec/routines/openstax/utilities/abstract_keyword_search_routine_spec.rb

data/spec/dummy/app/handlers/users_search.rb

@@ -1,11 +0,0 @@
-# Dummy handler for testing the general keyword search
-
-class UsersSearch < OpenStax::Utilities::AbstractKeywordSearchHandler
-  self.search_routine = SearchUsers
-  self.max_items = 10
-  self.min_characters = 3
-
-  def authorized?
-    true
-  end
-end