openstax_salesforce 0.11.0 → 0.12.0

data/spec/factories/user.rb

@@ -0,0 +1,17 @@
+FactoryGirl.define do
+  factory :user, class: 'OpenStax::Salesforce::User' do
+    uid           { SecureRandom.hex(10) }
+    name          { Faker::Name.name }
+    oauth_token   { SecureRandom.hex }
+    refresh_token { SecureRandom.hex }
+    instance_url  { Faker::Internet.url }
+
+    transient do
+      do_not_destroy_others false
+    end
+
+    after(:build) do |user, evaluator|
+      user.define_singleton_method(:ensure_only_one_record) {} if evaluator.do_not_destroy_others
+    end
+  end
+end

data/spec/openstax/salesforce/controllers/application_controller_spec.rb

@@ -0,0 +1,22 @@
+require 'rails_helper'
+
+RSpec.describe OpenStax::Salesforce::ApplicationController, type: :controller do
+
+  controller do
+    def index
+      render :text => "Yo"
+    end
+  end
+
+  it 'has forbidden status by default' do
+    get :index
+    expect(response).to have_http_status(:forbidden)
+  end
+
+  it 'can have its admin check overridden' do
+    mock_admin_user
+    get :index
+    expect(response).to have_http_status(:success)
+  end
+
+end

data/spec/openstax/salesforce/controllers/settings_controller_spec.rb

@@ -0,0 +1,86 @@
+require 'rails_helper'
+
+RSpec.describe OpenStax::Salesforce::SettingsController, type: :controller do
+
+  context 'as admin' do
+    before(:each) { mock_admin_user }
+
+    context '#callback' do
+      context 'when there is not yet a SF user' do
+        it 'adds a user' do
+          allow_any_instance_of(described_class)
+            .to receive(:env)
+            .and_return(omniauth_env_hash)
+
+          expect{post :callback}.to change {OpenStax::Salesforce::User.count}.by(1)
+        end
+      end
+
+      context 'when there are other SF users' do
+        it 'adds a user and removes existing users' do
+          other_user_1 = FactoryGirl.create(:user, do_not_destroy_others: true)
+          other_user_2 = FactoryGirl.create(:user, do_not_destroy_others: true)
+
+          allow_any_instance_of(described_class)
+            .to receive(:env)
+            .and_return(omniauth_env_hash)
+
+          expect{post :callback}.to change {OpenStax::Salesforce::User.count}.by(-1)
+
+          expect(OpenStax::Salesforce::User.all.map(&:id)).not_to contain_exactly(other_user_1.id, other_user_2.id)
+        end
+      end
+
+      context 'when a user with the same uid already exists' do
+        it 'reuses that user' do
+          a_user_1 = FactoryGirl.create(:user, uid: 'someuid')
+
+          allow_any_instance_of(described_class)
+            .to receive(:env)
+            .and_return(omniauth_env_hash)
+
+          post :callback
+
+          expect(a_user_1.reload.name).to eq "Bobby Thomas"
+        end
+      end
+    end
+
+    context '#destroy_user' do
+      # https://content.pivotal.io/blog/writing-rails-engine-rspec-controller-tests
+      # not needed elsewhere since we do other things to make them top-level routes
+      routes { OpenStax::Salesforce::Engine.routes }
+
+      it 'destroys users' do
+        FactoryGirl.create(:user)
+        expect{delete :destroy_user}.to change {OpenStax::Salesforce::User.count}.by(-1)
+      end
+    end
+
+  end
+
+  context 'as non-admin' do
+    routes { OpenStax::Salesforce::Engine.routes }
+
+    it 'has forbidden status' do
+      get :show
+      expect(response).to have_http_status(:forbidden)
+    end
+  end
+
+  def omniauth_env_hash
+    {
+      "omniauth.auth" => Hashie::Mash.new({
+        uid: 'someuid',
+        info: {
+          name: 'Bobby Thomas',
+        },
+        credentials: {
+          token: 'oauth_token',
+          refresh_token: 'refresh_token',
+          instance_url: 'http://blah.com/'
+        }
+      })
+    }
+  end
+end

data/spec/openstax/salesforce/remote/opportunity_spec.rb

@@ -0,0 +1,10 @@
+require 'rails_helper'
+
+RSpec.describe OpenStax::Salesforce::Remote::Opportunity do
+
+  it 'returns a TermYear object' do
+    opportunity = described_class.new(term_year: '2016 - 17 Fall')
+    expect(opportunity.term_year_object).to be_a OpenStax::Salesforce::Remote::TermYear
+  end
+
+end

data/spec/openstax/salesforce/remote/os_ancillary_spec.rb

@@ -0,0 +1,35 @@
+require 'rails_helper'
+
+RSpec.describe OpenStax::Salesforce::Remote::OsAncillary do
+
+  context 'when product is Concept Coach' do
+    subject { described_class.new(product: "Concept Coach") }
+
+    it { is_expected.to be_is_concept_coach }
+    it { is_expected.not_to be_is_tutor }
+    it { is_expected.to be_valid_product }
+  end
+
+  context 'when product is Tutor' do
+    subject { described_class.new(product: "Tutor") }
+
+    it { is_expected.not_to be_is_concept_coach }
+    it { is_expected.to be_is_tutor }
+    it { is_expected.to be_valid_product }
+  end
+
+  context 'when product is nil' do
+    subject { described_class.new }
+
+    it { is_expected.not_to be_is_concept_coach }
+    it { is_expected.not_to be_is_tutor }
+    it { is_expected.not_to be_valid_product }
+  end
+
+  it 'knows which account types are for college' do
+    described_class::COLLEGE_ACCOUNT_TYPES.each do |college_type|
+      expect(described_class.new(account_type: college_type)).to be_is_college
+    end
+  end
+
+end

data/spec/openstax/salesforce/remote/term_year_spec.rb

@@ -0,0 +1,81 @@
+require 'rails_helper'
+
+RSpec.describe OpenStax::Salesforce::Remote::TermYear do
+
+  context "#from_string" do
+    it "works for Fall" do
+      term_year = described_class.from_string("2015 - 16 Fall")
+
+      expect(term_year.start_year).to eq 2015
+      expect(term_year.end_year).to eq 2016
+      expect(term_year).to be_fall
+      expect(term_year).not_to be_spring
+    end
+
+    it "works for Spring" do
+      term_year = described_class.from_string("2015 - 16 Spring")
+
+      expect(term_year.start_year).to eq 2015
+      expect(term_year.end_year).to eq 2016
+      expect(term_year).not_to be_fall
+      expect(term_year).to be_spring
+    end
+
+    it "works for nil" do
+      term_year = described_class.from_string(nil)
+
+      expect(term_year).to be_nil
+    end
+
+    it "freaks out for bad years" do
+      expect{
+        described_class.from_string("2015 - 17 Fall")
+      }.to raise_error(StandardError)
+    end
+
+    it "freaks out for bad formats" do
+      expect{
+        described_class.from_string("fix formula 2016")
+      }.to raise_error(described_class::ParseError)
+    end
+  end
+
+  context "#initialize" do
+    it "freaks out for bad terms" do
+      expect{
+        described_class.new(start_year: 2015, term: :blah)
+      }.to raise_error(StandardError)
+    end
+  end
+
+  context "#next" do
+    it "moves from fall to spring" do
+      expect(described_class.from_string("2015 - 16 Fall").next.to_s).to eq "2015 - 16 Spring"
+    end
+
+    it "moves from spring to fall" do
+      expect(described_class.from_string("2015 - 16 Spring").next.to_s).to eq "2016 - 17 Fall"
+    end
+  end
+
+  context "#guess_from_created_at" do
+    it "guess early part of year into spring" do
+      expect(
+        described_class.guess_from_created_at(Time.zone.local(2016,2)).to_s
+      ).to eq "2015 - 16 Spring"
+    end
+
+    it "guesses summerish into fall" do
+      expect(
+        described_class.guess_from_created_at(Time.zone.local(2016,5)).to_s
+      ).to eq "2016 - 17 Fall"
+    end
+
+    it "guesses late fall into next spring" do
+      expect(
+        described_class.guess_from_created_at(Time.zone.local(2016,12)).to_s
+      ).to eq "2016 - 17 Spring"
+    end
+  end
+
+end

data/spec/rails_helper.rb

@@ -7,6 +7,7 @@ require 'factory_girl_rails'
 require 'faker'
 require 'squeel'
 require 'byebug'
+require 'database_cleaner'
 
 # Add additional requires below this line. Rails is not loaded until this point!
 
@@ -36,7 +37,7 @@ RSpec.configure do |config|
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, remove the following line or assign false
   # instead of true.
-  # config.use_transactional_fixtures = true
+  config.use_transactional_fixtures = false
 
   # RSpec Rails can automatically mix in different behaviours to your tests
   # based on their file location, for example enabling you to call `get` and
@@ -52,4 +53,48 @@ RSpec.configure do |config|
   # The different available types are documented in the features, such as in
   # https://relishapp.com/rspec/rspec-rails/docs
   config.infer_spec_type_from_file_location!
+
+  # Use DatabaseCleaner instead of rspec transaction rollbacks
+  # http://tomdallimore.com/blog/taking-the-test-trash-out-with-databasecleaner-and-rspec/
+
+  config.prepend_before(:suite) do
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
+  config.prepend_before(:all) do
+    DatabaseCleaner.start
+  end
+
+  config.prepend_before(:all, js: true) do
+    DatabaseCleaner.strategy = :truncation
+  end
+
+  config.prepend_before(:all, truncation: true) do
+    DatabaseCleaner.strategy = :truncation
+  end
+
+  config.prepend_before(:all) do
+    DatabaseCleaner.strategy = :transaction
+  end
+
+  config.prepend_before(:each) do
+    DatabaseCleaner.start
+  end
+
+  # https://github.com/DatabaseCleaner/database_cleaner#rspec-with-capybara-example says:
+  #   "It's also recommended to use append_after to ensure DatabaseCleaner.clean
+  #    runs after the after-test cleanup capybara/rspec installs."
+  config.append_after(:each) do
+    DatabaseCleaner.clean
+  end
+
+  config.append_after(:all) do
+    DatabaseCleaner.clean
+  end
+end
+
+def mock_admin_user
+  allow(OpenStax::Salesforce.configuration).to receive(:authenticate_admin_proc) {
+    ->(controller) { return true }
+  }
 end

data/spec/routing_spec.rb

@@ -0,0 +1,9 @@
+require "rails_helper"
+
+RSpec.describe 'Engine routes', type: :routing do
+  describe "/auth/salesforce/callback" do
+    it "routes to #callback" do
+      expect(get '/auth/salesforce/callback').to route_to('openstax/salesforce/settings#callback')
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openstax_salesforce
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.0
 platform: ruby
 authors:
 - JP Slavinsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-22 00:00:00.000000000 Z
+date: 2017-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -150,6 +150,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: database_cleaner
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Interface gem for accessing OpenStax's Salesforce instance
 email:
 - jps@kindlinglabs.com
@@ -164,7 +178,6 @@ files:
 - app/controllers/openstax/salesforce/settings_controller.rb
 - app/helpers/openstax/salesforce/application_helper.rb
 - app/models/openstax/salesforce/user.rb
-- app/models/user.rb
 - app/views/openstax/salesforce/settings/show.html.erb
 - config/initializers/omniauth.rb
 - config/initializers/openstax_salesforce.rb
@@ -174,9 +187,14 @@ files:
 - lib/openstax/salesforce/client.rb
 - lib/openstax/salesforce/engine.rb
 - lib/openstax/salesforce/remote/book.rb
+- lib/openstax/salesforce/remote/class_size.rb
 - lib/openstax/salesforce/remote/contact.rb
+- lib/openstax/salesforce/remote/individual_adoption.rb
 - lib/openstax/salesforce/remote/lead.rb
+- lib/openstax/salesforce/remote/opportunity.rb
+- lib/openstax/salesforce/remote/os_ancillary.rb
 - lib/openstax/salesforce/remote/school.rb
+- lib/openstax/salesforce/remote/term_year.rb
 - lib/openstax/salesforce/spec_helpers.rb
 - lib/openstax/salesforce/spec_helpers/salesforce_proxy.rb
 - lib/openstax/salesforce/user_missing.rb
@@ -221,8 +239,15 @@ files:
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
+- spec/factories/user.rb
+- spec/openstax/salesforce/controllers/application_controller_spec.rb
+- spec/openstax/salesforce/controllers/settings_controller_spec.rb
+- spec/openstax/salesforce/remote/opportunity_spec.rb
+- spec/openstax/salesforce/remote/os_ancillary_spec.rb
+- spec/openstax/salesforce/remote/term_year_spec.rb
 - spec/openstax/salesforce/spec_helpers_spec.rb
 - spec/rails_helper.rb
+- spec/routing_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/openstax/openstax_salesforce
 licenses:
@@ -287,6 +312,13 @@ test_files:
 - spec/dummy/public/favicon.ico
 - spec/dummy/Rakefile
 - spec/dummy/README.md
+- spec/factories/user.rb
+- spec/openstax/salesforce/controllers/application_controller_spec.rb
+- spec/openstax/salesforce/controllers/settings_controller_spec.rb
+- spec/openstax/salesforce/remote/opportunity_spec.rb
+- spec/openstax/salesforce/remote/os_ancillary_spec.rb
+- spec/openstax/salesforce/remote/term_year_spec.rb
 - spec/openstax/salesforce/spec_helpers_spec.rb
 - spec/rails_helper.rb
+- spec/routing_spec.rb
 - spec/spec_helper.rb

data/app/models/user.rb

@@ -1,25 +0,0 @@
-module OpenStax::Salesforce
-  class User < ActiveRecord::Base
-    validates :uid, presence: true
-    validates :oauth_token, presence: true
-    validates :refresh_token, presence: true
-    validates :instance_url, presence: true
-
-    after_save :ensure_only_one_record
-
-    def self.save_from_omniauth!(auth)
-      where(auth.slice(:uid).permit!).first_or_initialize.tap do |user|
-        user.uid = auth.uid
-        user.name = auth.info.name
-        user.oauth_token = auth.credentials.token
-        user.refresh_token = auth.credentials.refresh_token
-        user.instance_url = auth.credentials.instance_url
-        user.save!
-      end
-    end
-
-    def ensure_only_one_record
-      self.class.where{id != self.id}.destroy_all
-    end
-  end
-end