openstates 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 54bc4b599a448cce3390ad41081fa947d9fc1ea7
-  data.tar.gz: 2abd48ee2bd954dc8de98abebe8f1bcfd08ae680
+  metadata.gz: 4e57b5b7800bdcac08cfa5ee25329cfdc887636a
+  data.tar.gz: 56aae9f8bab39e246e429b925117433830022063
 SHA512:
-  metadata.gz: e8589886070d20f45029466d77e45de96b09a3020a2aa6d27e16be36ea17d102aaa0ad5987b5fd52106853cc36be155775f6fcbfb9a0bf35511a8dad4fcd38f5
-  data.tar.gz: 419adea1911286dc3fc60a1d171eafd0380eeba57f55f9b15061696f1317c174776208f0e4a3f084440ade7bdef16a8dff6aa0e72468a7358e305aaee192f6b8
+  metadata.gz: 961de741346cda6f4f4772bdaf988d53f5550a1adea741f23c378daad650e11a47e1eb20b26808c0693a3f630cc284c198cb74fed0f16fe77460ba1d7baa31d2
+  data.tar.gz: 145bf51ee52c8fded0347f6abfca4f806711aae16ed067a7833fd23903d78e9297d936a3d7b6f3924586216a31ac6960021608c7ba13ce6fbd5b01477d4637bb

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -0,0 +1,32 @@
+AllCops:
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+  ExtraDetails: true
+
+Style/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/SpecialGlobalVars:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/NegatedIf:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: single_quotes
+
+Style/DotPosition:
+  EnforcedStyle: leading
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: true
+  Max: 15

data/.travis.yml

@@ -0,0 +1,9 @@
+language: ruby
+
+script:
+  - bundle
+  - bundle exec rspec spec
+
+branches:
+  only:
+    - master

data/CHANGELOG.md

@@ -0,0 +1,37 @@
+# Change Log
+
+## 0.x Releases
+- `0.2.x` Releases - [0.2.0](#020)
+- `0.1.x` Releases - [0.1.0](#010)
+
+## 0.0.x Releases
+- `0.0.x` Releases - [0.0.1](#001)
+
+---
+## [0.2.0](https://github.com/wideeyelabs/ruby-openstates/releases/tag/v0.2.0)
+Released on 2017-02-17
+
+### Added
+Added the ability to fetch a single bill detail via the OpenStates id
+
+### Updated
+- Style consistency throughout the codebase
+
+### Removed
+
+
+## [0.1.0](https://github.com/wideeyelabs/ruby-openstates/releases/tag/v0.1.0)
+Released on 2017-01-06
+
+### Added
+
+### Updated
+- Use https instead of http
+
+### Removed
+
+
+## [0.0.1](https://github.com/wideeyelabs/ruby-openstates/releases/tag/v0.0.1)
+Released on 2013-12-01
+
+Initial Release

data/README.md

@@ -59,6 +59,12 @@ You can also search for a specific bill by it's bill_id.
 bill = OpenStates::Bill.find("12345")
 ```
 
+Or by its OpenStates `id`.
+
+```rb
+bill = OpenStates::Bill.find_by_openstates_id("KS00012345")
+```
+
 And lastly, you can get bill details by using the `bill_details` class
 method on OpenStates::Bill.
 

data/Rakefile

@@ -1 +1 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'

data/lib/openstates.rb

@@ -1,5 +1,4 @@
 require 'openstates/core'
 
 module OpenStates
-
 end

data/lib/openstates/api.rb

@@ -1,13 +1,13 @@
 module OpenStates
   module Api
     def metadata(state = nil)
-      url = "metadata/"
+      url = 'metadata/'
       url << "#{state}/" if state
       get(url)
     end
 
     def bills(options = {})
-      url = "bills/"
+      url = 'bills/'
       if options[:state] && options[:session] && options[:bill_id]
         url << "#{options[:state]}/#{options[:session]}/#{options[:bill_id]}/"
         [:state, :session, :bill_id].each do |key|
@@ -18,28 +18,33 @@ module OpenStates
       get(url, options)
     end
 
+    def bill(os_id)
+      url = "bills/#{os_id}/"
+      get(url, {})
+    end
+
     def legislators(options = {})
-      url = "legislators/"
+      url = 'legislators/'
       url << "#{options[:leg_id]}/" if options[:leg_id]
 
       get(url, options)
     end
 
     def geo_legislators(lat, lon)
-      url = "legislators/geo/"
+      url = 'legislators/geo/'
 
-      get(url, {:lat => lat, :long => lon})
+      get(url, lat: lat, long: lon)
     end
 
     def committees(options = {})
-      url = "committees/"
+      url = 'committees/'
       url << "#{options[:committee_id]}/" if options[:committee_id]
 
       get(url, options)
     end
 
     def events(options = {})
-      url = "events/"
+      url = 'events/'
       url << "#{options[:event_id]}/" if options[:event_id]
 
       get(url, options)
@@ -48,7 +53,7 @@ module OpenStates
     def districts(options = {})
       return [] if !options[:state]
 
-      url = "districts/"
+      url = 'districts/'
       url << "#{options[:state]}/"
       url << "#{options[:chamber]}/" if options[:chamber]
 

data/lib/openstates/connection.rb

@@ -1,13 +1,15 @@
 module OpenStates
   module Connection
-    BASE_URL = 'https://openstates.org/api/v1/'
+    BASE_URL = 'https://openstates.org/api/v1/'.freeze
+
+    # rubocop:disable Metrics/LineLength, Metrics/AbcSize, Metrics/MethodLength
     def connection
       @connection ||= begin
         conn = Faraday.new(BASE_URL) do |b|
           b.use Faraday::Response::Logger, logger
           b.use FaradayMiddleware::Mashify
           b.use FaradayMiddleware::ParseJson, content_type: 'application/json'
-          b.use FaradayMiddleware::Caching, cache, strip_params: %w[apikey] unless cache.nil?
+          b.use FaradayMiddleware::Caching, cache, strip_params: %w(apikey) unless cache.nil?
           b.response :raise_error
           b.adapter Faraday.default_adapter
         end
@@ -17,6 +19,7 @@ module OpenStates
         conn
       end
     end
+    # rubocop:enable Metrics/LineLength, Metrics/AbcSize, Metrics/MethodLength
 
     def get(path, params = nil)
       response = connection.get(path) do |request|

data/lib/openstates/mashify.rb

@@ -3,7 +3,7 @@ require 'faraday'
 module OpenStates
   class Mashify < Faraday::Response::Middleware
     def on_complete(env)
-      super if Hash === env[:body]
+      super if env[:body].is_a? Hash
     end
 
     def parse(body)

data/lib/openstates/model.rb

@@ -24,7 +24,7 @@ module OpenStates
       def find(id)
         return if !id
 
-        id_hash = Hash.new
+        id_hash = {}
         id_hash[id_key] = id
         response = OpenStates.send(api_method, id_hash)
 
@@ -52,12 +52,11 @@ module OpenStates
       return unless hash
 
       hash.each do |key, value|
+        next if value.nil?
+
         set_attr_method = "#{key}="
-        unless value.nil?
-          if respond_to?(set_attr_method)
-            self.__send__(set_attr_method, value)
-          end
-        end
+
+        __send__(set_attr_method, value) if respond_to?(set_attr_method)
       end
     end
   end

data/lib/openstates/models/bill.rb

@@ -48,6 +48,14 @@ module OpenStates
 
         from_hash(response)
       end
+
+      def find_by_openstates_id(os_id)
+        return if !os_id
+
+        response = OpenStates.bill(os_id)
+
+        from_hash(response)
+      end
     end
   end
 end

data/lib/openstates/version.rb

@@ -1,3 +1,3 @@
 module OpenStates
-  VERSION = "0.1.0"
+  VERSION = '0.2.0'.freeze
 end

data/openstates.gemspec

@@ -4,26 +4,27 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'openstates/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "openstates"
+  spec.name          = 'openstates'
   spec.version       = OpenStates::VERSION
-  spec.authors       = ["Chris"]
-  spec.email         = ["chris@wideeyelabs.com"]
-  spec.summary       = %q{Ruby gem to interact with the OpenStates API.}
-  spec.description   = %q{Ruby gem to interact with the OpenStates API.}
-  spec.homepage      = "https://github.com/WideEyeLabs"
-  spec.license       = "MIT"
+  spec.authors       = ['Chris']
+  spec.email         = ['chris@wideeyelabs.com']
+  spec.summary       = 'Ruby gem to interact with the OpenStates API.'
+  spec.description   = 'Ruby gem to interact with the OpenStates API.'
+  spec.homepage      = 'https://github.com/WideEyeLabs'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "faraday_middleware"
-  spec.add_dependency "hashie"
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "pry"
-  spec.add_development_dependency "pry-remote"
-  spec.add_development_dependency "pry-byebug"
+  spec.add_dependency 'faraday_middleware'
+  spec.add_dependency 'hashie'
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'pry-remote'
+  spec.add_development_dependency 'pry-byebug'
+  spec.add_development_dependency 'rubocop'
 end

data/spec/openstates/api_spec.rb

@@ -1,182 +1,193 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe OpenStates::Api do
-  before { OpenStates.stub(:get).and_return({}) }
+  before(:each) { allow(OpenStates).to receive(:get).and_return({}) }
 
-  describe ".metadata" do
-    it "should call .get on OpenStates" do
+  describe '.metadata' do
+    it 'calls .get on OpenStates' do
       expect(OpenStates).to receive(:get)
       OpenStates.metadata
     end
 
-    context "without a state passed" do
-      it "should call .get with 'metadata/'" do
-        expect(OpenStates).to receive(:get).with("metadata/")
+    context 'without a state passed' do
+      it 'calls .get with metadata/' do
+        expect(OpenStates).to receive(:get).with('metadata/')
         OpenStates.metadata
       end
     end
 
-    context "with a state passed in" do
-      it "should call .get with 'metadata/in/'" do
-        state = "in"
+    context 'with a state passed in' do
+      it 'calls .get with metadata/in/' do
+        state = 'in'
         expect(OpenStates).to receive(:get).with("metadata/#{state}/")
         OpenStates.metadata(state)
       end
     end
   end
 
-  describe ".bills" do
-    it "should call .get on OpenStates" do
+  describe '.bills' do
+    it 'calls .get on OpenStates' do
       expect(OpenStates).to receive(:get)
       OpenStates.bills
     end
 
-    context "without an options hash passed" do
-      it "should call .get with 'bills/' and an empty hash" do
-        expect(OpenStates).to receive(:get).with("bills/", {})
+    context 'without an options hash passed' do
+      it 'calls .get with bills/ and an empty hash' do
+        expect(OpenStates).to receive(:get).with('bills/', {})
         OpenStates.bills
       end
     end
 
-    context "with an options hash passed" do
-      it "should call .get with 'bills/in/summer/10' and an options hash" do
-        options = {:state => "in", :session => "summer", :bill_id => 10}
-        expect(OpenStates).to receive(:get).with("bills/#{options[:state]}/#{options[:session]}/#{options[:bill_id]}/", options)
+    context 'with an options hash passed' do
+      it 'calls .get with bills/in/summer/10 and an options hash' do
+        options = {state: 'in', session: 'summer', bill_id: 10}
+        expect(OpenStates).to receive(:get).with(
+          "bills/#{options[:state]}/#{options[:session]}/#{options[:bill_id]}/",
+          options
+        )
         OpenStates.bills(options)
       end
     end
   end
 
-  describe ".legislators" do
-    it "should call .get on OpenStates" do
+  describe '.legislators' do
+    it 'calls .get on OpenStates' do
       expect(OpenStates).to receive(:get)
       OpenStates.legislators
     end
 
-    context "without an options hash passed" do
-      it "should call .get with 'legislators/' and an empty hash" do
-        expect(OpenStates).to receive(:get).with("legislators/", {})
+    context 'without an options hash passed' do
+      it 'calls .get with legislators/ and an empty hash' do
+        expect(OpenStates).to receive(:get).with('legislators/', {})
         OpenStates.legislators
       end
     end
 
-    context "with an options hash passed" do
-      it "should call .get with 'legislators/' and an options hash" do
-        options = {:leg_id => 1}
-        expect(OpenStates).to receive(:get).with("legislators/#{options[:leg_id]}/", options)
+    context 'with an options hash passed' do
+      it 'calls .get with legislators/ and an options hash' do
+        options = {leg_id: 1}
+        expect(OpenStates).to receive(:get)
+          .with("legislators/#{options[:leg_id]}/", options)
         OpenStates.legislators(options)
       end
     end
   end
 
-  describe ".geo_legislators" do
-    it "should call .get on OpenStates" do
+  describe '.geo_legislators' do
+    it 'calls .get on OpenStates' do
       expect(OpenStates).to receive(:get)
       OpenStates.geo_legislators(nil, nil)
     end
 
-    it "should call .get with 'legislators/geo/' and a hash with lat/lon" do
-      lat, lon = 10,10
-      expect(OpenStates).to receive(:get).with("legislators/geo/", {:lat => lat, :long => lon})
+    it 'calls .get with legislators/geo/ and a hash with lat/lon' do
+      lat = 10
+      lon = 10
+      expect(OpenStates).to receive(:get)
+        .with('legislators/geo/', lat: lat, long: lon)
       OpenStates.geo_legislators(lat, lon)
     end
   end
 
-  describe ".committees" do
-    it "should call .get on OpenStates" do
+  describe '.committees' do
+    it 'calls .get on OpenStates' do
       expect(OpenStates).to receive(:get)
       OpenStates.committees
     end
 
-    context "without an options hash passed" do
-      it "should call .get with 'committees/' and an empty hash" do
-        expect(OpenStates).to receive(:get).with("committees/", {})
+    context 'without an options hash passed' do
+      it 'calls .get with committees/ and an empty hash' do
+        expect(OpenStates).to receive(:get).with('committees/', {})
         OpenStates.committees
       end
     end
 
-    context "with an options hash passed" do
-      it "should call .get with 'committees/' and an options hash" do
-        options = {:committee_id => 1}
-        expect(OpenStates).to receive(:get).with("committees/#{options[:committee_id]}/", options)
+    context 'with an options hash passed' do
+      it 'calls .get with committees/ and an options hash' do
+        options = {committee_id: 1}
+        expect(OpenStates).to receive(:get)
+          .with("committees/#{options[:committee_id]}/", options)
         OpenStates.committees(options)
       end
     end
   end
 
-  describe ".events" do
-    it "should call .get on OpenStates" do
+  describe '.events' do
+    it 'calls .get on OpenStates' do
       expect(OpenStates).to receive(:get)
       OpenStates.events
     end
 
-    context "without an options hash passed" do
-      it "should call .get with 'events/' and an empty hash" do
-        expect(OpenStates).to receive(:get).with("events/", {})
+    context 'without an options hash passed' do
+      it 'calls .get with events/ and an empty hash' do
+        expect(OpenStates).to receive(:get).with('events/', {})
         OpenStates.events
       end
     end
 
-    context "with an options hash passed" do
-      it "should call .get with 'events/' and an options hash" do
-        options = {:event_id => 1}
-        expect(OpenStates).to receive(:get).with("events/#{options[:event_id]}/", options)
+    context 'with an options hash passed' do
+      it 'calls .get with events/ and an options hash' do
+        options = {event_id: 1}
+        expect(OpenStates).to receive(:get)
+          .with("events/#{options[:event_id]}/", options)
         OpenStates.events(options)
       end
     end
   end
 
-  describe ".districts" do
-    context "without an options hash passed" do
-      it "should return an Array" do
+  describe '.districts' do
+    context 'without an options hash passed' do
+      it 'returns an Array' do
         expect(OpenStates.districts).to be_an Array
       end
 
-      it "should return an empty Array" do
+      it 'returns an empty Array' do
         expect(OpenStates.districts).to be_empty
       end
     end
 
-    context "with an options hash passed" do
-      context "with a state key only" do
-        it "should call .get on OpenStates" do
+    context 'with an options hash passed' do
+      context 'with a state key only' do
+        it 'calls .get on OpenStates' do
           expect(OpenStates).to receive(:get)
           OpenStates.districts(state: 'fl')
         end
 
-        it "should call .get with 'districts/' and an options hash" do
-          options = {:state => 'oh'}
-          expect(OpenStates).to receive(:get).with("districts/#{options[:state]}/", options)
+        it 'calls .get with districts/ and an options hash' do
+          options = {state: 'oh'}
+          expect(OpenStates).to receive(:get)
+            .with("districts/#{options[:state]}/", options)
           OpenStates.districts(options)
         end
       end
 
-      context "with a state and chamber key" do
-        it "should call .get with 'districts/' and an options hash" do
-          options = {:state => 'in', :chamber => "blah"}
-          expect(OpenStates).to receive(:get).with("districts/#{options[:state]}/#{options[:chamber]}/", options)
+      context 'with a state and chamber key' do
+        it 'calls .get with districts/ and an options hash' do
+          options = {state: 'in', chamber: 'blah'}
+          expect(OpenStates).to receive(:get)
+            .with("districts/#{options[:state]}/#{options[:chamber]}/", options)
           OpenStates.districts(options)
         end
       end
     end
   end
 
-  describe ".district_boundaries" do
+  describe '.district_boundaries' do
     let(:boundary_id) { 1 }
-    it "should call .get on OpenStates" do
+    it 'calls .get on OpenStates' do
       expect(OpenStates).to receive(:get)
       OpenStates.district_boundaries(boundary_id)
     end
 
-    context "with a boundary_id parameter" do
-      it "should call .get with 'districts/:boundary_id'" do
-        expect(OpenStates).to receive(:get).with("districts/boundary/#{boundary_id}/")
+    context 'with a boundary_id parameter' do
+      it 'calls .get with districts/:boundary_id' do
+        expect(OpenStates).to receive(:get)
+          .with("districts/boundary/#{boundary_id}/")
         OpenStates.district_boundaries(boundary_id)
       end
     end
 
-    context "without a boundary_id parameter" do
-      it "should return nil" do
+    context 'without a boundary_id parameter' do
+      it 'returns nil' do
         expect(OpenStates.district_boundaries(nil)).to be_nil
       end
     end

data/spec/openstates/models/bill_spec.rb

@@ -1,32 +1,60 @@
 require 'spec_helper'
 
 describe OpenStates::Bill do
-  describe ".api_method" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::Bill.api_method }.not_to raise_error
+  describe '.api_method' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::Bill.api_method }.not_to raise_error
     end
   end
 
-  describe ".id_key" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::Bill.id_key }.not_to raise_error
+  describe '.id_key' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::Bill.id_key }.not_to raise_error
     end
   end
 
-  describe ".bill_details" do
-    context "when state, session, and bill_id are nil" do
-      it "should return nil" do
+  describe '.bill_details' do
+    context 'when state, session, and bill_id are nil' do
+      it 'returns nil' do
         expect(OpenStates::Bill.bill_details(nil, nil, nil)).to be_nil
       end
     end
 
-    context "when state, session, and bill_id are not nil" do
-      it "should return an OpenState::Bill" do
+    context 'when state, session, and bill_id are not nil' do
+      it 'returns an OpenState::Bill' do
         state = 'fl'
         session = '2013'
         bill_id = '1234'
-        OpenStates.stub(:bills).and_return({:bill_id => bill_id, :state => state, :session => session})
-        OpenStates::Bill.bill_details(state, session, bill_id).should be_a OpenStates::Bill
+
+        allow(OpenStates).to receive(:bills).and_return(
+          bill_id: bill_id, state: state, session: session
+        )
+
+        expect(
+          OpenStates::Bill.bill_details(state, session, bill_id)
+        ).to be_a described_class
+      end
+    end
+  end
+
+  describe '.find_by_openstates_id' do
+    context 'openstates id is legit' do
+      it 'returns a Bill' do
+        openstate_bill_id = 'KSB00005007'
+
+        allow(OpenStates).to receive(:bill).and_return(
+          id: openstate_bill_id
+        )
+
+        expect(
+          OpenStates::Bill.find_by_openstates_id('KSB00005007')
+        ).to be_a described_class
+      end
+    end
+
+    context 'when openstate_bill_id is nil' do
+      it 'returns nil' do
+        expect(OpenStates::Bill.find_by_openstates_id(nil)).to be_nil
       end
     end
   end

data/spec/openstates/models/committee_spec.rb

@@ -1,15 +1,15 @@
 require 'spec_helper'
 
 describe OpenStates::Committee do
-  describe ".api_method" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::Committee.api_method }.not_to raise_error
+  describe '.api_method' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::Committee.api_method }.not_to raise_error
     end
   end
 
-  describe ".id_key" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::Committee.id_key }.not_to raise_error
+  describe '.id_key' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::Committee.id_key }.not_to raise_error
     end
   end
 end

data/spec/openstates/models/district_spec.rb

@@ -1,33 +1,34 @@
 require 'spec_helper'
 
 describe OpenStates::District do
-  describe ".api_method" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::District.api_method }.not_to raise_error
+  describe '.api_method' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::District.api_method }.not_to raise_error
     end
   end
 
-  describe ".id_key" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::District.id_key }.not_to raise_error
+  describe '.id_key' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::District.id_key }.not_to raise_error
     end
   end
 
-  describe ".find" do
+  describe '.find' do
     before(:each) do
-      OpenStates.stub(:district_boundaries).and_return({ :state => 'il' })
+      allow(OpenStates).to receive(:district_boundaries)
+        .and_return(state: 'il')
     end
 
-    context "without a boundary id" do
-      it "should return nil" do
+    context 'without a boundary id' do
+      it 'returns nil' do
         expect(OpenStates::District.find(nil)).to be_nil
       end
     end
 
-    context "with a boundary id" do
-      it "should return an OpenState::District" do
-        options = { :state => 'il' }
-        expect(OpenStates::District.find(options)).to be_a OpenStates::District
+    context 'with a boundary id' do
+      it 'returns an OpenState::District' do
+        options = {state: 'il'}
+        expect(OpenStates::District.find(options)).to be_a described_class
       end
     end
   end

data/spec/openstates/models/event_spec.rb

@@ -1,15 +1,15 @@
 require 'spec_helper'
 
 describe OpenStates::Event do
-  describe ".api_method" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::Event.api_method }.not_to raise_error
+  describe '.api_method' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::Event.api_method }.not_to raise_error
     end
   end
 
-  describe ".id_key" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::Event.id_key }.not_to raise_error
+  describe '.id_key' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::Event.id_key }.not_to raise_error
     end
   end
 end

data/spec/openstates/models/legislator_spec.rb

@@ -1,39 +1,41 @@
 require 'spec_helper'
 
 describe OpenStates::Legislator do
-  describe ".api_method" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::Legislator.api_method }.not_to raise_error
+  describe '.api_method' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::Legislator.api_method }.not_to raise_error
     end
   end
 
-  describe ".id_key" do
-    it "should not raise a NotImplementedError" do
-      expect{ OpenStates::Legislator.id_key }.not_to raise_error
+  describe '.id_key' do
+    it 'does not raise a NotImplementedError' do
+      expect { OpenStates::Legislator.id_key }.not_to raise_error
     end
   end
 
-  describe ".by_location" do
-    context "when lat and lon are nil" do
-      it "should return nil" do
-        OpenStates::Legislator.by_location(nil,nil).should be_nil
+  describe '.by_location' do
+    context 'when lat and lon are nil' do
+      it 'does return nil' do
+        expect(OpenStates::Legislator.by_location(nil, nil)).to be_nil
       end
     end
 
-    context "when lat and lon are not nil" do
+    context 'when lat and lon are not nil' do
       before(:each) do
         legislator_hash = {leg_id: '1', first_name: 'bob'}
         response = [legislator_hash, legislator_hash]
-        OpenStates.stub(:geo_legislators).and_return(response)
+        allow(OpenStates).to receive(:geo_legislators).and_return(response)
       end
 
-      it "should return an array" do
-        OpenStates::Legislator.by_location(123.10, -85.20).should be_an Array
+      it 'does return an array' do
+        expect(
+          OpenStates::Legislator.by_location(123.10, -85.20)
+        ).to be_an Array
       end
 
-      it "should return an array of legislator objects" do
+      it 'does return an array of legislator objects' do
         OpenStates::Legislator.by_location(123.10, -85.20).each do |obj|
-          obj.should be_a OpenStates::Legislator
+          expect(obj).to be_a OpenStates::Legislator
         end
       end
     end

data/spec/openstates/version_spec.rb

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
 describe OpenStates::VERSION do
-  it "should return a version string" do
-    OpenStates::VERSION.class.should == String
+  it 'returns a version string' do
+    expect(OpenStates::VERSION.class).to eq(String)
   end
 end
-
-

data/spec/spec_helper.rb

@@ -1,12 +1,12 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+
 require 'openstates'
 require 'pry'
 require 'pry-remote'
-require 'pry-debugger'
+require 'pry-byebug'
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.order = 'random'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openstates
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Chris
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-06 00:00:00.000000000 Z
+date: 2017-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby gem to interact with the OpenStates API.
 email:
 - chris@wideeyelabs.com
@@ -130,10 +144,13 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hound.yml"
 - ".rspec"
+- ".rubocop.yml"
 - ".ruby-version"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
-- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile

data/Guardfile

@@ -1,9 +0,0 @@
-# A sample Guardfile
-# More info at https://github.com/guard/guard#readme
-
-guard :rspec do
-  watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/openstates/(.+)\.rb$})     { |m| "spec/openstates/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb')  { "spec" }
-end
-