opensrs 0.3.5 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cef55dd62d0db183b1f6e3e85518268695882e8d
-  data.tar.gz: 1a195f62bdb2cd02ba0c9d6b4d90a7392ea4c386
+  metadata.gz: 859e3e67b33ab3a4c5f7c071531a409e16048650
+  data.tar.gz: ca25ef41d7a29a3f8bd1b491a022c4af1135caf1
 SHA512:
-  metadata.gz: 09f10fb90e00cc9b43e990a4fa2255b4cd3193533faa5d31064d3197f794f50cf20024f749dbb3a44d954df1d4066075a2e0af2718c4e35e32d2c08a29316d28
-  data.tar.gz: 90d8ba319a32a30764a8ccb1456a29286b5ae8ab2448a5f8e6f3c36635a8a79e6c628e3dbdd25dd2a77ac307428867d45893425b2e9926c82e49888652231abc
+  metadata.gz: 783c86e4637b6f6ba6f4c12e4519118e42e3c4e700c2ccf2ad702021ebe569d3a62e419f167827e74176ea1b2892cbd78d6768fcf94f73ee88c4fd8180d093ed
+  data.tar.gz: 8d271520d7d262eb3c11cf5645d3849e1f03ebfcf727fe4c1f2043d800a9dfdac745dd7d4f7b04d6d2fd9152daa05f7d1c630ade248d6a8f32c6b12b07916503

data/bin/console

@@ -0,0 +1,10 @@
+#!/usr/bin/env ruby
+
+require "bundler/setup"
+require "opensrs"
+
+require "pry"
+Pry.start
+
+require "irb"
+IRB.start

data/bin/setup

@@ -0,0 +1,7 @@
+#!/bin/bash
+set -euo pipefail
+IFS=$'\n\t'
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/lib/opensrs.rb

@@ -1,8 +1,8 @@
-require File.dirname(__FILE__) + '/opensrs/xml_processor'
-require File.dirname(__FILE__) + '/opensrs/xml_processor/libxml.rb'
-require File.dirname(__FILE__) + '/opensrs/server.rb'
-require File.dirname(__FILE__) + '/opensrs/response.rb'
-require File.dirname(__FILE__) + '/opensrs/version.rb'
+require "opensrs/xml_processor"
+require "opensrs/xml_processor/libxml"
+require "opensrs/server"
+require "opensrs/response"
+require "opensrs/version"
 
 module OpenSRS
-end
+end

data/lib/opensrs/response.rb

@@ -2,28 +2,30 @@ module OpenSRS
   class Response
     attr_reader :request_xml, :response_xml
     attr_accessor :response, :success
-    
+
     def initialize(parsed_response, request_xml, response_xml)
       @response     = parsed_response
       @request_xml  = request_xml
       @response_xml = response_xml
       @success      = success?
     end
-  
+
     # We need to return the error message unless the
     # response is successful.
     def errors
-      if !success?
-        if response["response_text"] and response["response_code"]
-          "#{response["response_text"]} (Code #{response["response_code"]})"
-        else
-          "Unknown error"
-        end
+      unless success?
+        msg  = @response["response_text"]
+        code = @response["response_code"]
+
+        return msg && code ? "#{msg} (Code #{code})" : "Unknown error"
       end
     end
-  
+
+    # If 'is_success' is returned, the API is letting us know that they
+    # will explicitly tell us whether something has succeeded or not.
+    # Otherwise, just assume it is successful.
     def success?
-      response["is_success"] ? response["is_success"].to_s == "1" : true
+      @response["is_success"] && @response["is_success"] == "1" ? true : false
     end
   end
-end
+end

data/lib/opensrs/server.rb

@@ -19,7 +19,7 @@ module OpenSRS
       @password = options[:password]
       @key      = options[:key]
       @timeout  = options[:timeout]
-      @open_timeout  = options[:open_timeout]
+      @open_timeout = options[:open_timeout]
       @logger   = options[:logger]
     end
 
@@ -47,7 +47,7 @@ module OpenSRS
     end
 
     def self.xml_processor=(name)
-      require File.dirname(__FILE__) + "/xml_processor/#{name.to_s.downcase}"
+      require "opensrs/xml_processor/#{name.to_s.downcase}"
       @@xml_processor = OpenSRS::XmlProcessor.const_get("#{name.to_s.capitalize}")
     end
 
@@ -56,7 +56,8 @@ module OpenSRS
     private
 
     def headers(request)
-      { "Content-Length"  => request.length.to_s,
+      {
+        "Content-Length"  => request.length.to_s,
         "Content-Type"    => "text/xml",
         "X-Username"      => username,
         "X-Signature"     => signature(request)
@@ -64,9 +65,7 @@ module OpenSRS
     end
 
     def signature(request)
-      signature = Digest::MD5.hexdigest(request + key)
-      signature = Digest::MD5.hexdigest(signature + key)
-      signature
+      Digest::MD5.hexdigest(Digest::MD5.hexdigest(request + key) + key)
     end
 
     def http

data/lib/opensrs/version.rb

@@ -1,5 +1,3 @@
 module OpenSRS
-  class Version
-    VERSION = "0.3.5"
-  end
+  VERSION = "0.3.6"
 end

data/lib/opensrs/xml_processor.rb

@@ -1,5 +1,4 @@
 module OpenSRS
-
   class XmlProcessor
 
     # Parses the main data block from OpenSRS and discards
@@ -71,5 +70,4 @@ module OpenSRS
     end
 
   end
-
 end

data/lib/opensrs/xml_processor/libxml.rb

@@ -1,60 +1,67 @@
-require "libxml"
+begin
+  require 'libxml'
+rescue LoadError => e
+  $stderr.puts "Cannot find `libxml` gem. Please install it before using it as the XML processor"
+  raise e
+end
 
 module OpenSRS
-  class XmlProcessor::Libxml < OpenSRS::XmlProcessor
-    include ::LibXML::XML
-    
-    # First, builds REXML elements for the inputted data. Then, it will
-    # go ahead and build the entire XML document to send to OpenSRS.
-    def self.build(data)
-      xml = Document.new
-      xml.root = envelope = Node.new("OPS_envelope")
-
-      envelope << header = Node.new("header")
-      envelope << body = Node.new("body")
-      header   << Node.new("version", "0.9")
-      body     << data_block = Node.new("data_block")
-
-      data_block << encode_data(data, data_block)
-
-      return xml.to_s
-    end
+  class XmlProcessor
+    class Libxml < OpenSRS::XmlProcessor
+      include ::LibXML::XML
 
-    protected
+      # First, builds REXML elements for the inputted data. Then, it will
+      # go ahead and build the entire XML document to send to OpenSRS.
+      def self.build(data)
+        xml = Document.new
+        xml.root = envelope = Node.new("OPS_envelope")
 
-    def self.data_block_element(response)
-      doc = Parser.string(response).parse
-      return doc.find("//OPS_envelope/body/data_block/*")
-    end
+        envelope << header = Node.new("header")
+        envelope << body = Node.new("body")
+        header   << Node.new("version", "0.9")
+        body     << data_block = Node.new("data_block")
 
-    def self.decode_dt_array_data(element)
-      dt_array = []
+        data_block << encode_data(data, data_block)
 
-      element.children.each do |item|
-        next if item.empty?
-        dt_array[item.attributes["key"].to_i] = decode_data(item)
+        return xml.to_s
       end
 
-      return dt_array
-    end
+      protected
 
-    def self.decode_dt_assoc_data(element)
-      dt_assoc = {}
+      def self.data_block_element(response)
+        doc = Parser.string(response).parse
+        return doc.find("//OPS_envelope/body/data_block/*")
+      end
 
-      element.children.each do |item|
-        next if item.content.strip.empty?
-        dt_assoc[item.attributes["key"]] = decode_data(item)
+      def self.decode_dt_array_data(element)
+        dt_array = []
+
+        element.children.each do |item|
+          next if item.empty?
+          dt_array[item.attributes["key"].to_i] = decode_data(item)
+        end
+
+        return dt_array
       end
 
-      return dt_assoc
-    end
+      def self.decode_dt_assoc_data(element)
+        dt_assoc = {}
 
-    # Accepts two parameters but uses only one; to keep the interface same as other xml parser classes
-    # Is that a side effect of Template pattern?
-    #
-    def self.new_element(element_name, container)
-      return Node.new(element_name.to_s)
-    end
+        element.children.each do |item|
+          next if item.content.strip.empty?
+          dt_assoc[item.attributes["key"]] = decode_data(item)
+        end
+
+        return dt_assoc
+      end
 
+      # Accepts two parameters but uses only one; to keep the interface same as other xml parser classes
+      # Is that a side effect of Template pattern?
+      #
+      def self.new_element(element_name, container)
+        return Node.new(element_name.to_s)
+      end
+
+    end
   end
-end
+end

data/lib/opensrs/xml_processor/nokogiri.rb

@@ -1,64 +1,66 @@
 begin
   require 'nokogiri'
 rescue LoadError => e
-  $stderr.puts "Cannot find Nokogiri gem. Please install Nokogiri before using it as the xml processor\n\n"
+  $stderr.puts "Cannot find `nokogiri` gem. Please install it before using it as the XML processor"
   raise e
 end
 
 module OpenSRS
-  class XmlProcessor::Nokogiri < OpenSRS::XmlProcessor
+  class XmlProcessor
+    class Nokogiri < OpenSRS::XmlProcessor
 
-    def self.build(data)
-      builder = ::Nokogiri::XML::Builder.new
+      def self.build(data)
+        builder = ::Nokogiri::XML::Builder.new
 
-      envelope   = ::Nokogiri::XML::Node.new("OPS_envelope", builder.doc)
-      header     = ::Nokogiri::XML::Node.new("header", builder.doc)
-      version    = ::Nokogiri::XML::Node.new("version", builder.doc)
-      body       = ::Nokogiri::XML::Node.new("body", builder.doc)
-      data_block = ::Nokogiri::XML::Node.new("data_block", builder.doc)
-      other_data = encode_data(data, builder.doc)
-      version << '0.9'
-      header << version
-      envelope << header
-      builder.doc << envelope
-      data_block << other_data
-      body << data_block
-      envelope << body
-      return builder.to_xml
-    end
+        envelope   = ::Nokogiri::XML::Node.new("OPS_envelope", builder.doc)
+        header     = ::Nokogiri::XML::Node.new("header", builder.doc)
+        version    = ::Nokogiri::XML::Node.new("version", builder.doc)
+        body       = ::Nokogiri::XML::Node.new("body", builder.doc)
+        data_block = ::Nokogiri::XML::Node.new("data_block", builder.doc)
+        other_data = encode_data(data, builder.doc)
+        version << '0.9'
+        header << version
+        envelope << header
+        builder.doc << envelope
+        data_block << other_data
+        body << data_block
+        envelope << body
+        return builder.to_xml
+      end
 
-    protected
+      protected
 
-    def self.data_block_element(response)
-      doc = ::Nokogiri::XML(response)
-      return doc.xpath('//OPS_envelope/body/data_block/*')
-    end
+      def self.data_block_element(response)
+        doc = ::Nokogiri::XML(response)
+        return doc.xpath('//OPS_envelope/body/data_block/*')
+      end
+
+      def self.decode_dt_array_data(element)
+        dt_array = []
 
-    def self.decode_dt_array_data(element)
-      dt_array = []
+        element.children.each do |item|
+          next if item.content.strip.empty?
+          dt_array[item.attributes["key"].value.to_i] = decode_data(item.children)
+        end
 
-      element.children.each do |item|
-        next if item.content.strip.empty?
-        dt_array[item.attributes["key"].value.to_i] = decode_data(item.children)
+        return dt_array
       end
 
-      return dt_array
-    end
+      def self.decode_dt_assoc_data(element)
+        dt_assoc = {}
 
-    def self.decode_dt_assoc_data(element)
-      dt_assoc = {}
+        element.children.each do |item|
+          next if item.content.strip.empty?
+          dt_assoc[item.attributes["key"].value] = decode_data(item.children)
+        end
 
-      element.children.each do |item|
-        next if item.content.strip.empty?
-        dt_assoc[item.attributes["key"].value] = decode_data(item.children)
+        return dt_assoc
       end
 
-      return dt_assoc
-    end
+      def self.new_element(element_name, container)
+        return ::Nokogiri::XML::Node.new(element_name.to_s, container)
+      end
 
-    def self.new_element(element_name, container)
-      return ::Nokogiri::XML::Node.new(element_name.to_s, container)
     end
-
   end
 end

data/opensrs.gemspec

@@ -1,15 +1,12 @@
 # coding: utf-8
-
 lib = File.expand_path('../lib', __FILE__)
-
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-
-require 'opensrs/version'
+require "opensrs/version"
 
 Gem::Specification.new do |spec|
 
   spec.name          = "opensrs"
-  spec.version       = OpenSRS::Version::VERSION
+  spec.version       = OpenSRS::VERSION
   spec.authors       = [ "Joshua Delsman" ]
   spec.email         = [ "j@srv.im" ]
   spec.summary       = "OpenSRS API for Ruby"
@@ -17,17 +14,18 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/voxxit/opensrs"
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = [ "lib" ]
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.bindir        = "exe"
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
 
   spec.add_runtime_dependency "libxml-ruby", "~> 2"
 
-  spec.add_development_dependency "bundler", "~> 1.8"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 2.0"
+  spec.add_development_dependency "rspec"
   spec.add_development_dependency "shoulda"
   spec.add_development_dependency "nokogiri"
+  spec.add_development_dependency "pry"
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opensrs
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - Joshua Delsman
 autorequire: 
-bindir: bin
+bindir: exe
 cert_chain: []
-date: 2015-03-07 00:00:00.000000000 Z
+date: 2015-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: libxml-ruby
@@ -28,16 +28,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -56,16 +56,16 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: shoulda
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Provides support to utilize the OpenSRS API with Ruby.
 email:
 - j@srv.im
@@ -109,6 +123,8 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/console
+- bin/setup
 - lib/opensrs.rb
 - lib/opensrs/response.rb
 - lib/opensrs/server.rb
@@ -117,11 +133,6 @@ files:
 - lib/opensrs/xml_processor/libxml.rb
 - lib/opensrs/xml_processor/nokogiri.rb
 - opensrs.gemspec
-- spec/opensrs/server_spec.rb
-- spec/opensrs/version_spec.rb
-- spec/opensrs/xml_processor/libxml_spec.rb
-- spec/opensrs/xml_processor/nokogiri_spec.rb
-- spec/spec_helper.rb
 homepage: https://github.com/voxxit/opensrs
 licenses:
 - MIT
@@ -146,9 +157,4 @@ rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: OpenSRS API for Ruby
-test_files:
-- spec/opensrs/server_spec.rb
-- spec/opensrs/version_spec.rb
-- spec/opensrs/xml_processor/libxml_spec.rb
-- spec/opensrs/xml_processor/nokogiri_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/spec/opensrs/server_spec.rb

@@ -1,139 +0,0 @@
-describe OpenSRS::Server do
-  let(:server) { OpenSRS::Server.new }
-
-  describe '#new' do
-    it 'allows timeouts to be set' do
-      server = OpenSRS::Server.new({ :timeout => 90 })
-      server.timeout.should == 90
-      server.open_timeout.should be_nil
-    end
-
-    it 'allows open timeouts to be set' do
-      server = OpenSRS::Server.new({ :timeout => 90, :open_timeout => 10 })
-      server.timeout.should eq(90)
-      server.open_timeout.should eq(10)
-    end
-
-    it 'leaves it up to Net::HTTP if no timeouts given' do
-      server.timeout.should be_nil
-      server.open_timeout.should be_nil
-    end
-
-    it 'allows a logger to be set during initialization' do
-      logger = double(:info => '')
-      server = OpenSRS::Server.new({ :logger => logger })
-      server.logger.should eq(logger)
-    end
-  end
-
-  describe ".call" do
-    let(:response) { double(:body => 'some response') }
-    let(:header) { {"some" => "header" } }
-    let(:xml) { '<some xml></some xml>' }
-    let(:response_xml) { xml }
-    let(:xml_processor) { double OpenSRS::XmlProcessor }
-    let(:http) { double(Net::HTTP, :use_ssl= => true, :verify_mode= => true)  }
-
-    before :each do
-      server.stub(:headers).and_return header
-      xml_processor.stub(:build).and_return xml
-      xml_processor.stub(:parse).and_return response_xml
-      server.stub(:xml_processor).and_return xml_processor
-      http.stub(:post).and_return response
-      Net::HTTP.stub(:new).and_return http
-    end
-
-    it "builds XML request" do
-      xml_processor.should_receive(:build).with(:protocol => "XCP", :some => 'option')
-      server.call(:some => 'option')
-    end
-
-    it "posts to given path" do
-      server.server = URI.parse 'http://with-path.com/endpoint'
-      http.should_receive(:post).with('/endpoint', xml, header).and_return double.as_null_object
-      server.call
-    end
-
-    it "parses the response" do
-      xml_processor.should_receive(:parse).with(response.body)
-      server.call(:some => 'option')
-    end
-
-    it "posts to root path" do
-      server.server = URI.parse 'http://root-path.com/'
-      http.should_receive(:post).with('/', xml, header).and_return double.as_null_object
-      server.call
-    end
-
-    it "defaults path to '/'" do
-      server.server = URI.parse 'http://no-path.com'
-      http.should_receive(:post).with('/', xml, header).and_return double.as_null_object
-      server.call
-    end
-
-    it 'allows overriding of default (Net:HTTP) timeouts' do
-      server.timeout = 90
-
-      http.should_receive(:open_timeout=).with(90)
-      http.should_receive(:read_timeout=).with(90)
-
-      server.call( { :some => 'data' } )
-    end
-
-    it 'allows overriding of default (Net:HTTP) timeouts' do
-      server.timeout = 180
-      server.open_timeout = 30
-
-      http.should_receive(:read_timeout=).with(180)
-      http.should_receive(:open_timeout=).with(180)
-      http.should_receive(:open_timeout=).with(30)
-
-      server.call( { :some => 'data' } )
-    end
-
-    it 're-raises Net:HTTP timeouts' do
-      http.should_receive(:post).and_raise err = Timeout::Error.new('test')
-      expect { server.call }.to raise_exception OpenSRS::TimeoutError
-    end
-
-    it 'wraps connection errors' do
-      http.should_receive(:post).and_raise err = Errno::ECONNREFUSED
-      expect { server.call }.to raise_exception OpenSRS::ConnectionError
-
-      http.should_receive(:post).and_raise err = Errno::ECONNRESET
-      expect { server.call }.to raise_exception OpenSRS::ConnectionError
-    end
-
-    describe "logger is present" do
-      let(:logger) { OpenSRS::TestLogger.new }
-      before :each do
-        server.logger = logger
-      end
-
-      it "should log the request and the response" do
-        xml_processor.should_receive(:build).with(:protocol => "XCP", :some => 'option')
-        server.call(:some => 'option')
-        logger.messages.length.should eq(2)
-        logger.messages.first.should match(/\[OpenSRS\] Request XML/)
-        logger.messages.first.should match(/<some xml>/)
-        logger.messages.last.should match(/\[OpenSRS\] Response XML/)
-        logger.messages.last.should match(/some response/)
-      end
-
-    end
-  end
-
-  describe "#test xml processor" do
-    context "on class initialization" do
-      it { server.xml_processor.should eql(OpenSRS::XmlProcessor::Libxml) }
-    end
-
-    context "on changing xml processor" do
-      before(:each) do
-        OpenSRS::Server.xml_processor = :nokogiri
-      end
-
-      it { server.xml_processor.should eql(OpenSRS::XmlProcessor::Nokogiri) }
-    end
-  end
-end

data/spec/opensrs/version_spec.rb

@@ -1,7 +0,0 @@
-describe OpenSRS::Version do
-  describe "VERSION" do
-    it "should return version string" do
-      OpenSRS::Version::VERSION.should eql("0.3.4")
-    end
-  end
-end

data/spec/opensrs/xml_processor/libxml_spec.rb

@@ -1,253 +0,0 @@
-require 'date'
-
-describe OpenSRS::XmlProcessor::Libxml do
-  describe ".build" do
-    it "should create XML for a nested hash" do
-      attributes = {:foo => {:bar => 'baz'}}
-      xml = OpenSRS::XmlProcessor::Libxml.build(attributes)
-      xml.should eq %{<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<OPS_envelope>\n  <header>\n    <version>0.9</version>\n  </header>\n  <body>\n    <data_block>\n      <dt_assoc>\n        <item key=\"foo\">\n          <dt_assoc>\n            <item key=\"bar\">baz</item>\n          </dt_assoc>\n        </item>\n      </dt_assoc>\n    </data_block>\n  </body>\n</OPS_envelope>\n}
-    end
-  end
-
-  describe '.encode_data' do
-    context "on a 3 element array" do
-      before(:each) do
-        @e = OpenSRS::XmlProcessor::Libxml.encode_data([1,2,3])
-      end
-
-      it "is a REXML::Element" do
-        @e.should be_an_instance_of(LibXML::XML::Node)
-      end
-
-      it "is a dt_array" do
-        @e.name.should == 'dt_array'
-      end
-
-      it "has 3 children all called <item>" do
-        @e.should have(3).children
-        @e.children[0].name.should == "item"
-        @e.children[1].name.should == "item"
-        @e.children[2].name.should == "item"
-      end
-
-      it "has children with keys 0, 1 and 2" do
-        @e.children[0].attributes["key"].should == "0"
-        @e.children[1].attributes["key"].should == "1"
-        @e.children[2].attributes["key"].should == "2"
-      end
-    end
-
-    context "on a hash" do
-      before(:each) do
-        @e = OpenSRS::XmlProcessor::Libxml.encode_data({:name => "kitteh"})
-      end
-
-      it "is a REXML::Element" do
-        @e.should be_an_instance_of(LibXML::XML::Node)
-      end
-
-      it "is a dt_assoc" do
-        @e.name.should == 'dt_assoc'
-      end
-
-      it "has an <item> child with the right key" do
-        @e.should have(1).children
-        @e.children[0].name.should == 'item'
-        @e.children[0].attributes["key"].should == 'name'
-      end
-    end
-
-    context "on a nested hash" do
-      before(:each) do
-        @e = OpenSRS::XmlProcessor::Libxml.encode_data({:suggestion => {:maximum => "10"}})
-      end
-
-      it "is a REXML::Element" do
-        @e.should be_an_instance_of(LibXML::XML::Node)
-      end
-
-      it "is a dt_assoc" do
-        @e.name.should == 'dt_assoc'
-      end
-
-      it "has an <item> child with the correct children" do
-        @e.should have(1).children
-        suggestion = @e.children[0]
-        suggestion.name.should == 'item'
-        suggestion.attributes["key"].should == 'suggestion'
-
-        suggestion.should have(1).children
-        dt_assoc = suggestion.children[0]
-        dt_assoc.name.should == 'dt_assoc'
-
-        dt_assoc.should have(1).children
-        maximum = dt_assoc.children[0]
-        maximum.name.should == 'item'
-        maximum.attributes["key"].should == 'maximum'
-      end
-    end
-
-    context "produces a scalar" do
-      it "from a string" do
-        OpenSRS::XmlProcessor::Libxml.encode_data("cheezburger").to_s.should == "cheezburger"
-      end
-
-      it "from a string with XML characters" do
-        OpenSRS::XmlProcessor::Libxml.encode_data("<smile>").to_s.should == "<smile>"
-      end
-
-      it "from an integer" do
-        OpenSRS::XmlProcessor::Libxml.encode_data(12345).to_s.should == "12345"
-      end
-
-      it "from a date" do
-        date = Date.parse("2010/02/12")
-        OpenSRS::XmlProcessor::Libxml.encode_data(date).to_s.should == "2010-02-12"
-      end
-
-      it "from a symbol" do
-        OpenSRS::XmlProcessor::Libxml.encode_data(:name).to_s.should == "name"
-      end
-
-      it "from true or false" do
-        OpenSRS::XmlProcessor::Libxml.encode_data(true).to_s.should == "true"
-        OpenSRS::XmlProcessor::Libxml.encode_data(false).to_s.should == "false"
-      end
-    end
-  end
-
-  describe '.parse' do
-    it "should handle scalar values" do
-      xml = %{<?xml version='1.0' encoding='UTF-8' standalone='no' ?>
-        <!DOCTYPE OPS_envelope SYSTEM 'ops.dtd'>
-        <OPS_envelope>
-          <header>
-            <version>1.0</version>
-          </header>
-          <body>
-            <data_block>
-              <dt_scalar>Tom Jones</dt_scalar>
-            </data_block>
-          </body>
-        </OPS_envelope>}
-
-      resp = OpenSRS::XmlProcessor::Libxml.parse(xml)
-      resp.should == "Tom Jones"
-    end
-
-    it "should handle associate arrays with arrays of values" do
-      xml = %{<?xml version='1.0' encoding='UTF-8' standalone='no' ?>
-      <!DOCTYPE OPS_envelope SYSTEM 'ops.dtd'>
-      <OPS_envelope>
-        <header>
-          <version>1.0</version>
-        </header>
-        <body>
-          <data_block>
-            <dt_assoc>
-              <item key='domain_list'>
-                <dt_array>
-                  <item key='0'>ns1.example.com</item>
-                  <item key='1'>ns2.example.com</item>
-                  <item key='2'>ns3.example.com</item>
-                </dt_array>
-              </item>
-            </dt_assoc>
-          </data_block>
-        </body>
-      </OPS_envelope>}
-
-      resp = OpenSRS::XmlProcessor::Libxml.parse(xml)
-      resp["domain_list"].class.should == Array
-      resp["domain_list"][0].should == "ns1.example.com"
-      resp["domain_list"][1].should == "ns2.example.com"
-      resp["domain_list"][2].should == "ns3.example.com"
-    end
-
-    it "should handle associative arrays containing other associative arrays" do
-      xml = %{<?xml version='1.0' encoding='UTF-8' standalone='no' ?>
-      <!DOCTYPE OPS_envelope SYSTEM 'ops.dtd'>
-      <OPS_envelope>
-        <header>
-          <version>1.0</version>
-        </header>
-        <body>
-          <data_block>
-            <dt_assoc>
-              <item key="contact_set">
-                <dt_assoc>
-                  <item key='owner'>
-                    <dt_assoc>
-                      <item key='first_name'>Tom</item>
-                      <item key='last_name'>Jones</item>
-                    </dt_assoc>
-                  </item>
-                  <item key='tech'>
-                    <dt_assoc>
-                      <item key='first_name'>Anne</item>
-                      <item key='last_name'>Smith</item>
-                    </dt_assoc>
-                  </item>
-                </dt_assoc>
-              </item>
-            </dt_assoc>
-          </data_block>
-        </body>
-      </OPS_envelope>}
-
-      resp = OpenSRS::XmlProcessor::Libxml.parse(xml)
-
-      resp["contact_set"]["owner"]["first_name"].should == "Tom"
-      resp["contact_set"]["owner"]["last_name"].should == "Jones"
-      resp["contact_set"]["tech"]["first_name"].should == "Anne"
-      resp["contact_set"]["tech"]["last_name"].should == "Smith"
-    end
-
-    context "with a balance enquiry example response" do
-      before(:each) do
-        xml = %{<?xml version='1.0' encoding='UTF-8' standalone='no' ?>
-          <!DOCTYPE OPS_envelope SYSTEM 'ops.dtd'>
-          <OPS_envelope>
-            <header>
-              <version>0.9</version>
-            </header>
-            <body>
-              <data_block>
-                <dt_assoc>
-                  <item key="protocol">XCP</item>
-                  <item key="action">REPLY</item>
-                  <item key="object">BALANCE</item>
-                  <item key="is_success">1</item>
-                  <item key="response_code">200</item>
-                  <item key="response_text">Command successful</item>
-                  <item key="attributes">
-                    <dt_assoc>
-                      <item key="balance">8549.18</item>
-                      <item key="hold_balance">1676.05</item>
-                    </dt_assoc>
-                  </item>
-                </dt_assoc>
-              </data_block>
-            </body>
-          </OPS_envelope>}
-
-        @resp = OpenSRS::XmlProcessor::Libxml.parse(xml)
-      end
-
-      it "produces a hash" do
-        @resp.should be_an_instance_of(Hash)
-      end
-
-      it "has top level keys" do
-        @resp["protocol"].should == "XCP"
-        @resp["action"].should == "REPLY"
-        @resp["object"].should == "BALANCE"
-      end
-
-      it "has second level keys" do
-        @resp["attributes"]["balance"].should == "8549.18"
-        @resp["attributes"]["hold_balance"].should == "1676.05"
-      end
-    end
-  end
-end

data/spec/opensrs/xml_processor/nokogiri_spec.rb

@@ -1,246 +0,0 @@
-require 'date'
-
-class OrderedHash < Hash
-end
-
-describe OpenSRS::XmlProcessor::Nokogiri do
-  describe ".build" do
-    it "should create XML for a nested hash" do
-      attributes = {:foo => {:bar => 'baz'}}
-      xml = OpenSRS::XmlProcessor::Nokogiri.build(attributes)
-      xml.should eq %{<?xml version=\"1.0\"?>\n<OPS_envelope>\n  <header>\n    <version>0.9</version>\n  </header>\n  <body>\n    <data_block>\n      <dt_assoc>\n        <item key=\"foo\">\n          <dt_assoc>\n            <item key=\"bar\">baz</item>\n          </dt_assoc>\n        </item>\n      </dt_assoc>\n    </data_block>\n  </body>\n</OPS_envelope>\n}
-    end
-  end
-
-  describe '.encode_data' do
-
-    before(:each) do
-      @builder = ::Nokogiri::XML::Builder.new
-      @doc     = @builder.doc
-    end
-
-    context "on a 3 element array" do
-      before(:each) do
-        @e = OpenSRS::XmlProcessor::Nokogiri.encode_data([1,2,3], @doc)
-      end
-
-      it { @e.should be_an_instance_of(::Nokogiri::XML::Element) }
-      it { @e.name.should eql('dt_array') }
-
-      it { @e.should have(3).children }
-      it { @e.children[0].name.should eql("item") }
-      it { @e.children[1].name.should eql("item") }
-      it { @e.children[2].name.should eql("item") }
-
-      it { @e.children[0].attributes["key"].value.should eql("0") }
-      it { @e.children[1].attributes["key"].value.should eql("1") }
-      it { @e.children[2].attributes["key"].value.should eql("2") }
-    end
-
-    context "on a hash" do
-      before(:each) do
-        @e = OpenSRS::XmlProcessor::Nokogiri.encode_data({:name => "kitteh"}, @doc)
-      end
-
-      it { @e.should be_an_instance_of(::Nokogiri::XML::Element) }
-      it { @e.name.should eql('dt_assoc') }
-
-      it { @e.should have(1).children }
-      it { @e.children[0].name.should eql('item') }
-      it { @e.children[0].attributes["key"].value.should eql('name') }
-    end
-
-    context "on a hash subclass" do
-      before(:each) do
-        ohash = OrderedHash.new
-        ohash[:name] = 'kitten'
-        @e = OpenSRS::XmlProcessor::Nokogiri.encode_data(ohash, @doc)
-      end
-
-      it { @e.should be_an_instance_of(::Nokogiri::XML::Element) }
-      it { @e.name.should eql('dt_assoc') }
-
-      it { @e.should have(1).children }
-      it { @e.children[0].name.should eql('item') }
-      it { @e.children[0].attributes["key"].value.should eql('name') }
-    end
-
-
-    context "on a nested hash" do
-      before(:each) do
-        @e          = OpenSRS::XmlProcessor::Nokogiri.encode_data({:suggestion => {:maximum => "10"}}, @doc)
-        @suggestion = @e.children[0]
-        @dt_assoc   = @suggestion.children[0]
-      end
-
-      it { @e.should be_an_instance_of(::Nokogiri::XML::Element) }
-      it { @e.name.should == 'dt_assoc' }
-
-      context "<item> child" do
-        it { @e.should have(1).children }
-        it { @suggestion.name.should eql('item') }
-        it { @suggestion.attributes["key"].value.should eql('suggestion') }
-      end
-
-      context "suggesion children" do
-        it { @suggestion.should have(1).children }
-        it { @dt_assoc.name.should eql('dt_assoc') }
-      end
-
-      context "dt_assoc children" do
-        before(:each) do
-          @maximum = @dt_assoc.children[0]
-        end
-        it { @dt_assoc.should have(1).children }
-        it { @maximum.name.should eql('item') }
-        it { @maximum.attributes["key"].value.should eql('maximum') }
-      end
-    end
-
-    context "produces a scalar" do
-      it { OpenSRS::XmlProcessor::Nokogiri.encode_data("cheezburger").to_s.should eql("cheezburger") }
-      it { OpenSRS::XmlProcessor::Nokogiri.encode_data("<smile>").to_s.should eql("<smile>") }
-
-      it { OpenSRS::XmlProcessor::Nokogiri.encode_data(12345).to_s.should eql("12345") }
-      it { OpenSRS::XmlProcessor::Nokogiri.encode_data(Date.parse("2010/02/12")).to_s.should eql("2010-02-12") }
-      it { OpenSRS::XmlProcessor::Nokogiri.encode_data(:name).to_s.should eql("name") }
-      it { OpenSRS::XmlProcessor::Nokogiri.encode_data(true).to_s.should eql("true") }
-      it { OpenSRS::XmlProcessor::Nokogiri.encode_data(false).to_s.should eql("false") }
-    end
-  end
-
-  describe '.parse' do
-
-    context "when scaler values" do
-      before(:each) do
-        xml = %{<?xml version='1.0' encoding='UTF-8' standalone='no' ?>
-          <!DOCTYPE OPS_envelope SYSTEM 'ops.dtd'>
-          <OPS_envelope>
-            <header>
-              <version>1.0</version>
-            </header>
-            <body>
-              <data_block>
-                <dt_scalar>Tom Jones</dt_scalar>
-              </data_block>
-            </body>
-          </OPS_envelope>}
-        @response = OpenSRS::XmlProcessor::Nokogiri.parse(xml)
-      end
-
-      it { @response.should eql("Tom Jones") }
-    end
-
-    context "when associative arrays with arrays of values" do
-      before(:each) do
-        xml = %{<?xml version='1.0' encoding='UTF-8' standalone='no' ?>
-        <!DOCTYPE OPS_envelope SYSTEM 'ops.dtd'>
-        <OPS_envelope>
-          <header>
-            <version>1.0</version>
-          </header>
-          <body>
-            <data_block>
-              <dt_assoc>
-                <item key='domain_list'>
-                  <dt_array>
-                    <item key='0'>ns1.example.com</item>
-                    <item key='1'>ns2.example.com</item>
-                    <item key='2'>ns3.example.com</item>
-                  </dt_array>
-                </item>
-              </dt_assoc>
-            </data_block>
-          </body>
-        </OPS_envelope>}
-
-        @response = OpenSRS::XmlProcessor::Nokogiri.parse(xml)
-      end
-
-      it { @response["domain_list"].class.should eql(Array) }
-      it { @response["domain_list"][0].should eql("ns1.example.com") }
-      it { @response["domain_list"][1].should eql("ns2.example.com") }
-      it { @response["domain_list"][2].should eql("ns3.example.com") }
-    end
-
-    context "when associative arrays containing other associative arrays" do
-      before(:each) do
-        xml = %{<?xml version='1.0' encoding='UTF-8' standalone='no' ?>
-        <!DOCTYPE OPS_envelope SYSTEM 'ops.dtd'>
-        <OPS_envelope>
-          <header>
-            <version>1.0</version>
-          </header>
-          <body>
-            <data_block>
-              <dt_assoc>
-                <item key="contact_set">
-                  <dt_assoc>
-                    <item key='owner'>
-                      <dt_assoc>
-                        <item key='first_name'>Tom</item>
-                        <item key='last_name'>Jones</item>
-                      </dt_assoc>
-                    </item>
-                    <item key='tech'>
-                      <dt_assoc>
-                        <item key='first_name'>Anne</item>
-                        <item key='last_name'>Smith</item>
-                      </dt_assoc>
-                    </item>
-                  </dt_assoc>
-                </item>
-              </dt_assoc>
-            </data_block>
-          </body>
-        </OPS_envelope>}
-
-        @response = OpenSRS::XmlProcessor::Nokogiri.parse(xml)
-      end
-      it { @response["contact_set"]["owner"]["first_name"].should eql("Tom") }
-      it { @response["contact_set"]["owner"]["last_name"].should eql("Jones") }
-      it { @response["contact_set"]["tech"]["first_name"].should eql("Anne") }
-      it { @response["contact_set"]["tech"]["last_name"].should eql("Smith") }
-    end
-
-    context "with a balance enquiry example response" do
-      before(:each) do
-        xml = %{<?xml version='1.0' encoding='UTF-8' standalone='no' ?>
-          <!DOCTYPE OPS_envelope SYSTEM 'ops.dtd'>
-          <OPS_envelope>
-            <header>
-              <version>0.9</version>
-            </header>
-            <body>
-              <data_block>
-                <dt_assoc>
-                  <item key="protocol">XCP</item>
-                  <item key="action">REPLY</item>
-                  <item key="object">BALANCE</item>
-                  <item key="is_success">1</item>
-                  <item key="response_code">200</item>
-                  <item key="response_text">Command successful</item>
-                  <item key="attributes">
-                    <dt_assoc>
-                      <item key="balance">8549.18</item>
-                      <item key="hold_balance">1676.05</item>
-                    </dt_assoc>
-                  </item>
-                </dt_assoc>
-              </data_block>
-            </body>
-          </OPS_envelope>}
-
-        @response = OpenSRS::XmlProcessor::Nokogiri.parse(xml)
-      end
-
-      it { @response.should be_an_instance_of(Hash) }
-      it { @response["protocol"].should eql("XCP") }
-      it { @response["action"].should eql("REPLY") }
-      it { @response["object"].should eql("BALANCE") }
-      it { @response["attributes"]["balance"].should eql("8549.18") }
-      it { @response["attributes"]["hold_balance"].should eql("1676.05") }
-
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,23 +0,0 @@
-require 'bundler/setup'
-
-Bundler.setup
-
-require 'opensrs'
-
-RSpec.configure do |config|
-  # config for rspec!
-end
-
-class OpenSRS::TestLogger
-
-  attr_reader :messages
-
-  def initialize
-    @messages = []
-  end
-
-  def info(message)
-    messages << message
-  end
-
-end