openshift-origin-console 1.3.2

data/test/functional/applications_controller_sanity_test.rb

@@ -0,0 +1,26 @@
+require File.expand_path('../../test_helper', __FILE__)
+
+class ApplicationsControllerSanityTest < ActionController::TestCase
+  tests ApplicationsController
+
+  def get_post_form(name = 'cart!diy-0.1')
+    {
+      :name => 'test1',
+      :application_type => name,
+      :domain_id => uuid.to_s
+    }
+  end
+
+  test "should create application and domain, and delete app" do
+    with_unique_user
+    post(:create, {:application => get_post_form})
+
+    assert app = assigns(:application)
+    assert app.errors.empty?, app.errors.to_hash.inspect
+    assert domain = assigns(:domain)
+    assert_redirected_to get_started_application_path(app, :wizard => true)
+
+    delete :destroy, :id => app.id
+    assert_redirected_to applications_path
+  end
+end

data/test/functional/applications_controller_test.rb

@@ -0,0 +1,365 @@
+require File.expand_path('../../test_helper', __FILE__)
+
+class ApplicationsControllerTest < ActionController::TestCase
+
+  test "should create and delete app" do
+    # in applications_controller_sanity_test
+  end
+
+  test 'template create and destroy' do
+    with_unique_domain
+    type = ApplicationType.all.select(&:template?).sample(1).first
+    omit("No templates are installed on this server") if type.nil?
+    post(:create, {:application => get_post_form(type.id)})
+
+    assert app = assigns(:application)
+    assert app.errors.empty?, app.errors.inspect
+    assert app.persisted?, app.inspect
+
+    app.destroy
+  end
+
+  test 'should redirect new to types' do
+    with_configured_user
+    get :new
+    assert_redirected_to application_types_path
+  end
+
+  test 'report and clear cached error if domain not found' do
+    with_configured_user
+    session[:domain] = 'does_not_exist'
+    get :index
+    assert_not_found_page(/Domain 'does_not_exist' does not exist/)
+    assert_nil session[:domain]
+  end
+
+  test 'index will cache domain' do
+    with_unique_domain
+    get :index
+    assert_equal @domain.id, session[:domain]
+  end
+
+  test 'index will use cached domain' do
+    with_unique_domain
+    session[:domain] = @domain.id
+    Domain.expects(:find).never
+    get :index
+    assert_equal @domain.id, session[:domain]
+  end
+
+  test "should assign domain errors on empty name" do
+    with_unique_user
+    app_params = get_post_form
+    post(:create, {:application => app_params})
+
+    assert_template 'application_types/show'
+    assert app = assigns(:application)
+    assert !app.errors.empty?
+    assert app.errors[:domain_name].present?, app.errors.inspect
+    assert_equal 1, app.errors[:domain_name].length
+  end
+
+  test "should assign errors on empty name" do
+    with_domain
+    app_params = get_post_form
+    app_params[:name] = ''
+    post(:create, {:application => app_params})
+
+    assert_template 'application_types/show'
+    assert app = assigns(:application)
+    assert !app.errors.empty?
+    assert app.errors[:name].present?, app.errors.inspect
+    assert_equal 1, app.errors[:name].length
+  end
+
+  test "should assign errors when advanced form" do
+    with_domain
+    app_params = get_post_form
+    app_params[:name] = ''
+    post(:create, {:application => app_params, :application_type => 'custom', :advanced => true})
+
+    assert_template 'application_types/show'
+    assert app = assigns(:application)
+    assert !app.errors.empty?
+    assert app.errors[:name].present?, app.errors.to_hash.inspect
+    assert_equal 1, app.errors[:name].length
+
+    assert_select '.alert.alert-error', /No cartridges are defined for this type/i
+    assert_select 'h3 > span.text-warning', 'None'
+    assert_select '.btn-primary[disabled=disabled]'
+    assert_select "select[name='application[scale]']"
+    assert_select "input[name='application[initial_git_url]']" do |inputs|
+      assert_nil inputs.first['value']
+    end
+    #assert_select "input[name='application[initial_git_branch]']" do |inputs|
+    #  assert_nil inputs.first['value']
+    #end
+  end
+
+  test "should assign errors when advanced form with carts" do
+    with_domain
+    app_params = get_post_form
+    app_type = {
+      :id => 'custom',
+      :cartridges => ['ruby-'],
+      :initial_git_url => 'http://foo.com',
+      :initial_git_branch => 'bar',
+    }
+    app_params[:name] = ''
+    app_params[:cartridges] = ['ruby-1.8']
+    app_params[:scale] = 'true'
+    post(:create, {:application => app_params, :application_type => app_type, :advanced => true})
+
+    assert_template 'application_types/show'
+    assert app = assigns(:application)
+    assert !app.errors.empty?
+    assert app.errors[:name].present?, app.errors.inspect
+    assert_equal 1, app.errors[:name].length
+
+    assert_select '.alert.alert-error', /Application name is required/i
+    assert_select "select[name='application[scale]'] > option[selected]", 'Scale with web traffic'
+    assert_select "input[name='application[initial_git_url]'][value=http://foo.com]"
+    #assert_select "input[name='application[initial_git_branch]'][value=bar]"
+    assert_select "select[name='application[cartridges][]'] > option[selected]", 'Ruby 1.8'
+  end
+
+  test "should assign errors on long name" do
+    with_domain
+    app_params = get_post_form
+    app_params[:name] = 'aoeu'*30
+    post(:create, {:application => app_params})
+
+    assert_template 'application_types/show'
+    assert app = assigns(:application)
+    assert assigns(:domain)
+    assert !app.errors.empty?
+    assert app.errors[:name].present?, app.errors.inspect
+    assert_equal 1, app.errors[:name].length, app.errors.inspect
+  end
+
+  test "should assign errors on invalid characters" do
+    with_domain
+    app_params = get_post_form
+    app_params[:name] = '@@ @@'
+    post(:create, {:application => app_params})
+
+    assert_template 'application_types/show'
+    assert app = assigns(:application)
+    assert assigns(:domain)
+    assert !app.errors.empty?
+    assert app.errors[:name].present?, app.errors.inspect
+    assert_equal 1, app.errors[:name].length, app.errors.inspect
+  end
+
+  test "should assign errors on invalid gear size" do
+    with_domain
+    app_params = get_post_form
+    app_params[:gear_profile] = 'foobar'
+    post(:create, {:application => app_params})
+
+    assert_template 'application_types/show'
+    assert app = assigns(:application)
+    assert !app.persisted?
+    assert !app.errors.empty?
+    # I need to be fixed to be gear_profile
+    assert app.errors[:node_profile].present?, app.errors.to_hash.inspect
+    assert_equal 1, app.errors[:node_profile].length, app.errors.to_hash.inspect
+
+    assert_select '.alert', /Invalid size: foobar/i
+  end
+
+  test "should retrieve application list" do
+    app = with_app
+
+    # get full version of the list
+    get(:index)
+    apps = assigns(:applications)
+    assert apps
+    assert_equal apps.length, 1
+    apps[0].name == app.name
+    assert_response :success
+  end
+
+  test "should filter application list with name" do
+    app = with_app
+
+    # get a filtered version of the list
+    get(:index, :applications_filter => {:name => app.name})
+    apps = assigns(:applications)
+    assert apps
+    assert_equal apps.length, 1
+    assert_equal apps[0].name, app.name
+    assert_response :success
+  end
+
+  test "should not filter application list with other name" do
+    app = with_app
+
+    # get a filtered version of the list
+    get(:index, :applications_filter => {:name => 'not'})
+    apps = assigns(:applications)
+    assert apps
+    assert_equal apps.length, 0
+    assert_response :success
+  end
+
+  test "should retrieve application details" do
+    get :show, :id => with_app.name
+    assert_response :success
+    assert app = assigns(:application)
+    assert_equal with_app.name, app.name
+    assert groups = assigns(:gear_groups)
+    assert_equal 1, groups.length
+    assert (groups[0].cartridges.map(&:name) - with_app.cartridges.map(&:name)).empty?
+    assert groups[0].cartridges[0].display_name
+    assert domain = assigns(:domain)
+    assert !assigns(:has_keys)
+  end
+
+  test "should retrieve application details with has_sshkey cache set" do
+    session[:has_sshkey] = true
+    get :show, :id => with_app.name
+    assert_response :success
+    assert app = assigns(:application)
+    assert has_keys = assigns(:has_keys)
+  end
+
+  test "should retrieve scalable application details" do
+    get :show, :id => with_scalable_app.name
+    assert_response :success
+    assert app = assigns(:application)
+    assert_equal with_scalable_app.name, app.name
+    assert groups = assigns(:gear_groups)
+    assert_equal 1, groups.length, groups.pretty_inspect
+    assert (groups[0].cartridges.map(&:name) - with_scalable_app.cartridges.map(&:name)).empty?
+    assert domain = assigns(:domain)
+  end
+
+  test "should retrieve application get started page" do
+    get :get_started, :id => with_app.name
+    assert_response :success
+    assert app = assigns(:application)
+    assert_equal with_app.name, app.name
+  end
+
+  test "should retrieve application delete confirm page" do
+    get :delete, :id => with_app.name
+    assert_response :success
+    assert app = assigns(:application)
+    assert_equal with_app.name, app.name
+  end
+
+  test "should result in a not found error when retrieving an application that does not exist" do
+    with_app
+    with_rescue_from{ get :show, :id => 'idontexist' }
+    assert_response :success
+    assert_select 'h1', /Application 'idontexist' does not exist/
+    assert_select 'a', "Application #{with_app.name}"
+  end
+
+  test "should result in a not found when retrieving a domain that does not exist" do
+    with_unique_user
+    with_rescue_from{ get :show, :id => 'idontexist' }
+    assert_response :success
+    assert_select 'h1', /Domain does not exist/
+  end
+
+  test "should result in a not found when retrieving an application that does not exist" do
+    with_domain
+    get :show, :id => 'idontexist'
+    assert_response :success
+    assert_select 'h1', /Application 'idontexist' does not exist/
+  end
+
+  test 'should combine messages correctly for template creation' do
+    with_unique_domain
+    template = ApplicationType.all.select(&:template?).select{ |t| t.template.credentials_message }.sample(1).first
+    omit("No templates installed on this system") if template.nil?
+    saved = states('saved').starts_as('no')
+    Application.any_instance.expects(:save).returns(true).then(saved.is('yes'))
+    Application.any_instance.expects(:persisted?).at_least_once.returns(false).when(saved.is('no'))
+    Application.any_instance.expects(:persisted?).at_least_once.returns(true).when(saved.is('yes'))
+    Application.any_instance.expects(:remote_results).at_least_once.returns(['message'])
+    post(:create, {:application => get_post_form(template.id)})
+
+    assert_equal ['message', template.template.credentials_message], flash[:info_pre]
+  end
+
+  test 'invalid destroy should render page' do
+    Application.any_instance.expects(:destroy).returns(false)
+    delete :destroy, :id => with_app.name
+    assert_response :success
+    assert_template :delete
+  end
+
+  test 'should support the creation of scalable apps with medium gears for privileged users' do
+    with_user_with_multiple_gear_sizes
+    find_or_create_domain
+
+    user = User.find(:one, :as => @controller.current_user)
+    @domain.applications.each(&:destroy) unless user.gears_free >= 2
+
+    medium_gear_app = {
+      :name => uuid,
+      :application_type => 'cart!php-5.3',
+      :gear_profile => 'medium',
+      :scale => 'true',
+      :domain_name => @domain.name
+    }
+
+    # Make the request
+    post(:create, {:application => medium_gear_app})
+
+    # Confirm app attributes
+    assert app = assigns(:application)
+    assert app.errors.empty?, app.errors.inspect
+    assert_equal 'medium', app.gear_profile
+    assert_equal 'true', app.scale.to_s
+    assert app.persisted?
+
+    app.destroy
+  end
+
+  test 'should not allow medium gears for non-privileged users' do
+    with_unique_domain
+    medium_gear_app_form = {
+      :name => uuid,
+      :application_type => 'cart!php-5.3',
+      :gear_profile => 'medium',
+      :domain_name => @domain.name
+    }
+
+    post(:create, {:application => medium_gear_app_form})
+
+    assert_response :success
+    assert app = assigns(:application)
+    assert app.errors.messages[:node_profile][0].match('Invalid Size: medium')
+  end
+
+  test 'should prevent scaled apps when not enough gears are available' do
+    # This space intentionally left blank;
+    # Testing this end-to-end would be relatively time consuming right now.
+  end
+
+#  test "should check for empty name" do
+#    form = get_post_form
+#    form[:name]=''
+#    post(:create, {:application => form})
+#    assert assigns(:application)
+#    assert assigns(:application).errors[:name].length > 0
+#    assert_response :success
+#  end
+
+#  test "should redirect on success" do
+#    post(:create, :application => get_post_form)
+#    assert assigns(:application)
+#    assert assigns(:application).errors.empty?
+#    assert_redirected_to :action => 'show'
+#    assert_template
+#  end
+
+  def get_post_form(name = 'cart!diy-0.1')
+    {:name => 'test1', :application_type => name}
+  end
+
+end

data/test/functional/building_controller_test.rb

@@ -0,0 +1,203 @@
+require File.expand_path('../../test_helper', __FILE__)
+require 'mocha'
+
+class BuildingControllerTest < ActionController::TestCase
+
+  uses_http_mock
+
+  def domain
+    {:id => 'test'}
+  end
+  def app_without_builds
+    {:name => 'test', :framework => 'php-5.3'}
+  end
+  def app_can_build
+    {:name => 'test', :framework => 'php-5.3', :building_app => 'jenkins'}
+  end
+  def app_with_builds
+    {:name => 'test', :framework => 'php-5.3', :building_with => 'jenkins-client-1.4', :build_job_url => 'Job URL: http://foo/builds', :building_app => 'jenkins'}
+  end
+  def jenkins_app
+    {:name => 'jenkins', :framework => 'jenkins-1.4'}
+  end
+
+  def with_app(other_app=nil, app=app_without_builds)
+    with_unique_user
+
+    ActiveResource::HttpMock.respond_to(false) do |mock|
+      mock.delete '/broker/rest/domains/test/applications/test/cartridges/jenkins-client-1.4.json', json_header, {}.to_json
+      mock.get '/broker/rest/cartridges.json', anonymous_json_header, [
+        {:name => 'jenkins-client-1.4', :tags => ['ci_builder']},
+        {:name => 'jenkins-1.4', :tags => ['ci']},
+      ].to_json
+      mock.get '/broker/rest/domains.json', json_header, [domain].to_json
+      mock.get '/broker/rest/domains/test/applications/test.json', json_header, app.to_json
+      mock.get '/broker/rest/domains/test/applications/jenkins.json', json_header, other_app.to_json if other_app
+      mock.get '/broker/rest/domains/test/applications.json', json_header, [app, other_app].compact.to_json
+      mock.get '/broker/rest/domains/test/applications/test/gear_groups.json', json_header, [
+        {:name => '@@app/comp-web/php-5.3', :gears => [
+          {:id => 1, :state => 'started'}
+        ], :cartridges => [
+          {:name => 'php-5.3'},
+        ]},
+        {:name => '@@app/comp-proxy/php-5.3', :gears => [
+          {:id => 2, :state => 'started'},
+        ], :cartridges => [
+          {:name => 'php-5.3'},
+          {:name => 'haproxy-1.4'},
+        ]},
+        {:name => '@@app/comp-mysql/mysql-5.0', :gears => [
+          {:id => 3, :state => 'started'},
+        ], :cartridges => [
+          {:name => 'my-sql-5.0'},
+        ]},
+      ].to_json
+    end
+    {:application_id => 'test'}
+  end
+
+  def with_jenkins_and_app
+    with_unique_user
+    with_app(jenkins_app, app_can_build)
+  end
+
+  def with_builds
+    with_unique_user
+    with_app(jenkins_app, app_with_builds)
+  end
+
+  test "should get redirected from show without jenkins client" do
+    get :show, with_app
+    assert app = assigns(:application)
+    assert assigns(:domain)
+    assert_redirected_to new_application_building_path(app)
+  end
+
+  test "should get redirected from delete without jenkins client" do
+    get :delete, with_app
+    assert app = assigns(:application)
+    assert assigns(:domain)
+    assert_redirected_to new_application_building_path(app)
+  end
+
+  test "should destroy" do
+    delete :destroy, with_app
+    assert app = assigns(:application)
+    assert assigns(:domain)
+    assert_redirected_to application_path(app)
+  end
+
+  test "should redraw if destroy fails" do
+    args = with_builds
+    ActiveResource::HttpMock.respond_to(false) do |mock|
+      mock.delete '/broker/rest/domains/test/applications/test/cartridges/jenkins-client-1.4.json', json_header, {:messages => [{:text => 'unable to delete'}]}.to_json, 422
+    end
+
+    delete :destroy, args
+    assert assigns(:application)
+    assert assigns(:domain)
+    assert_response :success
+    assert_template :delete
+    assert_select '.alert-error', 'unable to delete'
+  end
+
+  test "should see new page without a jenkins app" do
+    get :new, with_app
+    assert app = assigns(:application)
+    assert assigns(:domain)
+    assert jenk = assigns(:jenkins_server)
+    assert !jenk.persisted?
+    assert cart = assigns(:cartridge)
+    assert !cart.persisted?
+    assert_response :success
+  end
+
+  test "should see new page and load jenkins app" do
+    get :new, with_jenkins_and_app
+    assert app = assigns(:application)
+    assert assigns(:domain)
+    assert jenk = assigns(:jenkins_server)
+    assert jenk.persisted?
+    assert cart = assigns(:cartridge)
+    assert !cart.persisted?
+    assert_response :success
+  end
+
+  test "should tell the user when the Jenkins app isn't yet registered w/ DNS" do
+    # Don't actually sleep for 10 seconds at a go within this test.
+    BuildingController.any_instance.expects(:sleep).at_least_once
+
+    # Set up the cartridge save attempt to fail
+    Cartridge.any_instance.expects(:save).at_least_once.returns(false)
+    Cartridge.any_instance.expects(:has_exit_code?).at_least_once.returns(true)
+
+    # Build the REST environment
+    args = with_app(jenkins_app, app_can_build)
+
+    ActiveResource::HttpMock.respond_to(false) do |mock|
+      mock.post '/broker/rest/domains/test/applications/test/cartridges.json', json_header(true), { :name => 'jenkins-client-1.4' }.to_json, 422
+    end
+
+    # Simulate the POST
+    post :create, args
+
+    # Check that the flash text matches our desired message
+    assert_match /^The Jenkins server is not yet registered with DNS/, flash[:info_pre]
+  end
+
+  test "should create a jenkins server if it does not exist" do
+    args = with_app(nil, app_without_builds)
+
+    ActiveResource::HttpMock.respond_to(false) do |mock|
+      mock.post '/broker/rest/domains/test/applications/test/cartridges.json', json_header(true), { :name => 'jenkins-client-1.4' }.to_json, 201
+      mock.post '/broker/rest/domains/test/applications.json', json_header(true), { :name => 'jenkins2', :framework => 'jenkins-1.4', :messages => [{:field => 'result', :text => 'App remote message'}] }.to_json, 201
+    end
+
+    post :create, args.merge({:application => {:name => 'jenkins2'}})
+
+    assert_redirected_to application_building_path(args[:application_id])
+    assert flash[:info_pre].include? 'App remote message'
+  end
+
+  test "should stop if server creation fails" do
+    args = with_app(nil, app_without_builds)
+
+    ActiveResource::HttpMock.respond_to(false) do |mock|
+      mock.post '/broker/rest/domains/test/applications.json', json_header(true), { :name => 'jenkins2', :framework => 'jenkins-1.4', :messages => [{:field => 'base', :text => 'App remote error'}] }.to_json, 422
+    end
+
+    post :create, args.merge({:application => {:name => 'jenkins2'}})
+
+    assert_response :success
+    assert_template :new
+    assert_select '.alert-error', 'App remote error'
+  end
+
+  test "should create a jenkins server and redraw if cart fails" do
+    args = with_app(nil, app_without_builds)
+
+    ActiveResource::HttpMock.respond_to(false) do |mock|
+      mock.post '/broker/rest/domains/test/applications/test/cartridges.json', json_header(true), { :name => 'jenkins-client-1.4' }.to_json, 422
+      mock.post '/broker/rest/domains/test/applications.json', json_header(true), { :name => 'jenkins2', :framework => 'jenkins-1.4', :messages => [{:field => 'result', :text => 'App remote message'}] }.to_json, 201
+    end
+
+    post :create, args.merge({:application => {:name => 'jenkins2'}})
+
+    body = mock_body_for{ |r| /applications.json/ =~ r.path }
+    assert_equal 'jenkins-1.4', body['cartridge']
+    assert_equal 'jenkins2', body['name']
+
+    assert_response :success
+    assert_template :new
+    assert flash[:info_pre].include? 'App remote message'
+  end
+
+  test "should show if all components exist" do
+    get :show, with_builds
+    assert app = assigns(:application)
+    assert app.builds?, app.build_job_url
+    assert app.building_with
+    assert assigns(:domain)
+    assert_response :success
+  end
+end