openproject-token 2.0 → 2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5da90cc05359f099b94484c379973b4c4464b8f9ef7f6d20bdefba2b4fc61537
-  data.tar.gz: 5f87461bbf02ecf0d8c5663b4dba13ea9c511dbd807d8c3e15e4adfe5c040f57
+  metadata.gz: ead9b5f2d9c6a6397a00c9b78b808ffa9c181787f35103cbfca3167932f01f8f
+  data.tar.gz: 5fd6f7a10fbaaa88c74e843dd90c8aa85cd190e44e73f3338f84d571d5bd2794
 SHA512:
-  metadata.gz: dd82c0f1815535f7e568d969a1c4e469beaf4d5470014c59496c12e2cd82edf0b9c6e6d9267cfa4b97ef9b6408a737f41fb1d8ae3cdb70c7353ae29f4e7cb940
-  data.tar.gz: ec350f3838ec36b45fb6d0671bac492abd0bf7b5975ced83f2c430b6148274e34d93907525830aa4c5dc44fc2e2182f4092d7bc818d11bfdcd906a77a5411eda
+  metadata.gz: 24cda16d34060e6c6a0b76a36243c1c83caff021adc0fe768ed5f4093639de923597a9f46adf48cac7ef295cd0e7b2a5bb88a2cc03ea74eb06c1419c98f73921
+  data.tar.gz: b5373b041a70d3402881fa4b4fbcf1cecfb36d996c67d61373daf004e88e04a528bfbfa9e909dce749fbd19578d9ad052267999f59122ced451588543a5c0643

data/lib/open_project/token.rb

@@ -155,13 +155,8 @@ module OpenProject
 
     def load_attributes(attributes)
       attributes = Hash[attributes.map { |k, v| [k.to_s, v] }]
-      version = attributes["version"].then { |v| v && Gem::Version.new(v) } || current_gem_version
 
-      if version > current_gem_version
-        raise ArgumentError, "Version is too new"
-      end
-
-      @version = version.to_s
+      @version = read_version attributes
       @subscriber = attributes["subscriber"]
       @mail = attributes["mail"]
       @company = attributes["company"]
@@ -184,6 +179,37 @@ module OpenProject
       end
     end
 
+    ##
+    # Reads the version from the given attributes hash.
+    # Besides the usual values it allows for a special value `-1`.
+    # This is then results in the version being `nil` specifically rather than
+    # the current gem version by default.
+    #
+    # This way the generated token will get what ever version the importing party
+    # has. This is important due to a bug in openproject-token 1.x where any version
+    # other than `nil` (or the integer literal 1) results in a "Version is too new" error.
+    # This affects all OpenProject installations with a version older than 10.6
+    # which will run into internal server errors trying to activate their Enterprise
+    # tokens due to this.
+    #
+    # Generating tokens with version `-1` prevents that.
+    #
+    # @param attr [Hash] Parsed token attributes.
+    def read_version(attr)
+      value = attr["version"]
+      version = nil
+
+      if value.to_s != "-1"
+        version = value.then { |v| v && Gem::Version.new(v) } || current_gem_version
+
+        if version > current_gem_version
+          raise ArgumentError, "Version is too new"
+        end
+      end
+
+      version
+    end
+
     def date_attribute_keys
       %w(starts_at issued_at expires_at notify_admins_at notify_users_at block_changes_at)
     end

data/lib/open_project/token/version.rb

@@ -1,5 +1,5 @@
 module OpenProject
   class Token
-    VERSION = "2.0"
+    VERSION = "2.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openproject-token
 version: !ruby/object:Gem::Version
-  version: '2.0'
+  version: '2.1'
 platform: ruby
 authors:
 - OpenProject GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-15 00:00:00.000000000 Z
+date: 2020-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -84,7 +84,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: OpenProject EE token reader