openproject-primer_view_components 0.91.0 → 0.91.1

data/app/components/primer/alpha/action_menu/action_menu_element.js

@@ -480,6 +480,7 @@ _ActionMenuElement_handleItemActivated = function _ActionMenuElement_handleItemA
 _ActionMenuElement_handleIncludeFragmentReplaced = function _ActionMenuElement_handleIncludeFragmentReplaced() {
     __classPrivateFieldGet(this, _ActionMenuElement_instances, "a", _ActionMenuElement_firstItem_get)?.focus();
     __classPrivateFieldGet(this, _ActionMenuElement_instances, "m", _ActionMenuElement_softDisableItems).call(this);
+    this.overlay?.update();
     // async items have loaded, so component is ready
     this.setAttribute('data-ready', 'true');
 };

data/app/components/primer/alpha/action_menu/action_menu_element.ts

@@ -472,6 +472,7 @@ export class ActionMenuElement extends HTMLElement {
   #handleIncludeFragmentReplaced() {
     this.#firstItem?.focus()
     this.#softDisableItems()
+    this.overlay?.update()
 
     // async items have loaded, so component is ready
     this.setAttribute('data-ready', 'true')

data/app/controllers/primer/view_components/action_menu_controller.rb

@@ -10,6 +10,7 @@ module Primer
       def landing; end
 
       def deferred
+        sleep params[:delay].to_f if params[:delay].present?
         render "primer/view_components/action_menu/deferred"
       end
 

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 91
-      PATCH = 0
+      PATCH = 1
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/previews/primer/alpha/action_menu_preview/with_deferred_content_near_bottom_of_viewport.html.erb

@@ -0,0 +1,10 @@
+<%# The invoker is pinned near the bottom of the viewport, leaving enough room for the loading %>
+<%# spinner placeholder to fit below it but not enough for the full deferred content, reproducing %>
+<%# the scenario from DREAM-729. The `delay` param forces the fragment response to arrive after the %>
+<%# overlay has already been positioned using the placeholder's size, instead of racing the fetch %>
+<%# against the initial position calculation. %>
+<div style="position: fixed; bottom: 100px; right: 0;">
+  <%= render(Primer::Alpha::ActionMenu.new(menu_id: "deferred-bottom", src: primer_view_components.action_menu_deferred_path(delay: 0.3))) do |menu| %>
+    <% menu.with_show_button { "Menu with deferred content" } %>
+  <% end %>
+</div>

data/previews/primer/alpha/action_menu_preview.rb

@@ -310,6 +310,13 @@ module Primer
         render_with_template(locals: { nest_in_sub_menu: nest_in_sub_menu })
       end
 
+      # @label With deferred content near the bottom of the viewport
+      #
+      # @hidden
+      def with_deferred_content_near_bottom_of_viewport
+        render_with_template
+      end
+
       # @label With deferred preloaded content
       #
       def with_deferred_preloaded_content

data/static/info_arch.json

@@ -1438,6 +1438,19 @@
           ]
         }
       },
+      {
+        "preview_path": "primer/alpha/action_menu/with_deferred_content_near_bottom_of_viewport",
+        "name": "with_deferred_content_near_bottom_of_viewport",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
       {
         "preview_path": "primer/alpha/action_menu/with_deferred_preloaded_content",
         "name": "with_deferred_preloaded_content",

data/static/previews.json

@@ -632,6 +632,19 @@
           ]
         }
       },
+      {
+        "preview_path": "primer/alpha/action_menu/with_deferred_content_near_bottom_of_viewport",
+        "name": "with_deferred_content_near_bottom_of_viewport",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
       {
         "preview_path": "primer/alpha/action_menu/with_deferred_preloaded_content",
         "name": "with_deferred_preloaded_content",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.91.0
+  version: 0.91.1
 platform: ruby
 authors:
 - GitHub Open Source
@@ -985,6 +985,7 @@ files:
 - previews/primer/alpha/action_menu_preview/two_menus.html.erb
 - previews/primer/alpha/action_menu_preview/with_actions.html.erb
 - previews/primer/alpha/action_menu_preview/with_deferred_content.html.erb
+- previews/primer/alpha/action_menu_preview/with_deferred_content_near_bottom_of_viewport.html.erb
 - previews/primer/alpha/auto_complete_preview.rb
 - previews/primer/alpha/banner_preview.rb
 - previews/primer/alpha/banner_preview/with_action_button.html.erb