openproject-primer_view_components 0.90.1 → 0.91.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ef0f7482a2f05830e52f6bf79c82a255a5f93a6e0633254ef227cc0d9dac286
-  data.tar.gz: 97754d52c0c02941f138b71b1ca91a7de5e0fc62231984e488dc2ce06eed5695
+  metadata.gz: 9ece162d4bb90c9a0ff47147f17ca78a9f912d60278ae9bcc1c2c2158c443313
+  data.tar.gz: e171dfb9237266657147896d20fe7ca5be60b50b8787b37f95fdcce75136d586
 SHA512:
-  metadata.gz: '08227413c52a33a55b8bb8cffd1796a77a5ad8b532aa46ce5eeab6fefc0811b1eae0be865c91e4201b63eeb55a3115cf9ef85f83d7fc15c15e51bf9d49c32e06'
-  data.tar.gz: a1298136e10b35f585cc468e020282cd7e3c2efe0578f10ff5700faa7adc6ce828113e9d3b7a162c3d7f7e19bb38a325961f31b2645f13bb059a6e3f2cd4d3ff
+  metadata.gz: 569f889fe63f22c6f9ecef37ebdd5627734d5e600fc65b5f806d4dfb445cc3d27c0748b3813c255ebb75f29bd5137684d61e140b87a24ad1bb873e3f2ba2dcb9
+  data.tar.gz: 35feb5d650bf1676a5af0aa088d224b87d7626cc91440a9562756a5a69157548885a90fdbc91c4d54b4a0311aac24a5edaeeddc9e62dccf4dbd3c1666b316311

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 0.91.0
+
+### Minor Changes
+
+- [#512](https://github.com/opf/primer_view_components/pull/512) [`22fbe59`](https://github.com/opf/primer_view_components/commit/22fbe5973c85d47a2d9c6369e6b769076b997190) Thanks [@HDinger](https://github.com/HDinger)! - Support async TreeViews for select variant :single and :multiple for select strategy :self
+
 ## 0.90.1
 
 ### Patch Changes

data/app/components/primer/alpha/tree_view/sub_tree_node.rb

@@ -185,8 +185,8 @@ module Primer
         def render_in(*args, **_kwargs, &block)
           super.tap do
             # check this _after_ rendering so @sub_tree's slots are defined
-            if @node.select_variant != :none && @sub_tree.defer?
-              raise ArgumentError, "TreeView does not currently support select variants for sub-trees loaded asynchronously."
+            if @node.select_variant == :multiple && @sub_tree.defer? && @select_strategy != :self
+              raise ArgumentError, "TreeView does not currently support the multiple select variant with #{@select_strategy.inspect} select strategy for sub-trees loaded asynchronously."
             end
           end
         end

data/app/controllers/primer/view_components/tree_view_items_controller.rb

@@ -46,7 +46,8 @@ module Primer
 
         render(
           locals: {
-            action_menu_expanded: params[:action_menu_expanded] == "true"
+            action_menu_expanded: params[:action_menu_expanded] == "true",
+            select_variant: (params[:select_variant] || :none).to_sym
           }
         )
       end

data/app/views/primer/view_components/tree_view_items/async_alpha.html_fragment.erb

@@ -1,21 +1,21 @@
 <%= render(Primer::Alpha::TreeView::SubTree.new(path: ["primer"], node_variant: :div)) do |tree| %>
-  <% tree.with_sub_tree(label: "alpha") do |sub_tree| %>
+  <% tree.with_sub_tree(label: "alpha", select_variant: select_variant, select_strategy: :self) do |sub_tree| %>
     <% sub_tree.with_leading_visual_icons do |icons| %>
       <% icons.with_expanded_icon(icon: :"file-directory-open-fill", color: :accent) %>
       <% icons.with_collapsed_icon(icon: :"file-directory-fill", color: :accent) %>
     <% end %>
 
-    <% sub_tree.with_sub_tree(label: "action_menu", expanded: action_menu_expanded) do |sub_tree| %>
+    <% sub_tree.with_sub_tree(label: "action_menu", expanded: action_menu_expanded, select_variant: select_variant, select_strategy: :self) do |sub_tree| %>
       <% sub_tree.with_leading_visual_icons do |icons| %>
         <% icons.with_expanded_icon(icon: :"file-directory-open-fill", color: :accent) %>
         <% icons.with_collapsed_icon(icon: :"file-directory-fill", color: :accent) %>
       <% end %>
 
-      <% sub_tree.with_leaf(label: "group.rb") do |item| %>
+      <% sub_tree.with_leaf(label: "group.rb", select_variant: select_variant) do |item| %>
         <% item.with_leading_visual_icon(icon: :file) %>
       <% end %>
 
-      <% sub_tree.with_leaf(label: "heading.rb") do |item| %>
+      <% sub_tree.with_leaf(label: "heading.rb", select_variant: select_variant) do |item| %>
         <% item.with_leading_visual_icon(icon: :file) %>
       <% end %>
     <% end %>

data/lib/primer/view_components/version.rb

@@ -5,8 +5,8 @@ module Primer
   module ViewComponents
     module VERSION
       MAJOR = 0
-      MINOR = 90
-      PATCH = 1
+      MINOR = 91
+      PATCH = 0
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/previews/primer/alpha/tree_view_preview/async_alpha.html.erb

@@ -1,12 +1,12 @@
 <div style="max-width: 400px">
   <%= render(Primer::Alpha::TreeView.new) do |tree_view| %>
-    <% tree_view.with_sub_tree(label: "primer") do |sub_tree| %>
+    <% tree_view.with_sub_tree(label: "primer", select_variant: select_variant, select_strategy: :self) do |sub_tree| %>
       <% sub_tree.with_leading_visual_icons do |icons| %>
         <% icons.with_expanded_icon(icon: :"file-directory-open-fill", color: :accent) %>
         <% icons.with_collapsed_icon(icon: :"file-directory-fill", color: :accent) %>
       <% end %>
 
-      <% sub_tree.with_loading_skeleton(src: primer_view_components.tree_view_items_async_alpha_path(action_menu_expanded: action_menu_expanded)) %>
+      <% sub_tree.with_loading_skeleton(src: primer_view_components.tree_view_items_async_alpha_path(action_menu_expanded: action_menu_expanded, select_variant: select_variant)) %>
     <% end %>
   <% end %>
 </div>

data/previews/primer/alpha/tree_view_preview/async_form_input.html.erb

@@ -0,0 +1,16 @@
+<%= form_with(url: primer_view_components.generic_form_submission_path(format: :json)) do |f| %>
+  <%= render(Primer::Alpha::Stack.new) do %>
+    <%= render(Primer::Alpha::TreeView.new(form_arguments: { builder: f, name: "folder_structure" })) do |tree| %>
+      <% tree.with_sub_tree(label: "primer", select_variant: select_variant, select_strategy: :self) do |sub_tree| %>
+        <% sub_tree.with_leading_visual_icons do |icons| %>
+          <% icons.with_expanded_icon(icon: :"file-directory-open-fill", color: :accent) %>
+          <% icons.with_collapsed_icon(icon: :"file-directory-fill", color: :accent) %>
+        <% end %>
+
+        <% sub_tree.with_loading_skeleton(src: primer_view_components.tree_view_items_async_alpha_path(select_variant: select_variant)) %>
+      <% end %>
+    <% end %>
+
+    <%= render(Primer::Alpha::SubmitButton.new(name: :submit, label: "Submit")) %>
+  <% end %>
+<% end %>

data/previews/primer/alpha/tree_view_preview.rb

@@ -114,9 +114,11 @@ module Primer
       # @label Async alpha
       #
       # @param action_menu_expanded [Boolean] toggle
-      def async_alpha(action_menu_expanded: false)
+      # @param select_variant [Symbol] select [none, single, multiple]
+      def async_alpha(action_menu_expanded: false, select_variant: :none)
         render_with_template(locals: {
-          action_menu_expanded: coerce_bool(action_menu_expanded)
+          action_menu_expanded: coerce_bool(action_menu_expanded),
+          select_variant: select_variant.to_sym
         })
       end
 
@@ -197,6 +199,15 @@ module Primer
         })
       end
 
+      # @label Async form input
+      # @hidden
+      # @param select_variant [Symbol] select [single, multiple]
+      def async_form_input(select_variant: :single)
+        render_with_template(locals: {
+          select_variant: select_variant.to_sym
+        })
+      end
+
       # @label Doubled paths
       # @hidden
       def doubled_path

data/static/info_arch.json

@@ -10870,6 +10870,19 @@
           ]
         }
       },
+      {
+        "preview_path": "primer/alpha/tree_view/async_form_input",
+        "name": "async_form_input",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
       {
         "preview_path": "primer/alpha/tree_view/doubled_path",
         "name": "doubled_path",

data/static/previews.json

@@ -4932,6 +4932,19 @@
           ]
         }
       },
+      {
+        "preview_path": "primer/alpha/tree_view/async_form_input",
+        "name": "async_form_input",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
       {
         "preview_path": "primer/alpha/tree_view/doubled_path",
         "name": "doubled_path",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.90.1
+  version: 0.91.0
 platform: ruby
 authors:
 - GitHub Open Source
@@ -1097,6 +1097,7 @@ files:
 - previews/primer/alpha/tooltip_preview/with_right_most_position.html.erb
 - previews/primer/alpha/tree_view_preview.rb
 - previews/primer/alpha/tree_view_preview/async_alpha.html.erb
+- previews/primer/alpha/tree_view_preview/async_form_input.html.erb
 - previews/primer/alpha/tree_view_preview/buttons.html.erb
 - previews/primer/alpha/tree_view_preview/default.html.erb
 - previews/primer/alpha/tree_view_preview/doubled_path.html.erb