openproject-primer_view_components 0.84.4 → 0.84.5

data/app/components/primer/alpha/action_menu/action_menu_element.js

@@ -19,6 +19,7 @@ var _ActionMenuElement_instances, _a, _ActionMenuElement_abortController, _Actio
 var ActionMenuElement_1;
 import { controller, target } from '@github/catalyst';
 import '@oddbird/popover-polyfill';
+import AnchoredPositionElement from '../../anchored_position';
 import { observeMutationsUntilConditionMet } from '../../utils';
 import { ActionMenuFocusZoneStack } from './action_menu_focus_zone_stack';
 import { ClipboardCopyElement } from '@github/clipboard-copy-element';
@@ -365,6 +366,9 @@ _ActionMenuElement_handleItemKeyboardEvent = function _ActionMenuElement_handleI
 };
 _ActionMenuElement_handleToggleEvent = function _ActionMenuElement_handleToggleEvent(event) {
     const subMenu = event.target;
+    // Ignore toggle events from non-anchored-position elements (e.g. tooltips inside the menu)
+    if (!(event.target instanceof AnchoredPositionElement))
+        return;
     if (event.newState === 'open') {
         // allow tabbing away from primary menu, but trap focus in sub-menus
         const isPrimaryMenu = subMenu === this.overlay;

data/app/components/primer/alpha/action_menu/action_menu_element.ts

@@ -346,6 +346,9 @@ export class ActionMenuElement extends HTMLElement {
   #handleToggleEvent(event: ToggleEvent) {
     const subMenu = event.target as AnchoredPositionElement
 
+    // Ignore toggle events from non-anchored-position elements (e.g. tooltips inside the menu)
+    if (!(event.target instanceof AnchoredPositionElement)) return
+
     if (event.newState === 'open') {
       // allow tabbing away from primary menu, but trap focus in sub-menus
       const isPrimaryMenu = subMenu === this.overlay

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 84
-      PATCH = 4
+      PATCH = 5
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/previews/primer/alpha/action_menu_preview/multiple_select_form.html.erb

@@ -1,18 +1,18 @@
 <%= form_with(url: primer_view_components.action_menu_form_action_path(format: route_format)) do |f| %>
-  <% content = -> (base) do %>
-    <% base.with_item(label: "Fast forward", data: { value: "fast_forward" }) %>
-    <% base.with_item(label: "Recursive", data: { value: "recursive" }) %>
-    <% base.with_item(label: "Ours", data: { value: "ours" }, active: true) %>
-    <% base.with_item(label: "Resolve") %>
-  <% end %>
   <%= render(Primer::Alpha::ActionMenu.new(select_variant: :multiple, dynamic_label: true, dynamic_label_prefix: "Strategy", form_arguments: { builder: f, name: "foo" })) do |menu| %>
     <% menu.with_show_button { "Strategy" } %>
     <% if nest_in_sub_menu %>
       <% menu.with_sub_menu_item(label: "Sub-menu") do |sub_menu| %>
-        <% content.call(sub_menu) %>
+        <% sub_menu.with_item(label: "Fast forward", data: { value: "fast_forward" }) %>
+        <% sub_menu.with_item(label: "Recursive", data: { value: "recursive" }) %>
+        <% sub_menu.with_item(label: "Ours", data: { value: "ours" }, active: true) %>
+        <% sub_menu.with_item(label: "Resolve") %>
       <% end %>
     <% else %>
-      <% content.call(menu) %>
+      <% menu.with_item(label: "Fast forward", data: { value: "fast_forward" }) %>
+      <% menu.with_item(label: "Recursive", data: { value: "recursive" }) %>
+      <% menu.with_item(label: "Ours", data: { value: "ours" }, active: true) %>
+      <% menu.with_item(label: "Resolve") %>
     <% end %>
   <% end %>
   <hr>

data/previews/primer/alpha/action_menu_preview/opens_dialog.html.erb

@@ -1,21 +1,13 @@
 <%= render(Primer::Alpha::ActionMenu.new) do |component| %>
   <% component.with_show_button { "Menu" } %>
-  <% contents = -> (base) do %>
-    <% base.with_item(label: "Item", tag: :button, value: "") %>
-    <% base.with_item(
-      label: "Show dialog",
-      tag: :button,
-      content_arguments: { "data-show-dialog-id": "my-dialog" },
-      value: "",
-      scheme: :danger
-    ) %>
-  <% end %>
   <% if nest_in_sub_menu %>
     <% component.with_sub_menu_item(label: "Sub-menu") do |sub_menu_item| %>
-      <% contents.call(sub_menu_item) %>
+      <% sub_menu_item.with_item(label: "Item", tag: :button, value: "") %>
+      <% sub_menu_item.with_item(label: "Show dialog", tag: :button, content_arguments: { "data-show-dialog-id": "my-dialog" }, value: "", scheme: :danger) %>
     <% end %>
   <% else %>
-    <% contents.call(component) %>
+    <% component.with_item(label: "Item", tag: :button, value: "") %>
+    <% component.with_item(label: "Show dialog", tag: :button, content_arguments: { "data-show-dialog-id": "my-dialog" }, value: "", scheme: :danger) %>
   <% end %>
 <% end %>
 

data/previews/primer/alpha/action_menu_preview/single_select_form_items.html.erb

@@ -1,42 +1,12 @@
-<% contents = -> (menu) do %>
-  <% menu.with_item(
-    label: "Repository",
-    href: primer_view_components.action_menu_form_action_path(format: route_format),
-    form_arguments: {
-      method: :post,
-      inputs: [{
-        name: "query",
-        value: "query"
-      }, {
-        name: "foo", # use "foo" here because that's what the controller expects
-        value: "group-by-repository",
-      }],
-    }
-  ) %>
-  <% menu.with_item(
-    label: "Date",
-    href: primer_view_components.action_menu_form_action_path(format: route_format),
-    form_arguments: {
-      method: :post,
-      inputs: [{
-        name: "query",
-        value: "query"
-      }, {
-        name: "foo", # use "foo" here because that's what the controller expects
-        value: "sort-by-date"
-      }]
-    }
-  ) %>
-<% end %>
-
 <%= render(Primer::Alpha::ActionMenu.new(select_variant: :single)) do |menu| %>
   <% menu.with_show_button { "Group By" } %>
-
   <% if nest_in_sub_menu %>
     <% menu.with_sub_menu_item(label: "Sub-menu") do |sub_menu_item| %>
-      <% contents.call(sub_menu_item) %>
+      <% sub_menu_item.with_item(label: "Repository", href: primer_view_components.action_menu_form_action_path(format: route_format), form_arguments: { method: :post, inputs: [{ name: "query", value: "query" }, { name: "foo", value: "group-by-repository" }] }) %>
+      <% sub_menu_item.with_item(label: "Date", href: primer_view_components.action_menu_form_action_path(format: route_format), form_arguments: { method: :post, inputs: [{ name: "query", value: "query" }, { name: "foo", value: "sort-by-date" }] }) %>
     <% end %>
   <% else %>
-    <% contents.call(menu) %>
+    <% menu.with_item(label: "Repository", href: primer_view_components.action_menu_form_action_path(format: route_format), form_arguments: { method: :post, inputs: [{ name: "query", value: "query" }, { name: "foo", value: "group-by-repository" }] }) %>
+    <% menu.with_item(label: "Date", href: primer_view_components.action_menu_form_action_path(format: route_format), form_arguments: { method: :post, inputs: [{ name: "query", value: "query" }, { name: "foo", value: "sort-by-date" }] }) %>
   <% end %>
 <% end %>

data/previews/primer/alpha/action_menu_preview/with_actions.html.erb

@@ -8,24 +8,17 @@
 
 <%= render(Primer::Alpha::ActionMenu.new) do |component| %>
   <% component.with_show_button { "Trigger" } %>
-  <% contents = -> (base) do %>
-    <% base.with_item(label: "Alert", tag: :button, id: "alert-item", disabled: disable_items) %>
-    <% base.with_item(label: "Navigate", tag: :a, content_arguments: { href: primer_view_components.action_menu_landing_path }, disabled: disable_items) %>
-    <% base.with_item(label: "Copy text", tag: :"clipboard-copy", content_arguments: { value: "Text to copy" }, disabled: disable_items) %>
-    <% base.with_item(
-      label: "Submit form",
-      href: primer_view_components.action_menu_form_action_path(format: route_format),
-      form_arguments: {
-        name: "foo", value: "bar", method: :post
-      },
-      disabled: disable_items
-    ) %>
-  <% end %>
   <% if nest_in_sub_menu %>
     <% component.with_sub_menu_item(label: "Sub-menu") do |sub_menu_item| %>
-      <% contents.call(sub_menu_item) %>
+      <% sub_menu_item.with_item(label: "Alert", tag: :button, id: "alert-item", disabled: disable_items) %>
+      <% sub_menu_item.with_item(label: "Navigate", tag: :a, content_arguments: { href: primer_view_components.action_menu_landing_path }, disabled: disable_items) %>
+      <% sub_menu_item.with_item(label: "Copy text", tag: :"clipboard-copy", content_arguments: { value: "Text to copy" }, disabled: disable_items) %>
+      <% sub_menu_item.with_item(label: "Submit form", href: primer_view_components.action_menu_form_action_path(format: route_format), form_arguments: { name: "foo", value: "bar", method: :post }, disabled: disable_items) %>
     <% end %>
   <% else %>
-    <% contents.call(component) %>
+    <% component.with_item(label: "Alert", tag: :button, id: "alert-item", disabled: disable_items) %>
+    <% component.with_item(label: "Navigate", tag: :a, content_arguments: { href: primer_view_components.action_menu_landing_path }, disabled: disable_items) %>
+    <% component.with_item(label: "Copy text", tag: :"clipboard-copy", content_arguments: { value: "Text to copy" }, disabled: disable_items) %>
+    <% component.with_item(label: "Submit form", href: primer_view_components.action_menu_form_action_path(format: route_format), form_arguments: { name: "foo", value: "bar", method: :post }, disabled: disable_items) %>
   <% end %>
 <% end %>

data/previews/primer/alpha/action_menu_preview.rb

@@ -155,6 +155,7 @@ module Primer
         render(Primer::Alpha::ActionMenu.new) do |menu|
           menu.with_show_button(icon: :star, "aria-label": "Menu")
           menu.with_item(label: "Does something")
+          menu.with_item(label: "Does something else")
         end
       end
 

data/previews/primer/open_project/inline_message_preview/playground.html.erb

@@ -1,5 +1,3 @@
 <%= render(Primer::OpenProject::InlineMessage.new(scheme: scheme, size: size)) do %>
-  <%= render(Primer::Beta::Text.new(tag: :p)) do %>
-    <%= render(Primer::Beta::Text.new(tag: :strong).with_content("It is an inline message")) %>
-  <% end %>
+  <%= render(Primer::Beta::Text.new(tag: :strong).with_content("It is an inline message")) %>
 <% end %>

data/previews/primer/open_project/inline_message_preview.rb

@@ -6,6 +6,7 @@ module Primer
       # @label Default
       # @snapshot
       def default
+        render(Primer::OpenProject::InlineMessage.new(scheme: :warning, size: :medium)) { "Warning message" }
       end
 
       # @label Playground

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.84.4
+  version: 0.84.5
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-04-21 00:00:00.000000000 Z
+date: 2026-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -1282,7 +1282,6 @@ files:
 - previews/primer/open_project/grid_layout_preview.rb
 - previews/primer/open_project/heading_preview.rb
 - previews/primer/open_project/inline_message_preview.rb
-- previews/primer/open_project/inline_message_preview/default.html.erb
 - previews/primer/open_project/inline_message_preview/playground.html.erb
 - previews/primer/open_project/input_group_preview.rb
 - previews/primer/open_project/page_header_preview.rb

data/previews/primer/open_project/inline_message_preview/default.html.erb

@@ -1,5 +0,0 @@
-<%= render(Primer::OpenProject::InlineMessage.new(scheme: :warning, size: :small)) do %>
-  <%= render(Primer::Beta::Text.new(tag: :p)) do %>
-    <%= render(Primer::Beta::Text.new(tag: :strong).with_content("Warning message")) %>
-  <% end %>
-<% end %>