openproject-primer_view_components 0.73.0 → 0.73.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4dbb2f76ed2614870fed3e68d1f938ae39e2ad311e187abc9a7044dad9e9975
-  data.tar.gz: 5d9f8dd4063572c3b6a2a3032f9433b808470735d032f192a67f5f67fc59beaa
+  metadata.gz: 2e6885032916d63506e20a97fb22715724ead9cf217168aeca1b10b7dfdd6665
+  data.tar.gz: d27c1fd6a565d6e7eaf3033b3d9eb893a2ba9689a8c988f271008cd1a5bfb338
 SHA512:
-  metadata.gz: 14e3d2e082e3fd6bd986f17e868c794281ddbe5e084b16db24f3550ca5b988ac3bf6cf17cda73545c6329cc56529e9c374f2923dde6f05851769e821b71678fd
-  data.tar.gz: ec2e09042b8372b5c20ef7258a2d99ce33c7f25949d4a2a42e5d81a298a079d00f9bd36a3368111e7311ee06196dee1d2778d2aab9a22331a67f73a3cdafbb1c
+  metadata.gz: 3347347ac3a75d8d67414387a0759563403d9102603f0b7b5a51840ffe7c9ccc155bb0357d319701a5788090b6720bead908eb98f7884b8bd7cfe464a61a7996
+  data.tar.gz: 4b7d627b67c9cc17fe8250b419d70054f0b98576497129d05df741c7610114f4d0fcddd9d9e199d921ff8c27a6f50160325c648263182206f499db57db3b7e5c

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 0.73.1
+
+### Patch Changes
+
+- [#361](https://github.com/opf/primer_view_components/pull/361) [`acc6ee9`](https://github.com/opf/primer_view_components/commit/acc6ee91a14864895108308934ad1cb6c4221124) Thanks [@HDinger](https://github.com/HDinger)! - Change signature to hide the SegmentedControl in FilterableTreeView
+
 ## 0.73.0
 
 ### Minor Changes

data/app/components/primer/open_project/filterable_tree_view.html.erb

@@ -1,13 +1,12 @@
 <%= render(Primer::BaseComponent.new(**@system_arguments)) do %>
   <%= render(Primer::Alpha::Stack.new) do %>
     <%= render(Primer::Alpha::Stack.new(wrap: :reverse, direction: :horizontal, align: :center)) do %>
-      <%= render(Primer::Alpha::Stack.new(wrap: :wrap, direction: :horizontal, align: :center)) do %>
-        <% if @filter_mode_control.present? %>
-          <%= render(Primer::Alpha::StackItem.new) do %>
-            <%= render(@filter_mode_control) %>
-          <% end %>
+      <%= render(Primer::ConditionalWrapper.new(condition: !hide_filter_mode_control? && !hide_include_sub_items_check_box?,
+                                                component: Primer::Alpha::Stack, wrap: :wrap, direction: :horizontal, align: :center)) do %>
+        <%= render(Primer::Alpha::StackItem.new(hidden: hide_filter_mode_control?)) do %>
+          <%= render(@filter_mode_control) %>
         <% end %>
-        <%= render(Primer::Alpha::StackItem.new(hidden: @include_sub_items_check_box_arguments[:hidden])) do %>
+        <%= render(Primer::Alpha::StackItem.new(hidden: hide_include_sub_items_check_box?)) do %>
           <%= render(@include_sub_items_check_box) do |input| %>
             <% input.merge_input_arguments!(form: "") %>
           <% end %>

data/app/components/primer/open_project/filterable_tree_view.rb

@@ -119,7 +119,8 @@ module Primer
       DEFAULT_FILTER_MODE_CONTROL_ARGUMENTS = {
         aria: {
           label: I18n.t("filterable_tree_view.filter_mode.label")
-        }
+        },
+        hidden: false,
       }
 
       DEFAULT_FILTER_MODE_CONTROL_ARGUMENTS.freeze
@@ -186,15 +187,15 @@ module Primer
 
         @filter_input = Primer::Alpha::TextField.new(**filter_input_arguments)
 
-        unless filter_mode_control_arguments == :none
-          filter_mode_control_arguments[:data] = merge_data(
-            filter_mode_control_arguments, {
-              data: { target: "filterable-tree-view.filterModeControlList" }
-            }
-          )
 
-          @filter_mode_control = Primer::Alpha::SegmentedControl.new(**filter_mode_control_arguments)
-        end
+        @filter_mode_control_arguments = filter_mode_control_arguments.reverse_merge(DEFAULT_FILTER_MODE_CONTROL_ARGUMENTS)
+        @filter_mode_control_arguments[:data] = merge_data(
+          @filter_mode_control_arguments, {
+            data: { target: "filterable-tree-view.filterModeControlList" }
+          }
+        )
+
+        @filter_mode_control = Primer::Alpha::SegmentedControl.new(**@filter_mode_control_arguments)
 
         @include_sub_items_check_box_arguments = include_sub_items_check_box_arguments.reverse_merge(DEFAULT_INCLUDE_SUB_ITEMS_CHECK_BOX_ARGUMENTS)
 
@@ -255,6 +256,14 @@ module Primer
           with_default_filter_modes
         end
       end
+
+      def hide_filter_mode_control?
+        @filter_mode_control_arguments[:hidden]
+      end
+
+      def hide_include_sub_items_check_box?
+        @include_sub_items_check_box_arguments[:hidden]
+      end
     end
   end
 end

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 73
-      PATCH = 0
+      PATCH = 1
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/previews/primer/open_project/filterable_tree_view_preview/hide_segmented_control.html.erb

@@ -1,4 +1,4 @@
-<%= render(Primer::OpenProject::FilterableTreeView.new(filter_mode_control_arguments: :none)) do |tree| %>
+<%= render(Primer::OpenProject::FilterableTreeView.new(filter_mode_control_arguments: { hidden: true })) do |tree| %>
   <% tree.with_sub_tree(label: "Students", expanded: expanded) do |hogwarts| %>
     <% hogwarts.with_sub_tree(label: "Ravenclaw", expanded: expanded) do |ravenclaw| %>
       <% ravenclaw.with_leaf(label: "Luna Lovegood") %>

data/previews/primer/open_project/filterable_tree_view_preview/playground.html.erb

@@ -1,6 +1,6 @@
 <%= render(Primer::OpenProject::FilterableTreeView.new(
   include_sub_items_check_box_arguments: { hidden: !show_checkbox },
-  **(show_segmented_control ? {} : { filter_mode_control_arguments: :none })
+  filter_mode_control_arguments: { hidden: !show_segmented_control }
 )) do |tree| %>
   <% tree.with_sub_tree(label: "Students", expanded: expanded) do |hogwarts| %>
     <% hogwarts.with_sub_tree(label: "Ravenclaw", expanded: expanded) do |ravenclaw| %>

data/static/constants.json

@@ -1766,7 +1766,8 @@
     "DEFAULT_FILTER_MODE_CONTROL_ARGUMENTS": {
       "aria": {
         "label": "Filter mode"
-      }
+      },
+      "hidden": false
     },
     "DEFAULT_INCLUDE_SUB_ITEMS_CHECK_BOX_ARGUMENTS": {
       "label": "Include sub-items",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.73.0
+  version: 0.73.1
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-24 00:00:00.000000000 Z
+date: 2025-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview