openproject-primer_view_components 0.66.1 → 0.66.2

data/app/components/primer/open_project/tree_view/tree_view_sub_tree_node_element.d.ts

@@ -14,9 +14,11 @@ export declare class TreeViewSubTreeNodeElement extends HTMLElement {
     loadingIndicator: HTMLElement;
     loadingFailureMessage: HTMLElement;
     retryButton: HTMLButtonElement;
-    expanded: boolean;
-    loadingState: LoadingState;
     connectedCallback(): void;
+    get expanded(): boolean;
+    set expanded(newValue: boolean);
+    get loadingState(): LoadingState;
+    set loadingState(newState: LoadingState);
     get selectStrategy(): string;
     disconnectedCallback(): void;
     handleEvent(event: Event): void;

data/app/components/primer/open_project/tree_view/tree_view_sub_tree_node_element.js

@@ -15,19 +15,19 @@ var __classPrivateFieldSet = (this && this.__classPrivateFieldSet) || function (
     if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot write private member to an object whose class did not declare it");
     return (kind === "a" ? f.call(receiver, value) : f ? f.value = value : state.set(receiver, value)), value;
 };
-var _TreeViewSubTreeNodeElement_instances, _TreeViewSubTreeNodeElement_abortController, _TreeViewSubTreeNodeElement_activeElementIsLoader, _TreeViewSubTreeNodeElement_handleToggleEvent, _TreeViewSubTreeNodeElement_handleIncludeFragmentEvent, _TreeViewSubTreeNodeElement_handleRetryButtonEvent, _TreeViewSubTreeNodeElement_handleKeyboardEvent, _TreeViewSubTreeNodeElement_handleCheckboxEvent, _TreeViewSubTreeNodeElement_update, _TreeViewSubTreeNodeElement_checkboxElement_get;
+var _TreeViewSubTreeNodeElement_instances, _TreeViewSubTreeNodeElement_expanded, _TreeViewSubTreeNodeElement_loadingState, _TreeViewSubTreeNodeElement_abortController, _TreeViewSubTreeNodeElement_activeElementIsLoader, _TreeViewSubTreeNodeElement_handleToggleEvent, _TreeViewSubTreeNodeElement_handleIncludeFragmentEvent, _TreeViewSubTreeNodeElement_handleRetryButtonEvent, _TreeViewSubTreeNodeElement_handleKeyboardEvent, _TreeViewSubTreeNodeElement_handleCheckboxEvent, _TreeViewSubTreeNodeElement_update, _TreeViewSubTreeNodeElement_checkboxElement_get;
 import { controller, target } from '@github/catalyst';
 import { observeMutationsUntilConditionMet } from '../../utils';
 let TreeViewSubTreeNodeElement = class TreeViewSubTreeNodeElement extends HTMLElement {
     constructor() {
         super(...arguments);
         _TreeViewSubTreeNodeElement_instances.add(this);
+        _TreeViewSubTreeNodeElement_expanded.set(this, null);
+        _TreeViewSubTreeNodeElement_loadingState.set(this, 'success');
         _TreeViewSubTreeNodeElement_abortController.set(this, void 0);
         _TreeViewSubTreeNodeElement_activeElementIsLoader.set(this, false);
     }
     connectedCallback() {
-        this.expanded = this.node.getAttribute('aria-expanded') === 'true';
-        this.loadingState = 'success';
         observeMutationsUntilConditionMet(this, () => Boolean(this.node) && Boolean(this.subTree), () => {
             __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_instances, "m", _TreeViewSubTreeNodeElement_update).call(this);
         });
@@ -77,6 +77,23 @@ let TreeViewSubTreeNodeElement = class TreeViewSubTreeNodeElement extends HTMLEl
             attributeFilter: ['aria-checked'],
         });
     }
+    get expanded() {
+        if (__classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_expanded, "f") === null) {
+            __classPrivateFieldSet(this, _TreeViewSubTreeNodeElement_expanded, this.node.getAttribute('aria-expanded') === 'true', "f");
+        }
+        return __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_expanded, "f");
+    }
+    set expanded(newValue) {
+        __classPrivateFieldSet(this, _TreeViewSubTreeNodeElement_expanded, newValue, "f");
+        __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_instances, "m", _TreeViewSubTreeNodeElement_update).call(this);
+    }
+    get loadingState() {
+        return __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_loadingState, "f");
+    }
+    set loadingState(newState) {
+        __classPrivateFieldSet(this, _TreeViewSubTreeNodeElement_loadingState, newState, "f");
+        __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_instances, "m", _TreeViewSubTreeNodeElement_update).call(this);
+    }
     get selectStrategy() {
         return this.node.getAttribute('data-select-strategy') || 'descendants';
     }
@@ -101,7 +118,6 @@ let TreeViewSubTreeNodeElement = class TreeViewSubTreeNodeElement extends HTMLEl
     expand() {
         const alreadyExpanded = this.expanded;
         this.expanded = true;
-        __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_instances, "m", _TreeViewSubTreeNodeElement_update).call(this);
         if (!alreadyExpanded && this.treeView) {
             this.treeView.dispatchEvent(new CustomEvent('treeViewNodeExpanded', {
                 bubbles: true,
@@ -112,7 +128,6 @@ let TreeViewSubTreeNodeElement = class TreeViewSubTreeNodeElement extends HTMLEl
     collapse() {
         const alreadyCollapsed = !this.expanded;
         this.expanded = false;
-        __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_instances, "m", _TreeViewSubTreeNodeElement_update).call(this);
         if (!alreadyCollapsed && this.treeView) {
             // Prevent issue where currently focusable node is stuck inside a collapsed
             // sub-tree and no node in the entire tree can be focused
@@ -186,6 +201,8 @@ let TreeViewSubTreeNodeElement = class TreeViewSubTreeNodeElement extends HTMLEl
         }));
     }
 };
+_TreeViewSubTreeNodeElement_expanded = new WeakMap();
+_TreeViewSubTreeNodeElement_loadingState = new WeakMap();
 _TreeViewSubTreeNodeElement_abortController = new WeakMap();
 _TreeViewSubTreeNodeElement_activeElementIsLoader = new WeakMap();
 _TreeViewSubTreeNodeElement_instances = new WeakSet();
@@ -199,18 +216,15 @@ _TreeViewSubTreeNodeElement_handleIncludeFragmentEvent = function _TreeViewSubTr
         // the request has started
         case 'loadstart':
             this.loadingState = 'loading';
-            __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_instances, "m", _TreeViewSubTreeNodeElement_update).call(this);
             break;
         // the request failed
         case 'error':
             this.loadingState = 'error';
-            __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_instances, "m", _TreeViewSubTreeNodeElement_update).call(this);
             break;
         // request succeeded but element has not yet been replaced
         case 'include-fragment-replace':
-            this.loadingState = 'success';
             __classPrivateFieldSet(this, _TreeViewSubTreeNodeElement_activeElementIsLoader, document.activeElement === this.loadingIndicator.closest('li'), "f");
-            __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_instances, "m", _TreeViewSubTreeNodeElement_update).call(this);
+            this.loadingState = 'success';
             break;
         case 'include-fragment-replaced':
             if (__classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_activeElementIsLoader, "f")) {
@@ -232,7 +246,6 @@ _TreeViewSubTreeNodeElement_handleIncludeFragmentEvent = function _TreeViewSubTr
 _TreeViewSubTreeNodeElement_handleRetryButtonEvent = function _TreeViewSubTreeNodeElement_handleRetryButtonEvent(event) {
     if (event.type === 'click') {
         this.loadingState = 'loading';
-        __classPrivateFieldGet(this, _TreeViewSubTreeNodeElement_instances, "m", _TreeViewSubTreeNodeElement_update).call(this);
         this.includeFragment.refetch();
     }
 };

data/app/components/primer/open_project/tree_view/tree_view_sub_tree_node_element.ts

@@ -20,16 +20,12 @@ export class TreeViewSubTreeNodeElement extends HTMLElement {
   @target loadingFailureMessage: HTMLElement
   @target retryButton: HTMLButtonElement
 
-  expanded: boolean
-  loadingState: LoadingState
-
+  #expanded: boolean | null = null
+  #loadingState: LoadingState = 'success'
   #abortController: AbortController
   #activeElementIsLoader: boolean = false
 
   connectedCallback() {
-    this.expanded = this.node.getAttribute('aria-expanded') === 'true'
-    this.loadingState = 'success'
-
     observeMutationsUntilConditionMet(
       this,
       () => Boolean(this.node) && Boolean(this.subTree),
@@ -109,6 +105,28 @@ export class TreeViewSubTreeNodeElement extends HTMLElement {
     })
   }
 
+  get expanded(): boolean {
+    if (this.#expanded === null) {
+      this.#expanded = this.node.getAttribute('aria-expanded') === 'true'
+    }
+
+    return this.#expanded
+  }
+
+  set expanded(newValue: boolean) {
+    this.#expanded = newValue
+    this.#update()
+  }
+
+  get loadingState(): LoadingState {
+    return this.#loadingState
+  }
+
+  set loadingState(newState: LoadingState) {
+    this.#loadingState = newState
+    this.#update()
+  }
+
   get selectStrategy(): string {
     return this.node.getAttribute('data-select-strategy') || 'descendants'
   }
@@ -135,7 +153,6 @@ export class TreeViewSubTreeNodeElement extends HTMLElement {
     const alreadyExpanded = this.expanded
 
     this.expanded = true
-    this.#update()
 
     if (!alreadyExpanded && this.treeView) {
       this.treeView.dispatchEvent(
@@ -151,7 +168,6 @@ export class TreeViewSubTreeNodeElement extends HTMLElement {
     const alreadyCollapsed = !this.expanded
 
     this.expanded = false
-    this.#update()
 
     if (!alreadyCollapsed && this.treeView) {
       // Prevent issue where currently focusable node is stuck inside a collapsed
@@ -216,20 +232,17 @@ export class TreeViewSubTreeNodeElement extends HTMLElement {
       // the request has started
       case 'loadstart':
         this.loadingState = 'loading'
-        this.#update()
         break
 
       // the request failed
       case 'error':
         this.loadingState = 'error'
-        this.#update()
         break
 
       // request succeeded but element has not yet been replaced
       case 'include-fragment-replace':
-        this.loadingState = 'success'
         this.#activeElementIsLoader = document.activeElement === this.loadingIndicator.closest('li')
-        this.#update()
+        this.loadingState = 'success'
         break
 
       case 'include-fragment-replaced':
@@ -253,8 +266,6 @@ export class TreeViewSubTreeNodeElement extends HTMLElement {
   #handleRetryButtonEvent(event: Event) {
     if (event.type === 'click') {
       this.loadingState = 'loading'
-      this.#update()
-
       this.includeFragment.refetch()
     }
   }

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 66
-      PATCH = 1
+      PATCH = 2
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.66.1
+  version: 0.66.2
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-05-19 00:00:00.000000000 Z
+date: 2025-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview