openproject-primer_view_components 0.52.3 → 0.52.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab6dec56ffb6d80a8f8d4ccbed980b75707157fbdc6640c010940ebb83975f55
-  data.tar.gz: ad31a564b5a1d9da8c06a3ac228e6c50eabd6c9ea77700f7f60459640bbc2ac3
+  metadata.gz: c76bbbbf5c9b25dc9b49102a7a91b822c54d4a0e8973ce35ef7072bc07c44b63
+  data.tar.gz: 57c633f3c5164e60355955d9bc828d1e4e66bcf60ad355485e4ff28b7e2b2a98
 SHA512:
-  metadata.gz: 359bc6693381fe12ea642afefea1497c049cb0511349723bc23f63226baf86375df461d18eac57779356ed5a8d0c71b6b763989c03a641f221f2a6e95b1d11fc
-  data.tar.gz: bef96cd8baaa0fced4fda9f4e44d0c71e93ab8a876a17e27db9f899db1672e25768327b598499fce225a9c78c6016c36c8f2e4c2dacc2552bdd2a3d5d40828b7
+  metadata.gz: c4fb0afc8b4040994f8367864a43eabbcd1ac709231a349521fcf276164ff6cf6550b165633e41630f52b8ba169c7a386863308efe3369a7678bf087b0d36078
+  data.tar.gz: f7f39cf1ea0edd409bab750c750593fa300ed9398154e8d4d4f0ad3f7f1e4f14a88030a8a0bc0e175c6c8a8cd99547b29b181bb0042c45a73d76cc865f00fb3e

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # CHANGELOG
 
+## 0.52.4
+
+### Patch Changes
+
+- [#232](https://github.com/opf/primer_view_components/pull/232) [`3cf8fe4`](https://github.com/opf/primer_view_components/commit/3cf8fe408dfe9995f90af3a08f5e04c21f3ed30a) Thanks [@HDinger](https://github.com/HDinger)! - Allow custom texts for cancel and confirm button in DangerConfirmationDialog
+
+- [#231](https://github.com/opf/primer_view_components/pull/231) [`10cf9d2`](https://github.com/opf/primer_view_components/commit/10cf9d20660815b4ba78bc8bb7b9e18f3a60ce88) Thanks [@HDinger](https://github.com/HDinger)! - Fix form preview of DangerConfirmationDialog
+
 ## 0.52.3
 
 ### Patch Changes

data/app/components/primer/open_project/danger_confirmation_dialog.html.erb

@@ -11,8 +11,8 @@
         <% end %>
       </scrollable-region>
       <%= render(Primer::Alpha::Dialog::Footer.new(show_divider: false)) do %>
-        <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": dialog_id })) { I18n.t("button_cancel") } %>
-        <%= render(Primer::Beta::Button.new(type: (@form_wrapper.shows_form? ? :submit : :button), scheme: :danger, data: { "submit-dialog-id": dialog_id })) { I18n.t("button_delete_permanently") } %>
+        <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": dialog_id })) { @cancel_button_text } %>
+        <%= render(Primer::Beta::Button.new(type: (@form_wrapper.shows_form? ? :submit : :button), scheme: :danger, data: { "submit-dialog-id": dialog_id })) { @confirm_button_text } %>
       <% end %>
     <% end %>
   </danger-confirmation-dialog-form-helper>

data/app/components/primer/open_project/danger_confirmation_dialog.rb

@@ -67,12 +67,17 @@ module Primer
       def initialize(
         form_arguments: {},
         id: self.class.generate_id,
+        confirm_button_text: I18n.t("button_delete_permanently"),
+        cancel_button_text: I18n.t("button_cancel"),
         **system_arguments
       )
         @check_box_name = form_arguments.delete(:name) || "confirm_dangerous_action"
         @form_wrapper = FormWrapper.new(**form_arguments)
         @dialog_id = id.to_s
 
+        @confirm_button_text = confirm_button_text
+        @cancel_button_text = cancel_button_text
+
         @system_arguments = system_arguments
         @system_arguments[:id] = @dialog_id
         @system_arguments[:classes] = class_names(

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 52
-      PATCH = 3
+      PATCH = 4
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/previews/primer/open_project/danger_confirmation_dialog_preview/playground.html.erb

@@ -1,4 +1,6 @@
-<%= render(Primer::OpenProject::DangerConfirmationDialog.new(id: "my-dialog")) do |dialog| %>
+<%= render(Primer::OpenProject::DangerConfirmationDialog.new(id: "my-dialog",
+                                                             confirm_button_text: confirm_button_text,
+                                                             cancel_button_text: cancel_button_text)) do |dialog| %>
   <% dialog.with_show_button { "Click me" } %>
   <% dialog.with_confirmation_message(icon_arguments: { icon: icon, color: icon_color }) do |message| %>
     <% message.with_heading(tag: :h2).with_content("Proceed with danger?") %>

data/previews/primer/open_project/danger_confirmation_dialog_preview/with_form.html.erb

@@ -1,6 +1,6 @@
 <%= render(Primer::OpenProject::DangerConfirmationDialog.new(
     title: "Delete dialog",
-    form_arguments: { action: generic_form_submission_path(format: route_format) }
+    form_arguments: { action: "" } # Use the correct form action here.
   )) do |dialog| %>
   <% dialog.with_show_button { "Click me" } %>
   <% dialog.with_confirmation_message do |message|

data/previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form.html.erb

@@ -1,4 +1,5 @@
-<%= form_with(url: generic_form_submission_path(format: route_format)) do |f| %>
+<!-- Use the correct form URL here. -->
+<%= form_with(url: "") do |f| %>
   <%= render(Primer::OpenProject::DangerConfirmationDialog.new(
         title: "Delete dialog",
         form_arguments: { builder: f, name: "confirm_very_dangerous_action" }

data/previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form_test.html.erb

@@ -0,0 +1,13 @@
+<%= form_with(url: generic_form_submission_path(route_format)) do |f| %>
+  <%= render(Primer::OpenProject::DangerConfirmationDialog.new(
+        title: "Delete dialog",
+        form_arguments: { builder: f, name: "confirm_very_dangerous_action" }
+      )) do |dialog| %>
+    <% dialog.with_show_button { "Click me" } %>
+    <% dialog.with_confirmation_message do |message|
+        message.with_heading(tag: :h2).with_content("Permanently delete?")
+        message.with_description_content("This action is not reversible. Please proceed with caution.")
+       end %>
+    <% dialog.with_confirmation_check_box_content("I understand that this deletion cannot be reversed") %>
+  <% end %>
+<% end %>

data/previews/primer/open_project/danger_confirmation_dialog_preview/with_form_test.html.erb

@@ -0,0 +1,11 @@
+<%= render(Primer::OpenProject::DangerConfirmationDialog.new(
+    title: "Delete dialog",
+    form_arguments: { action: generic_form_submission_path(route_format) }
+  )) do |dialog| %>
+  <% dialog.with_show_button { "Click me" } %>
+  <% dialog.with_confirmation_message do |message|
+      message.with_heading(tag: :h2).with_content("Permanently delete?")
+      message.with_description_content("This action is not reversible. Please proceed with caution.")
+     end %>
+  <% dialog.with_confirmation_check_box_content("I understand that this deletion cannot be reversed") %>
+<% end %>

data/previews/primer/open_project/danger_confirmation_dialog_preview.rb

@@ -25,18 +25,24 @@ module Primer
       # @param icon_color [Symbol] select [default, muted, subtle, accent, success, attention, severe, danger, open, closed, done, sponsors, on_emphasis, inherit]
       # @param show_description toggle
       # @param show_additional_details toggle
+      # @param confirm_button_text [String]
+      # @param cancel_button_text [String]
       # @param check_box_text [String]
       def playground(
         icon: :"alert",
         icon_color: :danger,
         show_description: true,
         show_additional_details: false,
+        confirm_button_text: "Understood",
+        cancel_button_text: "NO!",
         check_box_text: "I understand that this deletion cannot be reversed"
       )
         render_with_template(locals: { icon: icon,
                                        icon_color: icon_color,
                                        show_description: show_description,
                                        show_additional_details: show_additional_details,
+                                       confirm_button_text: confirm_button_text,
+                                       cancel_button_text: cancel_button_text,
                                        check_box_text: check_box_text })
       end
 
@@ -66,6 +72,18 @@ module Primer
           dialog.with_confirmation_check_box_content("I understand that this deletion cannot be reversed")
         end
       end
+
+      # @label With form using FormBuilder for testing puposes
+      # @hidden
+      def with_form_builder_form_test(route_format: :html)
+        render_with_template(locals: { route_format: route_format })
+      end
+
+      # @label With form for testing purposes
+      # @hidden
+      def with_form_test(route_format: :html)
+        render_with_template(locals: { route_format: route_format })
+      end
     end
   end
 end

data/static/info_arch.json

@@ -17673,6 +17673,32 @@
             "color-contrast"
           ]
         }
+      },
+      {
+        "preview_path": "primer/open_project/danger_confirmation_dialog/with_form_builder_form_test",
+        "name": "with_form_builder_form_test",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
+      {
+        "preview_path": "primer/open_project/danger_confirmation_dialog/with_form_test",
+        "name": "with_form_test",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
       }
     ],
     "subcomponents": [

data/static/previews.json

@@ -3191,6 +3191,32 @@
             "color-contrast"
           ]
         }
+      },
+      {
+        "preview_path": "primer/open_project/danger_confirmation_dialog/with_form_builder_form_test",
+        "name": "with_form_builder_form_test",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
+      {
+        "preview_path": "primer/open_project/danger_confirmation_dialog/with_form_test",
+        "name": "with_form_test",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
       }
     ]
   },

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.52.3
+  version: 0.52.4
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-28 00:00:00.000000000 Z
+date: 2025-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -1032,6 +1032,8 @@ files:
 - previews/primer/open_project/danger_confirmation_dialog_preview/with_additional_details.html.erb
 - previews/primer/open_project/danger_confirmation_dialog_preview/with_form.html.erb
 - previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form.html.erb
+- previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form_test.html.erb
+- previews/primer/open_project/danger_confirmation_dialog_preview/with_form_test.html.erb
 - previews/primer/open_project/drag_handle_preview.rb
 - previews/primer/open_project/feedback_dialog_preview.rb
 - previews/primer/open_project/feedback_dialog_preview/playground.html.erb