openproject-primer_view_components 0.52.2 → 0.52.4

data/app/components/primer/beta/button.html.erb

@@ -9,8 +9,8 @@
     <% if trailing_visual %>
       <span class="Button-visual Button-trailingVisual">
         <% if @trailing_visual_counter %>
+          <span class="d-flex" aria-hidden="true"><%= trailing_visual %></span>
           <span class="sr-only">(<%= trailing_visual %>)</span>
-          <%= trailing_visual %>
         <% else %>
           <%= trailing_visual %>
         <% end %>

data/app/components/primer/beta/button.rb

@@ -70,7 +70,7 @@ module Primer
         label: Primer::Beta::Label,
         counter: lambda { |**system_arguments|
           @trailing_visual_counter = true
-          Primer::Beta::Counter.new("aria-hidden": true, **system_arguments)
+          Primer::Beta::Counter.new(**system_arguments)
         }
       }
 
@@ -108,6 +108,7 @@ module Primer
       # @param align_content [Symbol] <%= one_of(Primer::Beta::Button::ALIGN_CONTENT_OPTIONS) %>
       # @param tag [Symbol] (Primer::Beta::BaseButton::DEFAULT_TAG) <%= one_of(Primer::Beta::BaseButton::TAG_OPTIONS) %>
       # @param type [Symbol] (Primer::Beta::BaseButton::DEFAULT_TYPE) <%= one_of(Primer::Beta::BaseButton::TYPE_OPTIONS) %>
+      # @param inactive [Boolean] Whether the button looks visually disabled, but can still accept all the same interactions as an enabled button.
       # @param disabled [Boolean] Whether or not the button is disabled. If true, this option forces `tag:` to `:button`.
       # @param label_wrap [Boolean] Whether or not the button label text wraps and the button height expands.
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>

data/app/components/primer/open_project/danger_confirmation_dialog.html.erb

@@ -11,8 +11,8 @@
         <% end %>
       </scrollable-region>
       <%= render(Primer::Alpha::Dialog::Footer.new(show_divider: false)) do %>
-        <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": dialog_id })) { I18n.t("button_cancel") } %>
-        <%= render(Primer::Beta::Button.new(type: (@form_wrapper.shows_form? ? :submit : :button), scheme: :danger, data: { "submit-dialog-id": dialog_id })) { I18n.t("button_delete_permanently") } %>
+        <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": dialog_id })) { @cancel_button_text } %>
+        <%= render(Primer::Beta::Button.new(type: (@form_wrapper.shows_form? ? :submit : :button), scheme: :danger, data: { "submit-dialog-id": dialog_id })) { @confirm_button_text } %>
       <% end %>
     <% end %>
   </danger-confirmation-dialog-form-helper>

data/app/components/primer/open_project/danger_confirmation_dialog.rb

@@ -67,12 +67,17 @@ module Primer
       def initialize(
         form_arguments: {},
         id: self.class.generate_id,
+        confirm_button_text: I18n.t("button_delete_permanently"),
+        cancel_button_text: I18n.t("button_cancel"),
         **system_arguments
       )
         @check_box_name = form_arguments.delete(:name) || "confirm_dangerous_action"
         @form_wrapper = FormWrapper.new(**form_arguments)
         @dialog_id = id.to_s
 
+        @confirm_button_text = confirm_button_text
+        @cancel_button_text = cancel_button_text
+
         @system_arguments = system_arguments
         @system_arguments[:id] = @dialog_id
         @system_arguments[:classes] = class_names(

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 52
-      PATCH = 2
+      PATCH = 4
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/previews/primer/alpha/tooltip_preview.rb

@@ -65,7 +65,7 @@ module Primer
 
       # @label Tooltip with Primer::Beta::Link
       def tooltip_with_link(direction: :s, tooltip_text: "You can press a button")
-        render(Primer::Beta::Link.new(href: "#link-with-tooltip", id: "link-with-tooltip")) do |component|
+        render(Primer::Beta::Link.new(href: "#link-with-tooltip", id: "link-with-tooltip", underline: true)) do |component|
           component.with_tooltip(text: tooltip_text, direction: direction)
           "Button"
         end

data/previews/primer/open_project/danger_confirmation_dialog_preview/playground.html.erb

@@ -1,4 +1,6 @@
-<%= render(Primer::OpenProject::DangerConfirmationDialog.new(id: "my-dialog")) do |dialog| %>
+<%= render(Primer::OpenProject::DangerConfirmationDialog.new(id: "my-dialog",
+                                                             confirm_button_text: confirm_button_text,
+                                                             cancel_button_text: cancel_button_text)) do |dialog| %>
   <% dialog.with_show_button { "Click me" } %>
   <% dialog.with_confirmation_message(icon_arguments: { icon: icon, color: icon_color }) do |message| %>
     <% message.with_heading(tag: :h2).with_content("Proceed with danger?") %>

data/previews/primer/open_project/danger_confirmation_dialog_preview/with_form.html.erb

@@ -1,6 +1,6 @@
 <%= render(Primer::OpenProject::DangerConfirmationDialog.new(
     title: "Delete dialog",
-    form_arguments: { action: generic_form_submission_path(format: route_format) }
+    form_arguments: { action: "" } # Use the correct form action here.
   )) do |dialog| %>
   <% dialog.with_show_button { "Click me" } %>
   <% dialog.with_confirmation_message do |message|

data/previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form.html.erb

@@ -1,4 +1,5 @@
-<%= form_with(url: generic_form_submission_path(format: route_format)) do |f| %>
+<!-- Use the correct form URL here. -->
+<%= form_with(url: "") do |f| %>
   <%= render(Primer::OpenProject::DangerConfirmationDialog.new(
         title: "Delete dialog",
         form_arguments: { builder: f, name: "confirm_very_dangerous_action" }

data/previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form_test.html.erb

@@ -0,0 +1,13 @@
+<%= form_with(url: generic_form_submission_path(route_format)) do |f| %>
+  <%= render(Primer::OpenProject::DangerConfirmationDialog.new(
+        title: "Delete dialog",
+        form_arguments: { builder: f, name: "confirm_very_dangerous_action" }
+      )) do |dialog| %>
+    <% dialog.with_show_button { "Click me" } %>
+    <% dialog.with_confirmation_message do |message|
+        message.with_heading(tag: :h2).with_content("Permanently delete?")
+        message.with_description_content("This action is not reversible. Please proceed with caution.")
+       end %>
+    <% dialog.with_confirmation_check_box_content("I understand that this deletion cannot be reversed") %>
+  <% end %>
+<% end %>

data/previews/primer/open_project/danger_confirmation_dialog_preview/with_form_test.html.erb

@@ -0,0 +1,11 @@
+<%= render(Primer::OpenProject::DangerConfirmationDialog.new(
+    title: "Delete dialog",
+    form_arguments: { action: generic_form_submission_path(route_format) }
+  )) do |dialog| %>
+  <% dialog.with_show_button { "Click me" } %>
+  <% dialog.with_confirmation_message do |message|
+      message.with_heading(tag: :h2).with_content("Permanently delete?")
+      message.with_description_content("This action is not reversible. Please proceed with caution.")
+     end %>
+  <% dialog.with_confirmation_check_box_content("I understand that this deletion cannot be reversed") %>
+<% end %>

data/previews/primer/open_project/danger_confirmation_dialog_preview.rb

@@ -25,18 +25,24 @@ module Primer
       # @param icon_color [Symbol] select [default, muted, subtle, accent, success, attention, severe, danger, open, closed, done, sponsors, on_emphasis, inherit]
       # @param show_description toggle
       # @param show_additional_details toggle
+      # @param confirm_button_text [String]
+      # @param cancel_button_text [String]
       # @param check_box_text [String]
       def playground(
         icon: :"alert",
         icon_color: :danger,
         show_description: true,
         show_additional_details: false,
+        confirm_button_text: "Understood",
+        cancel_button_text: "NO!",
         check_box_text: "I understand that this deletion cannot be reversed"
       )
         render_with_template(locals: { icon: icon,
                                        icon_color: icon_color,
                                        show_description: show_description,
                                        show_additional_details: show_additional_details,
+                                       confirm_button_text: confirm_button_text,
+                                       cancel_button_text: cancel_button_text,
                                        check_box_text: check_box_text })
       end
 
@@ -66,6 +72,18 @@ module Primer
           dialog.with_confirmation_check_box_content("I understand that this deletion cannot be reversed")
         end
       end
+
+      # @label With form using FormBuilder for testing puposes
+      # @hidden
+      def with_form_builder_form_test(route_format: :html)
+        render_with_template(locals: { route_format: route_format })
+      end
+
+      # @label With form for testing purposes
+      # @hidden
+      def with_form_test(route_format: :html)
+        render_with_template(locals: { route_format: route_format })
+      end
     end
   end
 end

data/static/arguments.json

@@ -3646,6 +3646,12 @@
         "default": "`:button`",
         "description": "One of `:button`, `:reset`, or `:submit`."
       },
+      {
+        "name": "inactive",
+        "type": "Boolean",
+        "default": "N/A",
+        "description": "Whether the button looks visually disabled, but can still accept all the same interactions as an enabled button."
+      },
       {
         "name": "disabled",
         "type": "Boolean",

data/static/info_arch.json

@@ -12186,6 +12186,12 @@
         "default": "`:button`",
         "description": "One of `:button`, `:reset`, or `:submit`."
       },
+      {
+        "name": "inactive",
+        "type": "Boolean",
+        "default": "N/A",
+        "description": "Whether the button looks visually disabled, but can still accept all the same interactions as an enabled button."
+      },
       {
         "name": "disabled",
         "type": "Boolean",
@@ -17667,6 +17673,32 @@
             "color-contrast"
           ]
         }
+      },
+      {
+        "preview_path": "primer/open_project/danger_confirmation_dialog/with_form_builder_form_test",
+        "name": "with_form_builder_form_test",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
+      {
+        "preview_path": "primer/open_project/danger_confirmation_dialog/with_form_test",
+        "name": "with_form_test",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
       }
     ],
     "subcomponents": [

data/static/previews.json

@@ -3191,6 +3191,32 @@
             "color-contrast"
           ]
         }
+      },
+      {
+        "preview_path": "primer/open_project/danger_confirmation_dialog/with_form_builder_form_test",
+        "name": "with_form_builder_form_test",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
+      {
+        "preview_path": "primer/open_project/danger_confirmation_dialog/with_form_test",
+        "name": "with_form_test",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
       }
     ]
   },

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.52.2
+  version: 0.52.4
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-17 00:00:00.000000000 Z
+date: 2025-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -1032,6 +1032,8 @@ files:
 - previews/primer/open_project/danger_confirmation_dialog_preview/with_additional_details.html.erb
 - previews/primer/open_project/danger_confirmation_dialog_preview/with_form.html.erb
 - previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form.html.erb
+- previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form_test.html.erb
+- previews/primer/open_project/danger_confirmation_dialog_preview/with_form_test.html.erb
 - previews/primer/open_project/drag_handle_preview.rb
 - previews/primer/open_project/feedback_dialog_preview.rb
 - previews/primer/open_project/feedback_dialog_preview/playground.html.erb