openproject-primer_view_components 0.51.0 → 0.52.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 29f2e2c298d265746a0e011f41ba5bc2c03cfcd416dc2a056bf1613546422d6e
-  data.tar.gz: 8d95c5b9b1001e11b446eb051278bbf65950df8be0bfd98ca5a72213a29a558d
+  metadata.gz: fd140b594a3320327597c717407335fcb2a75d74160f81635780fe093f32a6db
+  data.tar.gz: a3d6b3886f9900157721df6a670b305360387f9969753a9f790605caa5c1faa3
 SHA512:
-  metadata.gz: 79be0758f8f987cb25fa8ccaf4a68800a3c91e18d25845776c927b6ddc8f2cd8a8ba37398ea43151575b0cafd3ed0be84511fec5854f19898dbd9509081c46d6
-  data.tar.gz: 9d953a0aca8d4ecc7bfb916e9462e6fcd3c7be2edde929c370ef1ef40915f3127cc8e90db6008adc34e1c98a4b102d7eefe027cd86371152aef17147d67d4a08
+  metadata.gz: 24f9cb45a17f8e132c3eb41117a2a0300dff084738285eef44818b57b5da876472030691fcafe463e5c77a1050c21fb39a79df2e7107b5ab7a6f95872c8df0e6
+  data.tar.gz: 3887155c4ef530bf37c7aa5c5dc30ef87dfb14002939d427a761b16c6e8e676cf52168de0f263972ba39cb71fd03105b7252cd1f2134c2980d630af4fb2a003a

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 0.52.0
+
+### Minor Changes
+
+- [#219](https://github.com/opf/primer_view_components/pull/219) [`e3a93b7`](https://github.com/opf/primer_view_components/commit/e3a93b72299395d039758b1fda8ec78d51687127) Thanks [@myabc](https://github.com/myabc)! - [#60359] Harmonise FeedbackDialog slot naming: renames the `additional_content` slot to `additional_details` to make Feedback Dialog consistent with the newly introduced Danger Confirmation Dialog.
+
 ## 0.51.0
 
 ### Minor Changes

data/app/components/primer/open_project/feedback_dialog.html.erb

@@ -1,8 +1,8 @@
 <%= render @dialog do |dialog| %>
   <% dialog.with_body do %>
     <%= feedback_message %>
-    <% if additional_content.present? %>
-      <%= additional_content %>
+    <% if additional_details.present? %>
+      <%= additional_details %>
     <% end %>
   <% end %>
   <% dialog.with_footer do %>

data/app/components/primer/open_project/feedback_dialog.rb

@@ -17,15 +17,15 @@ module Primer
         Primer::OpenProject::FeedbackMessage.new(icon_arguments: icon_arguments, **system_arguments)
       }
 
-      # Optional additional_content like a form input or toast.
+      # Optional additional_details like a form input or toast.
       #
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
-      renders_one :additional_content, lambda { |**system_arguments|
+      renders_one :additional_details, lambda { |**system_arguments|
         deny_tag_argument(**system_arguments)
         system_arguments[:tag] = :div
         system_arguments[:classes] = class_names(
           system_arguments[:classes],
-          "FeedbackDialog-additionalContent"
+          "FeedbackDialog-additionalDetails"
         )
 
         system_arguments[:display] ||= :flex

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
   module ViewComponents
     module VERSION
       MAJOR = 0
-      MINOR = 51
+      MINOR = 52
       PATCH = 0
 
       STRING = [MAJOR, MINOR, PATCH].join(".")

data/previews/primer/open_project/danger_confirmation_dialog_preview/playground.html.erb

@@ -6,7 +6,7 @@
   <% end %>
   <% if show_additional_details %>
     <% dialog.with_additional_details do %>
-      <%= render(Primer::Alpha::Banner.new) { "Some additional content below" } %>
+      <%= render(Primer::Alpha::Banner.new) { "Some additional details below" } %>
     <% end %>
   <% end %>
   <% dialog.with_confirmation_check_box_content(check_box_text) %>

data/previews/primer/open_project/feedback_dialog_preview/playground.html.erb

@@ -4,9 +4,9 @@
     <% message.with_heading(tag: :h2).with_content("Awesome!") %>
     <% message.with_description { "Great! Everything worked well." } if show_description %>
   <% end %>
-  <% if show_additional_content %>
-    <% dialog.with_additional_content(display: :inline) do %>
-      <%= render(Primer::Alpha::Banner.new) { "Some additional content below" } %>
+  <% if show_additional_details %>
+    <% dialog.with_additional_details(display: :inline) do %>
+      <%= render(Primer::Alpha::Banner.new) { "Some additional details below" } %>
       <% end %>
   <% end %>
   <% if custom_footer %>

data/previews/primer/open_project/feedback_dialog_preview/{additional_content.html.erb → with_additional_details.html.erb}

@@ -3,7 +3,7 @@
   <% dialog.with_feedback_message do |message| %>
     <% message.with_heading(tag: :h2).with_content("Action successful") %>
   <% end %>
-  <% dialog.with_additional_content do %>
+  <% dialog.with_additional_details do %>
     <% render(Primer::Beta::Text.new) { "You can render whatever component you want here." } %>
   <% end %>
 <% end %>

data/previews/primer/open_project/feedback_dialog_preview.rb

@@ -24,19 +24,19 @@ module Primer
       # @param icon_color [Symbol] select [default, muted, subtle, accent, success, attention, severe, danger, open, closed, done, sponsors, on_emphasis, inherit]
       # @param loading_state [Boolean] toggle
       # @param show_description toggle
-      # @param show_additional_content toggle
+      # @param show_additional_details toggle
       # @param custom_footer toggle
-      def playground(icon: :"check-circle", icon_color: :success, loading_state: false, show_description: true, show_additional_content: false, custom_footer: false)
+      def playground(icon: :"check-circle", icon_color: :success, loading_state: false, show_description: true, show_additional_details: false, custom_footer: false)
         render_with_template(locals: { icon: icon,
                                        icon_color: icon_color,
                                        loading_state: loading_state,
                                        show_description: show_description,
-                                       show_additional_content: show_additional_content,
+                                       show_additional_details: show_additional_details,
                                        custom_footer: custom_footer })
       end
 
-      # @label With additional content
-      def additional_content
+      # @label With additional details
+      def with_additional_details
         render_with_template(locals: {})
       end
 
@@ -52,7 +52,7 @@ module Primer
       end
 
       # @label With custom footer
-      def custom_footer
+      def with_custom_footer
         render_with_template(locals: {})
       end
 

data/static/info_arch.json

@@ -17497,8 +17497,8 @@
         ]
       },
       {
-        "name": "additional_content",
-        "description": "Optional additional_content like a form input or toast.",
+        "name": "additional_details",
+        "description": "Optional additional_details like a form input or toast.",
         "parameters": [
           {
             "name": "system_arguments",
@@ -17547,8 +17547,8 @@
         }
       },
       {
-        "preview_path": "primer/open_project/feedback_dialog/additional_content",
-        "name": "additional_content",
+        "preview_path": "primer/open_project/feedback_dialog/with_additional_details",
+        "name": "with_additional_details",
         "snapshot": "false",
         "skip_rules": {
           "wont_fix": [
@@ -17573,8 +17573,8 @@
         }
       },
       {
-        "preview_path": "primer/open_project/feedback_dialog/custom_footer",
-        "name": "custom_footer",
+        "preview_path": "primer/open_project/feedback_dialog/with_custom_footer",
+        "name": "with_custom_footer",
         "snapshot": "false",
         "skip_rules": {
           "wont_fix": [

data/static/previews.json

@@ -3680,8 +3680,8 @@
         }
       },
       {
-        "preview_path": "primer/open_project/feedback_dialog/additional_content",
-        "name": "additional_content",
+        "preview_path": "primer/open_project/feedback_dialog/with_additional_details",
+        "name": "with_additional_details",
         "snapshot": "false",
         "skip_rules": {
           "wont_fix": [
@@ -3706,8 +3706,8 @@
         }
       },
       {
-        "preview_path": "primer/open_project/feedback_dialog/custom_footer",
-        "name": "custom_footer",
+        "preview_path": "primer/open_project/feedback_dialog/with_custom_footer",
+        "name": "with_custom_footer",
         "snapshot": "false",
         "skip_rules": {
           "wont_fix": [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.51.0
+  version: 0.52.0
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-20 00:00:00.000000000 Z
+date: 2025-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -1034,9 +1034,9 @@ files:
 - previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form.html.erb
 - previews/primer/open_project/drag_handle_preview.rb
 - previews/primer/open_project/feedback_dialog_preview.rb
-- previews/primer/open_project/feedback_dialog_preview/additional_content.html.erb
-- previews/primer/open_project/feedback_dialog_preview/custom_footer.html.erb
 - previews/primer/open_project/feedback_dialog_preview/playground.html.erb
+- previews/primer/open_project/feedback_dialog_preview/with_additional_details.html.erb
+- previews/primer/open_project/feedback_dialog_preview/with_custom_footer.html.erb
 - previews/primer/open_project/feedback_message_preview.rb
 - previews/primer/open_project/flex_layout_preview.rb
 - previews/primer/open_project/grid_layout_preview.rb