openproject-primer_view_components 0.50.0 → 0.50.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8125e5833c77a58f2ce85f8781ad48954a0c8669105d3bf8e55c74f2c360c12
-  data.tar.gz: 0d501ea896daa1a624c75747219e0a188cf2c74887476a9335fbf3ed9961fbe8
+  metadata.gz: ee0c706f13dfedc8047f4183c4cb5570b6e05c0ad72592380d0298609b3474bd
+  data.tar.gz: 34c75cb39e5436abd05757aee46f36c0e570e3ef5a33037a239b5e93dc2ef8e3
 SHA512:
-  metadata.gz: 4e17df484d35909bcf040b50187384550a4ffea360250b3aa4f7555a7b2b792eb24ea441846b66ae931c32ff2cf781c7aa2ad5b089b62a979b1c585a5d8092c6
-  data.tar.gz: 84ec5382d94997acc7acd6a0f47e2ba06a51670590c81709d2d42a127d8451638be204c7b94f0c34b88ead697e97443713e00ad4f694bb2c09dd1ab3abd2675e
+  metadata.gz: b392abc90b6fde8fa348a04d8cf50669a7bf61c333ef019a2f571abb6eaa0e81e3017bda38d6e4e0a53e8801053a41a67d5bdec4a1e3f779fa153af0b7ed7b15
+  data.tar.gz: da34470011c02ec67f98082fb2192faaf614097b83f14d345ca0f396b6007a528cb0a857ec28c02c79fafba68d9ccad731d10996d3b68932ef78ab7d90157751

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 0.50.1
+
+### Patch Changes
+
+- [#3220](https://github.com/primer/view_components/pull/3220) [`688a4a2`](https://github.com/opf/primer_view_components/commit/688a4a263deb4be70763b9ba39cae854896b44ce) Thanks [@jonrohan](https://github.com/jonrohan)! - Remove SystemArgumentInsteadOfClass linter and fix bug with whitespace in rendered class
+
 ## 0.50.0
 
 ### Minor Changes

data/lib/primer/classify.rb

@@ -49,7 +49,7 @@ module Primer
             case key
             when :classes
               # insert :classes first to avoid huge doc diffs
-              result.unshift(val)
+              result.unshift(val) unless val.blank?
               next
             when :style
               style = val

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 50
-      PATCH = 0
+      PATCH = 1
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/lib/rubocop/config/default.yml

@@ -1,9 +1,6 @@
 require:
   - rubocop/cop/primer
 
-Primer/SystemArgumentInsteadOfClass:
-  Enabled: true
-
 Primer/NoTagMemoize:
   Enabled: false
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.50.0
+  version: 0.50.1
 platform: ruby
 authors:
 - GitHub Open Source
@@ -800,7 +800,6 @@ files:
 - lib/rubocop/cop/primer/deprecated_layout_component.rb
 - lib/rubocop/cop/primer/no_tag_memoize.rb
 - lib/rubocop/cop/primer/primer_octicon.rb
-- lib/rubocop/cop/primer/system_argument_instead_of_class.rb
 - lib/rubocop/cop/primer/test_selector.rb
 - lib/tasks/custom_utilities.yml
 - previews/pages/forms/01_introduction.md.erb

data/lib/rubocop/cop/primer/system_argument_instead_of_class.rb

@@ -1,57 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-require "primer/classify/utilities"
-
-# :nocov:
-module RuboCop
-  module Cop
-    module Primer
-      # This cop ensures that components use System Arguments instead of CSS classes.
-      #
-      # bad
-      # Component.new(classes: "mr-1")
-      #
-      # good
-      # Component.new(mr: 1)
-      class SystemArgumentInsteadOfClass < BaseCop
-        INVALID_MESSAGE = <<~STR
-          Avoid using CSS classes when you can use System Arguments: https://primer.style/view-components/system-arguments.
-        STR
-
-        def on_send(node)
-          return unless valid_node?(node)
-          return unless node.arguments?
-
-          # we are looking for hash arguments and they are always last
-          kwargs = node.arguments.last
-
-          return unless kwargs.type == :hash
-
-          # find classes pair
-          classes_arg = kwargs.pairs.find { |kwarg| kwarg.key.value == :classes }
-
-          return if classes_arg.nil?
-          return unless classes_arg.value.type == :str
-
-          # get actual classes
-          classes = classes_arg.value.value
-
-          system_arguments = ::Primer::Classify::Utilities.classes_to_hash(classes)
-
-          # no classes are fixable
-          return if system_arguments[:classes] == classes
-
-          add_offense(classes_arg, message: INVALID_MESSAGE)
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            args = ::Primer::Classify::Utilities.classes_to_args(node.value.value)
-            corrector.replace(node.loc.expression, args)
-          end
-        end
-      end
-    end
-  end
-end