openproject-primer_view_components 0.44.3 → 0.46.0

data/lib/primer/view_components/linters/base_linter.rb

@@ -42,13 +42,15 @@ module ERBLint
 
         tags.each do |tag|
           next if tag.closing?
-          next if self.class::TAGS&.none?(tag.name)
+          next if self.class::TAGS.present? && self.class::TAGS&.none?(tag.name)
 
           classes = tag.attributes["class"]&.value&.split(" ") || []
           tag_tree[tag][:offense] = false
 
           next if (classes & self.class::DISALLOWED_CLASSES).any?
-          next unless self.class::CLASSES.blank? || (classes & self.class::CLASSES).any?
+          next unless self.class::CLASSES.blank? || classes.any? do |klass|
+            self.class::CLASSES.any? { |matcher| matcher === klass } # rubocop:disable Style/CaseEquality
+          end
 
           args = map_arguments(tag, tag_tree[tag])
           correction = correction(args)

data/lib/primer/view_components/linters/blankslate_component_migration_counter.rb

@@ -6,7 +6,7 @@ module ERBLint
   module Linters
     # Counts the number of times a HTML Blankslate is used instead of the component.
     class BlankslateComponentMigrationCounter < BaseLinter
-      MESSAGE = "We are migrating Blankslate to use [Primer::Beta::Blankslate](https://primer.style/view-components/components/beta/blankslate), please try to use that instead of raw HTML."
+      MESSAGE = "We are migrating Blankslate to use [Primer::Beta::Blankslate](https://primer.style/components/blankslate/rails/beta), please try to use that instead of raw HTML."
       CLASSES = %w[blankslate].freeze
       TAGS = %w[div].freeze
     end

data/lib/primer/view_components/linters/select_menu_migration_counter.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require_relative "base_linter"
+
+module ERBLint
+  module Linters
+    # Counts the number of times a HTML SelectMenu is used instead of the SelectPanel component.
+    class SelectMenuMigrationCounter < BaseLinter
+      MESSAGE = "Please use the [Primer::Alpha::SelectPanel](https://primer.style/components/selectpanel/rails/alpha) component instead of SelectMenu."
+      CLASSES = ["SelectMenu", /\ASelectMenu-.*/].freeze
+      TAGS = [].freeze
+    end
+  end
+end

data/lib/primer/view_components/version.rb

@@ -5,8 +5,8 @@ module Primer
   module ViewComponents
     module VERSION
       MAJOR = 0
-      MINOR = 44
-      PATCH = 3
+      MINOR = 46
+      PATCH = 0
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/previews/primer/alpha/select_panel_preview/eventually_local_fetch.html.erb

@@ -5,7 +5,8 @@
   src: select_panel_items_path,
   select_variant: :multiple,
   fetch_strategy: :eventually_local,
-  open_on_load: open_on_load
+  open_on_load: open_on_load,
+  show_filter: show_filter,
 )) do |panel| %>
   <% panel.with_show_button { "Sci-fi equipment" } %>
   <% panel.with_footer(show_divider: true) do %>

data/previews/primer/alpha/select_panel_preview.rb

@@ -77,8 +77,9 @@ module Primer
       #
       # @snapshot interactive
       # @param open_on_load toggle
-      def eventually_local_fetch(open_on_load: false)
-        render_with_template(locals: { open_on_load: open_on_load })
+      # @param show_filter toggle
+      def eventually_local_fetch(open_on_load: false, show_filter: true)
+        render_with_template(locals: { open_on_load: open_on_load, show_filter: show_filter })
       end
 
       # @label Remote fetch

data/previews/primer/open_project/sub_header_preview.rb

@@ -11,10 +11,23 @@ module Primer
       # @param show_filter_input toggle
       # @param show_filter_button toggle
       # @param show_action_button toggle
+      # @param show_clear_button toggle
       # @param text text
-      def playground(show_filter_input: true, show_filter_button: true, show_action_button: true, text: nil)
+      # @param value text
+      def playground(
+        show_filter_input: true,
+        show_clear_button: true,
+        show_filter_button: true,
+        show_action_button: true,
+        text: nil,
+        value: nil
+      )
         render(Primer::OpenProject::SubHeader.new) do |component|
-          component.with_filter_input(name: "filter", label: "Filter") if show_filter_input
+          component.with_filter_input(
+            name: "filter",
+            label: "Filter",
+            show_clear_button: show_clear_button,
+            value: value) if show_filter_input
           component.with_filter_button do |button|
             button.with_trailing_visual_counter(count: "15")
             "Filter"

data/static/classes.json

@@ -591,6 +591,9 @@
   "SubHeader-filterContainer": [
     "Primer::OpenProject::SubHeader"
   ],
+  "SubHeader-filterInput_hiddenClearButton": [
+    "Primer::OpenProject::SubHeader"
+  ],
   "SubHeader-leftPane": [
     "Primer::OpenProject::SubHeader"
   ],

data/static/info_arch.json

@@ -2425,7 +2425,7 @@
   },
   {
     "fully_qualified_name": "Primer::Alpha::Banner",
-    "description": "Use `Banner` to highlight important information.",
+    "description": "Use `Banner` to highlight important information.\n\n### Events\n\n|Name      |Type                |Bubbles |Cancelable |\n|:---------|:-------------------|:-------|:----------|\n|`dismiss` |`CustomEvent<void>` |No      |No         |",
     "accessibility_docs": "### Improve discoverability with a heading and landmark\nBanners are made visually prominent with icons and colors to immediately draw attention.\n\nTo ensure the Banner is also easily discoverable for assistive technology users, consider:\n1. Providing a heading inside of the Banner that describes the purpose of the Banner.\n2. Designating the Banner as a `region` landmark. This can be achieved by rendering the Banner as a `section`  with an `aria-labelledby` pointing to the heading.\n\n### Communicating feedback\nWhen a Banner is used to communicate feedback, a live region or focus management technique should be in place to ensure that assistive technology users are aware of the feedback, especially when the Banner is shown client-side. Visit the [Banner's Accessibility section](https://primer.style/components/banner#accessibility), or defer to the accessibility team.\n\n#### Approach 1: Announcing a Banner\nA live region announcement can be used to communicate non-critical feedback, such as a success message.\n\nTo successfully trigger a live region announcement for a Banner that is un-`hidden` or dynamically injected onto the page, **do not** set the live region attribute/role on the Banner itself. Instead, it's important to rely on a live region that is already guaranteed to be on the page. Learn more about specific techniques at: [Staff only: Challenges with live regions](https://github.com/github/accessibility/blob/main/docs/coaching-recommendations/toast-flash-banner/accessible-banner-prototype.md#challenges-with-dynamically-inserted-live-region).\n\n#### Approach 2: Focusing a Banner\nFocusing the Banner can be appropriate for critical feedback scenarios, such as a [form validation error summary](https://primer.style/ui-patterns/forms/overview#interactive-summary-of-errors) where the Banner contains actions to help unblock the user.\n\nTo properly focus a Banner, add a `tabindex=\"-1\"` place focus with JavaScript (using the [`focus()` API](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus)).",
     "is_form_component": false,
     "is_published": true,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.44.3
+  version: 0.46.0
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-09-06 00:00:00.000000000 Z
+date: 2024-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -750,6 +750,7 @@ files:
 - lib/primer/view_components/linters/migrate_deprecated_flash_arguments.rb
 - lib/primer/view_components/linters/migrations/iconbutton_component.rb
 - lib/primer/view_components/linters/migrations/truncate_component.rb
+- lib/primer/view_components/linters/select_menu_migration_counter.rb
 - lib/primer/view_components/linters/severity_schema.rb
 - lib/primer/view_components/linters/subhead_component_migration_counter.rb
 - lib/primer/view_components/linters/super_in_component_templates.rb