openproject-primer_view_components 0.27.0 → 0.28.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 625ef28c9bb40b00a14026f72eeb9fb7627c446a69c6735528f8ce5ced1b7ab7
-  data.tar.gz: 34ef12fb54dde389edc3607367977b6f344341e6f04f98007b8b1abe97d71716
+  metadata.gz: b0fa76eaed82e32a169e106a7c5331e364410a77b3e90f16be74b7393f5f2482
+  data.tar.gz: f4ea4ac9f39c7bea4f6d252c6d76f2acb829df24883f7f1c9784a3acd2838d58
 SHA512:
-  metadata.gz: b471b62da42a63ba9df30cb2eafe51fb39a841c2b7e2bf504c758f168bda857529b2d9ace734790d07c65e35a3e83f1bbfad1dcb9cf29e106a38d49b1ab3db8e
-  data.tar.gz: c72334e36b1107f8f6c2ac9b06026de4d8954d9d3d69413c25e80f24f799cdca0be0c1e4a9b1bd7329455a0d3a2c185dc80fff84f0b0a42b25242e490c52dad4
+  metadata.gz: a93114a05144027314da5b83f035e087984736a983983da809047e9ddbb46fa46801f39ec3ec84f8cd18e73d21945a4ae477b03a81d1fb4d09c0bcce0e88d2ee
+  data.tar.gz: 9ff8e8f2547b22832e5900d9eb19219a1e19a7c7c5d30aa6b36e834f524518ada9f5e7d8ad9bc4524bc19dc01865598d991f835dd58fa4a356c685521d200e60

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # CHANGELOG
 
+## 0.28.1
+
+### Patch Changes
+
+- [#102](https://github.com/opf/primer_view_components/pull/102) [`b1bd1e2`](https://github.com/opf/primer_view_components/commit/b1bd1e26ef02172fdfb5780d3b109fad9a29bd65) Thanks [@HDinger](https://github.com/HDinger)! - Set target attribute on the actual link element in the Breadcrumb instead of the list element above
+
+## 0.28.0
+
+### Minor Changes
+
+- [#98](https://github.com/opf/primer_view_components/pull/98) [`7e56211`](https://github.com/opf/primer_view_components/commit/7e562112d65e48d42b1f7d5b2039bede68fc1383) Thanks [@HDinger](https://github.com/HDinger)! - Add a slot for Primer::OpenProject::ZenModeButton to the Primer::OpenProject::PageHeader
+
+### Patch Changes
+
+- [#100](https://github.com/opf/primer_view_components/pull/100) [`7d4e6fb`](https://github.com/opf/primer_view_components/commit/7d4e6fbde24069b80e6dae5f2c07fa1fd4538557) Thanks [@HDinger](https://github.com/HDinger)! - Set link target "\_top" as default for breadcrumb items and link actions
+
 ## 0.27.0
 
 ### Minor Changes

data/app/components/primer/beta/breadcrumbs.rb

@@ -48,8 +48,9 @@ module Primer
       class Item < Primer::Component
         attr_accessor :selected, :href
 
-        def initialize(href:, **system_arguments)
+        def initialize(href:, target: "_self", **system_arguments)
           @href = href
+          @target = target
           @system_arguments = deny_tag_argument(**system_arguments)
           @selected = false
 
@@ -58,7 +59,7 @@ module Primer
         end
 
         def call
-          link_arguments = { href: @href }
+          link_arguments = { href: @href, target: @target }
 
           if selected
             link_arguments[:"aria-current"] = "page"

data/app/components/primer/open_project/page_header.rb

@@ -71,8 +71,18 @@ module Primer
 
           Primer::Beta::Button.new(**system_arguments)
         },
+        zen_mode_button: lambda { |mobile_icon: Primer::OpenProject::ZenModeButton::ZEN_MODE_BUTTON_ICON, mobile_label: Primer::OpenProject::ZenModeButton::ZEN_MODE_BUTTON_LABEL, **system_arguments|
+          deny_tag_argument(**system_arguments)
+          system_arguments = set_action_arguments(system_arguments, scheme: DEFAULT_ACTION_SCHEME)
+          add_option_to_mobile_menu(system_arguments, mobile_icon, mobile_label, DEFAULT_ACTION_SCHEME)
+
+          Primer::OpenProject::ZenModeButton.new(**system_arguments)
+        },
+
         link: lambda { |mobile_icon:, mobile_label:, scheme: DEFAULT_ACTION_SCHEME, **system_arguments|
           deny_tag_argument(**system_arguments)
+          system_arguments[:target] ||= "_top"
+
           system_arguments = set_action_arguments(system_arguments, scheme: scheme)
           add_option_to_mobile_menu(system_arguments, mobile_icon, mobile_label, scheme)
 
@@ -151,6 +161,8 @@ module Primer
 
           link_arguments[:icon] = fetch_or_fallback(BACK_BUTTON_ICON_OPTIONS, DEFAULT_BACK_BUTTON_ICON)
           link_arguments[:href] = parsed_parent_item[:href]
+          link_arguments[:target] = "_top"
+
           link_arguments[:classes] = class_names(link_arguments[:classes], "PageHeader-parentLink")
           link_arguments[:display] ||= DEFAULT_PARENT_LINK_DISPLAY
 
@@ -169,7 +181,7 @@ module Primer
             if item.is_a?(String)
               breadcrumbs.with_item(href: "#") { item }
             else
-              breadcrumbs.with_item(href: item[:href]) { item[:text] }
+              breadcrumbs.with_item(href: item[:href], target: "_top") { item[:text] }
             end
           end
         end

data/app/components/primer/open_project/zen_mode_button.html.erb

@@ -3,8 +3,8 @@
           Primer::Beta::IconButton.new(
             scheme: :default,
             id: "zenModeButton",
-            icon: "screen-normal",
-            aria: { label: I18n.t("zen_mode") },
+            icon: ZEN_MODE_BUTTON_ICON,
+            aria: { label: ZEN_MODE_BUTTON_LABEL },
             data: { target: "zen-mode-button.button", action: "click:zen-mode-button#performAction" }
           )
         ) %>

data/app/components/primer/open_project/zen_mode_button.rb

@@ -8,6 +8,9 @@ module Primer
     class ZenModeButton < Primer::Component
       status :open_project
 
+      ZEN_MODE_BUTTON_LABEL = I18n.t("label_zen_mode")
+      ZEN_MODE_BUTTON_ICON = "screen-full"
+
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       def initialize(**system_arguments)
         @system_arguments = system_arguments

data/lib/primer/view_components/version.rb

@@ -5,8 +5,8 @@ module Primer
   module ViewComponents
     module VERSION
       MAJOR = 0
-      MINOR = 27
-      PATCH = 0
+      MINOR = 28
+      PATCH = 1
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/previews/primer/open_project/page_header_preview.rb

@@ -104,6 +104,22 @@ module Primer
         end
       end
 
+      # @label With a ZenModeButton inside the actions
+      # The missing label will be resolved automatically when included into the core
+      def zen_mode_button_actions
+        render(Primer::OpenProject::PageHeader.new) do |component|
+          component.with_title { "Great news" }
+          component.with_breadcrumbs([{ href: "/foo", text: "Foo" }, { href: "/bar", text: "Bar" }, "Baz"])
+
+          # The missing label will be resolved automatically when included into the core
+          component.with_action_zen_mode_button
+          component.with_action_button(mobile_icon: "plus", mobile_label: "Meeting", scheme: :primary) do |button|
+            button.with_leading_visual_icon(icon: "plus")
+            "Meeting"
+          end
+        end
+      end
+
       # @label With leading action (on wide)
       # **Leading action** is only shown on **wide screens** by default.
       # If you want to override that behaviour please use the system_argument: **display**

data/static/constants.json

@@ -1474,6 +1474,8 @@
   "Primer::OpenProject::PageHeader::Menu": {
   },
   "Primer::OpenProject::ZenModeButton": {
+    "ZEN_MODE_BUTTON_ICON": "screen-full",
+    "ZEN_MODE_BUTTON_LABEL": "Translation missing: en.label_zen_mode"
   },
   "Primer::Tooltip": {
     "ALIGN_DEFAULT": "default",

data/static/info_arch.json

@@ -16631,6 +16631,19 @@
           ]
         }
       },
+      {
+        "preview_path": "primer/open_project/page_header/zen_mode_button_actions",
+        "name": "zen_mode_button_actions",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
       {
         "preview_path": "primer/open_project/page_header/leading_action",
         "name": "leading_action",

data/static/previews.json

@@ -5222,6 +5222,19 @@
           ]
         }
       },
+      {
+        "preview_path": "primer/open_project/page_header/zen_mode_button_actions",
+        "name": "zen_mode_button_actions",
+        "snapshot": "false",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
+      },
       {
         "preview_path": "primer/open_project/page_header/leading_action",
         "name": "leading_action",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openproject-primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.27.0
+  version: 0.28.1
 platform: ruby
 authors:
 - GitHub Open Source
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-04-04 00:00:00.000000000 Z
+date: 2024-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview