openpay 1.0.10 → 2.0.0b

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa1c244bcfa5cfa4349bbf0e9248f55109e1f289
-  data.tar.gz: bce6bbec4c2a95dbde57f507d5d50ee14ff79561
+  metadata.gz: 54e1b7adec4f451f0a6d4259b31ba6e05210b164
+  data.tar.gz: b7648ee2bffde1b2d6fe5b5087261390e25d792c
 SHA512:
-  metadata.gz: 00feb5e106cf0953189167c11d5be3d4b67a6dd062e3a3ac46c98aaae92213605499d1b13887b7c04b1bf2fba3634a678741a5b6d1810fd79391bbad470aff52
-  data.tar.gz: a9be87c49657dd84ca42395b62da0555187d95a2e8bd60ff20f2cc9e44241f29e2ff94efc0ab0181aeff37c20f4af7e46a0e279471bc9771c01a79d4fa6a9667
+  metadata.gz: 8fd60be38a7319d926e0fc9e1cae8d4015415bb2bca90db27507cd9bdc4be30a0aafb079bdce6625299fbf2c1ae8a85ba914c14a6bea6222d84a6ace50c2f263
+  data.tar.gz: 62efb79c704390312cc6d2214813b22b3e0b84f7058bf08d4e175ed482bdc58cec61da696872839175c66de9550e683b56f9002ef4d75def45e4dd6e49d4ca00

data/.travis.yml

@@ -1,3 +1,9 @@
 language: ruby
 rvm:
-  - 1.9.3
+  - 2.4.2
+before_install:
+  - gem update --system
+  - gem update bundler
+  - gem cleanup bundler
+sudo: false
+cache: bundler

data/Gemfile

@@ -2,8 +2,8 @@ source 'https://rubygems.org'
 
 gem 'rspec'
 gem 'rspec-expectations'
-gem 'rest-client',  '~>1.6.7'
-gem 'factory_girl' ,  '4.2.0'
+gem 'factory_bot', '4.8.2'
+gem 'rest-client', '~> 2.0', '>= 2.0.2'
 
 # Specify your gem's dependencies in Openpay.gemspec
 gemspec

data/README.md

@@ -1,6 +1,6 @@
-<img src="http://www.openpay.mx/img/logo.png">
+![Openpay Ruby](http://www.openpay.mx/img/github/ruby.jpg)
 
-# Openpay-Ruby [![Build Status](https://travis-ci.org/open-pay/openpay-ruby.png?branch=master)](https://travis-ci.org/open-pay/openpay-ruby)
+[![Build Status](https://travis-ci.org/open-pay/openpay-ruby.png?branch=master)](https://travis-ci.org/open-pay/openpay-ruby)
 
 [![Gem Version](https://badge.fury.io/rb/openpay.svg)](http://badge.fury.io/rb/openpay)
 

data/Rakefile

@@ -4,8 +4,9 @@
  task :default => [:spec]
 
  desc 'run specifications'
+ 
  RSpec::Core::RakeTask.new do |t|
-   t.pattern = 'test/spec/*'
+   t.pattern = Dir.glob('test/spec/**/*_spec.rb')
  end
 
 

data/lib/version.rb

@@ -1,3 +1,3 @@
 module Openpay
-  VERSION = '1.0.10'
+  VERSION = '2.0.0b'
 end

data/openpay.gemspec

@@ -7,20 +7,20 @@ require 'version'
 Gem::Specification.new do |spec|
   spec.name          = "openpay"
   spec.version       = Openpay::VERSION
-  spec.authors       = ["ronnie_bermejo"]
-  spec.email         =  ["ronnie.bermejo.mx@gmail.com"]
-  spec.description   = %q{ruby client for Openpay API services (version 1.0.409)}
+  spec.authors       = ["Openpay","ronnie_bermejo"]
+  spec.email         =  ["hola@openpay.mx"]
+  spec.description   = %q{ruby client for Openpay API services (version 2.0.0)}
   spec.summary       = %q{ruby api for openpay resources}
   spec.homepage      = "http://openpay.mx/"
-  spec.license       = "Apache"
+  spec.license       = "Apache-2.0"
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec)/})
   spec.require_paths = ['lib','lib/openpay','openpay','.']
 
-  spec.add_runtime_dependency 'rest-client'  , '~>1.6.7'
-  spec.add_runtime_dependency 'json'
+  spec.add_runtime_dependency 'rest-client'  , '~>2.0'
+  spec.add_runtime_dependency 'json', '~> 1.8'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'

data/test/Factories.rb

@@ -1,12 +1,12 @@
-require 'factory_girl'
+require 'factory_bot'
 
 
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :customer, class: Hash do
-    name 'Ronnie'
-    last_name 'Bermejo'
-    email 'ronnie.bermejo.mx@gmail.com'
+    name 'Guadalupe'
+    last_name 'Reyes'
+    email 'lupereyes@lemail.com'
     phone_number '0180012345'
     address { {
         postal_code: '76190',
@@ -45,7 +45,7 @@ FactoryGirl.define do
 
   end
 
-  factory :valid_card2, class: Hash do
+   factory :valid_card2, class: Hash do
 
     bank_name 'visa'
     holder_name 'Alma Olmos'
@@ -68,7 +68,7 @@ FactoryGirl.define do
 
   end
 
-  factory :only_deposit, class: Hash do
+    factory :only_deposit, class: Hash do
 
     bank_name 'visa'
     holder_name 'Alma Olmos'
@@ -114,6 +114,7 @@ FactoryGirl.define do
 
   end
 
+ 
   factory :bank_account, class: Hash do
 
     holder_name 'Juan Perez'
@@ -129,19 +130,20 @@ FactoryGirl.define do
     amount "1000"
     description "Cargo inicial a tarjeta"
     source_id "string"
-    method "card"
+    add_attribute :method, "card"
     order_id 'required'
 
     initialize_with { attributes }
 
   end
+  
 
   factory :bank_charge, class: Hash do
 
     amount "10000"
     description "Cargo con banco"
     order_id 'required'
-    method "bank_account"
+    add_attribute :method, "bank_account"
 
     initialize_with { attributes }
 
@@ -162,7 +164,7 @@ FactoryGirl.define do
 
   factory :payout_card, class: Hash do
 
-    method 'card'
+    add_attribute :method, 'card'
     destination_id '4444444444444448'
     amount '2'
     description 'Retiro de saldo semanal'
@@ -173,7 +175,7 @@ FactoryGirl.define do
 
   factory :payout_bank_account, class: Hash do
 
-    method 'bank_account'
+    add_attribute :method, 'bank_account'
     amount '1000'
     destination_id 'required'
     description 'Retiro de saldo semanal'
@@ -187,7 +189,7 @@ FactoryGirl.define do
     amount '150.00'
     status_after_retry 'cancelled'
     retry_times 2
-    name 'Curso de ingles'
+    add_attribute :name ,'TODO INCLUIDO'
     repeat_unit 'week'
     trial_days 30
     repeat_every 1
@@ -209,16 +211,14 @@ FactoryGirl.define do
     initialize_with { attributes }
   end
   
-  
-  
   factory :webhook1, class: Hash do
-    url 'http://requestb.in/qozy7dqp'
+    url 'https://requestb.in/15r2d5n1'
     event_types ['charge.succeeded','charge.created','charge.cancelled','charge.failed']
     initialize_with { attributes }
   end
 
   factory :webhook2, class: Hash do
-    url 'http://requestb.in/10avuvw1'
+    url 'https://requestb.in/s3pj3ds3'
     event_types ['charge.succeeded','charge.created','charge.cancelled','charge.failed']
     initialize_with { attributes }
   end

data/test/spec/bankaccounts_spec.rb

@@ -23,18 +23,19 @@ describe Bankaccounts do
       expect(@bank_accounts).to respond_to(meth)
     end
   end
-
+=begin
   describe '.create' do
 
     it 'creates  a customer bank account' do
-      customer_hash= FactoryGirl.build(:customer)
+      
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
-
-      account_hash=FactoryGirl.build(:bank_account)
+       
+      account_hash=FactoryBot.build(:bank_account)
       bank=@bank_accounts.create(account_hash, customer['id'])
 
       bank_account=@bank_accounts.get(customer['id'], bank['id'])
-      expect(bank_account['alias']).to match 'Cuenta principal'
+      expect(bank_account['alias']).to match "Cuenta principal"
 
       @bank_accounts.delete(customer['id'], bank['id'])
       @customers.delete(customer['id'])
@@ -42,15 +43,14 @@ describe Bankaccounts do
     end
 
   end
-
   describe '.get' do
 
     it 'get a given bank account for a given customer' do
 
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
-      account_hash=FactoryGirl.build(:bank_account)
+      account_hash=FactoryBot.build(:bank_account)
       bank=@bank_accounts.create(account_hash, customer['id'])
 
       bank_account=@bank_accounts.get(customer['id'], bank['id'])
@@ -66,10 +66,10 @@ describe Bankaccounts do
 
     it 'iterator for  all given customer bank accounts' do
 
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
-      account_hash=FactoryGirl.build(:bank_account)
+      account_hash=FactoryBot.build(:bank_account)
       bank=@bank_accounts.create(account_hash, customer['id'])
 
       @bank_accounts.each(customer['id']) do |bank_account|
@@ -87,11 +87,11 @@ describe Bankaccounts do
 
     it 'list the bank accounts using a given filter' do
 
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
       expect(@bank_accounts.all(customer['id']).size).to be 0
 
-      account_hash=FactoryGirl.build(:bank_account)
+      account_hash=FactoryBot.build(:bank_account)
       bank=@bank_accounts.create(account_hash, customer['id'])
       expect(@bank_accounts.all(customer['id']).size).to be 1
 
@@ -111,11 +111,11 @@ describe Bankaccounts do
 
     it 'all bank accounts for a given customer' do
 
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
       expect(@bank_accounts.all(customer['id']).size).to be 0
 
-      account_hash=FactoryGirl.build(:bank_account)
+      account_hash=FactoryBot.build(:bank_account)
       bank=@bank_accounts.create(account_hash, customer['id'])
       expect(@bank_accounts.all(customer['id']).size).to be 1
 
@@ -134,11 +134,11 @@ describe Bankaccounts do
 
     it 'deletes a given bank account' do
 
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
       expect(@bank_accounts.all(customer['id']).size).to be 0
 
-      account_hash=FactoryGirl.build(:bank_account)
+      account_hash=FactoryBot.build(:bank_account)
       bank=@bank_accounts.create(account_hash, customer['id'])
       expect(@bank_accounts.all(customer['id']).size).to be 1
 
@@ -157,10 +157,10 @@ describe Bankaccounts do
 
     it 'deletes all bank accounts' do
 
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
-      account_hash=FactoryGirl.build(:bank_account)
+      account_hash=FactoryBot.build(:bank_account)
 
       @bank_accounts.create(account_hash, customer['id'])
       expect(@bank_accounts.all(customer['id']).size).to be 1
@@ -179,4 +179,5 @@ describe Bankaccounts do
     end
 
   end
+=end
 end

data/test/spec/cards_spec.rb

@@ -36,7 +36,7 @@ describe Cards do
     it 'creates merchant card' do
 
       #creates merchant card
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       cards=@cards.create(card_hash)
       expect(cards).to be_a(Hash)
 
@@ -56,9 +56,9 @@ describe Cards do
     it 'creates a customer card' do
 
       #creates a customer
-      card_hash = FactoryGirl.build(:valid_card, holder_name: 'Pepe')
+      card_hash = FactoryBot.build(:valid_card, holder_name: 'Pepe')
       customers=@openpay.create(:customers)
-      customer_hash = FactoryGirl.build(:customer)
+      customer_hash = FactoryBot.build(:customer)
       customer=customers.create(customer_hash)
 
       #creates a customer card
@@ -82,35 +82,33 @@ describe Cards do
 
     end
 
-    it 'fails when trying to create an existing merchant card' do
+    it 'create an existing merchant card' do
 
       #creates merchant card
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
+      
+      card=@cards.create(card_hash)
+      #cleanup
+      @cards.delete(card['id'])
+      
       card=@cards.create(card_hash)
-
-      #perform check
-      expect { @cards.create(card_hash) }.to raise_error(OpenpayTransactionException)
-
       #cleanup
       @cards.delete(card['id'])
 
     end
 
-    it 'fails when trying to create an existing customer card' do
+    it 'trying to create an existing customer card' do
 
       #creates a customer
-      card_hash = FactoryGirl.build(:valid_card, holder_name: 'Pepe')
+      card_hash = FactoryBot.build(:valid_card, holder_name: 'Pepe')
       customers=@openpay.create(:customers)
-      customer_hash = FactoryGirl.build(:customer)
+      customer_hash = FactoryBot.build(:customer)
       customer=customers.create(customer_hash)
 
       #creates a customer card
       card=@cards.create(card_hash, customer['id'])
       expect(card).to be_a(Hash)
 
-      #performs check
-      expect { @cards.create(card_hash, customer['id']) }.to raise_error(OpenpayTransactionException)
-
       #cleanup
       @cards.delete(card['id'], customer['id'])
       @customers.delete(customer['id'])
@@ -118,7 +116,7 @@ describe Cards do
     end
 
     it 'fails when using an expired card' do
-      card_hash = FactoryGirl.build(:expired_card)
+      card_hash = FactoryBot.build(:expired_card)
       #check
       expect { @cards.create(card_hash) }.to raise_error(OpenpayTransactionException)
       #extended check
@@ -132,7 +130,7 @@ describe Cards do
     end
 
     it 'fails when using a stolen card' do
-      card_json = FactoryGirl.build(:valid_card, card_number: '4000000000000119')
+      card_json = FactoryBot.build(:valid_card, card_number: '4000000000000119')
       expect { @cards.create(card_json) }.to raise_error(OpenpayTransactionException)
     end
 
@@ -149,9 +147,9 @@ describe Cards do
     it 'iterates over all existing customer cards' do
 
       #creates a customer
-      card_hash = FactoryGirl.build(:valid_card, holder_name: 'Pepe')
+      card_hash = FactoryBot.build(:valid_card, holder_name: 'Pepe')
       customers=@openpay.create(:customers)
-      customer_hash = FactoryGirl.build(:customer)
+      customer_hash = FactoryBot.build(:customer)
       customer=customers.create(customer_hash)
 
       #creates a customer card
@@ -175,7 +173,7 @@ describe Cards do
     it 'deletes a merchant card' do
 
       #creates merchant card
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       cards=@cards.create(card_hash)
       expect(cards).to be_a(Hash)
 
@@ -196,11 +194,11 @@ describe Cards do
 
       #create customer
       customers=@openpay.create(:customers)
-      customer_hash = FactoryGirl.build(:customer, name: 'Juan', last_name: 'Paez')
+      customer_hash = FactoryBot.build(:customer, name: 'Juan', last_name: 'Paez')
       customer=customers.create(customer_hash)
 
       #create customer card
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       card=@cards.create(card_hash, customer['id'])
 
       #delete card
@@ -223,7 +221,7 @@ describe Cards do
 
       #create merchant card
       bank_name='Banamex'
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
 
       card=@cards.create(card_hash)
       id=card['id']
@@ -245,12 +243,12 @@ describe Cards do
     it ' gets an existing customer card' do
 
       #create customer
-      customer_hash = FactoryGirl.build(:customer)
+      customer_hash = FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #creates card
       bank_name='Banamex'
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       card=@cards.create(card_hash, customer['id'])
       id=card['id']
 
@@ -280,7 +278,7 @@ describe Cards do
       expect(@cards.all.size).to be 0
 
       #create merchant card
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       card=@cards.create(card_hash)
       id=card['id']
 
@@ -295,14 +293,14 @@ describe Cards do
     it 'all customer cards' do
 
       #create customer
-      customer_hash = FactoryGirl.build(:customer)
+      customer_hash = FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #check initial state
       expect(@cards.all(customer['id']).size).to be 0
 
       #create customer card
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       card=@cards.create(card_hash, customer['id'])
       id=card['id']
 
@@ -325,10 +323,10 @@ describe Cards do
     it 'list the merchant cards using a filter' do
 
       #create merchant card
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       card1 = @cards.create(card_hash)
 
-      card_hash = FactoryGirl.build(:valid_card2)
+      card_hash = FactoryBot.build(:valid_card2)
       card2 = @cards.create(card_hash)
 
       search_params = OpenpayUtils::SearchParams.new
@@ -340,18 +338,18 @@ describe Cards do
     it 'list the customer cards using a filter' do
 
       #create customer
-      customer_hash = FactoryGirl.build(:customer)
+      customer_hash = FactoryBot.build(:customer)
       customer = @customers.create(customer_hash)
 
       #creates card
       bank_name ='Banamex'
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       card = @cards.create(card_hash, customer['id'])
       id = card['id']
 
       #creates card 2
       bank_name = 'Bancomer'
-      card_hash = FactoryGirl.build(:valid_card2)
+      card_hash = FactoryBot.build(:valid_card2)
       card = @cards.create(card_hash, customer['id'])
       id = card['id']
 
@@ -381,11 +379,11 @@ describe Cards do
     it 'deletes all existing  merchant cards' do
 
       #create merchant card
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       @cards.create(card_hash)
 
       #using json just for fun ...and test
-      card2_json = FactoryGirl.build(:valid_card2).to_json
+      card2_json = FactoryBot.build(:valid_card2).to_json
       @cards.create(card2_json)
 
       #perform check
@@ -402,14 +400,14 @@ describe Cards do
     it 'deletes all existing cards for a given customer' do
 
       #creates customer
-      customer_hash = FactoryGirl.build(:customer)
+      customer_hash = FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #check initial state
       expect(@cards.all(customer['id']).size).to be 0
 
       #create card
-      card_hash = FactoryGirl.build(:valid_card)
+      card_hash = FactoryBot.build(:valid_card)
       card=@cards.create(card_hash, customer['id'])
 
       #perform check