openpay 1.0.10 → 2.0.0b

data/test/spec/charges_spec.rb

@@ -25,17 +25,17 @@ describe Charges do
       expect(@charges).to respond_to(meth)
     end
   end
-
+  
   describe '.create' do
 
     it 'creates a new merchant charge using the card method using a pre-stored card' do
 
       #create card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash)
 
       #create charge attached to prev created card
-      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'],amount: 101)
+      charge_hash=FactoryBot.build(:card_charge, source_id: card['id'], order_id: card['id'],amount: 101)
       charge=@charges.create(charge_hash)
 
       #perform check
@@ -50,15 +50,15 @@ describe Charges do
     it 'creates a new customer charge using the card method using a pre-stored card' do
 
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash,customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'])
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'])
       charge=@charges.create(charge_hash,customer['id'])
 
       #perform check
@@ -71,30 +71,6 @@ describe Charges do
 
     end
 
-    it 'creates a new customer charge using the bank_account method' do
-
-      #create new customer
-      customer_hash= FactoryGirl.build(:customer)
-      customer=@customers.create(customer_hash)
-
-      #create bank account
-      account_hash=FactoryGirl.build(:bank_account)
-      account=@bank_accounts.create(account_hash,customer['id'])
-
-      #create charge
-      charge_hash=FactoryGirl.build(:bank_charge, order_id: account['id'])
-      charge=@charges.create(charge_hash,customer['id'])
-
-      #perform check
-      stored_charge=@charges.get(charge['id'],customer['id'])
-      expect(stored_charge['amount']).to be_within(0.1).of(10000)
-
-      #clean up
-      @bank_accounts.delete(customer['id'],account['id'])
-      @customers.delete(customer['id'])
-
-    end
-
   end
 
   describe '.get' do
@@ -102,11 +78,11 @@ describe Charges do
     it 'gets a merchant charge'  do
 
       #create card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash)
 
       #create charge attached to prev created card
-      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'],amount: 505)
+      charge_hash=FactoryBot.build(:card_charge, source_id: card['id'], order_id: card['id'],amount: 505)
       charge=@charges.create(charge_hash)
 
       #perform check
@@ -121,15 +97,15 @@ describe Charges do
     it 'gets a customer charge' do
 
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash,customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000)
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000)
       charge=@charges.create(charge_hash,customer['id'])
 
       #perform check
@@ -153,7 +129,7 @@ describe Charges do
 
     it 'all customer charges' do
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       expect(@charges.all(customer['id']).size).to be 0
@@ -168,15 +144,15 @@ describe Charges do
     it 'captures a merchant card charge'  do
 
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create merchant card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash)
 
       #create merchant charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000, capture:'false')
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000, capture:'false')
       charge=@charges.create(charge_hash)
 
       #capture merchant charge
@@ -190,15 +166,15 @@ describe Charges do
 
     it 'captures a customer card charge' do
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash,customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000,capture:'false')
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000,capture:'false')
       charge=@charges.create(charge_hash,customer['id'])
 
       #capture customer charge
@@ -217,15 +193,15 @@ describe Charges do
     it 'confirms a capture on a merchant charge' do
 
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create merchant card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash)
 
       #create merchant charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000, capture:'false')
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000, capture:'false')
       charge=@charges.create(charge_hash)
 
       confirm_capture_options = {  transaction_id: charge['id'], amount: 100  }
@@ -242,15 +218,15 @@ describe Charges do
 
     it 'confirms a capture on a customer charge' do
 
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash,customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000,capture:'false')
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000,capture:'false')
       charge=@charges.create(charge_hash,customer['id'])
 
       confirm_capture_options = { customer_id: customer['id'], transaction_id: charge['id'], amount: 100  }
@@ -272,15 +248,15 @@ describe Charges do
     #Refunds apply only for card charges
     it 'refunds  an existing merchant charge' do
       #create card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash)
 
       #create charge attached to prev created card
-      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'],amount: 505)
+      charge_hash=FactoryBot.build(:card_charge, source_id: card['id'], order_id: card['id'],amount: 505)
       charge=@charges.create(charge_hash)
 
       #creates refund_description
-      refund_description=FactoryGirl.build(:refund_description)
+      refund_description=FactoryBot.build(:refund_description)
       expect(@charges.get(charge['id'])['refund']).to be nil
 
       @charges.refund(charge['id'],refund_description)
@@ -290,35 +266,36 @@ describe Charges do
       @cards.delete(card['id'])
 
     end
-
+    
     it 'refunds an existing customer charge' do
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash,customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000)
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 100)
       charge=@charges.create(charge_hash,customer['id'])
 
       #creates refund_description
-      refund_description=FactoryGirl.build(:refund_description)
-
+      refund_description=FactoryBot.build(:refund_description)
 
       #perform check
       expect(@charges.get(charge['id'],customer['id'])['refund']).to be nil
+      sleep(50)
       @charges.refund(charge['id'],refund_description,customer['id'])
-      expect(@charges.get(charge['id'],customer['id'])['refund']['amount'] ).to be_within(0.1).of(4000)
+      
+      expect(@charges.get(charge['id'],customer['id'])['refund']['amount'] ).to be_within(0.1).of(100)
 
       #clean up
       @cards.delete(card['id'],customer['id'])
       @customers.delete(customer['id'])
 
     end
-
+    
   end
 
   describe '.list' do
@@ -326,17 +303,17 @@ describe Charges do
     it 'list customer charges' do
 
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash,customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'])
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'])
       charge=@charges.create(charge_hash,customer['id'])
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id']+"1")
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id']+"1")
       charge2=@charges.create(charge_hash,customer['id'])
 
       #perform check
@@ -365,17 +342,17 @@ describe Charges do
     it 'iterate over customer charges' do
 
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash,customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4)
+      charge_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4)
       @charges.create(charge_hash,customer['id'])
-      charge2_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'+"2"],amount: 4)
+      charge2_hash=FactoryBot.build(:card_charge, source_id:card['id'],order_id: card['id'+"2"],amount: 4)
 
       @charges.create(charge2_hash,customer['id'])
 

data/test/spec/customers_spec.rb

@@ -35,7 +35,7 @@ describe Customers do
       last_name='Perez'
 
       #json as input
-      customer_json= FactoryGirl.build(:customer, name: name, last_name: last_name).to_json
+      customer_json= FactoryBot.build(:customer, name: name, last_name: last_name).to_json
       customer=@customers.create(customer_json)
 
       #perform check
@@ -55,7 +55,7 @@ describe Customers do
       @customers.delete(id)
 
     end
-
+    
     it 'fails when passing invalid information' do
 
       #check no errors
@@ -63,7 +63,7 @@ describe Customers do
 
       #invalid email
       email='foo'
-      customer_hash = FactoryGirl.build(:customer, email: email)
+      customer_hash = FactoryBot.build(:customer, email: email)
 
       #perform check
       expect { @customers.create(customer_hash) }.to raise_exception OpenpayTransactionException
@@ -71,9 +71,8 @@ describe Customers do
         @customers.create(customer_hash)
       rescue OpenpayTransactionException => e
         expect(e.http_code).to be 400
-        expect(e.description).to match /\"{value}\" is not a valid email address/
+        expect(e.description).to match /'foo' is not a valid email address/
       end
-
       expect(@customers.errors?).to eq true
 
     end
@@ -84,7 +83,7 @@ describe Customers do
 
     it 'deletes an existing customer' do
       #creates customer
-      customer_hash = FactoryGirl.build(:customer, name: :delete_me)
+      customer_hash = FactoryBot.build(:customer, name: :delete_me)
       customer=@customers.create(customer_hash)
       id=customer['id']
       #delete customer
@@ -101,7 +100,7 @@ describe Customers do
 
       #create customer
       name='get_test'
-      customer_hash = FactoryGirl.build(:customer, name: name)
+      customer_hash = FactoryBot.build(:customer, name: name)
       customer=@customers.create(customer_hash)
       id=customer['id']
       #perform check
@@ -126,14 +125,14 @@ describe Customers do
 
       # creates customer
       name='customer_update_test'
-      customer_hash = FactoryGirl.build(:customer, name: name)
+      customer_hash = FactoryBot.build(:customer, name: name)
 
       customer=@customers.create(customer_hash)
       id=customer['id']
 
       #update customer
       name='new_name'
-      customer_hash = FactoryGirl.build(:customer, name: name)
+      customer_hash = FactoryBot.build(:customer, name: name)
       @customers.update(customer_hash, id)
       #perform check
       expect(@customers.get(id)['name']).to match name
@@ -150,7 +149,7 @@ describe Customers do
     it 'list customers given the filter' do
       # creates customer
       name='customer_update_test'
-      customer_hash = FactoryGirl.build(:customer, name: name)
+      customer_hash = FactoryBot.build(:customer, name: name)
 
       customer=@customers.create(customer_hash)
       id=customer['id']
@@ -178,7 +177,7 @@ describe Customers do
 
       # creates customer
       name='customer_update_test'
-      customer_hash = FactoryGirl.build(:customer, name: name)
+      customer_hash = FactoryBot.build(:customer, name: name)
       customer=@customers.create(customer_hash)
 
       #performs check
@@ -197,7 +196,7 @@ describe Customers do
 
       #create 5 customers
       name='customer_update_test'
-      customer_hash = FactoryGirl.build(:customer, name: name)
+      customer_hash = FactoryBot.build(:customer, name: name)
       5.times do
         @customers.create(customer_hash)
       end

data/test/spec/exceptions_spec.rb

@@ -34,7 +34,7 @@ describe 'Openpay Exceptions' do
     it 'should fail when an invalid field-value is passed in *email' do
       #invalid email format
       email='foo'
-      customer_hash = FactoryGirl.build(:customer, email: email)
+      customer_hash = FactoryBot.build(:customer, email: email)
 
       #perform checks
       expect { @customers.create(customer_hash) }.to raise_exception OpenpayTransactionException
@@ -64,26 +64,8 @@ describe 'Openpay Exceptions' do
       end
     end
 
-    it 'fails when trying to create an existing card' do
-
-      #create customer
-      customers=@openpay.create(:customers)
-      customer_hash = FactoryGirl.build(:customer, name: 'Juan', last_name: 'Perez')
-      customer=customers.create(customer_hash)
-      #create card using json
-      card_json = FactoryGirl.build(:valid_card).to_json
-      card=@cards.create(card_json)
-      #perform check
-      expect { @cards.create(card_json) }.to raise_error(OpenpayTransactionException)
-
-      #cleanup
-      @customers.delete(customer['id'])
-      card_hash=JSON.parse card
-      @cards.delete card_hash['id']
-    end
-
     it 'raise  an OpenpayTransactionException when using an expired card' do
-      card_hash = FactoryGirl.build(:expired_card)
+      card_hash = FactoryBot.build(:expired_card)
       expect { @cards.create(card_hash) }.to raise_error(OpenpayTransactionException)
       begin
         @cards.create(card_hash)

data/test/spec/fees_spec.rb

@@ -35,19 +35,19 @@ describe Fees do
     #In order to create a fee a charge should exists
     it 'creates a fee  ' do
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash, customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'], amount: 4000)
+      charge_hash=FactoryBot.build(:card_charge, source_id: card['id'], order_id: card['id'], amount: 4000)
       @charges.create(charge_hash, customer['id'])
-
+      sleep(50)
       #create customer fee
-      fee_hash = FactoryGirl.build(:fee, customer_id: customer['id'])
+      fee_hash = FactoryBot.build(:fee, customer_id: customer['id'])
       @fees.create(fee_hash)
 
       #performs check
@@ -61,16 +61,17 @@ describe Fees do
 
     it 'creates a fee using a json message' do
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash, customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'], amount: 4000)
+      charge_hash=FactoryBot.build(:card_charge, source_id: card['id'], order_id: card['id'], amount: 4000)
       @charges.create(charge_hash, customer['id'])
+      sleep(50)
 
       #create customer fee using json
       fee_json =%^{"customer_id":"#{customer['id']}","amount":"12.50","description":"Cobro de Comision"}^
@@ -90,29 +91,31 @@ describe Fees do
     end
 
   end
-
+  
   describe '.list' do
 
     it 'list fees with a given filter' do
 
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash, customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'], amount: 4000)
+      charge_hash=FactoryBot.build(:card_charge, source_id: card['id'], order_id: card['id'], amount: 4000)
       @charges.create(charge_hash, customer['id'])
+      sleep(50)
 
       #create customer fee
-      fee_hash = FactoryGirl.build(:fee, customer_id: customer['id'])
+      fee_hash = FactoryBot.build(:fee, customer_id: customer['id'])
       @fees.create(fee_hash)
+      sleep(50)
 
       #create customer fee
-      fee_hash = FactoryGirl.build(:fee, customer_id: customer['id'])
+      fee_hash = FactoryBot.build(:fee, customer_id: customer['id'])
       @fees.create(fee_hash)
 
 
@@ -135,19 +138,20 @@ describe Fees do
     it 'get all fees' do
 
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash= FactoryBot.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create customer card
-      card_hash=FactoryGirl.build(:valid_card)
+      card_hash=FactoryBot.build(:valid_card)
       card=@cards.create(card_hash, customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'], amount: 4000)
+      charge_hash=FactoryBot.build(:card_charge, source_id: card['id'], order_id: card['id'], amount: 4000)
       @charges.create(charge_hash, customer['id'])
+      sleep(50)
 
       #create customer fee
-      fee_hash = FactoryGirl.build(:fee, customer_id: customer['id'])
+      fee_hash = FactoryBot.build(:fee, customer_id: customer['id'])
       @fees.create(fee_hash)
 
       #performs check