openpay 0.9.8 → 1.0.1

data/Rakefile

@@ -1 +1,12 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+
+
+task :default => [:spec]
+
+desc 'run specifications'
+RSpec::Core::RakeTask.new do |t|
+  t.pattern = 'test/spec/*'
+end
+

data/lib/OpenPay/Charges.rb

@@ -37,13 +37,11 @@ class Charges < OpenPayResource
       customers=@api_hook.create(:customers)
       customers.capture_charge(customer_id,transaction_id )
     else
-      post(description, transaction_id+'/capture')
+      post( '',transaction_id+'/capture')
     end
   end
 
 
-
-
   def each(customer_id=nil)
     if customer_id
       all(customer_id).each do |card|

data/lib/OpenPay/errors/openpay_connection_exception.rb

@@ -1,3 +1,3 @@
-require 'openpay/errors/open_pay_exception'
+require 'openpay/errors/openpay_exception'
 class OpenpayConnectionException < OpenpayException
 end

data/lib/OpenPay/errors/{open_pay_exception.rb → openpay_exception.rb}

@@ -1,4 +1,5 @@
 class OpenpayException < StandardError
+
   attr_reader :description
   attr_reader :http_code
   attr_reader :http_body
@@ -6,11 +7,10 @@ class OpenpayException < StandardError
   attr_reader :error_code
   attr_reader :category
 
-
   def initialize(message=nil,json_message=true)
   #openpay errors  have a json error string
    if json_message
-       json= JSON.parse message
+      json= JSON.parse message
       @description = json['description']
       @http_code =   json['http_code']
       @error_code = json['error_code']
@@ -26,26 +26,4 @@ class OpenpayException < StandardError
     end
   end
 
-
-
-=begin
-rescue  RestClient::BadRequest  => e
-  oe=OpenpayTransactionException.new(e.message,e.http_code,e.http_body,e.http_body)
-  LOG.warn e.http_body
-  @errors=true
-  raise  oe
-rescue RestClient::BadGateway => e
-  oe=OpenpayConnectionException.new(e.message,e.http_code,e.http_body,e.http_body)
-  LOG.warn e.http_body
-  @errors=true
-  raise  oe
-rescue RestClient::Exception =>  e
-  oe=OpenpayApiError.new(e.message,e.http_code,e.http_body,e.http_body)
-  LOG.warn e.http_body
-  @errors=true
-  raise  oe
-=end
-
-
-
 end

data/lib/OpenPay/errors/openpay_transaction_exception.rb

@@ -1,4 +1,4 @@
-require 'openpay/errors/open_pay_exception'
+require 'openpay/errors/openpay_exception'
 
 class OpenpayTransactionException < OpenpayException
 

data/lib/OpenPay/openpay_api.rb

@@ -3,14 +3,14 @@ require 'open_pay_resource_factory'
 require 'base64'
 require 'rest-client'
 require 'uri'
-require 'errors/open_pay_exception'
+require 'openpay/errors/openpay_exception'
 
 
 LOG= Logger.new(STDOUT)
 
 #change to Logger::DEBUG if need trace information
 #due the nature of the information, we recommend to never use a log file when in debug
-LOG.level=Logger::DEBUG
+LOG.level=Logger::INFO
 
 
 class OpenpayApi

data/lib/openpay.rb

@@ -1,5 +1,5 @@
 #openpay version
-require 'openpay/version'
+require 'version'
 
 #external dependencies
 require 'rest-client'
@@ -26,9 +26,9 @@ module Openpay
   require 'openpay/charges'
 
   #exceptions
-  require 'openpay/errors/open_pay_exception_factory'
-  require 'openpay/errors/open_pay_exception'
+  require 'openpay/errors/openpay_exception_factory'
+  require 'openpay/errors/openpay_exception'
   require 'openpay/errors/openpay_transaction_exception'
   require 'openpay/errors/openpay_connection_exception'
 
-end
+end

data/lib/version.rb

@@ -0,0 +1,6 @@
+module Openpay
+
+  # Dec 31 2014, 6:00 PM Qro Local time.
+  # 97 test cases passed / 275.232 secs
+  VERSION = '1.0.1'
+end

data/{OpenPay.gemspec → openpay.gemspec}

@@ -1,14 +1,16 @@
 # coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'openpay/version'
+
+require 'version'
+
 
 Gem::Specification.new do |spec|
   spec.name          = "openpay"
   spec.version       = Openpay::VERSION
   spec.authors       = ["ronnie_bermejo"]
   spec.email         =  ["ronnie.bermejo.mx@gmail.com"]
-  spec.description   = %q{ruby client for Openpay API services (version 1.0.0)}
+  spec.description   = %q{ruby client for Openpay API services (version 1.0.1)}
   spec.summary       = %q{ruby api for openpay resources}
   spec.homepage      = "http://openpay.mx/"
   spec.license       = "Apache"
@@ -16,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec)/})
-  spec.require_paths = ["lib","lib/openpay"]
+  spec.require_paths = ["lib","lib/openpay",'openpay']
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/test/Factories.rb

@@ -165,8 +165,8 @@ FactoryGirl.define do
 
 
   factory :refund_description, class:Hash do
-     description 'A petición del cliente'
-     initialize_with { attributes }
+    description 'A peticion del cliente'
+    initialize_with { attributes }
 
   end
 
@@ -174,7 +174,7 @@ FactoryGirl.define do
   factory :fee, class:Hash do
         customer_id  'dvocf97jd20es3tw5laz'
         amount  '12.50'
-        description  'Cobro de Comisión'
+        description  'Cobro de Comision'
         initialize_with { attributes }
 
   end

data/test/spec/bankaccounts_spec.rb

@@ -1,4 +1,4 @@
-require '../spec_helper'
+require './test/spec_helper'
 
 
 describe  Bankaccounts do

data/test/spec/cards_spec.rb

@@ -1,4 +1,4 @@
-require '../spec_helper'
+require './test/spec_helper'
 
 
 describe Cards do
@@ -13,6 +13,9 @@ describe Cards do
     @cards=@openpay.create(:cards)
     @customers=@openpay.create(:customers)
 
+    @cards.delete_all
+
+
   end
 
   after(:all) do
@@ -140,20 +143,53 @@ describe Cards do
 
   describe '.each' do
 
-    it 'list all existing merchant cards' do
+    it 'iterates over all existing merchant cards' do
       @cards.each do |card|
         expect(card['expiration_year']).to match '14'
       end
     end
 
 
+    it 'iterates over all existing customer cards' do
+
+
+
+      #creates a customer
+      card_hash = FactoryGirl.build(:valid_card, holder_name: 'Pepe')
+      customers=@openpay.create(:customers)
+      customer_hash = FactoryGirl.build(:customer)
+      customer=customers.create(customer_hash)
+
+      #creates a customer card
+      card=@cards.create(card_hash, customer['id'])
+      expect(card).to be_a(Hash)
+
+      @cards.each(customer['id']) do |c|
+        expect(c['expiration_year']).to match '14'
+      end
+
+
+      #cleanup
+      @cards.delete(card['id'],customer['id'])
+      @customers.delete(customer['id'])
+
+
+
+
+    end
+
+
+
+
+
   end
 
 
   describe '.delete' do
 
 
-    it 'deletes a customer card' do
+    it 'deletes a merchant card' do
+
       #creates merchant card
       card_hash = FactoryGirl.build(:valid_card)
       cards=@cards.create(card_hash)
@@ -163,12 +199,11 @@ describe Cards do
       name='Vicente Olmos'
 
       #perform check
-      card=@cards.get(id)
-      expect(card['holder_name']).to match(name)
-      expect(card['card_number']).to match('1111')
 
-      #cleanup
-      @cards.delete(card['id'])
+      card=@cards.delete(id)
+      expect { @cards.get(id) }.to raise_exception(OpenpayTransactionException)
+
+
     end
 
 

data/test/spec/charges_spec.rb

@@ -1,5 +1,5 @@
 
-require '../spec_helper'
+require './test/spec_helper'
 
 describe Charges do
 
@@ -198,7 +198,31 @@ describe Charges do
 
   describe '.capture' do
 
-    it 'captures  an existing merchant charge'  do
+
+    it 'captures  a merchant card charge'  do
+
+      #create new customer
+      customer_hash= FactoryGirl.build(:customer)
+      customer=@customers.create(customer_hash)
+
+      #create merchant card
+      card_hash=FactoryGirl.build(:valid_card)
+      card=@cards.create(card_hash)
+
+      #create merchant charge
+      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000,capture:'false')
+      charge=@charges.create(charge_hash)
+
+      #capture merchant charge
+      @charges.capture(charge['id'])
+
+      #clean up
+      @cards.delete(card['id'])
+      @customers.delete(customer['id'])
+
+    end
+
+    it 'captures  an customer card charge'  do
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)
@@ -208,14 +232,11 @@ describe Charges do
       card=@cards.create(card_hash,customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000)
+      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000,capture:'false')
       charge=@charges.create(charge_hash,customer['id'])
 
-      #capture charge
-      captured_charge=@charges.capture(charge['id'],customer['id'])
-     p  captured_charge
-
-
+      #capture customer charge
+      @charges.capture(charge['id'],customer['id'])
 
       #clean up
       @cards.delete(card['id'],customer['id'])
@@ -223,15 +244,6 @@ describe Charges do
     end
 
 
-    it 'fails to capture an non existing merchant charge' do
-      pending 'check if the cancel method in reality works, documentation has some discrepancies'
-    end
-
-
-
-    it 'captures  an existing customer charge'  do
-      pending 'check if the cancel method in reality works, documentation has some discrepancies'
-    end
 
 
   end

data/test/spec/customers_spec.rb

@@ -1,4 +1,4 @@
-require '../spec_helper'
+require './test/spec_helper'
 
 
 describe Customers do

data/test/spec/exceptions_spec.rb

@@ -1,4 +1,4 @@
-require '../spec_helper'
+require './test/spec_helper'
 
 
 describe 'Openpay Exceptions' do

data/test/spec/fees_spec.rb

@@ -1,4 +1,4 @@
-require '../spec_helper'
+require './test/spec_helper'
 
 describe Fees do
 
@@ -69,7 +69,7 @@ describe Fees do
       @charges.create(charge_hash, customer['id'])
 
       #create customer fee using json
-      fee_json =%^{"customer_id":"#{customer['id']}","amount":"12.50","description":"Cobro de Comisión"}^
+      fee_json =%^{"customer_id":"#{customer['id']}","amount":"12.50","description":"Cobro de Comision"}^
       #performs check , it returns json
       expect(@fees.create(fee_json)).to have_json_path('amount')
 
@@ -77,6 +77,9 @@ describe Fees do
 
   end
 
+
+
+
   describe '.all' do
 
     it 'get all fees' do

data/test/spec/payouts_spec.rb

@@ -1,5 +1,5 @@
 
-require '../spec_helper'
+require './test/spec_helper'
 
 describe Payouts do
 
@@ -144,7 +144,7 @@ describe Payouts do
      expect(@payouts.all.last['transaction_type']) .to match 'payout'
     end
 
-    it 'all customer payout' do
+    it 'all customer payouts' do
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)

data/test/spec/plans_spec.rb

@@ -1,4 +1,4 @@
-require '../spec_helper'
+require './test/spec_helper'
 
 describe Plans do
 
@@ -166,61 +166,7 @@ describe Plans do
   end
 
 
-  #
-  #describe 'all_subscriptions' do
-  #
-  #
-  #  it 'returns all subscriptions for a given plan' do
-  #    #creates a plan
-  #    plan_hash= FactoryGirl.build(:plan, trial_days: 10)
-  #    plan=@plans.create(plan_hash)
-  #    expect(@plans.all_subscriptions(plan['id']).size).to be 0
-  #
-  #
-  #    #creates subscriptions
-  #
-  #    subscription_hash= FactoryGirl.build(:subscription)
-  #
-  #    @subscriptions.create(subscription_hash,plan['id'])
-  #    @subscriptions.create(subscription_hash,plan['id'])
-  #
-  #    expect(@plans.all_subscriptions(plan['id'])).to be 2
-  #
-  #    @plans.delete_all(customer['id'])
-  #    expect(@plans.all_subscriptions(plan['id'])).to be 0
-  #
-  #  end
-  #
-  #
-  #end
-  #
-  #describe '.each_subscription' do
-  #
-  #
-  #  it 'itereates over all subscriptions for a given plan' do
-  #
-  #    #creates a plan
-  #    plan_hash= FactoryGirl.build(:plan, trial_days: 10)
-  #    plan=@plans.create(plan_hash)
-  #
-  #
-  #    #creates subscriptions
-  #
-  #    customer_hash= FactoryGirl.build(:subscription)
-  #
-  #    @subscriptions.create(subscription_hash)
-  #    @subscriptions.create(subscription_hash)
-  #
-  #
-  #    it 'iterates over all paln subscription' do
-  #
-  #      @plans.each_subscription do |subscription|
-  #        pending 'no esta bien algo le falta'
-  #      end
-  #
-  #    end
-  #  end
-  #end
+
 
 end