opennebula-cli 7.2.0 → 7.2.1

data/lib/one_helper/onemarket_helper.rb

@@ -18,24 +18,26 @@ require 'one_helper'
 require 'opennebula/marketplace'
 require 'opennebula/marketplace_pool'
 
+# Helper class for Marketplace commands
 class OneMarketPlaceHelper < OpenNebulaHelper::OneHelper
+
     MARKETPLACE = {
-        :name   => "marketplace",
-        :short  => "-m id|name",
-        :large  => "--marketplace id|name" ,
-        :description => "Selects the marketplace",
+        :name   => 'marketplace',
+        :short  => '-m id|name',
+        :large  => '--marketplace id|name',
+        :description => 'Selects the marketplace',
         :format => String,
-        :proc   => lambda { |o, options|
-            OpenNebulaHelper.rname_to_id(o, "MARKETPLACE")
+        :proc   => lambda {|o, _options|
+            OpenNebulaHelper.rname_to_id(o, 'MARKETPLACE')
         }
     }
 
     def self.rname
-        "MARKETPLACE"
+        'MARKETPLACE'
     end
 
     def self.conf_file
-        "onemarket.yaml"
+        'onemarket.yaml'
     end
 
     def self.state_to_str(id)
@@ -47,51 +49,51 @@ class OneMarketPlaceHelper < OpenNebulaHelper::OneHelper
     def format_pool(options)
         config_file = self.class.table_conf
 
-        table = CLIHelper::ShowTable.new(config_file, self) do
-            column :ID, "ONE identifier for the Marketplace", :size=>4 do |d|
-                d["ID"]
+        CLIHelper::ShowTable.new(config_file, self) do
+            column :ID, 'ONE identifier for the Marketplace', :size=>4 do |d|
+                d['ID']
             end
 
-            column :USER, "Username of the Marketplace owner", :left,
-                    :size=>10 do |d|
+            column :USER, 'Username of the Marketplace owner', :left,
+                   :size=>10 do |d|
                 helper.user_name(d, options)
             end
 
-            column :GROUP, "Group of the Marketplace", :left,
-                    :size=>10 do |d|
+            column :GROUP, 'Group of the Marketplace', :left,
+                   :size=>10 do |d|
                 helper.group_name(d, options)
             end
 
-            column :NAME, "Name of the Marketplace", :left, :size=>30 do |d|
-                d["NAME"]
+            column :NAME, 'Name of the Marketplace', :left, :size=>30 do |d|
+                d['NAME']
             end
 
-            column :SIZE, "Marketplace total size", :size =>10 do |d|
+            column :SIZE, 'Marketplace total size', :size =>10 do |d|
                 OpenNebulaHelper.unit_to_str(d['TOTAL_MB'].to_i, {}, 'M')
             end
 
-            column :AVAIL, "Marketplace free size", :left, :size =>10 do |d|
+            column :AVAIL, 'Marketplace free size', :left, :size =>10 do |d|
                 if d['TOTAL_MB'].to_i == 0
-                    "-"
+                    '-'
                 else
-                    "#{((d['FREE_MB'].to_f/d['TOTAL_MB'].to_f) * 100).round()}%"
+                    "#{((d['FREE_MB'].to_f/d['TOTAL_MB'].to_f) * 100).round}%"
                 end
             end
 
-            column :APPS, "Number of marketplace apps", :size=>6 do |d|
-                if d["MARKETPLACEAPPS"]["ID"].nil?
-                    "0"
+            column :APPS, 'Number of marketplace apps', :size=>6 do |d|
+                if d['MARKETPLACEAPPS']['ID'].nil?
+                    '0'
                 else
-                    [d["MARKETPLACEAPPS"]["ID"]].flatten.size
+                    [d['MARKETPLACEAPPS']['ID']].flatten.size
                 end
             end
 
-            column :MAD, "Marketplace driver", :left, :size=>7 do |d|
-                d["MARKET_MAD"]
+            column :MAD, 'Marketplace driver', :left, :size=>7 do |d|
+                d['MARKET_MAD']
             end
 
-            column :ZONE, "Zone ID", :size=>4 do |d|
-                d["ZONE_ID"]
+            column :ZONE, 'Zone ID', :size=>4 do |d|
+                d['ZONE_ID']
             end
 
             column :STAT, 'Markeplace status', :left, :size => 4 do |d|
@@ -100,13 +102,11 @@ class OneMarketPlaceHelper < OpenNebulaHelper::OneHelper
 
             default :ID, :NAME, :SIZE, :AVAIL, :APPS, :MAD, :ZONE, :STAT
         end
-
-        table
     end
 
     private
 
-    def factory(id=nil)
+    def factory(id = nil)
         if id
             OpenNebula::MarketPlace.new_with_id(id, @client)
         else
@@ -115,51 +115,52 @@ class OneMarketPlaceHelper < OpenNebulaHelper::OneHelper
         end
     end
 
-    def factory_pool(user_flag=-2)
+    def factory_pool(_user_flag = -2)
         OpenNebula::MarketPlacePool.new(@client)
     end
 
-    def format_resource(market, options = {})
-        str="%-15s: %-20s"
-        str_h1="%-80s"
+    def format_resource(market, _options = {})
+        str='%-15s: %-20s'
+        str_h1='%-80s'
 
         CLIHelper.print_header(str_h1 % "MARKETPLACE #{market['ID']} INFORMATION")
-        puts str % ["ID",    market.id.to_s]
-        puts str % ["NAME",  market.name]
-        puts str % ["USER",  market['UNAME']]
-        puts str % ["GROUP", market['GNAME']]
-        puts str % ["STATE", market.state_str]
+        puts format(str, 'ID', market.id.to_s)
+        puts format(str, 'NAME', market.name)
+        puts format(str, 'USER', market['UNAME'])
+        puts format(str, 'GROUP', market['GNAME'])
+        puts format(str, 'STATE', market.state_str)
 
-        puts str % ["MARKET_MAD", market['MARKET_MAD']]
+        puts format(str, 'MARKET_MAD', market['MARKET_MAD'])
         puts
 
-        CLIHelper.print_header(str_h1 % "MARKETPLACE CAPACITY", false)
+        CLIHelper.print_header(str_h1 % 'MARKETPLACE CAPACITY', false)
 
-        puts str % ["TOTAL:", OpenNebulaHelper.unit_to_str(market['TOTAL_MB'].to_i,{},'M')]
-        puts str % ["FREE:",  OpenNebulaHelper.unit_to_str(market['FREE_MB'].to_i, {},'M')]
-        puts str % ["USED: ", OpenNebulaHelper.unit_to_str(market['USED_MB'].to_i, {},'M')]
+        puts format(str, 'TOTAL:', OpenNebulaHelper.unit_to_str(market['TOTAL_MB'].to_i, {}, 'M'))
+        puts format(str, 'FREE:', OpenNebulaHelper.unit_to_str(market['FREE_MB'].to_i, {}, 'M'))
+        puts format(str, 'USED: ', OpenNebulaHelper.unit_to_str(market['USED_MB'].to_i, {}, 'M'))
         puts
 
-        CLIHelper.print_header(str_h1 % "PERMISSIONS",false)
+        CLIHelper.print_header(str_h1 % 'PERMISSIONS', false)
 
-        ["OWNER", "GROUP", "OTHER"].each { |e|
-            mask = "---"
-            mask[0] = "u" if market["PERMISSIONS/#{e}_U"] == "1"
-            mask[1] = "m" if market["PERMISSIONS/#{e}_M"] == "1"
-            mask[2] = "a" if market["PERMISSIONS/#{e}_A"] == "1"
+        ['OWNER', 'GROUP', 'OTHER'].each do |e|
+            mask = '---'
+            mask[0] = 'u' if market["PERMISSIONS/#{e}_U"] == '1'
+            mask[1] = 'm' if market["PERMISSIONS/#{e}_M"] == '1'
+            mask[2] = 'a' if market["PERMISSIONS/#{e}_A"] == '1'
 
-            puts str % [e,  mask]
-        }
+            puts format(str, e, mask)
+        end
         puts
 
-        CLIHelper.print_header(str_h1 % "MARKETPLACE TEMPLATE", false)
+        CLIHelper.print_header(str_h1 % 'MARKETPLACE TEMPLATE', false)
         puts market.template_str
 
         puts
 
-        CLIHelper.print_header("%-15s" % "MARKETAPPS")
+        CLIHelper.print_header(format('%-15s', 'MARKETAPPS'))
         market.marketapp_ids.each do |id|
-            puts "%-15s" % [id]
+            puts format('%-15s', id)
         end
     end
+
 end