opennebula-cli 7.1.80.pre → 7.2.1

data/lib/one_helper/onevrouter_helper.rb

@@ -1,5 +1,5 @@
 # -------------------------------------------------------------------------- #
-# Copyright 2002-2025, OpenNebula Project, OpenNebula Systems                #
+# Copyright 2002-2026, OpenNebula Project, OpenNebula Systems                #
 #                                                                            #
 # Licensed under the Apache License, Version 2.0 (the "License"); you may    #
 # not use this file except in compliance with the License. You may obtain    #
@@ -18,58 +18,57 @@ require 'one_helper'
 require 'opennebula/virtual_router'
 require 'opennebula/virtual_router_pool'
 
+# Helper class for VRouter commands
 class OneVirtualRouterHelper < OpenNebulaHelper::OneHelper
 
     ALL_TEMPLATE = {
-        :name       => "all",
-        :large      => "--all",
-        :description => "Show all template data"
+        :name       => 'all',
+        :large      => '--all',
+        :description => 'Show all template data'
     }
 
     FLOAT = {
-        :name       => "float",
-        :large      => "--float",
-        :description => "Makes this IP request a Floating one"
+        :name       => 'float',
+        :large      => '--float',
+        :description => 'Makes this IP request a Floating one'
     }
 
     def self.rname
-        "VROUTER"
+        'VROUTER'
     end
 
     def self.conf_file
-        "onevrouter.yaml"
+        'onevrouter.yaml'
     end
 
     def format_pool(options)
         config_file = self.class.table_conf
 
-        table = CLIHelper::ShowTable.new(config_file, self) do
-            column :ID, "ONE identifier for the Virtual Router", :size=>4 do |d|
-                d["ID"]
+        CLIHelper::ShowTable.new(config_file, self) do
+            column :ID, 'ONE identifier for the Virtual Router', :size=>4 do |d|
+                d['ID']
             end
 
-            column :NAME, "Name of the Virtual Router", :left, :size=>27 do |d|
-                d["NAME"]
+            column :NAME, 'Name of the Virtual Router', :left, :size=>27 do |d|
+                d['NAME']
             end
 
-            column :USER, "Username of the Virtual Router owner", :left,
-                    :size=>15 do |d|
+            column :USER, 'Username of the Virtual Router owner', :left,
+                   :size=>15 do |d|
                 helper.user_name(d, options)
             end
 
-            column :GROUP, "Group of the Virtual Router", :left, :size=>15 do |d|
+            column :GROUP, 'Group of the Virtual Router', :left, :size=>15 do |d|
                 helper.group_name(d, options)
             end
 
             default :ID, :USER, :GROUP, :NAME
         end
-
-        table
     end
 
     private
 
-    def factory(id=nil)
+    def factory(id = nil)
         if id
             OpenNebula::VirtualRouter.new_with_id(id, @client)
         else
@@ -78,134 +77,134 @@ class OneVirtualRouterHelper < OpenNebulaHelper::OneHelper
         end
     end
 
-    def factory_pool(user_flag=-2)
+    def factory_pool(user_flag = -2)
         OpenNebula::VirtualRouterPool.new(@client, user_flag)
     end
 
     def format_resource(obj, options = {})
-        str="%-15s: %-20s"
-        str_h1="%-80s"
+        str='%-15s: %-20s'
+        str_h1='%-80s'
 
         CLIHelper.print_header(
-            str_h1 % "VIRTUAL ROUTER #{obj['ID']} INFORMATION")
-        puts str % ["ID", obj.id.to_s]
-        puts str % ["NAME", obj.name]
-        puts str % ["USER", obj['UNAME']]
-        puts str % ["GROUP", obj['GNAME']]
-        puts str % ["LOCK", OpenNebulaHelper.level_lock_to_str(obj['LOCK/LOCKED'])]
+            str_h1 % "VIRTUAL ROUTER #{obj['ID']} INFORMATION"
+        )
+        puts format(str, 'ID', obj.id.to_s)
+        puts format(str, 'NAME', obj.name)
+        puts format(str, 'USER', obj['UNAME'])
+        puts format(str, 'GROUP', obj['GNAME'])
+        puts format(str, 'LOCK', OpenNebulaHelper.level_lock_to_str(obj['LOCK/LOCKED']))
         puts
 
-        CLIHelper.print_header(str_h1 % "PERMISSIONS",false)
+        CLIHelper.print_header(str_h1 % 'PERMISSIONS', false)
 
-        ["OWNER", "GROUP", "OTHER"].each { |e|
-            mask = "---"
-            mask[0] = "u" if obj["PERMISSIONS/#{e}_U"] == "1"
-            mask[1] = "m" if obj["PERMISSIONS/#{e}_M"] == "1"
-            mask[2] = "a" if obj["PERMISSIONS/#{e}_A"] == "1"
+        ['OWNER', 'GROUP', 'OTHER'].each do |e|
+            mask = '---'
+            mask[0] = 'u' if obj["PERMISSIONS/#{e}_U"] == '1'
+            mask[1] = 'm' if obj["PERMISSIONS/#{e}_M"] == '1'
+            mask[2] = 'a' if obj["PERMISSIONS/#{e}_A"] == '1'
 
-            puts str % [e,  mask]
-        }
+            puts format(str, e, mask)
+        end
 
-        if obj.has_elements?("/VROUTER/TEMPLATE/NIC")
+        if obj.has_elements?('/VROUTER/TEMPLATE/NIC')
             puts
-            CLIHelper.print_header(str_h1 % "VIRTUAL ROUTER NICS",false)
+            CLIHelper.print_header(str_h1 % 'VIRTUAL ROUTER NICS', false)
 
-            nic_default = {"NETWORK" => "-",
-                           "IP" => "-"}
+            nic_default = { 'NETWORK' => '-',
+                           'IP' => '-' }
 
             array_id = 0
             vm_nics = [obj.to_hash['VROUTER']['TEMPLATE']['NIC']].flatten.compact
-            vm_nics.each {|nic|
-
-                next if nic.has_key?("CLI_DONE")
+            vm_nics.each do |nic|
+                next if nic.key?('CLI_DONE')
 
-                floating = (nic.has_key?("FLOATING_IP") && nic["FLOATING_IP"].upcase() == "YES" )
+                floating = nic.key?('FLOATING_IP') && nic['FLOATING_IP'].upcase == 'YES'
 
                 if floating
-                    if nic.has_key?("IP6_LINK")
-                        ip6_link = {"IP"           => nic.delete("IP6_LINK"),
-                                    "CLI_DONE"     => true,
-                                    "DOUBLE_ENTRY" => true}
-                        vm_nics.insert(array_id+1,ip6_link)
+                    if nic.key?('IP6_LINK')
+                        ip6_link = { 'IP'           => nic.delete('IP6_LINK'),
+                                    'CLI_DONE'     => true,
+                                    'DOUBLE_ENTRY' => true }
+                        vm_nics.insert(array_id+1, ip6_link)
 
                         array_id += 1
                     end
 
-                    if nic.has_key?("IP6_ULA")
-                        ip6_link = {"IP"           => nic.delete("IP6_ULA"),
-                                    "CLI_DONE"     => true,
-                                    "DOUBLE_ENTRY" => true}
-                        vm_nics.insert(array_id+1,ip6_link)
+                    if nic.key?('IP6_ULA')
+                        ip6_link = { 'IP'           => nic.delete('IP6_ULA'),
+                                    'CLI_DONE'     => true,
+                                    'DOUBLE_ENTRY' => true }
+                        vm_nics.insert(array_id+1, ip6_link)
 
                         array_id += 1
                     end
 
-                    if nic.has_key?("IP6_GLOBAL")
-                        ip6_link = {"IP"           => nic.delete("IP6_GLOBAL"),
-                                    "CLI_DONE"     => true,
-                                    "DOUBLE_ENTRY" => true}
-                        vm_nics.insert(array_id+1,ip6_link)
+                    if nic.key?('IP6_GLOBAL')
+                        ip6_link = { 'IP'           => nic.delete('IP6_GLOBAL'),
+                                    'CLI_DONE'     => true,
+                                    'DOUBLE_ENTRY' => true }
+                        vm_nics.insert(array_id+1, ip6_link)
 
                         array_id += 1
                     end
                 else
-                    nic.delete("IP")
+                    nic.delete('IP')
                 end
 
-                nic.merge!(nic_default) {|k,v1,v2| v1}
+                nic.merge!(nic_default) {|_k, v1, _v2| v1 }
                 array_id += 1
-            }
+            end
 
             CLIHelper::ShowTable.new(nil, self) do
-                column :ID, "", :size=>3 do |d|
-                    if d["DOUBLE_ENTRY"]
-                        ""
+                column :ID, '', :size=>3 do |d|
+                    if d['DOUBLE_ENTRY']
+                        ''
                     else
-                        d["NIC_ID"]
+                        d['NIC_ID']
                     end
                 end
 
-                column :NETWORK, "", :left, :size=>20 do |d|
-                    if d["DOUBLE_ENTRY"]
-                        ""
+                column :NETWORK, '', :left, :size=>20 do |d|
+                    if d['DOUBLE_ENTRY']
+                        ''
                     else
-                        d["NETWORK"]
+                        d['NETWORK']
                     end
                 end
 
-                column :MANAGEMENT, "", :left, :size=>10 do |d|
-                    if d["DOUBLE_ENTRY"]
-                        ""
+                column :MANAGEMENT, '', :left, :size=>10 do |d|
+                    if d['DOUBLE_ENTRY']
+                        ''
                     else
-                        if !d["VROUTER_MANAGEMENT"].nil?
-                            d["VROUTER_MANAGEMENT"]
+                        if !d['VROUTER_MANAGEMENT'].nil?
+                            d['VROUTER_MANAGEMENT']
                         else
-                            "NO"
+                            'NO'
                         end
                     end
                 end
 
-
-                column :IP, "",:left, :adjust, :size=>15 do |d|
-                    d["IP"]
+                column :IP, '', :left, :adjust, :size=>15 do |d|
+                    d['IP']
                 end
-            end.show(vm_nics,{})
+            end.show(vm_nics, {})
         end
 
-        while obj.has_elements?("/VROUTER/TEMPLATE/NIC")
-            obj.delete_element("/VROUTER/TEMPLATE/NIC")
-        end if !options[:all]
+        while obj.has_elements?('/VROUTER/TEMPLATE/NIC')
+            obj.delete_element('/VROUTER/TEMPLATE/NIC')
+        end unless options[:all]
 
         puts
 
-        CLIHelper.print_header(str_h1 % "TEMPLATE CONTENTS",false)
+        CLIHelper.print_header(str_h1 % 'TEMPLATE CONTENTS', false)
         puts obj.template_str
 
         puts
 
-        CLIHelper.print_header("%-15s" % "VIRTUAL MACHINES")
+        CLIHelper.print_header(format('%-15s', 'VIRTUAL MACHINES'))
         obj.vm_ids.each do |id|
-            puts "%-15s" % [id]
+            puts format('%-15s', id)
         end
     end
+
 end