openmeta.rb 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 --- 
-SHA1: 
-  metadata.gz: b526c286d3a9b6571647d09cc6de5369d409eca0
-  data.tar.gz: f0dd005385f43c0498bc39adad9e72806cfd6980
 SHA512: 
-  metadata.gz: 2db1a91510bf57b0a96f77b90b5be6c92fe314f13b357b2c0aa177e2ad1783792111ec56909b7d875615b3d39c88fff56887e7565ddae6c60dfac794cf93f93b
-  data.tar.gz: 7be4ac476f96b5394d97da073b10ceeba592002541d9273e3035f063826bc06e20776433156812229f008f7624312527de48a317543744943696f74710f89bad
+  data.tar.gz: 9209f5e1021db9d1223a0c725c50bdd6b1b0bf8636ef6843f756fad4fc930ce4ab3c23b75ef30b80c6ba133eceeeee093f0e0314f6810d9038e8147ad06d15fd
+  metadata.gz: 8c489230b0f0e4d3cc86f44d7c5f0cbcb46f28672dc5c4e6c2da96e04b689a2dc631454f34215df2a2270221c4b8faafe4f9abd469702defc84a86d460c067d0
+SHA1: 
+  data.tar.gz: e1f8b8523dcf22c33b4e24b6e1ed0c76952d7f41
+  metadata.gz: 95a114abb8668fe3a971e3ee349d462992ad442d

data/Guardfile

@@ -5,7 +5,7 @@ notification :growl
 
 group :backend do
 
-  guard 'rspec', :rvm  => ["macruby-nightly"], :notification  => true  do
+  guard 'rspec', :rvm  => ["macruby"], :notification  => true  do
 
     watch(%r{^spec/.+_spec\.rb$})
     watch(%r{^lib/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }

data/lib/openmeta.rb

@@ -85,13 +85,13 @@ module Openmeta
     def remove_tags(tags, from_files)
       from_files = fu_list(from_files)
 
+      return if tags.empty?
+
       from_files.each { |file|
-        # duplicate a frozen array
-        existing_tags = get_tags(file).dup
-        unless existing_tags.empty?
-          existing_tags.delete_if { |t| tags.include?(t) }
-          set_tags(existing_tags, file)
-        end
+        existing_tags = get_tags(file) # frozen array
+        next if existing_tags.nil? or existing_tags.empty?
+
+        set_tags(existing_tags - tags, file)
       }
     end
 

data/lib/openmeta/version.rb

@@ -1,4 +1,4 @@
 module Openmeta
-  VERSION = '1.3.1'
+  VERSION = '1.3.2'
 end
 

data/spec/openmeta_spec.rb

@@ -15,8 +15,12 @@ describe "Openmeta" do
       expect { Openmeta.get_tags("/path/to/nowhere") }.to raise_error(Openmeta::ObjCError)
     end
 
-    it "should not raise Error if file does not contains tags" do
-      expect { Openmeta.clone(@testfiles[0], @testfiles[1]) }.should_not raise_error
+    it "should not raise error if file does not contains tags" do
+      expect { Openmeta.clone(@testfiles[0], @testfiles[1]) }.to_not raise_error
+    end
+
+    it "should not raise error when removing nonexisting tags" do
+      expect { Openmeta.remove_tags(['NonExistingTag'], @testfiles[1]) }.to_not raise_error
     end
 
     it "should set tags and rating correctly" do
@@ -58,6 +62,7 @@ describe "Openmeta" do
       rtags.should match_array(tags)
     end
 
+
     after :all do
       FileUtils.safe_unlink(@testfiles)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: openmeta.rb
 version: !ruby/object:Gem::Version 
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors: 
 - Zhao Cai
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-03-31 00:00:00 Z
+date: 2013-04-02 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: thor