openlibrary 0.0.9 → 1.0.0

data/.gitignore

@@ -3,3 +3,4 @@
 Gemfile.lock
 pkg/*
 .rvmrc
+*~

data/README.rdoc

@@ -1,9 +1,9 @@
 == Openlibrary 
 
 
-OPENLIBRARY is a simple wrapper for the Openlibrary REST-API.
+OPENLIBRARY is a simple wrapper for the Open Library REST-API.
 
-For more information on the REST calls, you can view the api documentation at [here](http://openlibrary.org/developers/api).
+For more information on the REST calls, you can view the Open Library Books API documentation here[http://openlibrary.org/dev/docs/api/books], or visit the {Open Library Developer Center}[http://openlibrary.org/developers/api].
 
 
 == Installation
@@ -19,7 +19,7 @@ or in your Gemfile:
 
 == Usage
 
-You can retrieve a book's Openlibrary listing information.
+You can retrieve a book's Open Library listing information.
 
   # just require
   require 'openlibrary'
@@ -58,15 +58,13 @@ You can also retrieve a book's full metadata details.
   book_details.title
 
   # or an array of authors 
-  book_view.authors
+  book_details.authors
 
 == CONTRIBUTORS
 
-  {Jay Fajardo}[http://github.com/jayfajardo]
-  {Robert Berry}[http://github.com/bdigital]
-  {Eric Larson}[http://github.com/ewlarson]
-  {Charles Horn}[http://github.com/hornc]
-
-== TO DO
-
-Write Tests
+* Jay Fajardo https://github.com/jayfajardo
+* Robert Berry https://github.com/bdigital
+* Eric Larson https://github.com/ewlarson
+* Charles Horn https://github.com/hornc
+* John Shutt https://github.com/pemulis
+* Alex Grant https://github.com/grantovich

data/lib/openlibrary.rb

@@ -1,6 +1,7 @@
-require "openlibrary/version"
+require 'openlibrary/version'
 require 'json'
 require 'rest-client'
+require 'uri'
 
 module Openlibrary
 

data/lib/openlibrary/data.rb

@@ -34,10 +34,14 @@ module Openlibrary
     end
 
     def self.find(type,key)
-      request_url = "http://openlibrary.org/api/books?bibkeys=#{type}:#{key}&format=json&jscmd=data"
-      response = RestClient.get request_url
+      type_for_uri = URI.encode_www_form_component(type)
+      key_for_uri = URI.encode_www_form_component(key)
+
+      response = RestClient.get "http://openlibrary.org/api/books" +
+        "?bibkeys=#{type_for_uri}:#{key_for_uri}&format=json&jscmd=data"
       response_data = JSON.parse(response)
       book = response_data["#{type}:#{key}"]
+
       if book 
         book_meta = new  
 
@@ -60,12 +64,8 @@ module Openlibrary
         book_meta.pages = book["number_of_pages"]
         book_meta.weight = book["weight"]
         
-        #for debugging purposes
-        #puts book_meta
-
         book_meta
       else
-        puts "OPENLIBRARY: Using #{type} with #{key}, not found on Openlibrary.org"
         nil
       end    
     end

data/lib/openlibrary/version.rb

@@ -1,3 +1,3 @@
 module Openlibrary
-  VERSION = "0.0.9"
+  VERSION = "1.0.0"
 end

data/lib/openlibrary/view.rb

@@ -24,10 +24,14 @@ module Openlibrary
     end
 
     def self.find(type,key)
-      response = RestClient.get "http://openlibrary.org/api/books?bibkeys=#{type}:#{key}&format=json&jscmd=viewapi"
+      type_for_uri = URI.encode_www_form_component(type)
+      key_for_uri = URI.encode_www_form_component(key)
 
+      response = RestClient.get "http://openlibrary.org/api/books" +
+        "?bibkeys=#{type_for_uri}:#{key_for_uri}&format=json&jscmd=viewapi"
       response_data = JSON.parse(response)
       view = response_data["#{type}:#{key}"]
+
       if view 
         view_meta = new  
 
@@ -37,17 +41,11 @@ module Openlibrary
         view_meta.preview_url = view["preview_url"]
         view_meta.thumbnail_url = view["thumbnail_url"]
         
-        #for debugging purposes
-        #puts view_meta
-
         view_meta
       else
-        puts "OPENLIBRARY: #{key} was not found on Openlibrary.org"
         nil
       end    
     end
   end
 
-
 end
-

data/spec/openlibrary_spec.rb

@@ -6,3 +6,48 @@ describe Openlibrary do
   end
 end
 
+describe Openlibrary::View do
+	before do
+		@book_view = Openlibrary::View.new
+	end
+
+	subject { @book_view }
+
+	it { should_not respond_to(:some_random_thing) }
+
+	it { should respond_to(:bib_key) }
+	it { should respond_to(:info_url) }
+	it { should respond_to(:preview) }
+	it { should respond_to(:preview_url) }
+	it { should respond_to(:thumbnail_url) }
+end
+
+describe Openlibrary::Data do
+	before do
+		@book_data = Openlibrary::Data.new
+	end
+
+	subject { @book_data }
+	
+	it { should_not respond_to(:some_random_thing) }
+
+	it { should respond_to(:url) }
+	it { should respond_to(:title) }
+	it { should respond_to(:subtitle) }
+	it { should respond_to(:authors) }
+	it { should respond_to(:identifiers) }
+	it { should respond_to(:classifications) }
+	it { should respond_to(:subjects) }
+	it { should respond_to(:subject_places) }
+	it { should respond_to(:subject_people) }
+	it { should respond_to(:subject_times) }
+	it { should respond_to(:publishers) }
+	it { should respond_to(:publish_places) }
+	it { should respond_to(:publish_date) }
+	it { should respond_to(:excerpts) }
+	it { should respond_to(:links) }
+	it { should respond_to(:cover) }
+	it { should respond_to(:ebooks) }
+	it { should respond_to(:pages) }
+	it { should respond_to(:weight) }
+end

data/spec/spec_helper.rb

@@ -1,8 +1,8 @@
 require 'rspec'
 require 'openlibrary'
+require 'rest-client'
 
 RSpec.configure do |config|
   config.color_enabled = true
   config.formatter     = 'documentation'
 end
-

metadata

@@ -2,7 +2,7 @@
 name: openlibrary
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.9
+  version: 1.0.0
 platform: ruby
 authors: 
 - Jay Fajardo
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-06-21 00:00:00 Z
+date: 2013-02-02 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec