openlanes 3.0.0 → 3.0.1

data/lib/openlanes/engine/progress_log.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require "digest"
+require "tmpdir"
+
 module OpenLanes
   module Engine
     # One line of `run --log FILE`, laid out as fixed-width columns.
@@ -19,8 +22,7 @@ module OpenLanes
     # @example
     #   ProgressLog.render("editing spec.md", plan: "003.00", status: "⭐️ Planned",
     #     agent: "yoda-writer", seconds: 42, round: "01", pid: 91_234)
-
-    #   #=> "[16:22:14 | 003.00 | ⭐️ Planned            | yoda-writer          | 01 |   91234 |    42s] editing spec.md"
+    #   #=> "[16:22:14 | 003.00 | ⭐️  Planned            | yoda-writer          | 01 |   91234 |    42s] editing spec.md"
     module ProgressLog
       # Wall clock only. A log line answers "when", and the date is the file's.
       TIME_FORMAT = "%H:%M:%S"
@@ -31,12 +33,17 @@ module OpenLanes
       # "003.00".
       PLAN_WIDTH = 6
 
-      # Derived from the widest state as {Status#to_s} renders it, emoji
-      # included, so a state added to {STATUSES} with a longer label cannot
-      # silently knock the columns after it out of line — then trimmed by five
-      # cells: the emoji already names the state, so the longest labels can
-      # afford to lose their tails to keep the line short.
-      STATUS_WIDTH = Plans::STATUSES.map { |status| UI.display_width(status.to_s) }.max - 5
+      # Cells given to the emoji, and the gap after it. Many terminal fonts draw
+      # a colour emoji wider than its two cells, and with one space it overlapped
+      # the label's first letter ("🔴Changes").
+      EMOJI_WIDTH = 2
+      EMOJI_GAP = "  "
+
+      # Derived from the widest state as {.status_cell} renders it, so a state
+      # added to {STATUSES} with a longer label cannot silently knock the columns
+      # after it out of line. Untrimmed: cut to fit, "Changes Requested" and
+      # "Ready for Planning" read as "Changes Reque" and "Ready for Pla".
+      STATUS_WIDTH = Plans::STATUSES.map { |status| EMOJI_WIDTH + EMOJI_GAP.length + UI.display_width(status.label) }.max
 
       # The longest specialist name in `agents/` is `palpatine-planner` at 17,
       # and the names are hyphenated words rather than a bounded vocabulary, so
@@ -54,6 +61,10 @@ module OpenLanes
       # is still waiting on.
       SECONDS_WIDTH = 6
 
+      # The keywords {.render} takes besides the message. {UI.log} hands its
+      # taps more than these, and the file only these.
+      FIELDS = %i[plan status agent seconds round pid at].freeze
+
       # Between columns, inside the brackets.
       SEPARATOR = " | "
 
@@ -67,7 +78,25 @@ module OpenLanes
       # @see COLUMN_WIDTHS
       LINE_WIDTH = COLUMN_WIDTHS.sum + (SEPARATOR.length * (COLUMN_WIDTHS.size - 1)) + 2
 
+      # Hex digits of the checkout's path in a default log's name.
+      CHECKOUT_DIGITS = 6
+
       class << self
+        # Where a run's log goes when `--log` names nowhere: the temp
+        # directory, under the checkout's directory name and a short digest
+        # of its full path. The name alone collided: `~/a/minesweeper` and
+        # `~/b/minesweeper` both appended to `openlanes-minesweeper.log`, and
+        # two runs' lines read as one.
+        #
+        # @param root [String] the checkout
+        # @param kind [String, nil] which process logs, e.g. "web"
+        # @return [String] e.g. "/tmp/openlanes-minesweeper-3f9a1c.log"
+        def default_path(root, kind: nil)
+          root = File.expand_path(root)
+          digest = Digest::SHA256.hexdigest(root)[0, CHECKOUT_DIGITS]
+          File.join(Dir.tmpdir, "#{["openlanes", kind, File.basename(root), digest].compact.join("-")}.log")
+        end
+
         # Render one log line: bracketed fixed-width columns, then the message.
         #
         # No colour. The line goes to a file, where an escape sequence is neither
@@ -87,7 +116,7 @@ module OpenLanes
           columns = [
             left(at.strftime(TIME_FORMAT), TIME_WIDTH),
             left(plan, PLAN_WIDTH),
-            left(status, STATUS_WIDTH),
+            left(status_cell(status), STATUS_WIDTH),
             left(agent, AGENT_WIDTH),
             right(round, ROUND_WIDTH),
             right(pid, PID_WIDTH),
@@ -99,6 +128,18 @@ module OpenLanes
           text.empty? ? prefix : "#{prefix} #{text}"
         end
 
+        # The emoji fitted to {EMOJI_WIDTH} and followed by {EMOJI_GAP}, then the
+        # label. A value with no label (or none at all) passes through.
+        #
+        # @param status [String, nil] emoji and label, e.g. "⭐️ Planned"
+        # @return [String, nil]
+        def status_cell(status)
+          emoji, label = status.to_s.split(" ", 2)
+          return status if label.nil?
+
+          "#{UI.fit(emoji, EMOJI_WIDTH)}#{EMOJI_GAP}#{label}"
+        end
+
         # @param seconds [Numeric, nil]
         # @return [String] whole seconds with a trailing "s", or blank for nil
         def duration(seconds) = seconds.nil? ? "" : "#{seconds.round}s"

data/lib/openlanes/execution/prompt.rb

@@ -65,6 +65,7 @@ module OpenLanes
           Repository root: #{root}
 
           #{"The folder's name is not currently justified: #{subject.violation}" if subject.violation}
+          #{snapshot_note}
           #{operator_instructions}#{requirements_section}#{completion_section}#{suggestions_section}#{ledger_section(agent, subject, round:, successor:)}#{budget_section}#{time_budget_section(agent)}#{control_section(control, agent, subject)}#{questions_section}#{mailbox_section(agent, subject, partners)}
           ## Boundary — enforced, not requested
 
@@ -122,6 +123,18 @@ module OpenLanes
 
       attr_reader :agent, :subject, :root, :profile, :round, :successor, :partners, :control
 
+      # In a worktree the repository root holds its own `.plans`, a snapshot
+      # the publisher refreshes for the pull request. An agent that edited or
+      # signed it would be writing to a copy the next publish throws away.
+      #
+      # @return [String, nil]
+      def snapshot_note
+        return nil if File.expand_path(subject.feature.path).start_with?("#{File.expand_path(root)}/")
+
+        "The plan lives only at the plan folder above. Any `.plans` under the repository root is a\n" \
+          "snapshot the harness overwrites when it publishes: never read the plan from it or write to it."
+      end
+
       # Only a CLI that actually refuses the commands may be described as
       # refusing them.
       #

data/lib/openlanes/lifecycle/creator.rb

@@ -61,6 +61,30 @@ module OpenLanes
         end
       end
 
+      # How many words of an idea name its plan.
+      TOPIC_WORDS = 8
+
+      # The words a free-form idea's plan is named after: a frontmatter
+      # `title:`, else its first line, a heading's `#` marks dropped.
+      #
+      # Taking the first words of the raw text named the minesweeper trial's
+      # plan `minesweeper-minesweeper-is-played-on-a-grid`: the idea opened
+      # with `# Minesweeper` and then a paragraph starting with the same
+      # word, and the heading's `#` was dropped while its word was kept.
+      #
+      # @param idea [String] Markdown, as the page's idea dialog sends it
+      # @return [Array<String>] at most {TOPIC_WORDS} words, possibly none
+      def self.topic(idea)
+        meta, body = begin
+          Frontmatter.split(idea.to_s)
+        rescue Psych::Exception
+          [{}, idea.to_s.sub(Frontmatter::PATTERN, '\\2')]
+        end
+        title = meta["title"].to_s.strip
+        line = title.empty? ? body.lines.map(&:strip).find { !it.empty? }.to_s : title
+        line.sub(/\A\#{1,6}\s+/, "").split.first(TOPIC_WORDS)
+      end
+
       # Turn free text into the kebab tail of a folder name.
       #
       # @param words [Array<String>, String]