openhab-scripting 5.44.1 → 5.46.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd60fb96afbab0b86a01d0cbfce296604179e63899be95d6faefdc27e805dfe5
-  data.tar.gz: 88a9935ff405de0fef0cf645e936ea521fe940c88a8e40da6069183476019c00
+  metadata.gz: e6351743424c867636542a49ecdb2ef2eca63824d2009ae517763d256f7fab20
+  data.tar.gz: 72d778a25df32f555763c38539c1bb7d34ae2f24c70120d069504d18e036eaac
 SHA512:
-  metadata.gz: 8851a00c95338d7797062a7d901a763146ee96f4a8f652b3a30b380c5248961b3f418661c2cd2b899d292a7077723bbca818e778223996a98165b84a35c6cab6
-  data.tar.gz: 4ff6ccb08cb630373a385daec0bbb9accf3ec13358e373942fea74fb2f95c0b8f489a22f0de7b37f52765611a7ca6a921f743e1e57b7d3adf57e78fe2f362e1e
+  metadata.gz: a6d35c4a0489003faeabf001e3215bb8f4e9e805cdffb69ba0b10d9261127f08f07f1c0e61cc072ff849eab6dc70c88d9b11003c9f830c53e93ff92ce5ae03ce
+  data.tar.gz: 0be0d9f6149485518eabb0b4c08bb4a73ce7fdf7c9d231e9c9ee590f132a74f647dcbb4c3e3d1087dd2be10a1f487736e45214af2037e2093f019de3d3aeadda

data/lib/openhab/core/actions/notification.rb

@@ -91,22 +91,19 @@ module OpenHAB
             tag ||= severity
             args.push(msg.to_s, icon&.to_s, tag&.to_s)
 
-            # @deprecated OH 4.1
-            if Core.version >= Core::V4_2
-              buttons ||= []
-              buttons = buttons.map { |button_title, action| "#{button_title}=#{action}" } if buttons.is_a?(Hash)
-              raise ArgumentError, "buttons must contain (0..3) elements." unless (0..3).cover?(buttons.size)
+            buttons ||= []
+            buttons = buttons.map { |button_title, action| "#{button_title}=#{action}" } if buttons.is_a?(Hash)
+            raise ArgumentError, "buttons must contain (0..3) elements." unless (0..3).cover?(buttons.size)
 
-              attachment = "item:#{attachment.name}" if attachment.is_a?(Item) && attachment.image_item?
+            attachment = "item:#{attachment.name}" if attachment.is_a?(Item) && attachment.image_item?
 
-              args.push(title&.to_s,
-                        id&.to_s,
-                        on_click&.to_s,
-                        attachment&.to_s,
-                        buttons[0]&.to_s,
-                        buttons[1]&.to_s,
-                        buttons[2]&.to_s)
-            end
+            args.push(title&.to_s,
+                      id&.to_s,
+                      on_click&.to_s,
+                      attachment&.to_s,
+                      buttons[0]&.to_s,
+                      buttons[1]&.to_s,
+                      buttons[2]&.to_s)
 
             NotificationAction.__send__(*args)
           end

data/lib/openhab/core/actions/transformation.rb

@@ -7,7 +7,7 @@ module OpenHAB
       class Transformation
         class << self
           # @!visibility private
-          alias_method :raw_transform, :transform if instance_methods.include?(:transform)
+          alias_method :raw_transform, :transform if method_defined?(:transform)
 
           #
           # Applies a transformation of a given type with some function to a value.

data/lib/openhab/core/actions/voice.rb

@@ -7,7 +7,7 @@ module OpenHAB
       class Voice
         class << self
           # @!visibility private
-          alias_method :raw_say, :say if instance_methods.include?(:say)
+          alias_method :raw_say, :say if method_defined?(:say)
 
           #
           # Say text via openHAB Text-To-Speech service, Voice.say()

data/lib/openhab/core/actions.rb

@@ -53,9 +53,9 @@ module OpenHAB
       # @!method notify(msg, email: nil, icon: nil, tag: nil, severity: nil, id: nil, title: nil, on_click: nil, attachment: nil, buttons: nil)
       # @deprecated Use {Notification.send Notification.send} instead.
       #
-      def notify(*args, **kwargs)
+      def notify(*, **)
         logger.warn("`notify` method is deprecated. Use `Notification.send` instead.")
-        Notification.send(*args, **kwargs)
+        Notification.send(*, **)
       end
     end
   end

data/lib/openhab/core/entity_lookup.rb

@@ -137,9 +137,9 @@ module OpenHAB
       end
 
       # @!visibility private
-      def instance_eval_with_dummy_items(&block)
+      def instance_eval_with_dummy_items(&)
         DSL::ThreadLocal.thread_local(openhab_create_dummy_items: self.class.create_dummy_items?) do
-          instance_eval(&block)
+          instance_eval(&)
         end
       end
 

data/lib/openhab/core/events/item_state_changed_event.rb

@@ -82,9 +82,8 @@ module OpenHAB
         def inspect
           s = "#<OpenHAB::Core::Events::ItemStateChangedEvent item=#{item_name} " \
               "state=#{item_state.inspect} was=#{old_item_state.inspect}"
-          # @deprecated OH4.3 remove respond_to? checks in the next two lines when dropping OH 4.3
-          s += " last_state_update=#{last_state_update}" if respond_to?(:last_state_update) && last_state_update
-          s += " last_state_change=#{last_state_change}" if respond_to?(:last_state_change) && last_state_change
+          s += " last_state_update=#{last_state_update}" if last_state_update
+          s += " last_state_change=#{last_state_change}" if last_state_change
           s += " source=#{source.inspect}" if source
           "#{s}>"
         end

data/lib/openhab/core/gem.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+openhab_spec = Gem::Specification.new do |s|
+  s.name = "openhab"
+  s.version = -(ENV["OPENHAB_VERSION"] || "5.1.0")
+
+  def s.deleted_gem?
+    false
+  end
+
+  def s.installation_missing?
+    false
+  end
+end
+
+Gem::Specification.add_spec(openhab_spec)
+Gem.post_reset { Gem::Specification.add_spec(openhab_spec) }

data/lib/openhab/core/items/persistence.rb

@@ -670,15 +670,6 @@ module OpenHAB
         #   @since openHAB 4.2
         #
         def persist(*args)
-          # @deprecated OH 4.1 this if block content can be removed when dropping OH 4.1 support
-          if Core.version < Core::V4_2
-            raise ArgumentError, "wrong number of arguments (given #{args.size}, expected 0..1)" if args.size > 1
-
-            service = args.last || persistence_service
-            Actions::PersistenceExtensions.persist(self, service&.to_s)
-            return
-          end
-
           first_arg = args.first
           if first_arg.is_a?(TimeSeries)
             if args.size > 2
@@ -752,9 +743,6 @@ module OpenHAB
         #   @since openHAB 4.2
 
         %i[last_update next_update last_change next_change].each do |method|
-          # @deprecated OH 4.1 remove this guard when dropping OH 4.1
-          next unless Actions::PersistenceExtensions.respond_to?(method)
-
           class_eval <<~RUBY, __FILE__, __LINE__ + 1
             def #{method}(service = nil)                            # def last_update(service = nil)
               service ||= persistence_service                       #   service ||= persistence_service
@@ -794,9 +782,6 @@ module OpenHAB
         #   @since openHAB 4.2
 
         %i[previous_state next_state].each do |method|
-          # @deprecated OH 4.1 remove this guard when dropping OH 4.1
-          next unless Actions::PersistenceExtensions.respond_to?(method)
-
           class_eval <<~RUBY, __FILE__, __LINE__ + 1
             def #{method}(service = nil, skip_equal: false)       # def previous_state(service = nil, skip_equal: false)
               service ||= persistence_service                     #   service ||= persistence_service
@@ -819,10 +804,7 @@ module OpenHAB
 
             if riemann_param
               riemann_param = ", riemann_type: nil"
-              # @deprecated OH4.3 remove if guard when dropping OH 4.3
-              if Actions::PersistenceExtensions.const_defined?(:RiemannType)
-                riemann_arg = "to_riemann_type(riemann_type),"
-              end
+              riemann_arg = "to_riemann_type(riemann_type),"
             end
 
             class_eval <<~RUBY, __FILE__, __LINE__ + 1
@@ -846,17 +828,11 @@ module OpenHAB
             riemann_arg = nil
 
             def_persistence_method("#{method}_since#{suffix}", quantify:, riemann_param:)
-            # @deprecated OH 4.1 remove if guard, keeping the content, when dropping OH 4.1
-            if OpenHAB::Core.version >= OpenHAB::Core::V4_2
-              def_persistence_method("#{method}_until#{suffix}", quantify:, riemann_param:)
-            end
+            def_persistence_method("#{method}_until#{suffix}", quantify:, riemann_param:)
 
             if riemann_param
               riemann_param = ", riemann_type: nil"
-              # @deprecated OH4.3 remove if guard when dropping OH 4.3
-              if Actions::PersistenceExtensions.const_defined?(:RiemannType)
-                riemann_arg = "to_riemann_type(riemann_type),"
-              end
+              riemann_arg = "to_riemann_type(riemann_type),"
             end
 
             method = "#{method}_between"
@@ -889,7 +865,7 @@ module OpenHAB
 
         def_persistence_methods(:count_state_changes)
         alias_method :state_changes_since, :count_state_changes_since
-        alias_method :state_changes_until, :count_state_changes_until if OpenHAB::Core.version >= OpenHAB::Core::V4_2
+        alias_method :state_changes_until, :count_state_changes_until
         alias_method :state_changes_between, :count_state_changes_between
 
         def_persistence_methods(:delta, quantify: true)
@@ -900,27 +876,21 @@ module OpenHAB
 
         def_persistence_methods(:get_all_states, quantify: true)
         alias_method :all_states_since, :get_all_states_since
-        alias_method :all_states_until, :get_all_states_until if OpenHAB::Core.version >= OpenHAB::Core::V4_2
+        alias_method :all_states_until, :get_all_states_until
         alias_method :all_states_between, :get_all_states_between
 
         def_persistence_methods(:maximum, quantify: true)
         def_persistence_methods(:minimum, quantify: true)
-        def_persistence_methods(:median, quantify: true) if OpenHAB::Core.version >= OpenHAB::Core::V4_3
-        # @deprecated OH4.3 remove if guard when dropping OH 4.3
-        if Actions::PersistenceExtensions.const_defined?(:RiemannType)
-          # riemann_sum methods were added in OH 5.0 which already quantifies the result in core
-          def_persistence_methods(:riemann_sum, riemann_param: true)
-        end
+        def_persistence_methods(:median, quantify: true)
+        def_persistence_methods(:riemann_sum, riemann_param: true) # already quantified in core
         def_persistence_methods(:sum, quantify: true)
         def_persistence_methods(:updated?)
         def_persistence_methods(:variance, quantify: true, riemann_param: true)
 
-        if OpenHAB::Core.version >= OpenHAB::Core::V4_2
-          def_persistence_method(:persisted_state) # already quantified in core
+        def_persistence_method(:persisted_state) # already quantified in core
 
-          def_persistence_methods(:evolution_rate)
-          def_persistence_methods(:remove_all_states)
-        end
+        def_persistence_methods(:evolution_rate)
+        def_persistence_methods(:remove_all_states)
 
         # @deprecated OH 4.2 this method is deprecated in OH 4.2 and may be removed in a future version
         def evolution_rate(start, finish_or_service = nil, service = nil)

data/lib/openhab/core/items/registry.rb

@@ -52,9 +52,9 @@ module OpenHAB
         #
         # @see DSL::Items::Builder DSL::Items::Builder for more details and examples
         #
-        def build(preferred_provider = nil, update: true, &block)
+        def build(preferred_provider = nil, update: true, &)
           DSL::Items::BaseBuilderDSL.new(preferred_provider, update:)
-                                    .instance_eval_with_dummy_items(&block)
+                                    .instance_eval_with_dummy_items(&)
         end
 
         #

data/lib/openhab/core/items/semantics/enumerable.rb

@@ -97,16 +97,16 @@ module Enumerable
   # Send a command to every item in the collection
   # @return [self, nil] nil when `ensure` is in effect and all the items were already in the same state,
   #   otherwise self
-  def command(command, **kwargs)
-    self if count { |i| i.command(command, **kwargs) }.positive?
+  def command(command, **)
+    self if count { |i| i.command(command, **) }.positive?
   end
 
   # Send a command to every item in the collection, even when {OpenHAB::DSL.ensure_states! ensure_states!} is in effect.
   # @return [self]
-  def command!(command, **kwargs)
+  def command!(command, **)
     # We cannot alias this to #command above, otherwise it will call
     # DSL::Items::Ensure::Item#command which checks for ensure_states
-    each { |i| i.command!(command, **kwargs) }
+    each { |i| i.command!(command, **) }
     self
   end
 

data/lib/openhab/core/items/semantics.rb

@@ -174,12 +174,6 @@ module OpenHAB
         GroupItem.extend(Forwardable)
         GroupItem.def_delegators :members, :equipments, :locations
 
-        # This is a marker interface for all semantic tag classes.
-        # @interface
-        # @deprecated Since openHAB 4.0, {SemanticTag} is the interface that all tags implement.
-        #   Tags are simple instances, instead of another interface in a hierarchical structure.
-        Tag = org.openhab.core.semantics.Tag
-
         class << self
           # @!visibility private
           def service

data/lib/openhab/core/items.rb

@@ -42,7 +42,7 @@ module OpenHAB
         def def_predicate_methods(klass)
           values_for_enums(klass.ACCEPTED_DATA_TYPES).each do |state|
             _command_predicate, state_predicate = Types::PREDICATE_ALIASES[state.to_s]
-            next if klass.instance_methods.include?(state_predicate)
+            next if klass.method_defined?(state_predicate)
 
             logger.trace { "Defining #{klass}##{state_predicate} for #{state}" }
             klass.class_eval <<~RUBY, __FILE__, __LINE__ + 1
@@ -62,7 +62,7 @@ module OpenHAB
         def def_command_methods(klass)
           values_for_enums(klass.ACCEPTED_COMMAND_TYPES).each do |value|
             command = Types::COMMAND_ALIASES[value.to_s]
-            next if klass.instance_methods.include?(command)
+            next if klass.method_defined?(command)
 
             if value.is_a?(Types::State)
               logger.trace { "Defining #{klass}/Enumerable##{command}/#{command}! for #{value}" }
@@ -128,10 +128,10 @@ module OpenHAB
                .select { |k| k <= GenericItem && k != GroupItem && k != StringItem }
                .sort { |a, b| (a < b) ? 1 : -1 }
                .each do |klass|
-        klass.field_reader :ACCEPTED_COMMAND_TYPES, :ACCEPTED_DATA_TYPES unless klass == GenericItem
+                 klass.field_reader :ACCEPTED_COMMAND_TYPES, :ACCEPTED_DATA_TYPES unless klass == GenericItem
 
-        def_predicate_methods(klass)
-        def_command_methods(klass)
+                 def_predicate_methods(klass)
+                 def_command_methods(klass)
       end
 
       prepend_accepted_data_types

data/lib/openhab/core/lazy_array.rb

@@ -36,14 +36,14 @@ module OpenHAB
 
       # Delegate any other methods to the actual array, exclude mutating methods
       def method_missing(method, ...)
-        return to_a.send(method, ...) if method[-1] != "!" && Array.instance_methods.include?(method)
+        return to_a.send(method, ...) if method[-1] != "!" && Array.method_defined?(method)
 
         super
       end
 
       # @!visibility private
       def respond_to_missing?(method, include_private = false)
-        return true if method[-1] != "!" && Array.instance_methods.include?(method.to_sym)
+        return true if method[-1] != "!" && Array.method_defined?(method.to_sym)
 
         super
       end

data/lib/openhab/core/things/registry.rb

@@ -48,8 +48,8 @@ module OpenHAB
         # @raise [FrozenError] if `update` is true but the existing thing with the same uid
         #   wasn't created by the current provider.
         #
-        def build(preferred_provider = nil, update: true, &block)
-          DSL::Things::Builder.new(preferred_provider, update:).instance_eval(&block)
+        def build(preferred_provider = nil, update: true, &)
+          DSL::Things::Builder.new(preferred_provider, update:).instance_eval(&)
         end
 
         #

data/lib/openhab/core/types/date_time_type.rb

@@ -18,13 +18,7 @@ module OpenHAB
         remove_method :==
 
         extend Forwardable
-
-        # @deprecated OH 4.2 DateTimeType implements Java's Comparable interface in openHAB 4.3
-        if OpenHAB::Core.version >= OpenHAB::Core::V4_3
-          include ComparableType
-        else
-          include Comparable
-        end
+        include ComparableType
 
         class << self
           #
@@ -43,15 +37,8 @@ module OpenHAB
           end
         end
 
-        # @deprecated OH 4.2 Just call zoned_date_time(ZoneId.system_default) in OH 4.3
-        if OpenHAB::Core.version >= OpenHAB::Core::V4_3
-          def to_zoned_date_time(context = nil) # rubocop:disable Lint/UnusedMethodArgument
-            zoned_date_time(ZoneId.system_default)
-          end
-        else
-          def to_zoned_date_time(context = nil) # rubocop:disable Lint/UnusedMethodArgument
-            zoned_date_time
-          end
+        def to_zoned_date_time(context = nil) # rubocop:disable Lint/UnusedMethodArgument
+          zoned_date_time(ZoneId.system_default)
         end
 
         # @!method to_zoned_date_time(context = nil)
@@ -93,7 +80,7 @@ module OpenHAB
           if value.nil?
             super()
             return
-          elsif OpenHAB::Core.version >= OpenHAB::Core::V4_3 && value.respond_to?(:to_instant)
+          elsif value.respond_to?(:to_instant)
             super(value.to_instant)
             return
           elsif value.respond_to?(:to_zoned_date_time)
@@ -122,10 +109,7 @@ module OpenHAB
         def eql?(other)
           return false unless other.instance_of?(self.class)
 
-          # @deprecated OH 4.2 Call compare_to(other).zero? in OH 4.3 to avoid the deprecated getZonedDateTime()
-          return compare_to(other).zero? if OpenHAB::Core.version >= OpenHAB::Core::V4_3
-
-          zoned_date_time.compare_to(other.zoned_date_time).zero?
+          compare_to(other).zero?
         end
 
         #
@@ -141,10 +125,7 @@ module OpenHAB
         def <=>(other)
           logger.trace { "(#{self.class}) #{self} <=> #{other} (#{other.class})" }
           if other.is_a?(self.class)
-            # @deprecated OH 4.2 Call compare_to(other) in OH 4.3 to avoid the deprecated getZonedDateTime()
-            return compare_to(other) if OpenHAB::Core.version >= OpenHAB::Core::V4_3
-
-            zoned_date_time <=> other.zoned_date_time
+            compare_to(other)
           elsif other.respond_to?(:to_time)
             to_time <=> other.to_time
           elsif other.respond_to?(:coerce)
@@ -222,10 +203,9 @@ module OpenHAB
 
         # @!visibility private
         def respond_to_missing?(method, _include_private = false)
-          # @deprecated OH 4.2 Remove version check when dropping OH 4.2
-          return true if OpenHAB::Core.version >= OpenHAB::Core::V4_3 && to_instant.respond_to?(method)
+          return true if to_instant.respond_to?(method)
           return true if zoned_date_time.respond_to?(method)
-          return true if ::Time.instance_methods.include?(method.to_sym)
+          return true if ::Time.method_defined?(method.to_sym)
 
           super
         end
@@ -235,13 +215,9 @@ module OpenHAB
         # object representing the same instant
         #
         def method_missing(method, ...)
-          # @deprecated OH 4.2 Remove version check when dropping OH 4.2
-          if OpenHAB::Core.version >= OpenHAB::Core::V4_3 && to_instant.respond_to?(method)
-            return to_instant.send(method, ...)
-          end
-
+          return to_instant.send(method, ...) if to_instant.respond_to?(method)
           return zoned_date_time.send(method, ...) if zoned_date_time.respond_to?(method)
-          return to_time.send(method, ...) if ::Time.instance_methods.include?(method.to_sym)
+          return to_time.send(method, ...) if ::Time.method_defined?(method.to_sym)
 
           super
         end

data/lib/openhab/core/types/hsb_type.rb

@@ -244,8 +244,8 @@ module OpenHAB
         # @see planckian?
         # @see https://en.wikipedia.org/wiki/Planckian_locus Planckian Locus
         # @since openHAB 4.3
-        def planckian_cct(range: nil, **kwargs)
-          return unless planckian?(**kwargs)
+        def planckian_cct(range: nil, **)
+          return unless planckian?(**)
 
           range = range.range if range.is_a?(NumberItem)
           cct = self.cct

data/lib/openhab/core/types.rb

@@ -43,39 +43,39 @@ module OpenHAB
                .grep(Module)
                .select { |k| k < java.lang.Enum }
                .each do |klass|
-        # make sure == from Type is inherited
-        klass.remove_method(:==)
+                 # make sure == from Type is inherited
+                 klass.remove_method(:==)
 
-        # dynamically define predicate methods
-        klass.values.each do |value| # rubocop:disable Style/HashEachMethods -- this isn't a Ruby hash
-          # include all the aliases that we define for items both command and
-          # state aliases (since types can be interrogated as an incoming
-          # command, or as the state of an item)
-          command = :"#{Types::COMMAND_ALIASES[value.to_s]}?"
-          states = Types::PREDICATE_ALIASES[value.to_s]
+                 # dynamically define predicate methods
+                 klass.values.each do |value| # rubocop:disable Style/HashEachMethods -- this isn't a Ruby hash
+                   # include all the aliases that we define for items both command and
+                   # state aliases (since types can be interrogated as an incoming
+                   # command, or as the state of an item)
+                   command = :"#{Types::COMMAND_ALIASES[value.to_s]}?"
+                   states = Types::PREDICATE_ALIASES[value.to_s]
 
-          ([command] | states).each do |method|
-            logger.trace { "Defining #{klass}##{method} for #{value}" }
-            klass.class_eval <<~RUBY, __FILE__, __LINE__ + 1
-              def #{method}                                                 # def on?
-                as(#{value.class.java_class.simple_name}).equal?(#{value})  #   as(OnOffType).equal?(ON)
-              end                                                           # end
-            RUBY
-          end
+                   ([command] | states).each do |method|
+                     logger.trace { "Defining #{klass}##{method} for #{value}" }
+                     klass.class_eval <<~RUBY, __FILE__, __LINE__ + 1
+                       def #{method}                                                 # def on?
+                         as(#{value.class.java_class.simple_name}).equal?(#{value})  #   as(OnOffType).equal?(ON)
+                       end                                                           # end
+                     RUBY
+                   end
 
-          method = states.last
-          Events::ItemState.class_eval <<~RUBY, __FILE__, __LINE__ + 1
-            def #{method}                                                            # def on?
-              item_state.as(#{value.class.java_class.simple_name}).equal?(#{value})  #   item_state.as(OnOffType).equal?(ON)
-            end                                                                      # end
-          RUBY
+                   method = states.last
+                   Events::ItemState.class_eval <<~RUBY, __FILE__, __LINE__ + 1
+                     def #{method}                                                            # def on?
+                       item_state.as(#{value.class.java_class.simple_name}).equal?(#{value})  #   item_state.as(OnOffType).equal?(ON)
+                     end                                                                      # end
+                   RUBY
 
-          Events::ItemStateChangedEvent.class_eval <<~RUBY, __FILE__, __LINE__ + 1
-            def was_#{method}                                                            # def was_on?
-              old_item_state.as(#{value.class.java_class.simple_name}).equal?(#{value})  #   old_item_state.as(OnOffType).equal?(ON)
-            end                                                                          # end
-          RUBY
-        end
+                   Events::ItemStateChangedEvent.class_eval <<~RUBY, __FILE__, __LINE__ + 1
+                     def was_#{method}                                                            # def was_on?
+                       old_item_state.as(#{value.class.java_class.simple_name}).equal?(#{value})  #   old_item_state.as(OnOffType).equal?(ON)
+                     end                                                                          # end
+                   RUBY
+                 end
       end
     end
   end

data/lib/openhab/core.rb

@@ -17,6 +17,8 @@ module OpenHAB
     V5_0 = Gem::Version.new("5.0.0").freeze
     # @!visibility private
     V5_1 = Gem::Version.new("5.1.0").freeze
+    # @!visibility private
+    V5_2 = Gem::Version.new("5.2.0").freeze
 
     # @return [Gem::Version] Returns the current openHAB version as a Gem::Version object
     #   Note, this strips off snapshots, milestones and RC versions and returns the release version.
@@ -40,7 +42,7 @@ module OpenHAB
       @full_version ||= Gem::Version.new(VERSION).freeze
     end
 
-    raise "`openhab-scripting` requires openHAB >= 4.1.0" unless version >= V4_1
+    raise "`openhab-scripting` requires openHAB >= 5.0.0" unless version >= V5_0
 
     # @return [Integer] Number of seconds to wait between checks for automation manager
     CHECK_DELAY = 10
@@ -159,6 +161,10 @@ end
 require_relative "core/provider"
 
 Dir[File.expand_path("core/**/*.rb", __dir__)].each do |f|
+  # already been run by either a binstub, or the addon
+  next if f.end_with?("gem.rb")
   # metadata is autoloaded
-  require f unless f.include?("/metadata/")
+  next if f.include?("/metadata/")
+
+  require f
 end

data/lib/openhab/core_ext/java/duration.rb

@@ -36,7 +36,7 @@ module OpenHAB
         #   @return [true,false] Returns true if the duration is less than zero.
         #
 
-        unless instance_methods.include?(:positive?)
+        unless method_defined?(:positive?)
           #
           # @return [true, false] Returns true if the duration is greater than zero.
           #

data/lib/openhab/core_ext/java/list.rb

@@ -354,12 +354,12 @@ module Java::JavaUtil::List # rubocop:disable Style/ClassAndModuleChildren
     result
   end
 
-  def shuffle!(*args)
-    replace(shuffle(*args))
+  def shuffle!(*)
+    replace(shuffle(*))
   end
 
-  def slice(*args)
-    self[*args]
+  def slice(*)
+    self[*]
   end
 
   def slice!(*args)

data/lib/openhab/core_ext/ruby/symbol.rb

@@ -3,5 +3,5 @@
 # Extensions to Symbol
 class Symbol
   # Ruby 3.0 already has #name
-  alias_method :name, :to_s unless instance_methods.include?(:name)
+  alias_method :name, :to_s unless method_defined?(:name)
 end

data/lib/openhab/dsl/config_description/builder.rb

@@ -106,29 +106,33 @@ module OpenHAB
                       unit_label: nil,
                       verify: false)
           # Extract the named arguments into a hash
-          @parameters << method(__method__).parameters
-                                           .select { |param_type, _| param_type == :key } # rubocop:disable Style/HashSlice
-                                           .to_h { |_, key| [key, binding.local_variable_get(key)] }
-                                           .then do |p|
-            p[:options] = p[:options].map do |opt_value, opt_label|
-              org.openhab.core.config.core.ParameterOption.new(opt_value, opt_label)
-            end
-            p[:filter_criteria] = p[:filter_criteria].map do |filter_name, filter_value|
-              org.openhab.core.config.core.FilterCriteria.new(filter_name, filter_value)
-            end
-            p[:minimum] = p.delete(:min)&.to_d&.to_java
-            p[:maximum] = p.delete(:max)&.to_d&.to_java
-            p[:step] = p.delete(:step)&.to_d&.to_java
-            p[:group_name] ||= @current_group
-            type = org.openhab.core.config.core.ConfigDescriptionParameter::Type.value_of(type.to_s.upcase)
+          @parameters <<
+            method(__method__)
+            .parameters
+            .select { |param_type, _| param_type == :key } # rubocop:disable Style/HashSlice
+            .to_h { |_, key| [key, binding.local_variable_get(key)] }
+            .then do |p|
+              p[:options] = p[:options].map do |opt_value, opt_label|
+                org.openhab.core.config.core.ParameterOption.new(opt_value, opt_label)
+              end
+              p[:filter_criteria] = p[:filter_criteria].map do |filter_name, filter_value|
+                org.openhab.core.config.core.FilterCriteria.new(filter_name, filter_value)
+              end
+              p[:minimum] = p.delete(:min)&.to_d&.to_java
+              p[:maximum] = p.delete(:max)&.to_d&.to_java
+              p[:step] = p.delete(:step)&.to_d&.to_java
+              p[:group_name] ||= @current_group
+              type = org.openhab.core.config.core.ConfigDescriptionParameter::Type.value_of(type.to_s.upcase)
 
-            parameter = org.openhab.core.config.core.ConfigDescriptionParameterBuilder.create(name.to_s, type)
+              parameter = org.openhab.core.config.core.ConfigDescriptionParameterBuilder.create(
+                name.to_s, type
+              )
 
-            p.each do |key, value|
-              parameter.send(:"with_#{key}", value) unless value.nil?
+              p.each do |key, value|
+                parameter.send(:"with_#{key}", value) unless value.nil?
+              end
+              parameter.build
             end
-            parameter.build
-          end
         end
 
         #