openflow-protocol 0.1.6 → 0.1.7

data/spec/messages/statistics_reply_spec.rb

@@ -2,18 +2,23 @@ require 'spec_helper'
 
 describe OFStatisticsReply do
   context 'with description' do
-    it 'should read binary' do
-      desc = 'Manufacturer description'.pad(256) +
-             'Hardware description'.pad(256) +
-             'Software description'.pad(256) +
-             '123456789'.pad(32) +
-             'Datapath description'.pad(256)
-
-      msg = OFStatisticsReply.read [
+    let(:desc) {
+      'Manufacturer description'.pad(256) +
+      'Hardware description'.pad(256) +
+      'Software description'.pad(256) +
+      '123456789'.pad(32) +
+      'Datapath description'.pad(256)
+    }
+    let(:data) {
+      [
         1, 17, 0x04, 0x2c, 0, 0, 0, 1, # header
         0, 0,                          # statistic_type
         0, 1,                          # flags
       ].pack('C*') + desc
+    }
+
+    it 'should read binary' do
+      msg = OFStatisticsReply.read(data)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
       expect(msg.type).to eq(:statistics_reply)
       expect(msg.len).to eq(1068)
@@ -22,6 +27,10 @@ describe OFStatisticsReply do
       expect(msg.flags).to eq([:reply_more])
       expect(msg.statistics.serial_number).to eq('123456789')
     end
+    it 'should be parsable' do
+      msg = OFParser.read(data)
+      expect(msg.class).to eq(OFStatisticsReply)
+    end
     it 'should initialize with default values' do
       msg = OFStatisticsReply.new
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
@@ -52,8 +61,8 @@ describe OFStatisticsReply do
   end
 
   context 'with flow' do
-    it 'should read binary' do
-      msg = OFStatisticsReply.read [
+    let(:data) {
+      [
         1, 17, 0, 108, 0, 0, 0, 1, # header
         0, 1,                      # statistic_type
         0, 1,                      # flags
@@ -96,6 +105,10 @@ describe OFStatisticsReply do
         0, 1,       # port
         0xff, 0xff # max_length
       ].pack('C*')
+    }
+
+    it 'should read binary' do
+      msg = OFStatisticsReply.read(data)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
       expect(msg.type).to eq(:statistics_reply)
       expect(msg.len).to eq(108)
@@ -105,6 +118,10 @@ describe OFStatisticsReply do
       expect(msg.statistics.table_id).to eq(1)
       expect(msg.statistics.actions.length).to eq(1)
     end
+    it 'should be parsable' do
+      msg = OFParser.read(data)
+      expect(msg.class).to eq(OFStatisticsReply)
+    end
     it 'should initialize with default values' do
       msg = OFStatisticsReply.new(statistic_type: :flow)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
@@ -138,8 +155,8 @@ describe OFStatisticsReply do
   end
 
   context 'with aggregate' do
-    it 'should read binary' do
-      msg = OFStatisticsReply.read [
+    let(:data) {
+      [
         1, 17, 0, 36, 0, 0, 0, 1, # header
         0, 2,                     # statistic_type
         0, 1,                     # flags
@@ -150,6 +167,10 @@ describe OFStatisticsReply do
         0, 0, 0, 4,              # flow_count
         0, 0, 0, 0               # padding
       ].pack('C*')
+    }
+
+    it 'should read binary' do
+      msg = OFStatisticsReply.read(data)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
       expect(msg.type).to eq(:statistics_reply)
       expect(msg.len).to eq(36)
@@ -168,6 +189,10 @@ describe OFStatisticsReply do
       expect(msg.flags).to be_empty
       expect(msg.statistics.packet_count).to eq(0)
     end
+    it 'should be parsable' do
+      msg = OFParser.read(data)
+      expect(msg.class).to eq(OFStatisticsReply)
+    end
     it 'should initialize with some values' do
       msg = OFStatisticsReply.new(
         xid: 1,
@@ -190,8 +215,8 @@ describe OFStatisticsReply do
   end
 
   context 'with table' do
-    it 'should read binary' do
-      msg = OFStatisticsReply.read [
+    let(:data) {
+      [
         1, 17, 0, 76, 0, 0, 0, 1, # header
         0, 3,                     # statistic_type
         0, 1,                     # flags
@@ -209,6 +234,10 @@ describe OFStatisticsReply do
         0, 0, 0, 0, 0, 0, 0, 4,           # lookup_count
         0, 0, 0, 0, 0, 0, 0, 1            # matched_count
       ].pack('C*')
+    }
+
+    it 'should read binary' do
+      msg = OFStatisticsReply.read(data)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
       expect(msg.type).to eq(:statistics_reply)
       expect(msg.len).to eq(76)
@@ -218,6 +247,10 @@ describe OFStatisticsReply do
       expect(msg.statistics.length).to eq(1)
       expect(msg.statistics.first.table_id).to eq(1)
     end
+    it 'should be parsable' do
+      msg = OFParser.read(data)
+      expect(msg.class).to eq(OFStatisticsReply)
+    end
     it 'should initialize with default values' do
       msg = OFStatisticsReply.new(statistic_type: :table)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
@@ -247,8 +280,8 @@ describe OFStatisticsReply do
   end
 
   context 'with port' do
-    it 'should read binary' do
-      msg = OFStatisticsReply.read [
+    let(:data) {
+      [
         1, 17, 0, 116, 0, 0, 0, 1, # header
         0, 4,                      # statistic_type
         0, 1,                      # flags
@@ -269,6 +302,10 @@ describe OFStatisticsReply do
         0, 0, 0, 0, 0, 0, 0, 1,  # receive_crc_errors
         0, 0, 0, 0, 0, 0, 0, 3   # collisions
       ].pack('C*')
+    }
+
+    it 'should read binary' do
+      msg = OFStatisticsReply.read(data)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
       expect(msg.type).to eq(:statistics_reply)
       expect(msg.len).to eq(116)
@@ -278,6 +315,10 @@ describe OFStatisticsReply do
       expect(msg.statistics.length).to eq(1)
       expect(msg.statistics.first.port_number).to eq(1)
     end
+    it 'should be parsable' do
+      msg = OFParser.read(data)
+      expect(msg.class).to eq(OFStatisticsReply)
+    end
     it 'should initialize with default values' do
       msg = OFStatisticsReply.new(statistic_type: :port)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
@@ -307,8 +348,8 @@ describe OFStatisticsReply do
   end
 
   context 'with queue' do
-    it 'should read binary' do
-      msg = OFStatisticsReply.read [
+    let(:data) {
+      [
         1, 17, 0, 44, 0, 0, 0, 1, # header
         0, 5,                     # statistic_type
         0, 1,                     # flags
@@ -321,6 +362,10 @@ describe OFStatisticsReply do
         0, 0, 0, 0, 0, 0, 0, 10, # transmit_packets
         0, 0, 0, 0, 0, 0, 0, 2   # transmit_errors
       ].pack('C*')
+    }
+
+    it 'should read binary' do
+      msg = OFStatisticsReply.read(data)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
       expect(msg.type).to eq(:statistics_reply)
       expect(msg.len).to eq(44)
@@ -330,6 +375,10 @@ describe OFStatisticsReply do
       expect(msg.statistics.length).to eq(1)
       expect(msg.statistics.first.port_number).to eq(1)
     end
+    it 'should be parsable' do
+      msg = OFParser.read(data)
+      expect(msg.class).to eq(OFStatisticsReply)
+    end
     it 'should initialize with default values' do
       msg = OFStatisticsReply.new(statistic_type: :queue)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
@@ -359,8 +408,8 @@ describe OFStatisticsReply do
   end
 
   context 'with vendor' do
-    it 'should read binary' do
-      msg = OFStatisticsReply.read [
+    let(:data) {
+      [
         1, 17, 0, 20, 0, 0, 0, 1, # header
         0xff, 0xff,               # statistic_type
         0, 0,                     # flags
@@ -369,6 +418,10 @@ describe OFStatisticsReply do
         0, 0, 0, 1, # vendor
         1, 2, 3, 4  # body
       ].pack('C*')
+    }
+
+    it 'should read binary' do
+      msg = OFStatisticsReply.read(data)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
       expect(msg.type).to eq(:statistics_reply)
       expect(msg.len).to eq(20)
@@ -378,6 +431,10 @@ describe OFStatisticsReply do
       expect(msg.statistics.vendor).to eq(1)
       expect(msg.statistics.body).to eq([1, 2, 3, 4].pack('C*'))
     end
+    it 'should be parsable' do
+      msg = OFParser.read(data)
+      expect(msg.class).to eq(OFStatisticsReply)
+    end
     it 'should initialize with default values' do
       msg = OFStatisticsReply.new(statistic_type: :vendor)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)

data/spec/messages/statistics_request_spec.rb

@@ -1,13 +1,17 @@
 require 'spec_helper'
 
 describe OFStatisticsRequest do
+  let(:data) {
+    [
+      1, 16, 0, 12, 0, 0, 0, 1, # header
+      0, 0,                     # statistic_type
+      0, 0,                     # flags
+    ].pack('C*')
+  }
+
   context 'with description' do
     it 'should read binary' do
-      msg = OFStatisticsRequest.read [
-        1, 16, 0, 12, 0, 0, 0, 1, # header
-        0, 0,                     # statistic_type
-        0, 0,                     # flags
-      ].pack('C*')
+      msg = OFStatisticsRequest.read(data)
       expect(msg.version).to eq(OFMessage::OFP_VERSION)
       expect(msg.type).to eq(:statistics_request)
       expect(msg.len).to eq(12)
@@ -16,6 +20,10 @@ describe OFStatisticsRequest do
       expect(msg.flags).to be_empty
       expect(msg.statistics).to be_empty
     end
+    it 'should be parsable' do
+      msg = OFParser.read(data)
+      expect(msg.class).to eq(OFStatisticsRequest)
+    end
     it 'should initialize with default values' do
       msg = OFStatisticsRequest.new
       expect(msg.version).to eq(OFMessage::OFP_VERSION)

data/spec/messages/vendor_spec.rb

@@ -1,11 +1,15 @@
 require 'spec_helper'
 
 describe OFVendor do
-  it 'should read binary' do
-    msg = OFVendor.read [
+  let(:data) {
+    [
       1, 4, 0, 12, 0, 0, 0, 1, # header
       0, 0, 0, 1               # vendor
     ].pack('C*')
+  }
+
+  it 'should read binary' do
+    msg = OFVendor.read(data)
     expect(msg.version).to eq(OFMessage::OFP_VERSION)
     expect(msg.type).to eq(:vendor)
     expect(msg.len).to eq(12)
@@ -13,6 +17,10 @@ describe OFVendor do
     expect(msg.vendor).to eq(1)
     expect(msg.data).to be_empty
   end
+  it 'should be parsable' do
+    msg = OFParser.read(data)
+    expect(msg.class).to eq(OFVendor)
+  end
   it 'should read binary with data' do
     msg = OFVendor.read [
       1, 4, 0, 14, 0, 0, 0, 1, # header

data/spec/structs/packet_queue_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe OFPacketQueue do
+  it 'should read binary' do
+    queue = OFPacketQueue.read [
+      0, 0, 0, 1, # queue_id
+      0, 24,      # len
+      0, 0,       # padding
+      # queue_properties
+      #   queue_property_min_rate
+      0, 1, 0, 16, 0, 0, 0, 0, # header
+      0, 100,                  # rate
+      0, 0, 0, 0, 0, 0         # padding
+    ].pack('C*')
+    expect(queue.queue_id).to eq(1)
+    expect(queue.len).to eq(24)
+    expect(queue.properties.length).to eq(1)
+    expect(queue.properties.first.type).to eq(:min_rate)
+    expect(queue.properties.first.rate).to eq(100)
+  end
+  it 'should initialize with default values' do
+    queue = OFPacketQueue.new
+    expect(queue.queue_id).to eq(0)
+    expect(queue.len).to eq(8)
+  end
+  it 'should initialize with some values' do
+    queue = OFPacketQueue.new(
+      queue_id: 1,
+      properties: [OFQueuePropertyMinRate.new(rate: 100)]
+    )
+    expect(queue.queue_id).to eq(1)
+    expect(queue.len).to eq(24)
+    expect(queue.properties.length).to eq(1)
+    expect(queue.properties.first.type).to eq(:min_rate)
+    expect(queue.properties.first.rate).to eq(100)
+  end
+end

data/spec/structs/port_number_spec.rb

@@ -1,5 +1,24 @@
 require 'spec_helper'
 
+describe OFPortNumberStrict do
+  it 'should read binary' do
+    port_number = OFPortNumberStrict.read [0, 1].pack('C*')
+    expect(port_number).to eq(1)
+  end
+  it 'should initialize with default values' do
+    port_number = OFPortNumberStrict.new
+    expect(port_number).to eq(0)
+  end
+  it 'should initialize with some values' do
+    port_number = OFPortNumberStrict.new(2)
+    expect(port_number).to eq(2)
+  end
+  it 'should raise an error if greater than max value' do
+    expect { OFPortNumberStrict.new(:none) }.to raise_error(ArgumentError)
+    expect { OFPortNumberStrict.new(0xff01) }.to raise_error(ArgumentError)
+  end
+end
+
 describe OFPortNumber do
   it 'should read binary' do
     port_number = OFPortNumber.read [0, 1].pack('C*')

data/spec/structs/queue_properties/queue_properties_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe OFQueueProperties do
+  it 'should read binary' do
+    props = OFQueueProperties.read [
+      # none
+      0, 0, 0, 8, 0, 0, 0, 0,
+      # min_rate
+      0, 1, 0, 8, 0, 0, 0, 0, # header
+      0, 100,                 # rate
+      0, 0, 0, 0, 0, 0        # padding
+    ].pack('C*'), length: 24
+    expect(props.length).to eq(2)
+    expect(props.first.type).to eq(:none)
+    expect(props.last.type).to eq(:min_rate)
+  end
+  it 'should initialize with default values' do
+    props = OFQueueProperties.new
+    expect(props).to be_empty
+  end
+  it 'should initialize with some values' do
+    props = OFQueueProperties.new([
+      OFQueuePropertyMinRate.new(rate: 100)
+    ])
+    expect(props.length).to eq(1)
+    expect(props.first.type).to eq(:min_rate)
+    expect(props.first.rate).to eq(100)
+  end
+end

data/spec/structs/queue_properties/queue_property_min_rate_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe OFQueuePropertyMinRate do
+  it 'should read binary' do
+    prop = OFQueuePropertyMinRate.read [
+      0, 1, 0, 16, 0, 0, 0, 0, # header
+      0, 100,                  # rate
+      0, 0, 0, 0, 0, 0         # padding
+    ].pack('C*')
+    expect(prop.type).to eq(:min_rate)
+    expect(prop.len).to eq(16)
+    expect(prop.rate).to eq(100)
+  end
+  it 'should initialize with default values' do
+    prop = OFQueuePropertyMinRate.new
+    expect(prop.type).to eq(:min_rate)
+    expect(prop.len).to eq(16)
+    expect(prop.rate).to eq(0)
+  end
+  it 'should initialize with some values' do
+    prop = OFQueuePropertyMinRate.new(rate: 100)
+    expect(prop.type).to eq(:min_rate)
+    expect(prop.len).to eq(16)
+    expect(prop.rate).to eq(100)
+  end
+  it 'should disabled rate when > 1000' do
+    prop = OFQueuePropertyMinRate.new(rate: 1001)
+    expect(prop.type).to eq(:min_rate)
+    expect(prop.len).to eq(16)
+    expect(prop.rate).to eq(:disabled)
+  end
+end

data/spec/structs/queue_properties/queue_property_none_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe OFQueuePropertyNone do
+  it 'should read binary' do
+    prop = OFQueuePropertyNone.read [0, 0, 0, 8, 0, 0, 0, 0].pack('C*')
+    expect(prop.type).to eq(:none)
+    expect(prop.len).to eq(8)
+  end
+  it 'should initialize with default values' do
+    prop = OFQueuePropertyNone.new
+    expect(prop.type).to eq(:none)
+    expect(prop.len).to eq(8)
+  end
+end