opener-property-tagger 3.3.2 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6483ef2a01a413e280ed9555566499496748cb0b8c25ddd9853fb50165ab03f9
-  data.tar.gz: eb0f85d3d82aed282d21a3b51a0c75867b62c547b49fd1ceeaac374baff86111
+  metadata.gz: 6d4ff307d205b179b0914dc2f4d5278dcf9d345586bd2c1917e76f4dcfe6bb87
+  data.tar.gz: 459672172d0eac97a2b00784c63fe1c8375e06e6be07e1049611ee589ed758e9
 SHA512:
-  metadata.gz: fe31cb493644de7eaed474d9064e3f8880f229b8e05f0685aae18e730f5cd3d94c92aa403966904147b710f0e9589cffa840cf44ac83d64fc7f9c9211ffc6313
-  data.tar.gz: '0939965101de5ccd503bbdeae6b511552354d8f285e263b739b5d5f004ffdf03411fac5b4a97404f728bd1038f8320843c2dcb2f8ae70059eedc44e0682c4d71'
+  metadata.gz: 69792d8309041f86c67dd36f9c669c579f6891a8304a95db30879ee94c8e19a112ba3f1cc61d83350c8cbb7a4fac130628ac0a47ce4635afe5b79e6a42d11bb7
+  data.tar.gz: 7c261405d53473cd1c0785dcd1e7d19851c2491b8970a330cf8b97b3943e297ada8c3ee41d5395d1d2f4de7b40e76f2e58493a7dbdb5200129465e2087e65bb8

data/lib/opener/property_tagger.rb

@@ -1,6 +1,6 @@
 require 'open3'
 require 'slop'
-require 'oga'
+require 'nokogiri'
 require 'monitor'
 require 'httpclient'
 require 'hashie'

data/lib/opener/property_tagger/file_aspects_cache.rb

@@ -33,12 +33,17 @@ module Opener
       # @param [String] path
       #
       def load_aspects(path)
-        mapping = Hash.new { |hash, key| hash[key] = [] }
+        mapping = Hash.new{ |hash, key| hash[key] = [] }
 
-        File.foreach(path) do |line|
+        File.foreach path do |line|
           lemma, pos, aspect = line.chomp.split("\t")
+          l = Hashie::Mash.new(
+            lemma:  lemma,
+            pos:    pos,
+            aspect: aspect,
+          )
 
-          mapping[lemma.to_sym] << aspect
+          mapping[l.lemma.to_sym] << l
         end
 
         return mapping

data/lib/opener/property_tagger/processor.rb

@@ -6,7 +6,8 @@ module Opener
     class Processor
 
       attr_accessor :document
-      attr_accessor :aspects, :aspects_path, :aspects_url
+      attr_accessor :aspects_path, :aspects_url
+      attr_accessor :aspects, :lexicons
       attr_accessor :timestamp, :pretty
 
       ##
@@ -25,18 +26,19 @@ module Opener
       #  by default due to the performance overhead.
       #
       def initialize file, params: {}, url: nil, path: nil, timestamp: true, pretty: false
-        @document     = Oga.parse_xml file
+        @document     = Nokogiri.XML file
         raise 'Error parsing input. Input is required to be KAF' unless is_kaf?
         @timestamp    = timestamp
         @pretty       = pretty
 
         @params       = params
-        @cache_keys   = params[:cache_keys] || {lang: language}
         @remote       = !url.nil?
         @aspects_path = path
         @aspects_url  = url
+        @cache_keys   = params[:cache_keys] || {}
+        @cache_keys.merge! lang: @document.root.attr('xml:lang')
 
-        @aspects = if @remote then REMOTE_ASPECTS_CACHE[**@cache_keys].aspects else FILE_ASPECTS_CACHE[aspects_file] end
+        @lexicons = if @remote then REMOTE_ASPECTS_CACHE[**@cache_keys].aspects else FILE_ASPECTS_CACHE[aspects_file] end
       end
 
       ##
@@ -44,83 +46,79 @@ module Opener
       # @return [String]
       #
       def process
-        existing_aspects = extract_aspects
-
         add_features_layer
         add_properties_layer
 
-        existing_aspects.each_with_index do |(key, value), index|
+        extract_aspects.each.with_index do |(lemma, values), index|
           index += 1
 
-          add_property(key, value, index)
+          add_property lemma, values, index
         end
 
         add_linguistic_processor
 
-        return pretty ? pretty_print(document) : document.to_xml
+        pretty ? pretty_print(document) : document.to_xml
       end
 
-      ##
-      # Get the language of the input file.
-      #
-      # @return [String]
-      #
       def language
-        return @language ||= document.at_xpath('KAF').get('xml:lang')
+        @language ||= document.at_xpath('KAF').attr('xml:lang')
       end
 
-      ##
-      # Get the terms from the input file
-      # @return [Hash]
-      #
       def terms
         unless @terms
           @terms = {}
 
           document.xpath('KAF/terms/term').each do |term|
-            @terms[term.get('tid').to_sym] = term.get('lemma')
+            @terms[term.attr('tid').to_sym] = { lemma: term.attr('lemma'), text: term.attr('text')}
           end
         end
 
-        return @terms
+        @terms
       end
 
+      # Use of n-grams to determine if a unigram (1 lemma) or bigram (2
+      # lemmas) belong to a property.
+      MAX_NGRAM = 2
+
       ##
       # Check which terms belong to an aspect (property)
+      # Text have priority over Lemmas, overriding if there is a conflict
       # @return [Hash]
       #
       def extract_aspects
-        term_ids  = terms.keys
-        lemmas    = terms.values
-
-        current_token = 0
-        # Use of n-grams to determine if a unigram (1 lemma) or bigram (2
-        # lemmas) belong to a property.
-        max_ngram = 2
-
-        uniq_aspects = Hash.new { |hash, key| hash[key] = [] }
-
-        while current_token < terms.count
-          (0..max_ngram).each do |tam_ngram|
-            if current_token + tam_ngram <= terms.count
-              ngram = lemmas[current_token..current_token+tam_ngram].join(" ").downcase
-
-              if aspects[ngram.to_sym]
-                properties = aspects[ngram.to_sym]
-                ids        = term_ids[current_token..current_token+tam_ngram]
-
-                properties.uniq.each do |property|
-                  next if !property or property.strip.empty?
-
-                  uniq_aspects[property.to_sym] << [ids,ngram]
+        all_term_ids = terms.keys
+        lemmas       = terms.values
+        uniq_aspects = Hash.new{ |hash, lemma| hash[lemma] = [] }
+
+        [:lemma, :text].each do |k|
+          current_token = 0
+
+          while current_token < terms.count
+            (0..MAX_NGRAM).each do |tam_ngram|
+              next unless current_token + tam_ngram <= terms.count
+
+              ngram = lemmas[current_token..current_token+tam_ngram].map{ |a| a[k] }.join(" ").downcase
+
+              @lexicons[ngram.to_sym]&.each do |l|
+                properties = if l.aspects.present? then l.aspects else [l.aspect] end
+                properties.each do |p|
+                  next if p.blank?
+                  term_ids = all_term_ids[current_token..current_token+tam_ngram]
+                  next if uniq_aspects[p.to_sym].find{ |v| v.term_ids == term_ids }
+
+                  uniq_aspects[p.to_sym] << Hashie::Mash.new(
+                    term_ids: term_ids,
+                    ngram:    ngram,
+                    lexicon:  l,
+                  )
                 end
               end
             end
+            current_token += 1
           end
-          current_token += 1
         end
 
-        return Hash[uniq_aspects.sort]
+        Hash[uniq_aspects.sort]
       end
 
       ##
@@ -140,25 +138,25 @@ module Opener
         new_node("properties", "KAF/features")
       end
 
-      def add_property(key, value, index)
+      def add_property lemma, values, index
         property_node = new_node("property", "KAF/features/properties")
 
-        property_node.set('lemma', key.to_s)
-        property_node.set('pid', "p#{index.to_s}")
+        property_node['lemma'] = lemma.to_s
+        property_node['pid']   = "p#{index.to_s}"
 
         references_node = new_node("references", property_node)
 
-        value.uniq.each do |v|
-          comment = Oga::XML::Comment.new(:text => " #{v.last} ")
-
-          references_node.children << comment
+        values.each do |v|
+          comm_node = Nokogiri::XML::Comment.new(references_node, " #{v.ngram} ")
+          references_node.add_child comm_node
 
-          span_node = new_node("span", references_node)
+          span_node = new_node 'span', references_node
 
-          v.first.each do |val|
-            target_node = new_node("target", span_node)
+          v.term_ids.each do |id|
+            target_node       = new_node 'target', span_node
 
-            target_node.set('id', val.to_s)
+            target_node['id'] = id.to_s
+            target_node['lexicon-id'] = v.lexicon.id if v.lexicon.id
           end
         end
       end
@@ -169,19 +167,19 @@ module Opener
         version     = '2.0'
 
         node = new_node('linguisticProcessors', 'KAF/kafHeader')
-        node.set('layer', 'features')
+        node['layer'] = 'features'
 
         lp_node = new_node('lp', node)
 
-        lp_node.set('version', "#{last_edited}-#{version}")
-        lp_node.set('name', description)
+        lp_node['version'] = "#{last_edited}-#{version}"
+        lp_node['name']    = description
 
         if timestamp
           format = '%Y-%m-%dT%H:%M:%S%Z'
 
-          lp_node.set('timestamp', Time.now.strftime(format))
+          lp_node['timestamp'] = Time.now.strftime(format)
         else
-          lp_node.set('timestamp', '*')
+          lp_node['timestamp'] = '*'
         end
       end
 
@@ -200,7 +198,7 @@ module Opener
         formatter.compact = true
         formatter.write(doc, out)
 
-        return out.strip
+        out.strip
       end
 
       protected
@@ -212,11 +210,11 @@ module Opener
           parent_node = parent
         end
 
-        node = Oga::XML::Element.new(:name => tag)
+        node = Nokogiri::XML::Element.new(tag, document)
 
-        parent_node.children << node
+        parent_node.add_child node
 
-        return node
+        node
       end
 
       ##
@@ -224,7 +222,7 @@ module Opener
       # @return [Boolean]
       #
       def is_kaf?
-        return !!document.at_xpath('KAF')
+        !!document.at_xpath('KAF')
       end
 
       ##

data/lib/opener/property_tagger/remote_aspects_cache.rb

@@ -41,15 +41,18 @@ module Opener
       end
 
       def load_aspects lang:, cache:, **params
-        url      = "#{@url}&language_code=#{lang}&#{params.to_query}"
-        url     += "&if_updated_since=#{cache.from.iso8601}" if cache
+        url  = "#{@url}&language_code=#{lang}&#{params.to_query}"
+        url += "&if_updated_since=#{cache.from.utc.iso8601}" if cache
         puts "#{lang}: loading aspects from #{url}"
 
         lexicons = JSON.parse HTTPClient.new.get(url).body
         lexicons = lexicons['data'].map{ |l| Hashie::Mash.new l }
         mapping  = Hash.new{ |hash, key| hash[key] = [] }
         lexicons.each do |l|
-          mapping[l.lemma.to_sym] << l.aspect
+          mapping[l.lemma.to_sym] << l
+          l.variants&.each do |v|
+            mapping[v.lemma.to_sym] << l
+          end
         end
 
         mapping

data/lib/opener/property_tagger/version.rb

@@ -1,7 +1,7 @@
 module Opener
   class PropertyTagger
 
-    VERSION = '3.3.2'
+    VERSION = '3.4.0'
 
   end
 end

data/opener-property-tagger.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'opener-webservice', '~> 2.1'
   gem.add_dependency 'opener-core', '~> 2.2'
 
-  gem.add_dependency 'oga', ['~> 1.0', '>= 1.3.1']
+  gem.add_dependency 'nokogiri'
   gem.add_dependency 'httpclient'
   gem.add_dependency 'hashie'
   gem.add_dependency 'activesupport'

metadata

@@ -1,170 +1,164 @@
 --- !ruby/object:Gem::Specification
 name: opener-property-tagger
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 3.4.0
 platform: ruby
 authors:
 - development@olery.com
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-07 00:00:00.000000000 Z
+date: 2021-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
+  name: opener-daemons
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.2'
-  name: opener-daemons
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.2'
 - !ruby/object:Gem::Dependency
+  name: opener-webservice
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.1'
-  name: opener-webservice
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.1'
 - !ruby/object:Gem::Dependency
+  name: opener-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.2'
-  name: opener-core
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.2'
 - !ruby/object:Gem::Dependency
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.1
-  name: oga
-  prerelease: false
+        version: '0'
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: '0'
 - !ruby/object:Gem::Dependency
+  name: httpclient
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: httpclient
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: hashie
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: hashie
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: activesupport
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-  name: rspec
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
+  name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: cucumber
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: rake
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
-  name: benchmark-ips
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -219,7 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.7.9
+rubygems_version: 2.7.8
 signing_key:
 specification_version: 4
 summary: Property tagger for hotels in Dutch and English.