opener-opinion-detector 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31c4caf46aa2fa93dd88d5138cbd495325783565
-  data.tar.gz: 4e5d503fcc00e415d5bb0322a0adc0260d5b2cde
+  metadata.gz: 741deb8f509516cff44d47143287ea1d61573792
+  data.tar.gz: 7147f00cd7f11a48a709f2b1f62b388d25f78244
 SHA512:
-  metadata.gz: d0ebc3136cec62b3178af44eacb6f49d7498a7806fa160fc802b4c496e5695728c1c3b19181e2972a48cf8f66fe5d49957fc1b96a8f9c38524ca22dfa54ffdf9
-  data.tar.gz: 7edbf31a74dae022a6ca3e16eb6adb848bb00d5376fa9bf66d22ed8d144d6a19674ebbc00960e6d6144ca9cff7b0fde21b9393efbb80254e19fb84a209dcd02c
+  metadata.gz: ebe3bf2848a991733fa37ce2f63afe9146ca71edcaa2c24b3ae038de58ba62f84c3adca2e5d63d5860c59760085a332ced2b2f2c49855206580b93e0282efd26
+  data.tar.gz: c48954a106dd3dc149f9c549e07665f04cec27e167549d39e6b883b8f29dc6df5f0b5cb6ebb714ab1f7960172efb0066f81f8ecc02799520c79b04ee0bb21829

data/lib/opener/opinion_detector.rb

@@ -2,6 +2,7 @@ require 'open3'
 
 require 'nokogiri'
 require 'slop'
+require 'opener/core'
 require 'opener/opinion_detectors/base'
 
 require_relative 'opinion_detector/version'
@@ -38,7 +39,7 @@ module Opener
       language = language_from_kaf(input)
 
       unless valid_language?(language)
-        raise ArgumentError, "The specified language (#{language}) is invalid"
+        raise Core::UnsupportedLanguageError, language
       end
 
       kernel = language_constant(language).new(kernel_options)
@@ -46,7 +47,20 @@ module Opener
       return kernel.run(input)
     end
 
-    protected
+    ##
+    # Extracts the language from a KAF document.
+    #
+    # @param [String] input
+    # @return [String]
+    #
+    def language_from_kaf(input)
+      document = Nokogiri::XML(input)
+      language = document.xpath('KAF/@xml:lang')[0]
+
+      return language ? language.to_s : nil
+    end
+
+    private
 
     ##
     # Returns the options to use for the kernel.
@@ -67,18 +81,6 @@ module Opener
         ENV['OPINION_DETECTOR_MODELS_PATH']
     end
 
-    ##
-    # Extracts the language from a KAF document.
-    #
-    # @param [String] input
-    # @return [String]
-    #
-    def language_from_kaf(input)
-      reader = Nokogiri::XML::Reader(input)
-
-      return reader.read.lang
-    end
-
     ##
     # @param [String] language
     # @return [Class]

data/lib/opener/opinion_detector/version.rb

@@ -1,5 +1,5 @@
 module Opener
   class OpinionDetector
-    VERSION = '2.0.0'
+    VERSION = '2.0.1'
   end
 end

data/opener-opinion-detector.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'opener-opinion-detector-base'
   gem.add_dependency 'opener-daemons', '~> 2.2'
   gem.add_dependency 'opener-webservice', '~> 2.1'
-  gem.add_dependency 'opener-core', '~> 2.2'
+  gem.add_dependency 'opener-core', '~> 2.3'
 
   gem.add_dependency 'nokogiri'
   gem.add_dependency 'slop', '~> 3.5'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opener-opinion-detector
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - development@olery.com
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-25 00:00:00.000000000 Z
+date: 2014-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opener-opinion-detector-base
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement