opener-opinion-detector-basic 3.2.7 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a359f51820d658e268c5ea8215e295bf6bba49fd2a10b4e6bf118c0218b05fd
-  data.tar.gz: 9bff0744e84164bd87cb362c3fcb9c367658109de6c5b076a8c0b41aa3ca7e13
+  metadata.gz: 6c015888b4578913991c2589ebb6fc24d34980cb4e5dc4a57412bf5775fcb5db
+  data.tar.gz: 4250a3371836791463512e06bda9bbcdc0010015c5edde93c70b4cbf64507726
 SHA512:
-  metadata.gz: fe970070831b765eb857ac92f54888b85f0d36582683db710f8203ecd8f101da7cd329ef3abc8f9f1a1b726e0eead3e19eabcb8135d1977f68d3c437f154885a
-  data.tar.gz: ec097e7a1652589e5c040fbbc4175a17d79ed8626fc69a61e8b9729f66ec22ebefcd35ce26f9e120f7862468e0c45a90a78aecb7e3fd4247302d445f8b589bde
+  metadata.gz: 6c9084991ede605db1fe11ef0e9a2de6b853bb9dc9fe499ac0074f39b4eaf9396af55c58d65fa3f12453d4f71253652a82ae9feab1304b9732ffd1ad58569d8d
+  data.tar.gz: a53259fd1364af42392d120065b95d0658c2b153878e4a7847a8332c626b9421b9fb45728ebf43d9b71fa976416c8eb065cdc1a90473d9ea609e99bb84aca243

data/lib/opener/opinion_detector_basic/kaf/opinion.rb

@@ -109,7 +109,7 @@ module Opener
           unless index+1 >= terms_count
             min = index+1
             max = [index+1+max_distance,terms_count].min
-            @right_candidates = filter_candidates(sentence_terms[min..max])
+            @right_candidates = filter_candidates sentence_terms[min..max]
           end
 
           index = 0
@@ -123,14 +123,14 @@ module Opener
           unless index == 0
             min = [0, index-1-max_distance].max
             max = index
-            @left_candidates = filter_candidates(sentence_terms[min..max])
+            @left_candidates = filter_candidates sentence_terms[min..max].reverse
           end
 
           if right_candidates.any?
             @target_ids << right_candidates.first.id
           end
           if left_candidates.any?
-            @target_ids << left_candidates.first.id
+            @target_ids << left_candidates.last.id
           end
         end
 
@@ -143,7 +143,8 @@ module Opener
         # @return [Hash]
         #
         def filter_candidates sentence_terms
-          sentence_terms.select{|t| (t.pos == 'N' || t.pos == 'R') && !ids.include?(t.id)}
+          filtered = sentence_terms.take_while{ |t| !t.is_punct? } # stop on punctuation
+          filtered.select{ |t| (t.pos == 'N' || t.pos == 'R') && !ids.include?(t.id) }
         end
 
       end

data/lib/opener/opinion_detector_basic/kaf/term.rb

@@ -173,6 +173,10 @@ module Opener
           pos == 'J' || xpos == ',' || lemma == ',' || CONJUNCTIONS[language]&.include?(lemma)
         end
 
+        def is_punct?
+          pos == '.' || lemma == '-' || xpos == ',' || lemma == ','
+        end
+
         private
 
         # @return [Oga::XML::Element]

data/lib/opener/opinion_detector_basic/version.rb

@@ -1,7 +1,7 @@
 module Opener
   class OpinionDetectorBasic
 
-    VERSION = '3.2.7'
+    VERSION = '3.3.0'
 
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opener-opinion-detector-basic
 version: !ruby/object:Gem::Version
-  version: 3.2.7
+  version: 3.3.0
 platform: ruby
 authors:
 - development@olery.com
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-18 00:00:00.000000000 Z
+date: 2024-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opener-daemons
@@ -199,7 +199,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.14
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Basic Opinion Detector.