opener-opinion-detector-basic 3.2.4 → 3.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa1aba5cb9ba31f6e2205af1499f866f9e998883701b303f2229ecc855348293
-  data.tar.gz: db3a5d5021a0013757ba68252ccaed4c185a0960aaa9ca26e47681e0b3300d11
+  metadata.gz: 25eca945fb8a710dedd525a176d6bc67dc447e8df35641040e36d15a62174426
+  data.tar.gz: ba69559d1744561cd062293e753d189f396c046a7a9421ca76ee404e88c7e51b
 SHA512:
-  metadata.gz: 5e6e4ae440580e6ed2974c4a75b46f544212c8557ae3fe43fcbb4e4c3a7d7a6d71a058451f3abdae352766914182dc40237f42df54a565c7c866054828c758c8
-  data.tar.gz: 3db868535c5f43814b4b883ecd9d5b0bd02fb59de5ed290c6c1b3face4d65993d84c2971a2c7dc021b607b6c228735dd82f8931c909911302577dd3bcb4558f5
+  metadata.gz: 63ad07f3acd8c86374dfcc50c6b30b5ac2dc9457404ad4f4e22cdf2f5e2e742cb52b3d7303f109c89bb32c212ee07028a68ed2cb3e8b42609ba6ebcd795878ab
+  data.tar.gz: 11e843fb887c1fcfa3e33e68e1e05330a3bac7a5a4bc27261e8c7fec93b76bba20a470e4b2e634197b60b1731d47ea341f9f5312916cb12f82031a9ec17239cf

data/lib/opener/opinion_detector_basic/kaf/opinion.rb

@@ -126,43 +126,16 @@ module Opener
             @left_candidates = filter_candidates(sentence_terms[min..max])
           end
 
-          unless right_candidates.empty?
-            candidate = right_candidates.first
-            @target_ids << candidate.id
+          if right_candidates.any?
+            @target_ids << right_candidates.first.id
           end
-
-          if target_ids.empty?
-            list = mix_lists(right_candidates, left_candidates)
-            list.each do |l|
-              @target_ids << l.id
-              break
-            end
+          if left_candidates.any?
+            @target_ids << left_candidates.last.id
           end
         end
 
         protected
 
-        ##
-        # If there are no opinion targets, right and left candidates
-        # are mixed into one list and the first one is picked as the target.
-        #
-        # @return [Array]
-        #
-        def mix_lists(lista, listb)
-          list = []
-          min = [lista.count, listb.count].min
-          (0..min).each do |i|
-            list << lista[i]
-            list << listb[i]
-            if lista.count > listb.count
-              list << lista[min]
-            elsif listb.count > lista.count
-              list << listb[min]
-            end
-          end
-          return list.compact
-        end
-
         ##
         # Filters candidate terms depending on their part of speech and if
         # they are already part of the expression.

data/lib/opener/opinion_detector_basic/kaf/term.rb

@@ -14,9 +14,10 @@ module Opener
           'nl' => %w{, en},
           'en' => %w{, and},
           'es' => %w{, y e},
+          'pt' => %w{, e},
           'it' => %w{, e ed},
           'de' => %w{, und},
-          'fr' => %w{, et}
+          'fr' => %w{, et},
         }
 
         def initialize node, document, language
@@ -74,6 +75,10 @@ module Opener
           @pos ||= node.attr('pos')
         end
 
+        def xpos
+          @xpos ||= node.attr('xpos')
+        end
+
         def lexicon_id
           @lexicon_id ||= node.attr('lexicon-id')
         end
@@ -161,11 +166,11 @@ module Opener
 
         ##
         # Checks if a term is a conjunction.
-        #
-        # @return [TrueClass|FalseClass]
+        # Comma is identified as conjunction by default
+        # Sometimes, comma comes with space after it
         #
         def is_conjunction?(language)
-          pos == 'J' || CONJUNCTIONS[language]&.include?(lemma)
+          pos == 'J' || xpos == ',' || lemma == ',' || CONJUNCTIONS[language]&.include?(lemma)
         end
 
         private

data/lib/opener/opinion_detector_basic/version.rb

@@ -1,7 +1,7 @@
 module Opener
   class OpinionDetectorBasic
 
-    VERSION = '3.2.4'
+    VERSION = '3.2.8'
 
   end
 end

data/lib/opener/opinion_detector_basic.rb

@@ -41,6 +41,7 @@ module Opener
     def initialize(options = {})
       @args    = options.delete(:args) || []
       @options = options
+      ENV['OPINION_LEGACY'] = 'true' # Processor is still not working
       @klass   = if ENV['OPINION_LEGACY'] then LegacyProcessor else Processor end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opener-opinion-detector-basic
 version: !ruby/object:Gem::Version
-  version: 3.2.4
+  version: 3.2.8
 platform: ruby
 authors:
 - development@olery.com
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-03 00:00:00.000000000 Z
+date: 2021-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opener-daemons