opencpu 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cc821de62d9d3981b61ed2c4a501c9c67fd14335
-  data.tar.gz: 2257ce6bd32d940475aab7063b9c8f0812a38a75
+  metadata.gz: b22793ec74be38b993028d6173a3c248c94ebded
+  data.tar.gz: 36dcb14376dd06f049e2777c7bddc72dfcf00d29
 SHA512:
-  metadata.gz: 326ddd1a403277239f0e9ba3ba8e860ecf50ef960b03efbd65dc596dccac401f68dfa5d878ea414f3a1477ea806b55f265abf25cf5f98c8a5e0406f81da09a14
-  data.tar.gz: b2f0770627b0663321cd710b1bff62148ba6c123c1ab76c0ec96473e4ce79d7d434d699cc97b781c64ca2c216c2e7a1258cd72750659fdb3cf3055974c063bd0
+  metadata.gz: 6f8b357ba69afe78df0de40ef150183cdaf47c32dc0afad57211651f5c1175d7eac039f1a0354506ff920acadbea0344d433ceeda42787c6504bb78b6dbd0bb4
+  data.tar.gz: 03c3e679339495a20c1959daf76b630598fae225092a854888b966cdf7c44d441d313ac34bad0844c289ed81f0fd7d1446cff14575250e91a26738423f175996

data/.travis.yml

@@ -4,3 +4,5 @@ rvm:
   - 2.0.0-p576
   - 2.1.3
 script: bundle exec rspec spec
+before_install:
+  - gem install bundler

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.9.1
+
+* Added `convert_na_to_nil=true/false` option to Client#execute
+
 # 0.9.0
 
 * Added support for Github R repos through OpenCPU

data/lib/opencpu/client.rb

@@ -8,12 +8,29 @@ module OpenCPU
     end
 
     def execute(package, function, options = {})
-      user   = options.fetch :user, :system
-      data   = options.fetch :data, {}
-      format = options.fetch :format, :json
-      github_remote = options.fetch :github_remote, false
+      user                      = options.fetch :user, :system
+      data                      = options.fetch :data, {}
+      format                    = options.fetch :format, :json
+      github_remote             = options.fetch :github_remote, false
+      should_convert_na_to_nil  = options.fetch :convert_na_to_nil, false
+
       process_query package_url(package, function, user, github_remote, :json), data, format do |response|
-        JSON.parse(response.body)
+        output = JSON.parse(response.body)
+        output = convert_na_to_nil(output) if should_convert_na_to_nil
+        output
+      end
+    end
+
+    def convert_na_to_nil(data)
+      case data
+      when 'NA'
+        nil
+      when Hash
+        data.each { |k, v| data[k] = convert_na_to_nil(v) }
+      when Array
+        data.map! { |v| convert_na_to_nil(v) }
+      else
+        data
       end
     end
 

data/lib/opencpu/version.rb

@@ -1,6 +1,6 @@
 module OpenCPU
   MAJOR = 0
   MINOR = 9
-  TINY  = 0
+  TINY  = 1
   VERSION = [MAJOR, MINOR, TINY].join('.')
 end

data/spec/fixtures/vcr_cassettes/animation_flip_coin.yml

@@ -3004,4 +3004,3 @@ http_interactions:
         \    \n"
     http_version: 
   recorded_at: Tue, 14 Oct 2014 18:51:02 GMT
-recorded_with: VCR 2.9.3

data/spec/fixtures/vcr_cassettes/response_with_na_values.yml

@@ -0,0 +1,61 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://public.opencpu.org/ocpu/library/base/R/identity/json
+    body:
+      encoding: UTF-8
+      string: x=data.frame(x%3D1%2Cy%3D1)
+    headers: {}
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx/1.4.6 (Ubuntu)
+      Date:
+      - Tue, 14 Oct 2014 19:01:39 GMT
+      Content-Type:
+      - application/json
+      Location:
+      - https://public.opencpu.org/ocpu/tmp/x0c19f32080/
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      Cache-Control:
+      - max-age=300, public
+      X-Ocpu-Session:
+      - x0c19f32080
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Headers:
+      - Origin, Content-Type, Accept, Accept-Encoding, Cache-Control
+      Access-Control-Expose-Headers:
+      - Location, X-ocpu-session, Content-Type, Cache-Control
+      X-Ocpu-R:
+      - R version 3.1.1 (2014-07-10)
+      X-Ocpu-Locale:
+      - en_US.UTF-8
+      X-Ocpu-Time:
+      - 2014-10-14 12:01:39 PDT
+      X-Ocpu-Version:
+      - 1.4.4
+      X-Ocpu-Server:
+      - rApache
+      X-Ocpu-Cache:
+      - MISS
+    body:
+      encoding: UTF-8
+      string: |+
+        [
+          {
+            "x": "NA",
+            "y": "not_na" 
+          }
+        ]
+
+    http_version: 
+  recorded_at: Tue, 14 Oct 2014 19:01:39 GMT
+recorded_with: VCR 2.9.3

data/spec/lib/opencpu/client_spec.rb

@@ -105,6 +105,15 @@ describe OpenCPU::Client do
       end
     end
 
+    context 'na_to_nil = true option is given' do
+      it 'converts "na" values to nil' do
+        VCR.use_cassette :response_with_na_values do |cassette|
+          response = client.execute(:base, :identity, format: nil, data: {}, convert_na_to_nil: true)
+          expect(response).to eq [{"x"=>nil, "y"=>"not_na"}]
+        end
+      end
+    end
+
     context 'multipart form / file uploads' do
       it "works" do
         skip # vcr is broken for file uploads https://github.com/vcr/vcr/issues/441
@@ -190,6 +199,25 @@ describe OpenCPU::Client do
     end
   end
 
+  describe "#convert_na_to_nil" do
+    let(:client) { described_class.new }
+
+    it "converts 'NA' values in hashes in arrays" do
+      res = client.convert_na_to_nil([4, {foo: 'NA'}])
+      expect(res[1][:foo]).to be_nil
+    end
+
+    it "converts 'NA' values in arrays in hashes" do
+      res = client.convert_na_to_nil(foo: [1, 'NA'])
+      expect(res[:foo][1]).to be_nil
+    end
+
+    it 'leaves other values alone' do
+      res = client.convert_na_to_nil(foo: [1, 'NOTNA'])
+      expect(res[:foo][1]).to eq 'NOTNA'
+    end
+  end
+
   describe '#request_options' do
     it 'uses verify_ssl setting' do
       expect(described_class.new.send(:request_options, {}, nil)[:verify]).to be_truthy

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opencpu
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Ivan Malykh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-08 00:00:00.000000000 Z
+date: 2016-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
@@ -213,6 +213,7 @@ files:
 - spec/fixtures/vcr_cassettes/github_animation_flip_coin.yml
 - spec/fixtures/vcr_cassettes/github_animation_flip_coin_error.yml
 - spec/fixtures/vcr_cassettes/prepare.yml
+- spec/fixtures/vcr_cassettes/response_with_na_values.yml
 - spec/fixtures/vcr_cassettes/url_encoded_request.yml
 - spec/fixtures/vcr_cassettes/user_digest_hmac.yml
 - spec/lib/opencpu/client_spec.rb
@@ -240,7 +241,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Wrapper around OpenCPU REST API
@@ -252,6 +253,7 @@ test_files:
 - spec/fixtures/vcr_cassettes/github_animation_flip_coin.yml
 - spec/fixtures/vcr_cassettes/github_animation_flip_coin_error.yml
 - spec/fixtures/vcr_cassettes/prepare.yml
+- spec/fixtures/vcr_cassettes/response_with_na_values.yml
 - spec/fixtures/vcr_cassettes/url_encoded_request.yml
 - spec/fixtures/vcr_cassettes/user_digest_hmac.yml
 - spec/lib/opencpu/client_spec.rb