openclacky 0.9.16 → 0.9.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5e4f19a4e5cd22ab1ecc81bfb9c62db1b458a9823699ce853d6094a24b4d3496
-  data.tar.gz: b0916deb0e5cce5d68f2454ddf35e267409869c19c26e7c203adfd8215aeabe4
+  metadata.gz: 538f6014a8386fcddf69dbf69efd162a00ad594d776b812eba5ac04f98953995
+  data.tar.gz: 4d9952dbbf2e20d1a598b136a0f01e821a1e53391240c197afe60e3570d4bfce
 SHA512:
-  metadata.gz: fe1aeaeac77dddfbb06bfc702c4d09adbffb338b0815481902b3490ab8610448f38ec0921b8e7a6885154b722a89528f911995bb473025339890554399611094
-  data.tar.gz: ca2505ac215e2cf9430b2b5c7e9629f581108daa6798d6a379e61e8446c199def9537813218b835304c3bf412d8df452767e78fff1a39a05b7d125c93ec0a8f3
+  metadata.gz: 8ed52fb94f805bc83c8ab996c9a1f01635665b054750900623002edc29a0197c9ab99be08d192e2f1f1040c8665451e155d9878fec5a71c213d7c3130fbbb956
+  data.tar.gz: 248569c522a59c37c3bda8342141be750609ca4fca996a8d563fcb953e6dcb1446fbc379082691b5503679d26d9168aa8e2503f7b169b3b4daeafa9428b7cf5b

data/CHANGELOG.md

@@ -7,6 +7,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.9.18] - 2026-03-28
+
+### Fixed
+- **Brand skill config now reloads from disk on every `load_all`**: brand skills installed or activated after the initial startup were previously invisible until restart — the skill loader now refreshes `BrandConfig` each time it loads skills, so newly installed brand skills take effect immediately
+
+### More
+- Remove `private` keyword from all internal classes to improve Ruby 2.6 compatibility
+- Rename `install.sh` → `install_full.sh`; promote `install_simple.sh` → `install.sh` as the default entry point
+
+## [0.9.17] - 2026-03-27
+
+### Added
+- **Browser screenshots now saved to disk**: every screenshot action automatically saves both the original full-resolution PNG and the compressed (800px) version to disk — the agent reports both file paths so you can reference, open, or pass the screenshots to other tools
+- **Provider "Get API Key" links in onboarding**: the setup wizard now shows a direct link to the provider's website when you select a provider that has a `website_url` — making it easier to sign up and get your API key without leaving the flow
+
+### Fixed
+- **WebSocket auto-reconnect for Feishu and WeCom channels**: the WebSocket clients for Feishu and WeCom now automatically retry the connection after failures — channels stay online without manual intervention after a network hiccup
+- **Brand command in simple install script**: the `clacky` brand command was incorrectly invoked in `install_simple.sh` — now fixed so the post-install branding step runs correctly
+- **Windows WSL2 and Hyper-V detection in PowerShell installer**: improved detection logic for WSL2 and Hyper-V environments in `install.ps1`, reducing false negatives on Windows machines with non-standard configurations
+
 ## [0.9.16] - 2026-03-27
 
 ### Fixed

data/lib/clacky/agent/cost_tracker.rb

@@ -84,7 +84,6 @@ module Clacky
       # Simple approximation: characters / 4 (English text)
 
 
-      private
 
       # Collect token usage data for current iteration and return it.
       # Does NOT call @ui directly — the caller is responsible for displaying

data/lib/clacky/agent/hook_manager.rb

@@ -51,7 +51,6 @@ module Clacky
       end
     end
 
-    private
 
     def validate_event!(event)
       return if HOOK_EVENTS.include?(event)

data/lib/clacky/agent/message_compressor.rb

@@ -108,7 +108,6 @@ module Clacky
       [system_msg, *parsed_messages, *safe_recent].compact
     end
 
-    private
 
     def parse_compressed_result(result, chunk_path: nil)
       # Return the compressed result as a single assistant message

data/lib/clacky/agent/message_compressor_helper.rb

@@ -214,7 +214,6 @@ module Clacky
         end
       end
 
-      private
 
       # Returns true if msg is a tool result, regardless of storage format.
       # Canonical: role:"tool"  |  Legacy Anthropic-native: role:"user" + tool_result blocks

data/lib/clacky/agent/session_serializer.rb

@@ -193,7 +193,6 @@ module Clacky
         { has_more: has_more }
       end
 
-      private
 
       # Render a single non-user message into the UI.
       # Used by both the normal round-based replay and the compressed-session fallback.

data/lib/clacky/agent/skill_manager.rb

@@ -258,7 +258,6 @@ module Clacky
         @ui&.show_info("Injected skill content for /#{skill.identifier}")
       end
 
-      private
 
       # Find skills whose identifiers are similar to the given name.
       # Uses substring matching first, then character overlap as a fallback.

data/lib/clacky/brand_config.rb

@@ -862,7 +862,6 @@ module Clacky
       }
     end
 
-    private
 
     def to_yaml
       data = {}

data/lib/clacky/client.rb

@@ -121,7 +121,6 @@ module Clacky
       model_str.match?(/claude(?:-3[-.]?[5-9]|-[4-9]|-sonnet-[34])/)
     end
 
-    private
 
     # ── Bedrock Converse request / response ───────────────────────────────────
 

data/lib/clacky/default_skills/channel-setup/feishu_setup.rb

@@ -104,7 +104,6 @@ class ToolClient
     raise "ToolClient connection failed: #{e.message}"
   end
 
-  private
 
   def http
     return @http if @http
@@ -286,7 +285,6 @@ class FeishuApiClient
     get_json("#{FEISHU_API_BASE}/app/#{app_id}")
   end
 
-  private
 
   # Execute a GET fetch in the browser page context.
   # Uses window.csrfToken — required by all /developers/v1/ endpoints.

data/lib/clacky/plain_ui_controller.rb

@@ -135,7 +135,6 @@ module Clacky
     def set_input_tips(message, type: :info); end
     def stop; end
 
-    private
 
     def puts_line(text)
       @mutex.synchronize do

data/lib/clacky/providers.rb

@@ -17,7 +17,8 @@ module Clacky
         "base_url" => "https://openrouter.ai/api/v1",
         "api" => "openai-responses",
         "default_model" => "anthropic/claude-sonnet-4-6",
-        "models" => []  # Dynamic - fetched from API
+        "models" => [],  # Dynamic - fetched from API
+        "website_url" => "https://openrouter.ai/keys"
       }.freeze,
 
       "minimax" => {
@@ -25,7 +26,8 @@ module Clacky
         "base_url" => "https://api.minimaxi.com/v1",
         "api" => "openai-completions",
         "default_model" => "MiniMax-M2.7",
-        "models" => ["MiniMax-M2.5", "MiniMax-M2.7"]
+        "models" => ["MiniMax-M2.5", "MiniMax-M2.7"],
+        "website_url" => "https://www.minimaxi.com/user-center/basic-information/interface-key"
       }.freeze,
 
       "kimi" => {
@@ -33,7 +35,8 @@ module Clacky
         "base_url" => "https://api.moonshot.cn/v1",
         "api" => "openai-completions",
         "default_model" => "kimi-k2.5",
-        "models" => ["kimi-k2.5"]
+        "models" => ["kimi-k2.5"],
+        "website_url" => "https://platform.moonshot.cn/console/api-keys"
       }.freeze,
 
       "anthropic" => {
@@ -41,7 +44,8 @@ module Clacky
         "base_url" => "https://api.anthropic.com",
         "api" => "anthropic-messages",
         "default_model" => "claude-sonnet-4.6",
-        "models" => ["claude-opus-4-6", "claude-sonnet-4.6", "claude-haiku-4.5"]
+        "models" => ["claude-opus-4-6", "claude-sonnet-4.6", "claude-haiku-4.5"],
+        "website_url" => "https://console.anthropic.com/settings/keys"
       }.freeze,
 
       "bedrock-jp" => {
@@ -52,7 +56,8 @@ module Clacky
         "models" => [
           "jp.anthropic.claude-sonnet-4-6",
           "jp.anthropic.claude-haiku-4-6"
-        ]
+        ],
+        "website_url" => "https://console.aws.amazon.com/iam/home#/security_credentials"
       }.freeze
 
     }.freeze

data/lib/clacky/server/browser_manager.rb

@@ -190,7 +190,6 @@ module Clacky
     # ---------------------------------------------------------------------------
     # Private
     # ---------------------------------------------------------------------------
-    private
 
     def load_config
       return {} unless File.exist?(BROWSER_CONFIG_PATH)

data/lib/clacky/server/channel/adapters/feishu/adapter.rb

@@ -143,7 +143,6 @@ module Clacky
             errors
           end
 
-          private
 
           # Handle incoming WebSocket event
           # @param raw_event [Hash] Raw event data

data/lib/clacky/server/channel/adapters/feishu/bot.rb

@@ -160,7 +160,6 @@ module Clacky
             end
           end
 
-          private
 
           # Build message content and type based on text content.
           # Uses interactive card (schema 2.0) for code blocks and tables,

data/lib/clacky/server/channel/adapters/feishu/message_parser.rb

@@ -42,7 +42,6 @@ module Clacky
             end
           end
 
-          private
 
           # Parse message.receive event
           # @return [Hash, nil]

data/lib/clacky/server/channel/adapters/feishu/ws_client.rb

@@ -51,7 +51,11 @@ module Clacky
             @ws_socket&.close rescue nil
           end
 
-          private
+
+          # Timeout for IO.select on the read loop. Feishu server sends pings every
+          # @ping_interval seconds (default 90s). Allow two missed pings before
+          # treating the connection as dead.
+          READ_TIMEOUT_MULTIPLIER = 2.5
 
           def connect_and_listen
             Clacky::Logger.info("[feishu-ws] Fetching WebSocket endpoint...")
@@ -92,9 +96,22 @@ module Clacky
 
             start_ping_thread
 
+            # read_timeout is based on the server-provided ping interval so it
+            # automatically adapts if Feishu changes the cadence.
+            read_timeout = (@ping_interval * READ_TIMEOUT_MULTIPLIER).ceil
+
             loop do
               break unless @running
-              data = socket.readpartial(4096)
+
+              # Use IO.select with a timeout to detect silent connection drops
+              # (NAT expiry, firewall idle-kill) that never send a TCP FIN/RST.
+              ready = IO.select([socket], nil, nil, read_timeout)
+              unless ready
+                Clacky::Logger.warn("[feishu-ws] read timeout (#{read_timeout}s), reconnecting...")
+                return
+              end
+
+              data = socket.read_nonblock(4096)
               @incoming << data
               while (frame = @incoming.next)
                 case frame.type
@@ -106,13 +123,14 @@ module Clacky
                 when :ping
                   send_raw_frame(:pong, frame.data)
                 when :close
-                  Clacky::Logger.info("[feishu-ws] WebSocket closed, will reconnect")
+                  Clacky::Logger.info("[feishu-ws] WebSocket closed by server, will reconnect")
                   return
                 end
               end
             end
-          rescue EOFError, Errno::ECONNRESET
-            Clacky::Logger.warn("[feishu-ws] Connection lost, reconnecting in #{RECONNECT_DELAY}s...")
+          rescue EOFError, IOError, Errno::ECONNRESET, Errno::EPIPE,
+                 Errno::ETIMEDOUT, OpenSSL::SSL::SSLError => e
+            Clacky::Logger.warn("[feishu-ws] Connection lost (#{e.class}: #{e.message}), reconnecting in #{RECONNECT_DELAY}s...")
           ensure
             @ws_open = false
             @ws_socket = nil
@@ -254,7 +272,10 @@ module Clacky
                     headers: { "type" => "ping" }
                   )
                 rescue => e
-                  warn "[feishu-ws] ping failed: #{e.message}"
+                  Clacky::Logger.warn("[feishu-ws] ping failed (#{e.class}: #{e.message}), forcing reconnect")
+                  # Close the socket so IO.select in the read loop immediately
+                  # returns nil / read_nonblock raises IOError, triggering reconnect.
+                  @ws_socket&.close rescue nil
                   break
                 end
               end

data/lib/clacky/server/channel/adapters/wecom/adapter.rb

@@ -74,7 +74,6 @@ module Clacky
             errors
           end
 
-          private
 
           def handle_raw_message(raw)
             msgtype = raw["msgtype"]

data/lib/clacky/server/channel/adapters/wecom/ws_client.rb

@@ -115,7 +115,13 @@ module Clacky
             raise
           end
 
-          private
+
+          # Timeout for IO.select on the read loop. If no data arrives within this
+          # window we treat the connection as dead and reconnect. This catches the
+          # silent-drop case where the TCP stack never delivers a FIN/RST (e.g.
+          # NAT timeout, firewall idle-kill). The WeCom server sends pings every
+          # ~30 s, so 75 s gives two missed pings before we give up.
+          READ_TIMEOUT_S = 75
 
           def connect_and_listen
             uri = URI.parse(@ws_url)
@@ -151,7 +157,17 @@ module Clacky
 
             loop do
               break unless @running
-              data = ssl.readpartial(4096)
+
+              # Use IO.select with a timeout so we detect silent connection drops
+              # (e.g. NAT expiry) that never deliver a TCP FIN/RST. Without this,
+              # readpartial blocks forever and the thread hangs permanently.
+              ready = IO.select([ssl], nil, nil, READ_TIMEOUT_S)
+              unless ready
+                Clacky::Logger.warn("[WecomWSClient] read timeout (#{READ_TIMEOUT_S}s), reconnecting...")
+                return
+              end
+
+              data = ssl.read_nonblock(4096)
               @incoming << data
               while (frame = @incoming.next)
                 case frame.type
@@ -160,13 +176,14 @@ module Clacky
                 when :ping
                   send_raw_frame(:pong, frame.data)
                 when :close
-                  Clacky::Logger.info("[WecomWSClient] connection closed")
+                  Clacky::Logger.info("[WecomWSClient] connection closed by server")
                   return
                 end
               end
             end
-          rescue EOFError, Errno::ECONNRESET
-            Clacky::Logger.info("[WecomWSClient] connection lost, reconnecting...")
+          rescue EOFError, IOError, Errno::ECONNRESET, Errno::EPIPE,
+                 Errno::ETIMEDOUT, OpenSSL::SSL::SSLError => e
+            Clacky::Logger.info("[WecomWSClient] connection lost (#{e.class}: #{e.message}), reconnecting...")
           ensure
             @ws_open = false
             @ws_socket = nil
@@ -257,7 +274,15 @@ module Clacky
               loop do
                 sleep HEARTBEAT_INTERVAL
                 break unless @running
-                send_frame(cmd: "ping", req_id: generate_req_id("ping"))
+                begin
+                  send_frame(cmd: "ping", req_id: generate_req_id("ping"))
+                rescue => e
+                  Clacky::Logger.warn("[WecomWSClient] ping failed (#{e.class}: #{e.message}), forcing reconnect")
+                  # Close the socket so IO.select in the read loop immediately
+                  # returns nil / read_nonblock raises IOError, triggering reconnect.
+                  @ws_socket&.close rescue nil
+                  break
+                end
               end
             end
           end

data/lib/clacky/server/channel/adapters/weixin/adapter.rb

@@ -177,7 +177,6 @@ module Clacky
             false
           end
 
-          private
 
           def process_message(msg)
             # Only process inbound USER messages (message_type 1 = USER)

data/lib/clacky/server/channel/adapters/weixin/api_client.rb

@@ -173,7 +173,6 @@ module Clacky
             aes_ecb_decrypt(encrypted_bytes, raw_aes_key)
           end
 
-          private
 
           # Full upload pipeline: encrypt → getuploadurl → CDN PUT → return CDNMedia hash.
           def upload_media(raw_bytes:, file_name:, media_type:, to_user_id:)

data/lib/clacky/server/channel/channel_manager.rb

@@ -96,7 +96,6 @@ module Clacky
         end
       end
 
-      private
 
       def start_adapter(platform)
         klass = Adapters.find(platform)

data/lib/clacky/server/channel/channel_ui_controller.rb

@@ -166,7 +166,6 @@ module Clacky
       def set_input_tips(message, type: :info); end
       def stop; end
 
-      private
 
       def send_text(text)
         text = text.to_s.gsub(/<think>[\s\S]*?<\/think>\n*/i, "").strip

data/lib/clacky/server/http_server.rb

@@ -299,7 +299,6 @@ module Clacky
         server.start
       end
 
-      private
 
       # ── Router ────────────────────────────────────────────────────────────────
 
@@ -1528,7 +1527,8 @@ module Clacky
             name:          preset["name"],
             base_url:      preset["base_url"],
             default_model: preset["default_model"],
-            models:        preset["models"] || []
+            models:        preset["models"] || [],
+            website_url:   preset["website_url"]
           }
         end
         json_response(res, 200, { providers: providers })

data/lib/clacky/server/server_master.rb

@@ -106,7 +106,6 @@ module Clacky
         remove_pid_file
       end
 
-      private
 
       # Spawn a fresh Ruby process that loads the (possibly updated) gem from disk.
       # The listen socket is inherited via its file descriptor number.

data/lib/clacky/server/session_registry.rb

@@ -187,7 +187,6 @@ module Clacky
         end
       end
 
-      private
 
       # Normalize source field from a disk session hash.
       # "system" is a legacy value renamed to "setup" — treat them as equivalent.

data/lib/clacky/server/web_ui_controller.rb

@@ -288,7 +288,6 @@ module Clacky
         emit("server_stop")
       end
 
-      private
 
       # Generate a short human-readable summary for a tool call display.
       # Delegates to each tool's own format_call method when available.

data/lib/clacky/session_manager.rb

@@ -108,7 +108,6 @@ module Clacky
       end.size
     end
 
-    private
 
     def ensure_sessions_dir
       FileUtils.mkdir_p(@sessions_dir) unless Dir.exist?(@sessions_dir)

data/lib/clacky/skill.rb

@@ -327,7 +327,6 @@ module Clacky
       end
     end
 
-    private
 
     def load_skill
       if @brand_skill

data/lib/clacky/skill_loader.rb

@@ -42,6 +42,10 @@ module Clacky
     # Clears previously loaded skills before loading to ensure idempotency
     # @return [Array<Skill>] Loaded skills
     def load_all
+      # Always refresh brand_config from disk so newly installed/activated brand
+      # skills are visible even if this SkillLoader was created before the change.
+      @brand_config = Clacky::BrandConfig.load
+
       # Clear existing skills to ensure idempotent reloading
       clear
 
@@ -297,7 +301,6 @@ module Clacky
       true
     end
 
-    private
 
     def load_skills_from_directory(dir, source_type)
       return [] unless dir.exist?

data/lib/clacky/tools/browser.rb

@@ -6,6 +6,9 @@ require "timeout"
 require "tmpdir"
 require "shellwords"
 require "yaml"
+require "base64"
+require "fileutils"
+require "securerandom"
 require_relative "base"
 
 module Clacky
@@ -159,11 +162,20 @@ module Clacky
         action = result[:action].to_s
 
         if action == "screenshot" && result[:image_data]
-          mime_type  = result[:mime_type] || "image/jpeg"
-          image_data = result[:image_data]
-          data_url   = "data:#{mime_type};base64,#{image_data}"
+          mime_type       = result[:mime_type] || "image/png"
+          image_data      = result[:image_data]
+          data_url        = "data:#{mime_type};base64,#{image_data}"
+          original_path   = result[:original_path]
+          compressed_path = result[:compressed_path]
+
+          text = "Screenshot captured."
+          if original_path || compressed_path
+            text += "\n- Original (full resolution): #{original_path || 'unavailable'}" \
+                    "\n- Compressed (800px, sent to AI): #{compressed_path || 'unavailable'}"
+          end
+
           return [
-            { type: "text",      text:      "Screenshot captured." },
+            { type: "text",      text:      text },
             { type: "image_url", image_url: { url: data_url } }
           ]
         end
@@ -180,7 +192,6 @@ module Clacky
         }.compact
       end
 
-      private
 
       BROWSER_CONFIG_PATH = File.expand_path("~/.clacky/browser.yml").freeze
 
@@ -416,6 +427,9 @@ module Clacky
                    output: text.empty? ? "Screenshot captured." : text }
         end
 
+        # Save original (full-resolution) PNG to disk before any downscaling
+        original_path = save_screenshot_to_disk(image_block["data"], suffix: "original")
+
         image_data = png_downscale_base64(image_block["data"], SCREENSHOT_MAX_WIDTH)
 
         if image_data.bytesize > SCREENSHOT_MAX_BASE64_BYTES
@@ -424,8 +438,13 @@ module Clacky
                    output: "Screenshot too large after resize (#{size_kb}KB). Use action=snapshot instead." }
         end
 
+        # Save compressed (800px) PNG for AI reference
+        compressed_path = save_screenshot_to_disk(image_data, suffix: "compressed")
+
         { action: "screenshot", success: true, profile: "user",
-          image_data: image_data, mime_type: "image/png", output: "Screenshot captured." }
+          image_data: image_data, mime_type: "image/png",
+          original_path: original_path, compressed_path: compressed_path,
+          output: "Screenshot captured." }
       end
 
       private def png_downscale_base64(b64, max_width)
@@ -443,6 +462,25 @@ module Clacky
         result
       end
 
+      # Save a base64-encoded PNG screenshot to disk and return the file path.
+      # suffix: "original" or "compressed" — embedded in filename for clarity.
+      # Uses the same upload directory as other image files so the agent can
+      # reference, read, or pass the path to other tools.
+      private def save_screenshot_to_disk(base64_data, suffix: nil)
+        upload_dir = File.join(Dir.tmpdir, "clacky-uploads")
+        FileUtils.mkdir_p(upload_dir)
+        ts       = Time.now.strftime("%Y%m%d_%H%M%S")
+        hex      = SecureRandom.hex(4)
+        label    = suffix ? "_#{suffix}" : ""
+        filename = "screenshot_#{ts}_#{hex}#{label}.png"
+        path     = File.join(upload_dir, filename)
+        File.binwrite(path, Base64.strict_decode64(base64_data))
+        path
+      rescue => e
+        Clacky::Logger.error("screenshot_save_failed", error: e.message)
+        nil
+      end
+
       # -----------------------------------------------------------------------
       # Chrome MCP
       # -----------------------------------------------------------------------

data/lib/clacky/tools/file_reader.rb

@@ -313,7 +313,6 @@ module Clacky
         end
       end
 
-      private
 
       # List first-level directory contents (files and directories)
       private def list_directory_contents(path)

data/lib/clacky/tools/grep.rb

@@ -267,7 +267,6 @@ module Clacky
         compact
       end
 
-      private
 
       def search_file(file, regex, context_lines, max_matches)
         matches = []

data/lib/clacky/tools/run_project.rb

@@ -100,7 +100,6 @@ module Clacky
         end
       end
 
-      private
 
       def start_project
         config = load_project_config

data/lib/clacky/tools/todo_manager.rb

@@ -98,7 +98,6 @@ module Clacky
         end
       end
 
-      private
 
       def load_todos
         @todos

data/lib/clacky/ui2/components/command_suggestions.rb

@@ -185,7 +185,6 @@ module Clacky
           flush
         end
 
-        private
 
         # Update the complete commands list (system + skills)
         private def update_commands

data/lib/clacky/ui2/components/inline_input.rb

@@ -176,7 +176,6 @@ module Clacky
           @result_queue = nil
         end
 
-        private
 
         def handle_enter
           result = expand_placeholders(current_line)

data/lib/clacky/ui2/components/input_area.rb

@@ -624,7 +624,6 @@ module Clacky
           end
         end
 
-        private
 
         # Update command suggestions based on current input
         # Shows suggestions when input starts with /

data/lib/clacky/ui2/components/message_component.rb

@@ -32,7 +32,6 @@ module Clacky
           end
         end
 
-        private
 
         # Render user message
         # @param content [String] Message content